New issue
Advanced search Search tips

Issue 694423 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Mar 2017
Cc:
EstimatedDays: ----
NextAction: ----
OS: iOS
Pri: 3
Type: Bug



Sign in to add a comment

Make publisher information RTL friendly in CS Articles

Project Member Reported by gambard@chromium.org, Feb 21 2017

Issue description

Depending of the first characters of the publisher name, the information is displayed Name-Date or Date-Name.
Adjust it to the locale used.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Mar 1 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/5201cea324d851562d5d454483ae921862d1da10

commit 5201cea324d851562d5d454483ae921862d1da10
Author: gambard <gambard@chromium.org>
Date: Wed Mar 01 16:45:37 2017

Make publisher information RTL friendly

Displays the publisher information in the order compliant with the locale
layout.

BUG= 694423 

Review-Url: https://codereview.chromium.org/2721343002
Cr-Commit-Position: refs/heads/master@{#453951}

[modify] https://crrev.com/5201cea324d851562d5d454483ae921862d1da10/ios/chrome/browser/ui/content_suggestions/BUILD.gn
[modify] https://crrev.com/5201cea324d851562d5d454483ae921862d1da10/ios/chrome/browser/ui/content_suggestions/content_suggestions_article_item.mm

Comment 2 by gambard@google.com, Mar 1 2017

Status: Fixed (was: Assigned)
Project Member

Comment 3 by bugdroid1@chromium.org, Mar 3 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/5acfe365a2d66040792eb951bf919ae178deb860

commit 5acfe365a2d66040792eb951bf919ae178deb860
Author: gambard <gambard@chromium.org>
Date: Fri Mar 03 21:35:09 2017

Fix util to adjust string for locale direction

Change the util to perform according to its comment.

BUG= 694423 

Review-Url: https://codereview.chromium.org/2730763003
Cr-Commit-Position: refs/heads/master@{#454682}

[modify] https://crrev.com/5acfe365a2d66040792eb951bf919ae178deb860/ios/chrome/browser/ui/util/i18n_string.mm

Sign in to add a comment