New issue
Advanced search Search tips

Issue 694420 link

Starred by 1 user
Status: Fixed
Owner:
jlebel@chromium.org
Closed: Mar 2017
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Mac
Pri: 3
Type: Bug



Sign in to add a comment

Need to remove dead code related to none material design profile menu

Project Member Reported by jlebel@chromium.org, Feb 21 2017 
The profile menu is now always with material design. The code related to this option should be removed.
See:
https://cs.chromium.org/chromium/src/components/signin/core/common/profile_management_switches.h?l=39
switches::IsMaterialDesignUserMenu();
Project Member

Comment 1 by bugdroid1@chromium.org, Mar 7 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/90c1986a3559d1f57ae92ff654bcd5a64a41e96f

commit 90c1986a3559d1f57ae92ff654bcd5a64a41e96f
Author: jlebel <jlebel@chromium.org>
Date: Tue Mar 07 17:24:33 2017

Removing pre-material design menu setting.

BUG= 694420 

Review-Url: https://codereview.chromium.org/2708073002
Cr-Commit-Position: refs/heads/master@{#455113}

[modify] https://crrev.com/90c1986a3559d1f57ae92ff654bcd5a64a41e96f/chrome/app/generated_resources.grd
[modify] https://crrev.com/90c1986a3559d1f57ae92ff654bcd5a64a41e96f/chrome/app/vector_icons/BUILD.gn
[delete] https://crrev.com/94aeb8cb883faee716cca33b7601df68a2d8c09c/chrome/app/vector_icons/mode_edit.icon
[modify] https://crrev.com/90c1986a3559d1f57ae92ff654bcd5a64a41e96f/chrome/browser/about_flags.cc
[modify] https://crrev.com/90c1986a3559d1f57ae92ff654bcd5a64a41e96f/chrome/browser/sync/sync_global_error.cc
[modify] https://crrev.com/90c1986a3559d1f57ae92ff654bcd5a64a41e96f/chrome/browser/sync/sync_global_error.h
[modify] https://crrev.com/90c1986a3559d1f57ae92ff654bcd5a64a41e96f/chrome/browser/sync/sync_global_error_factory.cc
[delete] https://crrev.com/94aeb8cb883faee716cca33b7601df68a2d8c09c/chrome/browser/sync/sync_global_error_unittest.cc
[modify] https://crrev.com/90c1986a3559d1f57ae92ff654bcd5a64a41e96f/chrome/browser/ui/avatar_button_error_controller.cc
[modify] https://crrev.com/90c1986a3559d1f57ae92ff654bcd5a64a41e96f/chrome/browser/ui/cocoa/profiles/avatar_button_controller.mm
[modify] https://crrev.com/90c1986a3559d1f57ae92ff654bcd5a64a41e96f/chrome/browser/ui/cocoa/profiles/profile_chooser_controller.mm
[modify] https://crrev.com/90c1986a3559d1f57ae92ff654bcd5a64a41e96f/chrome/browser/ui/cocoa/profiles/profile_chooser_controller_unittest.mm
[modify] https://crrev.com/90c1986a3559d1f57ae92ff654bcd5a64a41e96f/chrome/browser/ui/views/profiles/new_avatar_button.cc
[modify] https://crrev.com/90c1986a3559d1f57ae92ff654bcd5a64a41e96f/chrome/browser/ui/views/profiles/profile_chooser_view.cc
[modify] https://crrev.com/90c1986a3559d1f57ae92ff654bcd5a64a41e96f/chrome/browser/ui/views/profiles/profile_chooser_view.h
[modify] https://crrev.com/90c1986a3559d1f57ae92ff654bcd5a64a41e96f/chrome/browser/ui/views/profiles/profile_chooser_view_browsertest.cc
[modify] https://crrev.com/90c1986a3559d1f57ae92ff654bcd5a64a41e96f/chrome/browser/ui/webui/signin/login_ui_service.cc
[modify] https://crrev.com/90c1986a3559d1f57ae92ff654bcd5a64a41e96f/chrome/test/BUILD.gn
[modify] https://crrev.com/90c1986a3559d1f57ae92ff654bcd5a64a41e96f/components/signin/core/common/profile_management_switches.cc
[modify] https://crrev.com/90c1986a3559d1f57ae92ff654bcd5a64a41e96f/components/signin/core/common/profile_management_switches.h
[modify] https://crrev.com/90c1986a3559d1f57ae92ff654bcd5a64a41e96f/components/signin/core/common/signin_switches.cc
[modify] https://crrev.com/90c1986a3559d1f57ae92ff654bcd5a64a41e96f/components/signin/core/common/signin_switches.h

Comment 2 by jlebel@chromium.org, Mar 7 2017

Status: Fixed (was: Assigned)
►

Sign in to add a comment