New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 694411 link

Starred by 1 user
Status: Untriaged
Owner: ----
Cc:
█ vpalatin@chromium.org
█ rspangler@chromium.org
adurbin@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 3
Type: Bug



Sign in to add a comment

ec: Consider porting adapters to newer RWSIG_TYPE_RWSIG

Project Member Reported by drinkcat@chromium.org, Feb 21 2017 
All of the USB-C adapters use the deprecated CONFIG_RWSIG_TYPE_USBPD1 config option, namely:

dingdong
hoho
honeybuns
lucid
minimuffin
zinger

It would be nice to investigate whether we can port them to use the newer rwsig signature algorithm (as implemented in  Issue 690773 ), as this help simplify our codebase and remove a few ifdefs.

This does come as some cost in terms of image size (mainly because we need to include an FMAP for the signer to work), but it might be possible to fit it in the existing images.

Comment 1 by rspangler@chromium.org, Feb 22 2017 

Alternately, maybe we should make a more compact signature format for use in EC, since the vboot 2.1 structs are kinda overkill.  Something with a header with at least a magic number + struct version + struct size so futility can find it automatically (vs. usbpd1, which it can't guess).
Project Member

Comment 2 by sheriffbot@chromium.org, Mar 7 2018

Labels: Hotlist-Recharge-Cold
Status: Untriaged (was: Available)
This issue has been Available for over a year. If it's no longer important or seems unlikely to be fixed, please consider closing it out. If it is important, please re-triage the issue.

Sorry for the inconvenience if the bug really should have been left as Available. If you change it back, also remove the "Hotlist-Recharge-Cold" label.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

Comment 3 by pbe...@chromium.org, Mar 30 2018

Components: OS>Firmware>EC
►

Sign in to add a comment