Using the per-revision bisect providing the bisect results,

You are probably looking for a change made after 446472 (known good), but no later than 446473 (first known bad).

CHANGE-LOG URL:
-----------------
https://chromium.googlesource.com/chromium/src/+log/9874e16e6ccd443a33d4207619e87c6fc6ad1dcd..42d8de0ce3d18a85197a8394be1d21f0aecb6d01

From the CL above, assigning the issue to the concern owner
Review-Url: https://codereview.chromium.org/2567873002

phulce@/kdzwinel@ - Unable to find the authors name in the owner list, so assigning to the reviewer. Could you please check whether this is caused with respect to your change, if not please help us in assigning it to the right owner.

Thanks!

Curious that the cookies table doesn't suffer from the same problem yet that was the target of the CL in question. I'll look into it.

I gave it a quick look. Gray background is how non-focused selected elements look like. You will get that on any table row by selecting it and clicking outside the table. What happens in this video is: user selects special creationNode row, clicks "remove all" (taking away the focus from the table and giving selected element a gray background), table gets cleared but the special creationNode row is kept together with its selected state. This is reproducible on every editable table (including cookies), but happens only for the "add new" row. Not yet sure what in my CL causes this, but I can take a look if @phulce haven't started working on it yet.

@kdzwinel thanks that'd be great if you could check if the cause came from there! I think the reporter is referring to the inconsistency between storage pane and cookies pane.

In the "actual" video, the focus is removed but the selection is kept when clicking on Clear All.
In the "expected" video and in the cookies pane, the focus and selection are both removed when clicking on Clear All.

Looping in @eostroukhov since he has also been working on storage panels recently. Have you noticed this when making your storage changes?

Ah, you are correct, it's not reproducible on the cookies table. I was clicking 'delete selected' instead of 'clear all' when I tested it.

I went through my CL again and I did made some changes in dataGrid.css and dataGrid.js that are shared between Storage and Cookie tables. However, I don't see how those changes could have caused the issue in question.

The problem seems to be that `DOMStorageItemsView._domStorageItemsCleared` is not being called after storage was cleared (probably because it was already empty?). Calling it would deselect the creationNode.

BTW I played with Storage and Cookies some more and found two more inconsistencies in the related area:  https://crbug.com/694741  &  https://crbug.com/694759  .

Ok thanks for investigating kdzwinel! I can pick up the fixes for those.

Friendly ping to get an update on this.

Hey sorry, there's a CL I have that was approved but significant changes happened to the underlying code post-LGTM, and then I/reviewer were on serial PTO. Trying to push it through today.

To follow along: https://codereview.chromium.org/2714913002/

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/63095504581ef0e664faf74614e5ca98f9cb9047

commit 63095504581ef0e664faf74614e5ca98f9cb9047
Author: phulce <phulce@chromium.org>
Date: Wed Mar 01 19:49:13 2017

DevTools: Fixes to Storage panel inconsistencies

* Fixes Backspace delete in CookiesTable
* Fixes selection preservation when 'Delete Selected' is used in CookiesTable
* Fixes selection removal when 'Clear All' is used in Storage panes

BUG= 694399 , 694741 

Review-Url: https://codereview.chromium.org/2714913002
Cr-Commit-Position: refs/heads/master@{#454002}

[modify] https://crrev.com/63095504581ef0e664faf74614e5ca98f9cb9047/third_party/WebKit/Source/devtools/front_end/cookie_table/CookiesTable.js
[modify] https://crrev.com/63095504581ef0e664faf74614e5ca98f9cb9047/third_party/WebKit/Source/devtools/front_end/resources/CookieItemsView.js
[modify] https://crrev.com/63095504581ef0e664faf74614e5ca98f9cb9047/third_party/WebKit/Source/devtools/front_end/resources/DOMStorageItemsView.js

Tested the issue on Latest Dev# 58.0.3029.6 on Windows, Mac and Linux and found the issue to be Fixed.
Grey highlight is not seen after Clear icon is clicked. Hence adding TE-Verified Labels.
Attaching Screencast for reference.
Thank You.

Deleted: 694399.ogv 1.3 MB

	694399.ogv 1.3 MB View Download