Security chip on Mac Cocoa browser behaves strangely |
|||||||||||
Issue descriptionChrome Version : 56.0.2924.87 OS Version: OS X 10.12.3 What steps will reproduce the problem? 1. Visit https://permission.site 2. Request location permission, and ignore the prompt (but do not dismiss it) 3. Type google.com in the omnibox and press enter (with the prompt still showing) Observe that the "Secure" security chip remains in the active state, and stays in the active state for all subsequent navigations to HTTPS pages until you get another permission request prompt. A related bug is as follows: 1. Visit https://permission.site 2. Request location permission, and ignore the prompt (but do not dismiss it) 3. Open a new tab by clicking on the button in the tab strip, or switch to another open tab 4. Switch back to the permission.site tab Observe that the security chip no longer carries the active state it had when first requesting the permission. Screenshots attached. I've started poking around to work out how to fix this - spqchan, if you have quick advice that would be appreciated.
,
Feb 21 2017
,
Feb 21 2017
This is most likely caused by the bubble not updating the decoration properly when it's dismissed by the navigation. I'll look into this
,
Feb 25 2017
I can't repro with the repro steps, but these work for me: 1. Go to permission.site 2. Click Camera to get prompt (but don't touch it) 3. Click Notifications 4. Click in omnibox and type www.apple.com, press Return 5. Cmd-[ to go back - prompt won't be visible but Secure will be highlighted If the fixes are not involved, we should aim for M-58
,
Feb 27 2017
Possibly related to https://bugs.chromium.org/p/chromium/issues/detail?id=695971 +1, M58 would be great if possible Sarah, thanks!
,
Feb 27 2017
These might be related, I hope they can get fixed as well: (On Mac), right-click on "🔒 Secure", move the pointer away, esc → the "🔒 Secure" field stays gray. (On Mac), drag the "🔒 Secure" into a bookmark folder (inside the "Bookmarks Bar" folder) that appears on hover ">>" → the "🔒 Secure" field stays gray.
,
Feb 27 2017
,
Mar 15 2017
,
Mar 16 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/4cf8e7e6215f686f727736826109303c3b115eec commit 4cf8e7e6215f686f727736826109303c3b115eec Author: spqchan <spqchan@chromium.org> Date: Thu Mar 16 19:41:29 2017 [Mac] Fix for the security chip There was a race condition with the Page Info icon where it might switch between LocationIconDecoration and SecurityStateBubbleDecoration BUG= 694396 Review-Url: https://codereview.chromium.org/2752623003 Cr-Commit-Position: refs/heads/master@{#457521} [modify] https://crrev.com/4cf8e7e6215f686f727736826109303c3b115eec/chrome/browser/ui/cocoa/permission_bubble/permission_bubble_controller.h [modify] https://crrev.com/4cf8e7e6215f686f727736826109303c3b115eec/chrome/browser/ui/cocoa/permission_bubble/permission_bubble_controller.mm [modify] https://crrev.com/4cf8e7e6215f686f727736826109303c3b115eec/chrome/browser/ui/cocoa/permission_bubble/permission_bubble_controller_unittest.mm
,
Mar 16 2017
,
Mar 16 2017
Thanks for looking at this!
,
Mar 17 2017
Your change meets the bar and is auto-approved for M58. Please go ahead and merge the CL to branch 3029 manually. Please contact milestone owner if you have questions. Owners: amineer@(Android), cmasso@(iOS), bhthompson@(ChromeOS), govind@(Desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Mar 17 2017
Your change is approved for M58. Please merge ASAP so that it will be picked up for next Beta Release, RC cut on (Monday-03/20) at 5.00 PM PST.
,
Mar 20 2017
Verified the fix on Mac 10.12.3 using latest canary #59.0.3046.0 as per the comment #0. Observed that "Secure" security chip did not remain in active state after typing google.com in the omnibox and pressing enter. Hence, the fix is working as expected. Attaching the screencast for reference Adding the verified labels. Thanks...!!
,
Mar 20 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/dcbb8a3ca037cb79a60ac1b56e661f900d72c872 commit dcbb8a3ca037cb79a60ac1b56e661f900d72c872 Author: spqchan <spqchan@chromium.org> Date: Mon Mar 20 21:43:21 2017 [Mac] Fix for the security chip There was a race condition with the Page Info icon where it might switch between LocationIconDecoration and SecurityStateBubbleDecoration BUG= 694396 Review-Url: https://codereview.chromium.org/2752623003 Cr-Commit-Position: refs/heads/master@{#457521} (cherry picked from commit 4cf8e7e6215f686f727736826109303c3b115eec) Review-Url: https://codereview.chromium.org/2761903002 . Cr-Commit-Position: refs/branch-heads/3029@{#312} Cr-Branched-From: 939b32ee5ba05c396eef3fd992822fcca9a2e262-refs/heads/master@{#454471} [modify] https://crrev.com/dcbb8a3ca037cb79a60ac1b56e661f900d72c872/chrome/browser/ui/cocoa/website_settings/permission_bubble_controller.h [modify] https://crrev.com/dcbb8a3ca037cb79a60ac1b56e661f900d72c872/chrome/browser/ui/cocoa/website_settings/permission_bubble_controller.mm [modify] https://crrev.com/dcbb8a3ca037cb79a60ac1b56e661f900d72c872/chrome/browser/ui/cocoa/website_settings/permission_bubble_controller_unittest.mm
,
Mar 20 2017
,
Mar 22 2017
Verified the fix on Mac 10.12.3 using latest beta #58.0.3029.33 as per the comment #0. Observed that "Secure" security chip did not remain in active state after typing google.com in the omnibox and pressing enter. Hence, the fix is working as expected. Attaching the screencast for reference Adding the verified labels. Thanks...!! |
|||||||||||
►
Sign in to add a comment |
|||||||||||
Comment 1 by dominickn@chromium.org
, Feb 21 2017