New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 694394 link

Starred by 4 users

Issue metadata

Status: Verified
Owner:
Not on Chrome
Closed: Apr 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Chrome , Mac
Pri: 1
Type: Bug-Regression



Sign in to add a comment

Hide/disable "Clear Browsing Data" entrypoints in Guest Mode

Reported by lpa...@etouch.net, Feb 21 2017

Issue description

Chrome Version: 58.0.3018.2 (Official Build) 9684a56837d6ddb675c417f4adf046583c8db38a-refs/branch-heads/3018@{#2}(32/64 Bit)
OS:  Windows(7,8,8.1,10), Mac(10.11.6, 10.12.1, 10.12).

Steps to reproduce:
1. Launch Chrome, click on Avatar icon, go to Guest mode.
2. Click on Wrench icon, go to more tool and select 'Clear Browsing Data'.
3. Observe.

Actual Result: 'Clear Browsing Data overlay' is not displayed
Expected Result: 'Clearing Browsing Data' overlay should be seen.

This is regression issue broken in 'M 58' and will soon update the bisect info:
Manual Bisect Info: 
Good Build 58.0.3015.0
Bad Build 58.0.3016.0

Note: This issue is not reproducible on LINUX OS.
 
Actual Result.mp4
977 KB View Download
Expected Result.mp4
910 KB View Download
Labels: hasbisect-per-revision ReleaseBlock-Beta
Owner: dbeam@chromium.org
Status: Assigned (was: Unconfirmed)
Using the per-revision bisect providing the bisect results,
Good build: 58.0.3015.0 (Revision: 451180).
Bad build: 58.0.3016.0 (Revision: 451403).

You are probably looking for a change made after 451337 (known good), but no later than 451338 (first known bad).

CHANGE-LOG URL:
---------------
https://chromium.googlesource.com/chromium/src/+log/e85944f082b27f903fcea5491549de058e157528..a8109d958f144e541a204da6debd820d936d6108

From the CL above, assigning the issue to the concern owner

@dbeam: Could you please look into the issue, pardon me if it has nothing to do with your changes and if possible please assign it to concern owner.

Review-Url:https://codereview.chromium.org/2699973002

Note :Able to reproduce the issue in Win 10.0 and Mac 10.12.3 & Not seen in Ubuntu 14.04 and able to reproduce in latest Canary #58.0.3018.0
Adding Release Block-Beta for this issue.Please undo if not the case.
Cc: rbasuvula@chromium.org

Comment 3 by dbeam@chromium.org, Feb 21 2017

Cc: steve...@chromium.org tbuck...@chromium.org
why do we care about showing the "Clear browsing data" dialog in guest mode?
Labels: -ReleaseBlock-Beta
This is not a blocker, since it's specific to Guest mode functionality.
dbeam@, Friendly ping!!
Still we are able to reproduce the issue on latest Canary-58.0.3026.0 of Windows-7. Could you please look into this.
Thank you!

Comment 6 by dbeam@chromium.org, Mar 1 2017

Labels: -M-58

Comment 7 by dbeam@chromium.org, Mar 1 2017

Owner: tbuck...@chromium.org
Project Member

Comment 8 by sheriffbot@chromium.org, Apr 3 2017

Status: Available (was: Assigned)
--Chrome Identity automated triaging--

This bug is Assigned and has gone one month without any activity, so it is being moved to Available to indicate that it is not actively being worked on. If you are working on this bug, please mark yourself as the owner and move back to Assigned. Please see https://goo.gl/78kbny for more details. Please remove the Services>SignIn or UI>Browser>Profiles components if this bug isn't related to Chrome Identity.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Components: UI>Settings
Labels: Proj-MaterialDesign-WebUI
This is working in Guest Mode on Chrome OS version 59.0.3055.0 canary. Is it still reproducing on Windows in M59?

Comment 10 by dbeam@chromium.org, Apr 10 2017

Labels: Hotlist-MD-Settings-PrivacyCBD OS-Chrome OS-Linux

Comment 11 by dbeam@chromium.org, Apr 10 2017

Labels: -Hotlist-MD-Settings-PrivacyCBD Hotlist-MD-Settings-Privacy-CBD
Owner: yitingc@chromium.org
+yitingc, maxwalker, dknox -- is there a reason we need to offer Clear Browsing Data in Guest Mode? We'd ideally like to remove it if possible.

Background: in Guest mode on Mac/Windows/Linux, there is no entrypoint for Clear Browsing Data via the old Settings page (chrome://settings-frame), but you could open it via History or the keyboard shortcut.
Cc: msramek@chromium.org
I think we don't.

CBD doesn't affect Incognito sessions either (which is achieved by the simple fact that chrome://settings always open in the regular mode). This is the desired behavior, because one can easily delete Incognito data by closing Incognito.

The same argument applies in Guest mode; closing the Guest session should be the primary way to delete its data.
Cc: yitingc@chromium.org
Owner: tsergeant@chromium.org
Status: Assigned (was: Available)
Summary: Hide/disable "Clear Browsing Data" entrypoints in Guest Mode (was: Regression:'Clear Browsing Data' overlay is not displayed in Guest mode.)
Ok, seems like we should then disable it in the Wrench menu and on chrome://history when in Guest Mode. @tsergeant could you look into this?
One other thing to point out is that History is hard to get to in Guest mode: You need to explicitly type chrome://history into the Omnibox (there's no wrench menu entry or keyboard shortcut).

Does this need to be fixed for M59?

Status: Started (was: Assigned)
CL is at https://codereview.chromium.org/2817813004/, some screenshots:
disabled_cbd_sidebar.png
23.1 KB View Download
Screenshot from 2017-04-13 13:02:24.png
27.9 KB View Download
Looks good to me! Thanks for the fast response!

Re: M59, I think the History entrypoint could be fine to leave in but we should certainly disable the menu item.
Project Member

Comment 19 by bugdroid1@chromium.org, Apr 18 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/341a827fdc6dcfc2dca619121cf18117c72225f2

commit 341a827fdc6dcfc2dca619121cf18117c72225f2
Author: tsergeant <tsergeant@chromium.org>
Date: Tue Apr 18 03:54:33 2017

Disable Clear Browsing Data menu item in guest profiles

Following the switch to MD Settings, the Clear Browsing Data dialog is
not accessible from guest profiles -- instead, closing the session is
the primary way to delete the guest's data.

This CL disables the entry point to Clear Browsing Data from the main
menu, which otherwise would open MD Settings with no CBD dialog visible.

BUG= 694394 

Review-Url: https://codereview.chromium.org/2823983003
Cr-Commit-Position: refs/heads/master@{#465131}

[modify] https://crrev.com/341a827fdc6dcfc2dca619121cf18117c72225f2/chrome/browser/ui/browser_command_controller.cc

Project Member

Comment 20 by bugdroid1@chromium.org, Apr 18 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/dcf200334b52ac07d81baaec5257e4a964fa3137

commit dcf200334b52ac07d81baaec5257e4a964fa3137
Author: tsergeant <tsergeant@chromium.org>
Date: Tue Apr 18 06:23:05 2017

Disable Clear Browsing Data button in History for guest profiles

Following the switch to MD Settings, the Clear Browsing Data dialog is
not accessible from guest profiles -- instead, closing the session is
the primary way to delete the guest's data.

This CL disables the Clear Browsing Data button in the History page,
which otherwise would open MD Settings with no CBD dialog visible.

BUG= 694394 
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2817813004
Cr-Commit-Position: refs/heads/master@{#465154}

[modify] https://crrev.com/dcf200334b52ac07d81baaec5257e4a964fa3137/chrome/browser/resources/md_history/side_bar.html
[modify] https://crrev.com/dcf200334b52ac07d81baaec5257e4a964fa3137/chrome/browser/resources/md_history/side_bar.js

Labels: Merge-Request-59
Fixes landed, and verified on Canary. Requesting merge of #19 to M59.
Project Member

Comment 22 by sheriffbot@chromium.org, Apr 21 2017

Labels: -Merge-Request-59 Hotlist-Merge-Approved Merge-Approved-59
Your change meets the bar and is auto-approved for M59. Please go ahead and merge the CL to branch 3071 manually. Please contact milestone owner if you have questions.
Owners: amineer@(Android), cmasso@(iOS), gkihumba@(ChromeOS), Abdul Syed@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Project Member

Comment 23 by bugdroid1@chromium.org, Apr 21 2017

Labels: -merge-approved-59 merge-merged-3071
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e182fef5af8b9168b97f25bb98ea03c61e9cf8e0

commit e182fef5af8b9168b97f25bb98ea03c61e9cf8e0
Author: Tim Sergeant <tsergeant@chromium.org>
Date: Fri Apr 21 01:13:18 2017

Disable Clear Browsing Data menu item in guest profiles

Following the switch to MD Settings, the Clear Browsing Data dialog is
not accessible from guest profiles -- instead, closing the session is
the primary way to delete the guest's data.

This CL disables the entry point to Clear Browsing Data from the main
menu, which otherwise would open MD Settings with no CBD dialog visible.

BUG= 694394 

Review-Url: https://codereview.chromium.org/2823983003
Cr-Commit-Position: refs/heads/master@{#465131}
(cherry picked from commit 341a827fdc6dcfc2dca619121cf18117c72225f2)

Review-Url: https://codereview.chromium.org/2836523002 .
Cr-Commit-Position: refs/branch-heads/3071@{#110}
Cr-Branched-From: a106f0abbf69dad349d4aaf4bcc4f5d376dd2377-refs/heads/master@{#464641}

[modify] https://crrev.com/e182fef5af8b9168b97f25bb98ea03c61e9cf8e0/chrome/browser/ui/browser_command_controller.cc

Status: Fixed (was: Started)
Labels: TE-Verified-M59 TE-Verified-59.0.3071.25
Rechecked the issue on Windows 10, MAC 10.12.4, Ubuntu 14.04 for chrome version 59.0.3071.25, fix is working as intended. Clear Browsing Data is disabled in Wrench menu in guest mode. Adding TE-verified labels.

Thanks.!

Comment 26 by dbeam@chromium.org, Apr 25 2017

hey tsergeant@, can we merge dcf200334b52ac07d81baaec5257e4a964fa3137 to branch-heads/3071 as well?
Sure, if you think it should be fixed in 59. I'll do the merge now.
Project Member

Comment 28 by bugdroid1@chromium.org, Apr 26 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e9aaf57d85c09c987b5a23bb3c6eff1339d888f8

commit e9aaf57d85c09c987b5a23bb3c6eff1339d888f8
Author: Tim Sergeant <tsergeant@chromium.org>
Date: Wed Apr 26 01:01:54 2017

Disable Clear Browsing Data button in History for guest profiles

Following the switch to MD Settings, the Clear Browsing Data dialog is
not accessible from guest profiles -- instead, closing the session is
the primary way to delete the guest's data.

This CL disables the Clear Browsing Data button in the History page,
which otherwise would open MD Settings with no CBD dialog visible.

BUG= 694394 
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2817813004
Cr-Commit-Position: refs/heads/master@{#465154}
(cherry picked from commit dcf200334b52ac07d81baaec5257e4a964fa3137)

Review-Url: https://codereview.chromium.org/2846433002 .
Cr-Commit-Position: refs/branch-heads/3071@{#215}
Cr-Branched-From: a106f0abbf69dad349d4aaf4bcc4f5d376dd2377-refs/heads/master@{#464641}

[modify] https://crrev.com/e9aaf57d85c09c987b5a23bb3c6eff1339d888f8/chrome/browser/resources/md_history/side_bar.html
[modify] https://crrev.com/e9aaf57d85c09c987b5a23bb3c6eff1339d888f8/chrome/browser/resources/md_history/side_bar.js

Labels: TE-Verified-59.0.3071.29
Rechecked the issue on Windows 10, MAC 10.12.4, Ubuntu 14.04 for chrome version 59.0.3071.29, fix is working as intended. Clear Browsing Data is disabled in Wrench menu in guest mode. Adding TE-verified labels.

Thanks.!
Status: Verified (was: Fixed)
Clear Browsing Data option from the main menu is disabled
Clear Browsing Data button in the History page is disabled

Verified on 9460.30.0, 59.0.3071.41

Sign in to add a comment