Hide/disable "Clear Browsing Data" entrypoints in Guest Mode
Reported by
lpa...@etouch.net,
Feb 21 2017
|
|||||||||||||||||||||
Issue descriptionChrome Version: 58.0.3018.2 (Official Build) 9684a56837d6ddb675c417f4adf046583c8db38a-refs/branch-heads/3018@{#2}(32/64 Bit) OS: Windows(7,8,8.1,10), Mac(10.11.6, 10.12.1, 10.12). Steps to reproduce: 1. Launch Chrome, click on Avatar icon, go to Guest mode. 2. Click on Wrench icon, go to more tool and select 'Clear Browsing Data'. 3. Observe. Actual Result: 'Clear Browsing Data overlay' is not displayed Expected Result: 'Clearing Browsing Data' overlay should be seen. This is regression issue broken in 'M 58' and will soon update the bisect info: Manual Bisect Info: Good Build 58.0.3015.0 Bad Build 58.0.3016.0 Note: This issue is not reproducible on LINUX OS.
,
Feb 21 2017
,
Feb 21 2017
why do we care about showing the "Clear browsing data" dialog in guest mode?
,
Feb 22 2017
This is not a blocker, since it's specific to Guest mode functionality.
,
Mar 1 2017
dbeam@, Friendly ping!! Still we are able to reproduce the issue on latest Canary-58.0.3026.0 of Windows-7. Could you please look into this. Thank you!
,
Mar 1 2017
,
Mar 1 2017
,
Apr 3 2017
--Chrome Identity automated triaging-- This bug is Assigned and has gone one month without any activity, so it is being moved to Available to indicate that it is not actively being worked on. If you are working on this bug, please mark yourself as the owner and move back to Assigned. Please see https://goo.gl/78kbny for more details. Please remove the Services>SignIn or UI>Browser>Profiles components if this bug isn't related to Chrome Identity. For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Apr 3 2017
This is working in Guest Mode on Chrome OS version 59.0.3055.0 canary. Is it still reproducing on Windows in M59?
,
Apr 10 2017
,
Apr 10 2017
,
Apr 12 2017
+yitingc, maxwalker, dknox -- is there a reason we need to offer Clear Browsing Data in Guest Mode? We'd ideally like to remove it if possible. Background: in Guest mode on Mac/Windows/Linux, there is no entrypoint for Clear Browsing Data via the old Settings page (chrome://settings-frame), but you could open it via History or the keyboard shortcut.
,
Apr 12 2017
,
Apr 12 2017
I think we don't. CBD doesn't affect Incognito sessions either (which is achieved by the simple fact that chrome://settings always open in the regular mode). This is the desired behavior, because one can easily delete Incognito data by closing Incognito. The same argument applies in Guest mode; closing the Guest session should be the primary way to delete its data.
,
Apr 13 2017
Ok, seems like we should then disable it in the Wrench menu and on chrome://history when in Guest Mode. @tsergeant could you look into this?
,
Apr 13 2017
One other thing to point out is that History is hard to get to in Guest mode: You need to explicitly type chrome://history into the Omnibox (there's no wrench menu entry or keyboard shortcut). Does this need to be fixed for M59?
,
Apr 13 2017
CL is at https://codereview.chromium.org/2817813004/, some screenshots:
,
Apr 13 2017
Looks good to me! Thanks for the fast response! Re: M59, I think the History entrypoint could be fine to leave in but we should certainly disable the menu item.
,
Apr 18 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/341a827fdc6dcfc2dca619121cf18117c72225f2 commit 341a827fdc6dcfc2dca619121cf18117c72225f2 Author: tsergeant <tsergeant@chromium.org> Date: Tue Apr 18 03:54:33 2017 Disable Clear Browsing Data menu item in guest profiles Following the switch to MD Settings, the Clear Browsing Data dialog is not accessible from guest profiles -- instead, closing the session is the primary way to delete the guest's data. This CL disables the entry point to Clear Browsing Data from the main menu, which otherwise would open MD Settings with no CBD dialog visible. BUG= 694394 Review-Url: https://codereview.chromium.org/2823983003 Cr-Commit-Position: refs/heads/master@{#465131} [modify] https://crrev.com/341a827fdc6dcfc2dca619121cf18117c72225f2/chrome/browser/ui/browser_command_controller.cc
,
Apr 18 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/dcf200334b52ac07d81baaec5257e4a964fa3137 commit dcf200334b52ac07d81baaec5257e4a964fa3137 Author: tsergeant <tsergeant@chromium.org> Date: Tue Apr 18 06:23:05 2017 Disable Clear Browsing Data button in History for guest profiles Following the switch to MD Settings, the Clear Browsing Data dialog is not accessible from guest profiles -- instead, closing the session is the primary way to delete the guest's data. This CL disables the Clear Browsing Data button in the History page, which otherwise would open MD Settings with no CBD dialog visible. BUG= 694394 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2817813004 Cr-Commit-Position: refs/heads/master@{#465154} [modify] https://crrev.com/dcf200334b52ac07d81baaec5257e4a964fa3137/chrome/browser/resources/md_history/side_bar.html [modify] https://crrev.com/dcf200334b52ac07d81baaec5257e4a964fa3137/chrome/browser/resources/md_history/side_bar.js
,
Apr 21 2017
Fixes landed, and verified on Canary. Requesting merge of #19 to M59.
,
Apr 21 2017
Your change meets the bar and is auto-approved for M59. Please go ahead and merge the CL to branch 3071 manually. Please contact milestone owner if you have questions. Owners: amineer@(Android), cmasso@(iOS), gkihumba@(ChromeOS), Abdul Syed@(Desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Apr 21 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/e182fef5af8b9168b97f25bb98ea03c61e9cf8e0 commit e182fef5af8b9168b97f25bb98ea03c61e9cf8e0 Author: Tim Sergeant <tsergeant@chromium.org> Date: Fri Apr 21 01:13:18 2017 Disable Clear Browsing Data menu item in guest profiles Following the switch to MD Settings, the Clear Browsing Data dialog is not accessible from guest profiles -- instead, closing the session is the primary way to delete the guest's data. This CL disables the entry point to Clear Browsing Data from the main menu, which otherwise would open MD Settings with no CBD dialog visible. BUG= 694394 Review-Url: https://codereview.chromium.org/2823983003 Cr-Commit-Position: refs/heads/master@{#465131} (cherry picked from commit 341a827fdc6dcfc2dca619121cf18117c72225f2) Review-Url: https://codereview.chromium.org/2836523002 . Cr-Commit-Position: refs/branch-heads/3071@{#110} Cr-Branched-From: a106f0abbf69dad349d4aaf4bcc4f5d376dd2377-refs/heads/master@{#464641} [modify] https://crrev.com/e182fef5af8b9168b97f25bb98ea03c61e9cf8e0/chrome/browser/ui/browser_command_controller.cc
,
Apr 21 2017
,
Apr 25 2017
Rechecked the issue on Windows 10, MAC 10.12.4, Ubuntu 14.04 for chrome version 59.0.3071.25, fix is working as intended. Clear Browsing Data is disabled in Wrench menu in guest mode. Adding TE-verified labels. Thanks.!
,
Apr 25 2017
hey tsergeant@, can we merge dcf200334b52ac07d81baaec5257e4a964fa3137 to branch-heads/3071 as well?
,
Apr 26 2017
Sure, if you think it should be fixed in 59. I'll do the merge now.
,
Apr 26 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/e9aaf57d85c09c987b5a23bb3c6eff1339d888f8 commit e9aaf57d85c09c987b5a23bb3c6eff1339d888f8 Author: Tim Sergeant <tsergeant@chromium.org> Date: Wed Apr 26 01:01:54 2017 Disable Clear Browsing Data button in History for guest profiles Following the switch to MD Settings, the Clear Browsing Data dialog is not accessible from guest profiles -- instead, closing the session is the primary way to delete the guest's data. This CL disables the Clear Browsing Data button in the History page, which otherwise would open MD Settings with no CBD dialog visible. BUG= 694394 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2817813004 Cr-Commit-Position: refs/heads/master@{#465154} (cherry picked from commit dcf200334b52ac07d81baaec5257e4a964fa3137) Review-Url: https://codereview.chromium.org/2846433002 . Cr-Commit-Position: refs/branch-heads/3071@{#215} Cr-Branched-From: a106f0abbf69dad349d4aaf4bcc4f5d376dd2377-refs/heads/master@{#464641} [modify] https://crrev.com/e9aaf57d85c09c987b5a23bb3c6eff1339d888f8/chrome/browser/resources/md_history/side_bar.html [modify] https://crrev.com/e9aaf57d85c09c987b5a23bb3c6eff1339d888f8/chrome/browser/resources/md_history/side_bar.js
,
Apr 27 2017
Rechecked the issue on Windows 10, MAC 10.12.4, Ubuntu 14.04 for chrome version 59.0.3071.29, fix is working as intended. Clear Browsing Data is disabled in Wrench menu in guest mode. Adding TE-verified labels. Thanks.!
,
May 8 2017
Clear Browsing Data option from the main menu is disabled Clear Browsing Data button in the History page is disabled Verified on 9460.30.0, 59.0.3071.41 |
|||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||
Comment 1 by rbasuvula@chromium.org
, Feb 21 2017Owner: dbeam@chromium.org
Status: Assigned (was: Unconfirmed)