New issue
Advanced search Search tips

Issue 694360 link

Starred by 1 user
Status: Fixed
Owner:
yosin@chromium.org
Closed: Feb 2017
Cc:
editing-dev@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Task

Blocking:
issue 590369



Sign in to add a comment

Expand expensive inline functions of FrameSelection

Project Member Reported by yosin@chromium.org, Feb 21 2017 
Following inline member functions in FrameSelection are non longer cheap, they need computeVisibleSelectionInDOMTree(), we should expand them in call sites:

- rootEditableElement()
- hasEditableStyle()
- isContentEditable()
- isContentRichlyEditable()
- base() 
- extent()
- start()
- end()
- isNone() 
- isCaret()
- isRange()
Project Member

Comment 1 by bugdroid1@chromium.org, Feb 21 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/1d4a8832edffa6fb5a0d4e217008fb959b8c9fe6

commit 1d4a8832edffa6fb5a0d4e217008fb959b8c9fe6
Author: yosin <yosin@chromium.org>
Date: Tue Feb 21 05:33:54 2017

Expand FrameSeleciton::isContentRichlyEditable()

This patch expands |FrameSeleciton::isContentRichlyEditable()| to increase
chance of hoisting update layout.

Note: This is mechanical change to replace |selection().isContentRichlyEditable()|
by
|selection().computeVisibleSelectionInDOMTreeDeprecated().isContentRichlyEditable()|
Following patch will remove deprecated version.

This patch is part of expanding expensive member functions in |FrameSelection|:
- rootEditableElement()
- hasEditableStyle()
- isContentEditable()
- isContentRichlyEditable()
- base()
- extent()
- start()
- end()
- isNone()
- isCaret()
- isRange()

BUG= 694360 
TEST=n/a; no behavior changes

Review-Url: https://codereview.chromium.org/2706023003
Cr-Commit-Position: refs/heads/master@{#451707}

[modify] https://crrev.com/1d4a8832edffa6fb5a0d4e217008fb959b8c9fe6/third_party/WebKit/Source/core/editing/Editor.cpp
[modify] https://crrev.com/1d4a8832edffa6fb5a0d4e217008fb959b8c9fe6/third_party/WebKit/Source/core/editing/FrameSelection.h
[modify] https://crrev.com/1d4a8832edffa6fb5a0d4e217008fb959b8c9fe6/third_party/WebKit/Source/core/editing/commands/EditorCommand.cpp
Project Member

Comment 2 by bugdroid1@chromium.org, Feb 21 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ddf5cfcdc3c53c40d09312564084d5ca638be348

commit ddf5cfcdc3c53c40d09312564084d5ca638be348
Author: yosin <yosin@chromium.org>
Date: Tue Feb 21 11:10:37 2017

Expand FrameSeleciton::rootEditableElement()  to increase chances of hoisting update layout

This patch expands |FrameSeleciton::rootEditableElement()| to increase
chance of hoisting update layout.

Note: This is mechanical change to replace |selection().rootEditableElement()|
by |selection().computeVisibleSelectionInDOMTreeDeprecated().rootEditableElement()|
Following patch will remove deprecated version.

This patch is apart of expanding expensive member functions in |FrameSelection|:
- rootEditableElement()
- hasEditableStyle()
- isContentEditable()
- isContentRichlyEditable()
- getSelectionType()
- base()
- extent()
- start()
- end()
- isNone()
- isCaret()
- isRange()

BUG= 694360 
TEST=n/a; no behavior changes

Review-Url: https://codereview.chromium.org/2704933006
Cr-Commit-Position: refs/heads/master@{#451724}

[modify] https://crrev.com/ddf5cfcdc3c53c40d09312564084d5ca638be348/third_party/WebKit/Source/core/dom/Element.cpp
[modify] https://crrev.com/ddf5cfcdc3c53c40d09312564084d5ca638be348/third_party/WebKit/Source/core/editing/Editor.cpp
[modify] https://crrev.com/ddf5cfcdc3c53c40d09312564084d5ca638be348/third_party/WebKit/Source/core/editing/InputMethodController.cpp
[modify] https://crrev.com/ddf5cfcdc3c53c40d09312564084d5ca638be348/third_party/WebKit/Source/core/editing/commands/EditorCommand.cpp
[modify] https://crrev.com/ddf5cfcdc3c53c40d09312564084d5ca638be348/third_party/WebKit/Source/core/editing/commands/RemoveFormatCommand.cpp
[modify] https://crrev.com/ddf5cfcdc3c53c40d09312564084d5ca638be348/third_party/WebKit/Source/core/page/DragController.cpp
[modify] https://crrev.com/ddf5cfcdc3c53c40d09312564084d5ca638be348/third_party/WebKit/Source/web/WebRange.cpp
[modify] https://crrev.com/ddf5cfcdc3c53c40d09312564084d5ca638be348/third_party/WebKit/Source/web/tests/WebFrameTest.cpp
Project Member

Comment 3 by bugdroid1@chromium.org, Feb 21 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d4cacfa2ec6d6f41385b40f46af7ab385aba0921

commit d4cacfa2ec6d6f41385b40f46af7ab385aba0921
Author: yosin <yosin@chromium.org>
Date: Tue Feb 21 12:59:42 2017

Expand FrameSeleciton::end()

This patch expands |FrameSeleciton::end()| to increase
chance of hoisting update layout.

Note: This is mechanical change to replace |selection().end()|
by |selection().computeVisibleSelectionInDOMTreeDeprecated().end()|
Following patch will remove deprecated version.

This patch is part of expanding expensive member functions in |FrameSelection|:
- rootEditableElement()
- hasEditableStyle()
- isContentEditable()
- isContentRichlyEditable()
- base()
- extent()
- start()
- end()
- isNone()
- isCaret()
- isRange()

BUG= 694360 
TEST=n/a; no behavior changes

Review-Url: https://codereview.chromium.org/2703313002
Cr-Commit-Position: refs/heads/master@{#451743}

[modify] https://crrev.com/d4cacfa2ec6d6f41385b40f46af7ab385aba0921/third_party/WebKit/Source/core/editing/FrameSelection.h
[modify] https://crrev.com/d4cacfa2ec6d6f41385b40f46af7ab385aba0921/third_party/WebKit/Source/core/editing/InputMethodController.cpp
[modify] https://crrev.com/d4cacfa2ec6d6f41385b40f46af7ab385aba0921/third_party/WebKit/Source/core/editing/InputMethodControllerTest.cpp
[modify] https://crrev.com/d4cacfa2ec6d6f41385b40f46af7ab385aba0921/third_party/WebKit/Source/core/editing/spellcheck/SpellChecker.cpp
[modify] https://crrev.com/d4cacfa2ec6d6f41385b40f46af7ab385aba0921/third_party/WebKit/Source/core/input/EventHandlerTest.cpp
[modify] https://crrev.com/d4cacfa2ec6d6f41385b40f46af7ab385aba0921/third_party/WebKit/Source/web/WebFrameWidgetImpl.cpp
[modify] https://crrev.com/d4cacfa2ec6d6f41385b40f46af7ab385aba0921/third_party/WebKit/Source/web/WebLocalFrameImpl.cpp
[modify] https://crrev.com/d4cacfa2ec6d6f41385b40f46af7ab385aba0921/third_party/WebKit/Source/web/WebViewImpl.cpp
Project Member

Comment 4 by bugdroid1@chromium.org, Feb 21 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c183eaa3876b03b16c2c84e3dfb3b87b63071a5b

commit c183eaa3876b03b16c2c84e3dfb3b87b63071a5b
Author: yosin <yosin@chromium.org>
Date: Tue Feb 21 13:01:12 2017

Expand FrameSeleciton::isCaret()  to increase chances of hoisting update layout

This patch expands |FrameSeleciton::isCaret()| to increase
chance of hoisting update layout.

Note: This is mechanical change to replace |selection().isCaret()|
by |selection().computeVisibleSelectionInDOMTreeDeprecated().isCaret()|
Following patch will remove deprecated version.

This patch is apart of expanding expensive member functions in |FrameSelection|:
- rootEditableElement()
- hasEditableStyle()
- isContentEditable()
- isContentRichlyEditable()
- getSelectionType()
- base()
- extent()
- start()
- end()
- isNone()
- isCaret()
- isRange()

BUG= 694360 
TEST=n/a; no behavior changes

Review-Url: https://codereview.chromium.org/2704123003
Cr-Commit-Position: refs/heads/master@{#451744}

[modify] https://crrev.com/c183eaa3876b03b16c2c84e3dfb3b87b63071a5b/third_party/WebKit/Source/core/editing/Editor.cpp
[modify] https://crrev.com/c183eaa3876b03b16c2c84e3dfb3b87b63071a5b/third_party/WebKit/Source/core/editing/FrameSelection.cpp
[modify] https://crrev.com/c183eaa3876b03b16c2c84e3dfb3b87b63071a5b/third_party/WebKit/Source/core/editing/FrameSelection.h
[modify] https://crrev.com/c183eaa3876b03b16c2c84e3dfb3b87b63071a5b/third_party/WebKit/Source/core/editing/FrameSelectionTest.cpp
[modify] https://crrev.com/c183eaa3876b03b16c2c84e3dfb3b87b63071a5b/third_party/WebKit/Source/core/editing/commands/DeleteSelectionCommandTest.cpp
[modify] https://crrev.com/c183eaa3876b03b16c2c84e3dfb3b87b63071a5b/third_party/WebKit/Source/core/editing/commands/EditorCommand.cpp
[modify] https://crrev.com/c183eaa3876b03b16c2c84e3dfb3b87b63071a5b/third_party/WebKit/Source/core/editing/spellcheck/SpellChecker.cpp
[modify] https://crrev.com/c183eaa3876b03b16c2c84e3dfb3b87b63071a5b/third_party/WebKit/Source/core/input/EventHandlerTest.cpp
[modify] https://crrev.com/c183eaa3876b03b16c2c84e3dfb3b87b63071a5b/third_party/WebKit/Source/core/page/DragController.cpp
[modify] https://crrev.com/c183eaa3876b03b16c2c84e3dfb3b87b63071a5b/third_party/WebKit/Source/web/WebFrameWidgetImpl.cpp
[modify] https://crrev.com/c183eaa3876b03b16c2c84e3dfb3b87b63071a5b/third_party/WebKit/Source/web/WebViewImpl.cpp
Project Member

Comment 5 by bugdroid1@chromium.org, Feb 21 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f895c25f6f60ffbddc9afac93d134a677551b37b

commit f895c25f6f60ffbddc9afac93d134a677551b37b
Author: yosin <yosin@chromium.org>
Date: Tue Feb 21 17:03:44 2017

Expand FrameSeleciton::isRange()  to increase chances of hoisting update layout

This patch expands |FrameSeleciton::isRange()| to increase
chance of hoisting update layout.

Note: This is mechanical change to replace |selection().isRange()|
by |selection().computeVisibleSelectionInDOMTreeDeprecated().isRange()|
Following patch will remove deprecated version.

This patch is apart of expanding expensive member functions in |FrameSelection|:
- rootEditableElement()
- hasEditableStyle()
- isContentEditable()
- isContentRichlyEditable()
- getSelectionType()
- base()
- extent()
- start()
- end()
- isNone()
- isRange()
- isRange()

BUG= 694360 
TEST=n/a; no behavior changes

Review-Url: https://codereview.chromium.org/2708703003
Cr-Commit-Position: refs/heads/master@{#451781}

[modify] https://crrev.com/f895c25f6f60ffbddc9afac93d134a677551b37b/third_party/WebKit/Source/core/editing/Editor.cpp
[modify] https://crrev.com/f895c25f6f60ffbddc9afac93d134a677551b37b/third_party/WebKit/Source/core/editing/FrameSelection.h
[modify] https://crrev.com/f895c25f6f60ffbddc9afac93d134a677551b37b/third_party/WebKit/Source/core/editing/SelectionController.cpp
[modify] https://crrev.com/f895c25f6f60ffbddc9afac93d134a677551b37b/third_party/WebKit/Source/core/editing/commands/EditorCommand.cpp
[modify] https://crrev.com/f895c25f6f60ffbddc9afac93d134a677551b37b/third_party/WebKit/Source/core/editing/commands/TypingCommand.cpp
[modify] https://crrev.com/f895c25f6f60ffbddc9afac93d134a677551b37b/third_party/WebKit/Source/core/frame/LocalFrame.cpp
[modify] https://crrev.com/f895c25f6f60ffbddc9afac93d134a677551b37b/third_party/WebKit/Source/core/html/HTMLLabelElement.cpp
[modify] https://crrev.com/f895c25f6f60ffbddc9afac93d134a677551b37b/third_party/WebKit/Source/core/input/EventHandler.cpp
[modify] https://crrev.com/f895c25f6f60ffbddc9afac93d134a677551b37b/third_party/WebKit/Source/core/input/EventHandlerTest.cpp
[modify] https://crrev.com/f895c25f6f60ffbddc9afac93d134a677551b37b/third_party/WebKit/Source/core/input/MouseEventManager.cpp
[modify] https://crrev.com/f895c25f6f60ffbddc9afac93d134a677551b37b/third_party/WebKit/Source/core/page/DragController.cpp
[modify] https://crrev.com/f895c25f6f60ffbddc9afac93d134a677551b37b/third_party/WebKit/Source/web/WebLocalFrameImpl.cpp
Project Member

Comment 6 by bugdroid1@chromium.org, Feb 22 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/871eda697365b8e2f6513bb3ccb376bc27ef4bbe

commit 871eda697365b8e2f6513bb3ccb376bc27ef4bbe
Author: yosin <yosin@chromium.org>
Date: Wed Feb 22 08:53:26 2017

Expand FrameSeleciton::start() to increase chances of hoisting update layout

This patch expands |FrameSeleciton::start()| to increase
chance of hoisting update layout.

Note: This is mechanical change to replace |selection().start()|
by |selection().computeVisibleSelectionInDOMTreeDeprecated().start()|
Following patch will remove deprecated version.

This patch is apart of expanding expensive member functions in |FrameSelection|:
- rootEditableElement()
- hasEditableStyle()
- isContentEditable()
- isContentRichlyEditable()
- getSelectionType()
- base()
- extent()
- start()
- end()
- isNone()
- isCaret()
- isRange()

BUG= 694360 
TEST=n/a; no behavior changes

Review-Url: https://codereview.chromium.org/2702403004
Cr-Commit-Position: refs/heads/master@{#451939}

[modify] https://crrev.com/871eda697365b8e2f6513bb3ccb376bc27ef4bbe/third_party/WebKit/Source/core/clipboard/DataTransfer.cpp
[modify] https://crrev.com/871eda697365b8e2f6513bb3ccb376bc27ef4bbe/third_party/WebKit/Source/core/editing/Editor.cpp
[modify] https://crrev.com/871eda697365b8e2f6513bb3ccb376bc27ef4bbe/third_party/WebKit/Source/core/editing/EditorKeyBindings.cpp
[modify] https://crrev.com/871eda697365b8e2f6513bb3ccb376bc27ef4bbe/third_party/WebKit/Source/core/editing/FrameSelection.cpp
[modify] https://crrev.com/871eda697365b8e2f6513bb3ccb376bc27ef4bbe/third_party/WebKit/Source/core/editing/FrameSelection.h
[modify] https://crrev.com/871eda697365b8e2f6513bb3ccb376bc27ef4bbe/third_party/WebKit/Source/core/editing/FrameSelectionTest.cpp
[modify] https://crrev.com/871eda697365b8e2f6513bb3ccb376bc27ef4bbe/third_party/WebKit/Source/core/editing/InputMethodController.cpp
[modify] https://crrev.com/871eda697365b8e2f6513bb3ccb376bc27ef4bbe/third_party/WebKit/Source/core/editing/InputMethodControllerTest.cpp
[modify] https://crrev.com/871eda697365b8e2f6513bb3ccb376bc27ef4bbe/third_party/WebKit/Source/core/editing/spellcheck/SpellChecker.cpp
[modify] https://crrev.com/871eda697365b8e2f6513bb3ccb376bc27ef4bbe/third_party/WebKit/Source/core/input/EventHandlerTest.cpp
[modify] https://crrev.com/871eda697365b8e2f6513bb3ccb376bc27ef4bbe/third_party/WebKit/Source/web/WebFrameWidgetImpl.cpp
[modify] https://crrev.com/871eda697365b8e2f6513bb3ccb376bc27ef4bbe/third_party/WebKit/Source/web/WebLocalFrameImpl.cpp
[modify] https://crrev.com/871eda697365b8e2f6513bb3ccb376bc27ef4bbe/third_party/WebKit/Source/web/WebViewImpl.cpp
Project Member

Comment 7 by bugdroid1@chromium.org, Feb 22 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/1886d611f3f71c0ebe55a6d8fc49a40297ef7f99

commit 1886d611f3f71c0ebe55a6d8fc49a40297ef7f99
Author: yosin <yosin@chromium.org>
Date: Wed Feb 22 09:38:19 2017

Expand FrameSeleciton::base() to increase chances of hoisting update layout

This patch expands |FrameSeleciton::base()| to increase chance of hoisting
update layout.

Note: This is mechanical change to replace |selection().base()|
by |selection().computeVisibleSelectionInDOMTreeDeprecated().base()|
and modify some explicit case use |computeVisibleSelectionInDOMTree()|.
Following patch will remove deprecated version.

This patch is apart of expanding expensive member functions in |FrameSelection|:
- rootEditableElement()
- hasEditableStyle()
- isContentEditable()
- isContentRichlyEditable()
- getSelectionType()
- base()
- extent()
- start()
- end()
- isNone()
- isCaret()
- isRange()

BUG= 694360 
TEST=n/a; no behavior changes

Review-Url: https://codereview.chromium.org/2709793003
Cr-Commit-Position: refs/heads/master@{#451957}

[modify] https://crrev.com/1886d611f3f71c0ebe55a6d8fc49a40297ef7f99/third_party/WebKit/Source/core/editing/FrameSelection.h
[modify] https://crrev.com/1886d611f3f71c0ebe55a6d8fc49a40297ef7f99/third_party/WebKit/Source/core/editing/InputMethodController.cpp
[modify] https://crrev.com/1886d611f3f71c0ebe55a6d8fc49a40297ef7f99/third_party/WebKit/Source/core/editing/commands/DeleteSelectionCommandTest.cpp
[modify] https://crrev.com/1886d611f3f71c0ebe55a6d8fc49a40297ef7f99/third_party/WebKit/Source/core/page/DragController.cpp
[modify] https://crrev.com/1886d611f3f71c0ebe55a6d8fc49a40297ef7f99/third_party/WebKit/Source/core/testing/Internals.cpp
Project Member

Comment 8 by bugdroid1@chromium.org, Feb 22 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a68600309d39180eda0c6f30be56058dabe2d8c8

commit a68600309d39180eda0c6f30be56058dabe2d8c8
Author: yosin <yosin@chromium.org>
Date: Wed Feb 22 09:47:54 2017

Expand FrameSeleciton::isContentEditable() to increase chances of hoisting update layout

This patch expands |FrameSeleciton::isContentEditable()| to increase
chance of hoisting update layout.

Note: This is mechanical change to replace |selection().isContentEditable()|
by |selection().computeVisibleSelectionInDOMTreeDeprecated().isContentEditable()|
Following patch will remove deprecated version.

This patch is apart of expanding expensive member functions in |FrameSelection|:
- rootEditableElement()
- hasEditableStyle()
- isContentEditable()
- isContentRichlyEditable()
- getSelectionType()
- base()
- extent()
- start()
- end()
- isNone()
- isCaret()
- isRange()

BUG= 694360 
TEST=n/a; no behavior changes

Review-Url: https://codereview.chromium.org/2709503003
Cr-Commit-Position: refs/heads/master@{#451959}

[modify] https://crrev.com/a68600309d39180eda0c6f30be56058dabe2d8c8/third_party/WebKit/Source/core/editing/Editor.cpp
[modify] https://crrev.com/a68600309d39180eda0c6f30be56058dabe2d8c8/third_party/WebKit/Source/core/editing/FrameSelection.cpp
[modify] https://crrev.com/a68600309d39180eda0c6f30be56058dabe2d8c8/third_party/WebKit/Source/core/editing/FrameSelection.h
[modify] https://crrev.com/a68600309d39180eda0c6f30be56058dabe2d8c8/third_party/WebKit/Source/core/editing/SelectionController.cpp
[modify] https://crrev.com/a68600309d39180eda0c6f30be56058dabe2d8c8/third_party/WebKit/Source/core/editing/commands/EditorCommand.cpp
[modify] https://crrev.com/a68600309d39180eda0c6f30be56058dabe2d8c8/third_party/WebKit/Source/core/page/DragController.cpp
[modify] https://crrev.com/a68600309d39180eda0c6f30be56058dabe2d8c8/third_party/WebKit/Source/core/svg/UnsafeSVGAttributeSanitizationTest.cpp
Project Member

Comment 9 by bugdroid1@chromium.org, Feb 22 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/44432291616740a6a8ae87b6460aa2b5be812018

commit 44432291616740a6a8ae87b6460aa2b5be812018
Author: yosin <yosin@chromium.org>
Date: Wed Feb 22 10:08:39 2017

Expand FrameSeleciton::rootEditableElement() to increase chances of hoisting update layout

This patch expands |FrameSeleciton::rootEditableElement()| to increase
chance of hoisting update layout.

Note: This is mechanical change to replace |selection().rootEditableElement()|
by |selection().computeVisibleSelectionInDOMTreeDeprecated().rootEditableElement()|
Following patch will remove deprecated version.

This patch is apart of expanding expensive member functions in |FrameSelection|:
- rootEditableElement()
- hasEditableStyle()
- isContentEditable()
- isContentRichlyEditable()
- getSelectionType()
- base()
- extent()
- start()
- end()
- isNone()
- isCaret()
- isRange()

BUG= 694360 
TEST=n/a; no behavior changes

Review-Url: https://codereview.chromium.org/2706033011
Cr-Commit-Position: refs/heads/master@{#451967}

[modify] https://crrev.com/44432291616740a6a8ae87b6460aa2b5be812018/third_party/WebKit/Source/core/editing/Editor.cpp
[modify] https://crrev.com/44432291616740a6a8ae87b6460aa2b5be812018/third_party/WebKit/Source/core/editing/FrameSelection.cpp
[modify] https://crrev.com/44432291616740a6a8ae87b6460aa2b5be812018/third_party/WebKit/Source/core/editing/FrameSelection.h
[modify] https://crrev.com/44432291616740a6a8ae87b6460aa2b5be812018/third_party/WebKit/Source/core/input/EventHandler.cpp
Project Member

Comment 10 by bugdroid1@chromium.org, Feb 22 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/82b855c5f7d20fc8a8b5bcb4a61f17e3fde257de

commit 82b855c5f7d20fc8a8b5bcb4a61f17e3fde257de
Author: yosin <yosin@chromium.org>
Date: Wed Feb 22 14:07:55 2017

Expand FrameSeleciton::getSelectionType() to increase chances of hoisting update layout

This patch expands |FrameSeleciton::getSelectionType()| to increase
chance of hoisting update layout.

Note: This is mechanical change to replace |selection().getSelectionType()|
by |selection().computeVisibleSelectionInDOMTreeDeprecated().getSelectionType()|
Following patch will remove deprecated version.

This patch is apart of expanding expensive member functions in |FrameSelection|:
- rootEditableElement()
- hasEditableStyle()
- isContentEditable()
- isContentRichlyEditable()
- getSelectionType()
- base()
- extent()
- start()
- end()
- isNone()
- isCaret()
- isRange()

BUG= 694360 
TEST=n/a; no behavior changes

Review-Url: https://codereview.chromium.org/2706013005
Cr-Commit-Position: refs/heads/master@{#452030}

[modify] https://crrev.com/82b855c5f7d20fc8a8b5bcb4a61f17e3fde257de/third_party/WebKit/Source/core/editing/Editor.cpp
[modify] https://crrev.com/82b855c5f7d20fc8a8b5bcb4a61f17e3fde257de/third_party/WebKit/Source/core/editing/FrameSelection.cpp
[modify] https://crrev.com/82b855c5f7d20fc8a8b5bcb4a61f17e3fde257de/third_party/WebKit/Source/core/editing/FrameSelection.h
[modify] https://crrev.com/82b855c5f7d20fc8a8b5bcb4a61f17e3fde257de/third_party/WebKit/Source/core/svg/UnsafeSVGAttributeSanitizationTest.cpp
Project Member

Comment 11 by bugdroid1@chromium.org, Feb 23 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/3032e512f4c50e0275cc2306cf75208ee7c9a2c4

commit 3032e512f4c50e0275cc2306cf75208ee7c9a2c4
Author: yosin <yosin@chromium.org>
Date: Thu Feb 23 08:56:46 2017

Expand FrameSeleciton::isNone() to increase chances of hoisting update layout

This patch expands |FrameSeleciton::isNone()| to increase chance of hoisting
update layout.

Note: This is mechanical change to replace |selection().isNone()|
by |selection().computeVisibleSelectionInDOMTreeDeprecated().isNone()|
Following patch will remove deprecated version.

This patch is apart of expanding expensive member functions in |FrameSelection|:
- rootEditableElement()
- hasEditableStyle()
- isContentEditable()
- isContentRichlyEditable()
- getSelectionType()
- base()
- extent()
- start()
- end()
- isNone()
- isCaret()
- isRange()

BUG= 694360 
TEST=n/a; no behavior changes

Review-Url: https://codereview.chromium.org/2710883002
Cr-Commit-Position: refs/heads/master@{#452435}

[modify] https://crrev.com/3032e512f4c50e0275cc2306cf75208ee7c9a2c4/third_party/WebKit/Source/core/editing/DOMSelection.cpp
[modify] https://crrev.com/3032e512f4c50e0275cc2306cf75208ee7c9a2c4/third_party/WebKit/Source/core/editing/Editor.cpp
[modify] https://crrev.com/3032e512f4c50e0275cc2306cf75208ee7c9a2c4/third_party/WebKit/Source/core/editing/FrameSelection.cpp
[modify] https://crrev.com/3032e512f4c50e0275cc2306cf75208ee7c9a2c4/third_party/WebKit/Source/core/editing/FrameSelection.h
[modify] https://crrev.com/3032e512f4c50e0275cc2306cf75208ee7c9a2c4/third_party/WebKit/Source/core/editing/FrameSelectionTest.cpp
[modify] https://crrev.com/3032e512f4c50e0275cc2306cf75208ee7c9a2c4/third_party/WebKit/Source/core/editing/InputMethodController.cpp
[modify] https://crrev.com/3032e512f4c50e0275cc2306cf75208ee7c9a2c4/third_party/WebKit/Source/core/editing/commands/EditorCommand.cpp
[modify] https://crrev.com/3032e512f4c50e0275cc2306cf75208ee7c9a2c4/third_party/WebKit/Source/core/input/EventHandler.cpp
[modify] https://crrev.com/3032e512f4c50e0275cc2306cf75208ee7c9a2c4/third_party/WebKit/Source/core/input/EventHandlerTest.cpp
[modify] https://crrev.com/3032e512f4c50e0275cc2306cf75208ee7c9a2c4/third_party/WebKit/Source/core/page/DragController.cpp
[modify] https://crrev.com/3032e512f4c50e0275cc2306cf75208ee7c9a2c4/third_party/WebKit/Source/web/WebFrameWidgetImpl.cpp
[modify] https://crrev.com/3032e512f4c50e0275cc2306cf75208ee7c9a2c4/third_party/WebKit/Source/web/WebLocalFrameImpl.cpp
[modify] https://crrev.com/3032e512f4c50e0275cc2306cf75208ee7c9a2c4/third_party/WebKit/Source/web/WebViewImpl.cpp
Project Member

Comment 12 by bugdroid1@chromium.org, Feb 23 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/0c3513655473a49b2ef7aeafb366f8ca74422a5b

commit 0c3513655473a49b2ef7aeafb366f8ca74422a5b
Author: yosin <yosin@chromium.org>
Date: Thu Feb 23 23:40:59 2017

Expand FrameSeleciton::hasEditableStyle() to increase chances of hoisting update layout

This patch expands |FrameSeleciton::hasEditableStyle()| to increase chance of
hoisting update layout.

Note: This is mechanical change to replace |selection().hasEditableStyle()|
by |selection().computeVisibleSelectionInDOMTreeDeprecated().hasEditableStyle()| and
manual change to |computeVisibleSelectionInDOMTree()| in explicit case, e.g.
just after |computeVisibleSelectionInDOMTreeDeprecated()|.

Following patch will remove deprecated version.

This patch is apart of expanding expensive member functions in |FrameSelection|:
- rootEditableElement()
- hasEditableStyle()
- isContentEditable()
- isContentRichlyEditable()
- getSelectionType()
- base()
- extent()
- start()
- end()
- isNone()
- isCaret()
- isRange()

BUG= 694360 
TEST=n/a; no behavior changes

Review-Url: https://codereview.chromium.org/2708213006
Cr-Commit-Position: refs/heads/master@{#452675}

[modify] https://crrev.com/0c3513655473a49b2ef7aeafb366f8ca74422a5b/third_party/WebKit/Source/core/editing/FrameSelection.cpp
[modify] https://crrev.com/0c3513655473a49b2ef7aeafb366f8ca74422a5b/third_party/WebKit/Source/core/editing/FrameSelection.h
[modify] https://crrev.com/0c3513655473a49b2ef7aeafb366f8ca74422a5b/third_party/WebKit/Source/core/editing/SelectionController.cpp
Project Member

Comment 13 by bugdroid1@chromium.org, Feb 24 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/34cc7838d2f985415a86720094454696a953a4c3

commit 34cc7838d2f985415a86720094454696a953a4c3
Author: yosin <yosin@chromium.org>
Date: Fri Feb 24 02:02:02 2017

Expand FrameSeleciton::extent() to increase chances of hoisting update layout

This patch expands |FrameSeleciton::extent()| to increase chance of hoisting
update layout.

Note: This is mechanical change to replace |selection().extent()|
by |selection().computeVisibleSelectionInDOMTreeDeprecated().extent()| and
manual change to |computeVisibleSelectionInDOMTree()| in explicit case, e.g.
just after |computeVisibleSelectionInDOMTreeDeprecated()|.

Following patch will remove deprecated version.

This patch is apart of expanding expensive member functions in |FrameSelection|:
- rootEditableElement()
- hasEditableStyle()
- isContentEditable()
- isContentRichlyEditable()
- getSelectionType()
- base()
- extent()
- start()
- end()
- isNone()
- isCaret()
- isRange()

BUG= 694360 
TEST=n/a; no behavior changes

Review-Url: https://codereview.chromium.org/2709943004
Cr-Commit-Position: refs/heads/master@{#452714}

[modify] https://crrev.com/34cc7838d2f985415a86720094454696a953a4c3/third_party/WebKit/Source/core/editing/FrameSelection.cpp
[modify] https://crrev.com/34cc7838d2f985415a86720094454696a953a4c3/third_party/WebKit/Source/core/editing/FrameSelection.h
[modify] https://crrev.com/34cc7838d2f985415a86720094454696a953a4c3/third_party/WebKit/Source/core/editing/InputMethodController.cpp
[modify] https://crrev.com/34cc7838d2f985415a86720094454696a953a4c3/third_party/WebKit/Source/core/testing/Internals.cpp

Comment 14 by yosin@chromium.org, Feb 24 2017

Status: Fixed (was: Started)
►

Sign in to add a comment