New issue
Advanced search Search tips

Issue 694348 link

Starred by 2 users
Status: Fixed
Owner:
no...@chromium.org
Closed: Sep 24
Cc:
tandrii@chromium.org
no...@chromium.org
phosek@chromium.org
iannu...@google.com
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

Have a single way to denote patchset to recipes

Project Member Reported by iannucci@chromium.org, Feb 21 2017 
Right now we have many different properties which are involved with recipes that receive a patchset:

  * patch_project
  * patchset
  * patch_storage
  * issue
  * patch_gerrit_url
  * patch_git_url
  * patch_issue
  * patch_project
  * patch_ref
  * patch_set
 
And maybe others? This is wayyy too many properties. All of these cases could conceptually be reduced to a single property "patch_url", which the recipe would interpret and be able to apply appropriately (even if it was just a step that expanded the url into these existing properties, at least the API to the recipe would be sane).

I think we're at the point where such a cleanup would be possible, especially after we have issue 662654 resolved.

Comment 1 by no...@chromium.org, Feb 21 2017 

proposal: make it a direct a function of buildbucket's buildset tag:

buildset: patch/gerrit/chromium-review.googlesource.com/1000/1
patch_url:    gerrit://chromium-review.googlesource.com/1000/1

buildset: patch/rietveld/codereview.chromium.org/1000/1	
patch_url:    rietveld://codereview.chromium.org/1000/1

from these URLs we can derive without RPCs:
  * patchset
  * patch_storage
  * issue
  * patch_gerrit_url
  * patch_issue
  * patch_ref
  * patch_set

with an RPC:

  * patch_project
  * patch_git_url

Comment 2 by iannucci@chromium.org, Feb 21 2017 

Yeah I'm OK with that. So are you proposing that there would be NO 'patch_url' property, and it will JUST rely on the properties['buildbucket']['buildset'] value? Or would it look for 'patch_url' in the form you describe, and if it's missing, synthesize it from the properties['buildbucket']['buildset'] value?

Comment 3 by no...@chromium.org, Feb 21 2017 

no no, I propose the patch_url property to have one of the proposed schemes. "buildbucket" property must not be consulted. In fact, buildbucket property is an implementation detail of buildbot-buildbucket integration (it stores some stuff there) and this property is not present in Milo jobs, e.g. https://luci-milo.appspot.com/swarming/task/347264189b398f10

Comment 4 by iannucci@chromium.org, Feb 21 2017 

oh, OK. So all recipes would expect 'patch_url' with the schema you propose. SGTM.

Comment 5 by iannucci@chromium.org, May 15 2017

Status: Available (was: Untriaged)
This will need to be revisited after we use gerrit for everything. I suspect it will be easy to close then.
Project Member

Comment 6 by sheriffbot@chromium.org, May 16 2018

Labels: Hotlist-Recharge-Cold
Status: Untriaged (was: Available)
This issue has been Available for over a year. If it's no longer important or seems unlikely to be fixed, please consider closing it out. If it is important, please re-triage the issue.

Sorry for the inconvenience if the bug really should have been left as Available.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

Comment 7 by no...@chromium.org, May 16 2018 

buildbucket module has build_input attr with a Gerrit change. It is derived from buildsets. It should be used instead.

Comment 8 by tandrii@chromium.org, May 16 2018

Cc: phosek@chromium.org
Labels: -Hotlist-Recharge-Cold
Status: Available (was: Untriaged)
Yeah, after nodir@ work in issue 784021, the right way is possible. The challenge is removing the other ways. This means:
 * migrate bot_update
 * change default test_api.properties.tryserver to emit just buildset (and all downstream changes it entails)
 * stop setting properties in CQ, Gerrit buildbucket plugin, and git cl try.

Comment 9 by no...@chromium.org, Aug 30

Owner: no...@chromium.org
Status: Started (was: Available)
Project Member

Comment 10 by bugdroid1@chromium.org, Aug 30 

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/luci/recipes-py/+/1a9239db3740a699a5b7ba732cd0be42b89548e0

commit 1a9239db3740a699a5b7ba732cd0be42b89548e0
Author: Nodir Turakulov <nodir@google.com>
Date: Thu Aug 30 22:15:01 2018

[buildbucket] Parse CL from legacy properties

If no GerritChange was parsed from tags and patch_storage='gerrit', then
parse GerritChange from properties patch_gerrit_url, patch_project, patch_issue,
patch_set, issue and/or patchset.

R=tandrii@chromium.org
Recipe-Nontrivial-Roll: build
Recipe-Nontrivial-Roll: build_limited_scripts_slave
Bug: 694348
Change-Id: I373e902ee05c351561d9037d17072e0bf7202fff
Reviewed-on: https://chromium-review.googlesource.com/1196934
Commit-Queue: Nodir Turakulov <nodir@chromium.org>
Reviewed-by: Andrii Shyshkalov <tandrii@chromium.org>

[add] https://crrev.com/1a9239db3740a699a5b7ba732cd0be42b89548e0/recipe_modules/buildbucket/tests/build.expected/buildbot gerrit change.json
[add] https://crrev.com/1a9239db3740a699a5b7ba732cd0be42b89548e0/recipe_modules/buildbucket/tests/build.expected/buildbot gerrit change, issue and patchset properties.json
[modify] https://crrev.com/1a9239db3740a699a5b7ba732cd0be42b89548e0/recipe_modules/buildbucket/tests/build.py
[add] https://crrev.com/1a9239db3740a699a5b7ba732cd0be42b89548e0/recipe_modules/buildbucket/tests/build.expected/buildbot gerrit change, string issue, not a number.json
[add] https://crrev.com/1a9239db3740a699a5b7ba732cd0be42b89548e0/recipe_modules/buildbucket/tests/build.expected/buildbot gerrit change, no project.json
[modify] https://crrev.com/1a9239db3740a699a5b7ba732cd0be42b89548e0/README.recipes.md
[modify] https://crrev.com/1a9239db3740a699a5b7ba732cd0be42b89548e0/recipe_modules/buildbucket/api.py
[modify] https://crrev.com/1a9239db3740a699a5b7ba732cd0be42b89548e0/recipe_modules/buildbucket/__init__.py
[modify] https://crrev.com/1a9239db3740a699a5b7ba732cd0be42b89548e0/recipe_modules/buildbucket/util.py
[add] https://crrev.com/1a9239db3740a699a5b7ba732cd0be42b89548e0/recipe_modules/buildbucket/tests/build.expected/buildbot gerrit change, string issue.json
Project Member

Comment 11 by bugdroid1@chromium.org, Aug 31 

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/luci/recipes-py/+/b159b6a105fb08ac1bf1ab55d0d3537676d6226b

commit b159b6a105fb08ac1bf1ab55d0d3537676d6226b
Author: Michael Achenbach <machenbach@chromium.org>
Date: Fri Aug 31 09:05:44 2018

Revert "[buildbucket] Parse CL from legacy properties"

This reverts commit 1a9239db3740a699a5b7ba732cd0be42b89548e0.

Reason for revert: https://crbug.com/879495

Original change's description:
> [buildbucket] Parse CL from legacy properties
> 
> If no GerritChange was parsed from tags and patch_storage='gerrit', then
> parse GerritChange from properties patch_gerrit_url, patch_project, patch_issue,
> patch_set, issue and/or patchset.
> 
> R=​tandrii@chromium.org
> Recipe-Nontrivial-Roll: build
> Recipe-Nontrivial-Roll: build_limited_scripts_slave
> Bug: 694348
> Change-Id: I373e902ee05c351561d9037d17072e0bf7202fff
> Reviewed-on: https://chromium-review.googlesource.com/1196934
> Commit-Queue: Nodir Turakulov <nodir@chromium.org>
> Reviewed-by: Andrii Shyshkalov <tandrii@chromium.org>

TBR=nodir@chromium.org,tandrii@chromium.org

Change-Id: I24e41df200e1910461dd3cffe0e7aa6f59d013bd
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 694348,879495
Reviewed-on: https://chromium-review.googlesource.com/1199065
Reviewed-by: Michael Achenbach <machenbach@chromium.org>
Commit-Queue: Michael Achenbach <machenbach@chromium.org>

[delete] https://crrev.com/1a9239db3740a699a5b7ba732cd0be42b89548e0/recipe_modules/buildbucket/tests/build.expected/buildbot gerrit change.json
[delete] https://crrev.com/1a9239db3740a699a5b7ba732cd0be42b89548e0/recipe_modules/buildbucket/tests/build.expected/buildbot gerrit change, issue and patchset properties.json
[modify] https://crrev.com/b159b6a105fb08ac1bf1ab55d0d3537676d6226b/recipe_modules/buildbucket/tests/build.py
[delete] https://crrev.com/1a9239db3740a699a5b7ba732cd0be42b89548e0/recipe_modules/buildbucket/tests/build.expected/buildbot gerrit change, string issue, not a number.json
[delete] https://crrev.com/1a9239db3740a699a5b7ba732cd0be42b89548e0/recipe_modules/buildbucket/tests/build.expected/buildbot gerrit change, no project.json
[modify] https://crrev.com/b159b6a105fb08ac1bf1ab55d0d3537676d6226b/README.recipes.md
[modify] https://crrev.com/b159b6a105fb08ac1bf1ab55d0d3537676d6226b/recipe_modules/buildbucket/api.py
[modify] https://crrev.com/b159b6a105fb08ac1bf1ab55d0d3537676d6226b/recipe_modules/buildbucket/__init__.py
[modify] https://crrev.com/b159b6a105fb08ac1bf1ab55d0d3537676d6226b/recipe_modules/buildbucket/util.py
[delete] https://crrev.com/1a9239db3740a699a5b7ba732cd0be42b89548e0/recipe_modules/buildbucket/tests/build.expected/buildbot gerrit change, string issue.json
Project Member

Comment 12 by bugdroid1@chromium.org, Aug 31 

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/luci/recipes-py/+/f25fbdce1dc0976980f2b1f5120af828e9a68a34

commit f25fbdce1dc0976980f2b1f5120af828e9a68a34
Author: Nodir Turakulov <nodir@google.com>
Date: Fri Aug 31 16:30:46 2018

Reland [buildbucket] Parse CL from legacy properties

This is a reland of
https://chromium-review.googlesource.com/c/infra/luci/recipes-py/+/1196934

Only generated files are different.

Original change's description:
> [buildbucket] Parse CL from legacy properties
>
> If no GerritChange was parsed from tags and patch_storage='gerrit', then
> parse GerritChange from properties patch_gerrit_url, patch_project, patch_issue,
> patch_set, issue and/or patchset.
>
> R=tandrii@chromium.org
> Recipe-Nontrivial-Roll: build
> Recipe-Nontrivial-Roll: build_limited_scripts_slave
> Bug: 694348
> Change-Id: I373e902ee05c351561d9037d17072e0bf7202fff
> Reviewed-on: https://chromium-review.googlesource.com/1196934
> Commit-Queue: Nodir Turakulov <nodir@chromium.org>
> Reviewed-by: Andrii Shyshkalov <tandrii@chromium.org>

Recipe-Nontrivial-Roll: build
Recipe-Nontrivial-Roll: build_limited_scripts_slave
Bug: 877161, 879495
Change-Id: Iec301d9218262b48cc1c18dbd2861e3bdb98564b
Reviewed-on: https://chromium-review.googlesource.com/1199846
Commit-Queue: Nodir Turakulov <nodir@chromium.org>
Reviewed-by: Michael Achenbach <machenbach@chromium.org>

[add] https://crrev.com/f25fbdce1dc0976980f2b1f5120af828e9a68a34/recipe_modules/buildbucket/tests/build.expected/buildbot gerrit change.json
[add] https://crrev.com/f25fbdce1dc0976980f2b1f5120af828e9a68a34/recipe_modules/buildbucket/tests/build.expected/buildbot gerrit change, issue and patchset properties.json
[modify] https://crrev.com/f25fbdce1dc0976980f2b1f5120af828e9a68a34/recipe_modules/buildbucket/tests/build.py
[add] https://crrev.com/f25fbdce1dc0976980f2b1f5120af828e9a68a34/recipe_modules/buildbucket/tests/build.expected/buildbot gerrit change, string issue, not a number.json
[add] https://crrev.com/f25fbdce1dc0976980f2b1f5120af828e9a68a34/recipe_modules/buildbucket/tests/build.expected/buildbot gerrit change, no project.json
[modify] https://crrev.com/f25fbdce1dc0976980f2b1f5120af828e9a68a34/README.recipes.md
[modify] https://crrev.com/f25fbdce1dc0976980f2b1f5120af828e9a68a34/recipe_modules/buildbucket/api.py
[modify] https://crrev.com/f25fbdce1dc0976980f2b1f5120af828e9a68a34/recipe_modules/buildbucket/__init__.py
[modify] https://crrev.com/f25fbdce1dc0976980f2b1f5120af828e9a68a34/recipe_modules/buildbucket/util.py
[add] https://crrev.com/f25fbdce1dc0976980f2b1f5120af828e9a68a34/recipe_modules/buildbucket/tests/build.expected/buildbot gerrit change, string issue.json
Project Member

Comment 13 by bugdroid1@chromium.org, Aug 31 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/tools/depot_tools/+/efc95d6b9a8b53b8aa1d03ced4f2943894582b66

commit efc95d6b9a8b53b8aa1d03ced4f2943894582b66
Author: Nodir Turakulov <nodir@google.com>
Date: Fri Aug 31 21:30:57 2018

[bot_update] Untie revision and repository properties

repository and revision have less to do with each other than it seems:
revision is for checkout and the part of code that reads revision does not
read repository.
repository property is used to determine what to apply the patchset to.

When initializing their values from buildbucket.build.input, do it separately.
Also, initialize repository from Gerrit changes, not Gitiles commit.

See also
https://chromium-review.googlesource.com/c/infra/luci/recipes-py/+/1199854
https://chromium-review.googlesource.com/c/infra/luci/recipes-py/+/1199856
Bug: 877161, 694348
Change-Id: I4907a31ce055a3526b15f1a3c8e8f15c2c831437
Reviewed-on: https://chromium-review.googlesource.com/1200065
Reviewed-by: Andrii Shyshkalov <tandrii@chromium.org>
Commit-Queue: Nodir Turakulov <nodir@chromium.org>

[modify] https://crrev.com/efc95d6b9a8b53b8aa1d03ced4f2943894582b66/recipes/README.recipes.md
[modify] https://crrev.com/efc95d6b9a8b53b8aa1d03ced4f2943894582b66/recipes/recipe_modules/bot_update/examples/buildbucket.py
[modify] https://crrev.com/efc95d6b9a8b53b8aa1d03ced4f2943894582b66/recipes/recipe_modules/bot_update/api.py
[add] https://crrev.com/efc95d6b9a8b53b8aa1d03ced4f2943894582b66/recipes/recipe_modules/bot_update/examples/buildbucket.expected/try.json
Project Member

Comment 14 by bugdroid1@chromium.org, Aug 31 

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/luci/recipes-py/+/05d5dfbcffe7924ac6344f14904224db54a93574

commit 05d5dfbcffe7924ac6344f14904224db54a93574
Author: Nodir Turakulov <nodir@google.com>
Date: Fri Aug 31 21:35:41 2018

[buildbucket] Ignore "repository" and "branch" properties

https://chromium-review.googlesource.com/c/infra/luci/recipes-py/+/1198584
populates build.input.gitiles_commit from repository and branch properties.
This is incorrect because those properties, apparently, has nothing to do with
the commit to checkout, rather than with patchset to apply.
Therefore, they must not contribute to build.input.gitiles_commit.

This changes build.input.gitiles_commit populated from legacy property to never
specify host and project (i.e. they are not guaranteed to be populated),
so tags_for_child_build() was updated accordingly.

bot_update is being updated to (temporarily) read "repository" property from
build.input.gerrit_changes[0] in case it is missing, as opposed to
build.input.gitiles_commit:
https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1200065

Bug: 877161, 694348
Change-Id: I0fd8dec0b15fab6a4363a3b7b2220fdd18160639
Reviewed-on: https://chromium-review.googlesource.com/1199854
Reviewed-by: Andrii Shyshkalov <tandrii@chromium.org>
Commit-Queue: Nodir Turakulov <nodir@chromium.org>

[delete] https://crrev.com/f25fbdce1dc0976980f2b1f5120af828e9a68a34/recipe_modules/buildbucket/tests/build.expected/buildbot gitiles commit, a project prefix.json
[delete] https://crrev.com/f25fbdce1dc0976980f2b1f5120af828e9a68a34/recipe_modules/buildbucket/tests/build.expected/buildbot gitiles commit, no revision, with CL.json
[delete] https://crrev.com/f25fbdce1dc0976980f2b1f5120af828e9a68a34/recipe_modules/buildbucket/tests/build.expected/buildbot gitiles commit, branch.json
[modify] https://crrev.com/05d5dfbcffe7924ac6344f14904224db54a93574/recipe_modules/buildbucket/tests/build.py
[delete] https://crrev.com/f25fbdce1dc0976980f2b1f5120af828e9a68a34/recipe_modules/buildbucket/tests/build.expected/buildbot gitiles commit, invalid repo.json
[rename] https://crrev.com/05d5dfbcffe7924ac6344f14904224db54a93574/recipe_modules/buildbucket/tests/build.expected/buildbot gitiles commit, invalid revision.json
[modify] https://crrev.com/05d5dfbcffe7924ac6344f14904224db54a93574/recipe_modules/buildbucket/util.py
[modify] https://crrev.com/05d5dfbcffe7924ac6344f14904224db54a93574/recipe_modules/buildbucket/tests/build.expected/buildbot gitiles commit, HEAD revision.json
[rename] https://crrev.com/05d5dfbcffe7924ac6344f14904224db54a93574/recipe_modules/buildbucket/tests/build.expected/buildbot gerrit change with revision.json
[modify] https://crrev.com/05d5dfbcffe7924ac6344f14904224db54a93574/README.recipes.md
[add] https://crrev.com/05d5dfbcffe7924ac6344f14904224db54a93574/recipe_modules/buildbucket/tests/build.expected/buildbot gerrit change, patch_gerrit_url without scheme.json
[modify] https://crrev.com/05d5dfbcffe7924ac6344f14904224db54a93574/recipe_modules/buildbucket/__init__.py
[copy] https://crrev.com/05d5dfbcffe7924ac6344f14904224db54a93574/recipe_modules/buildbucket/tests/build.expected/buildbot gerrit change, patch_gerrit_url with unexpected scheme.json
[modify] https://crrev.com/05d5dfbcffe7924ac6344f14904224db54a93574/recipe_modules/buildbucket/tests/build.expected/buildbot gitiles commit.json
[modify] https://crrev.com/05d5dfbcffe7924ac6344f14904224db54a93574/recipe_modules/buildbucket/api.py
[delete] https://crrev.com/f25fbdce1dc0976980f2b1f5120af828e9a68a34/recipe_modules/buildbucket/tests/build.expected/buildbot gitiles commit, no revision.json
[delete] https://crrev.com/f25fbdce1dc0976980f2b1f5120af828e9a68a34/recipe_modules/buildbucket/tests/build.expected/buildbot gitiles commit, neither ref nor revision.json
Project Member

Comment 15 by bugdroid1@chromium.org, Aug 31 

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/luci/recipes-py/+/809e57935211b3fcb802f74a7844d4f36eff6b87

commit 809e57935211b3fcb802f74a7844d4f36eff6b87
Author: Nodir Turakulov <nodir@google.com>
Date: Fri Aug 31 21:46:44 2018

[buildbucket] add support for parent_got_revision

got_revision is normally propagated from a parent build to a child build
as a parent_got_revision property.
It is possible that there are builders that rely on parent_got_revision
and don't use buildbucket for triggering, don't specify
commit buildset tag or whose parent did not have "revision" but
did have "got_revision".

Fallback to parent_got_revision if revision is not available.

Bug: 877161, 694348
Change-Id: I981e940bc777c809925f4dc267876d8a5910cda4
Reviewed-on: https://chromium-review.googlesource.com/1199856
Commit-Queue: Nodir Turakulov <nodir@chromium.org>
Reviewed-by: Andrii Shyshkalov <tandrii@chromium.org>

[modify] https://crrev.com/809e57935211b3fcb802f74a7844d4f36eff6b87/recipe_modules/buildbucket/tests/build.py
[add] https://crrev.com/809e57935211b3fcb802f74a7844d4f36eff6b87/recipe_modules/buildbucket/tests/build.expected/buildbot gitiles commit, both revision and parent_got_revision.json
[modify] https://crrev.com/809e57935211b3fcb802f74a7844d4f36eff6b87/README.recipes.md
[modify] https://crrev.com/809e57935211b3fcb802f74a7844d4f36eff6b87/recipe_modules/buildbucket/api.py
[modify] https://crrev.com/809e57935211b3fcb802f74a7844d4f36eff6b87/recipe_modules/buildbucket/__init__.py
[add] https://crrev.com/809e57935211b3fcb802f74a7844d4f36eff6b87/recipe_modules/buildbucket/tests/build.expected/buildbot gitiles commit, parent_got_revision.json
Project Member

Comment 16 by bugdroid1@chromium.org, Sep 1 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/27028c1e27b992351011dcb9bfeb7cd437ffc5ca

commit 27028c1e27b992351011dcb9bfeb7cd437ffc5ca
Author: depot-tools-chromium-autoroll <depot-tools-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Date: Sat Sep 01 01:25:15 2018

Roll src/third_party/depot_tools 4259762b3597..e323bd9d2263 (3 commits)

https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/4259762b3597..e323bd9d2263


git log 4259762b3597..e323bd9d2263 --date=short --no-merges --format='%ad %ae %s'
2018-08-31 recipe-roller@chromium.org Roll recipe dependencies (trivial).
2018-08-31 recipe-roller@chromium.org Roll recipe dependencies (trivial).
2018-08-31 nodir@google.com [bot_update] Untie revision and repository properties


Created with:
  gclient setdep -r src/third_party/depot_tools@e323bd9d2263

The AutoRoll server is located here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.



BUG=chromium:877161,chromium:694348
TBR=agable@chromium.org

Change-Id: I2435f620a6af4d970ed09912de690acbafa7523a
Reviewed-on: https://chromium-review.googlesource.com/1199875
Reviewed-by: depot-tools-chromium-autoroll <depot-tools-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: depot-tools-chromium-autoroll <depot-tools-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#588240}
[modify] https://crrev.com/27028c1e27b992351011dcb9bfeb7cd437ffc5ca/DEPS
Project Member

Comment 17 by bugdroid1@chromium.org, Sep 7 

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/luci/recipes-py/+/25a327e765e0410f2dcaf152db9cdaba73207182

commit 25a327e765e0410f2dcaf152db9cdaba73207182
Author: Nodir Turakulov <nodir@google.com>
Date: Fri Sep 07 18:34:10 2018

[buildbucket] Add git_repo to test_api.try_build

Gerrit project != LUCI project. Add git_repo to buildbucket.test_api.try_build
consistent with buildbucket.test_api.ci_build.

R=tandrii@chromium.org

Bug: 694348
Change-Id: I5973ecf10ccf69b931d187ec83a47b838835b162
Reviewed-on: https://chromium-review.googlesource.com/1213402
Reviewed-by: Ryan Tseng <hinoka@chromium.org>
Commit-Queue: Nodir Turakulov <nodir@chromium.org>

[modify] https://crrev.com/25a327e765e0410f2dcaf152db9cdaba73207182/recipe_modules/buildbucket/test_api.py
[modify] https://crrev.com/25a327e765e0410f2dcaf152db9cdaba73207182/recipe_modules/buildbucket/examples/full.expected/basic-try.json
[modify] https://crrev.com/25a327e765e0410f2dcaf152db9cdaba73207182/recipe_modules/buildbucket/examples/full.py
Project Member

Comment 18 by bugdroid1@chromium.org, Sep 7 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/tools/depot_tools/+/bf6feefa8a42b78a638e382c3a5b6b683b36c3aa

commit bf6feefa8a42b78a638e382c3a5b6b683b36c3aa
Author: Nodir Turakulov <nodir@google.com>
Date: Fri Sep 07 19:03:12 2018

Update tryserver to use buildbucket.build.input.gerrit_changes

tryserver module's purpose is to provide high level API for patches.
Update it to use buildbucket.build.input.gerrit_changes[0].
Add helper properties for gerrit repo URL and gerrit ref.

This will be used by both bot_update and gclient.

R=hinoka@chromium.org, tandrii@chromium.org

Bug: 694348
Change-Id: I7eb416e75737310404c4354fa680fd3499eddaa7
Reviewed-on: https://chromium-review.googlesource.com/1211653
Commit-Queue: Nodir Turakulov <nodir@chromium.org>
Reviewed-by: Ryan Tseng <hinoka@chromium.org>
Reviewed-by: Andrii Shyshkalov <tandrii@chromium.org>
Reviewed-by: Edward Lesmes <ehmaldonado@chromium.org>

[modify] https://crrev.com/bf6feefa8a42b78a638e382c3a5b6b683b36c3aa/recipes/recipe_modules/tryserver/examples/full.expected/with_gerrit_patch.json
[modify] https://crrev.com/bf6feefa8a42b78a638e382c3a5b6b683b36c3aa/recipes/recipe_modules/tryserver/api.py
[modify] https://crrev.com/bf6feefa8a42b78a638e382c3a5b6b683b36c3aa/recipes/README.recipes.md
[modify] https://crrev.com/bf6feefa8a42b78a638e382c3a5b6b683b36c3aa/recipes/recipe_modules/tryserver/examples/full.py
[modify] https://crrev.com/bf6feefa8a42b78a638e382c3a5b6b683b36c3aa/recipes/recipe_modules/tryserver/__init__.py
Project Member

Comment 21 by bugdroid1@chromium.org, Sep 7 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/tools/build/+/2a0a8686bf6fcb80ff86730d07afe1ef4b59b2e1

commit 2a0a8686bf6fcb80ff86730d07afe1ef4b59b2e1
Author: Nodir Turakulov <nodir@google.com>
Date: Fri Sep 07 21:47:44 2018

[v8] Use buildbucket in tests

Use buildbucket module in v8 tests

Bug: 694348
Change-Id: Icf4d8586117278e5df6a616e09fcab98de2cf77f
Reviewed-on: https://chromium-review.googlesource.com/1214285
Reviewed-by: Andrii Shyshkalov <tandrii@chromium.org>
Commit-Queue: Nodir Turakulov <nodir@chromium.org>

[modify] https://crrev.com/2a0a8686bf6fcb80ff86730d07afe1ef4b59b2e1/scripts/slave/recipes/v8.expected/full_tryserver_v8_v8_linux_noi18n_rel_ng.json
[modify] https://crrev.com/2a0a8686bf6fcb80ff86730d07afe1ef4b59b2e1/scripts/slave/recipes/v8.expected/full_tryserver_v8_v8_linux64_fyi_rel_ng.json
[modify] https://crrev.com/2a0a8686bf6fcb80ff86730d07afe1ef4b59b2e1/scripts/slave/recipes/v8.expected/full_tryserver_v8_v8_foobar_rel_ng_triggered_flakes.json
[modify] https://crrev.com/2a0a8686bf6fcb80ff86730d07afe1ef4b59b2e1/scripts/slave/recipes/v8.expected/full_tryserver_v8_v8_linux64_sanitizer_coverage_rel.json
[modify] https://crrev.com/2a0a8686bf6fcb80ff86730d07afe1ef4b59b2e1/scripts/slave/recipes/v8.expected/full_tryserver_v8_v8_win_rel_ng.json
[modify] https://crrev.com/2a0a8686bf6fcb80ff86730d07afe1ef4b59b2e1/scripts/slave/recipes/v8.expected/full_tryserver_v8_v8_linux_arm_rel_ng.json
[modify] https://crrev.com/2a0a8686bf6fcb80ff86730d07afe1ef4b59b2e1/scripts/slave/recipes/v8.expected/full_tryserver_v8_v8_foobar_rel_ng_triggered_triggered_by_cq.json
[modify] https://crrev.com/2a0a8686bf6fcb80ff86730d07afe1ef4b59b2e1/scripts/slave/recipes/v8.expected/full_tryserver_v8_v8_linux_dbg_ng.json
[modify] https://crrev.com/2a0a8686bf6fcb80ff86730d07afe1ef4b59b2e1/scripts/slave/recipes/v8.expected/full_tryserver_v8_v8_linux_nodcheck_rel_ng.json
[modify] https://crrev.com/2a0a8686bf6fcb80ff86730d07afe1ef4b59b2e1/scripts/slave/recipes/v8.expected/full_tryserver_v8_v8_foobar_rel_ng_triggered_slow_tests.json
[modify] https://crrev.com/2a0a8686bf6fcb80ff86730d07afe1ef4b59b2e1/scripts/slave/recipes/v8.expected/full_tryserver_v8_v8_foobar_rel_ng_triggered_test_filter.json
[modify] https://crrev.com/2a0a8686bf6fcb80ff86730d07afe1ef4b59b2e1/scripts/slave/recipes/v8.expected/full_tryserver_v8_v8_linux64_verify_csa_rel_ng.json
[modify] https://crrev.com/2a0a8686bf6fcb80ff86730d07afe1ef4b59b2e1/scripts/slave/recipes/v8.expected/full_tryserver_v8_v8_win64_msvc_rel_ng.json
[modify] https://crrev.com/2a0a8686bf6fcb80ff86730d07afe1ef4b59b2e1/scripts/slave/recipes/v8.expected/full_tryserver_v8_v8_win64_rel_ng.json
[modify] https://crrev.com/2a0a8686bf6fcb80ff86730d07afe1ef4b59b2e1/scripts/slave/recipes/v8.expected/full_tryserver_v8_v8_linux64_cfi_rel_ng.json
[modify] https://crrev.com/2a0a8686bf6fcb80ff86730d07afe1ef4b59b2e1/scripts/slave/recipes/v8.expected/full_tryserver_v8_v8_foobar_rel_ng_triggered_positional_extra_flags.json
[modify] https://crrev.com/2a0a8686bf6fcb80ff86730d07afe1ef4b59b2e1/scripts/slave/recipes/v8.expected/full_tryserver_v8_v8_linux64_asan_rel_ng.json
[modify] https://crrev.com/2a0a8686bf6fcb80ff86730d07afe1ef4b59b2e1/scripts/slave/recipes/v8.expected/full_tryserver_v8_v8_foobar_rel_ng_triggered_failures.json
[modify] https://crrev.com/2a0a8686bf6fcb80ff86730d07afe1ef4b59b2e1/scripts/slave/recipe_modules/v8/test_api.py
[modify] https://crrev.com/2a0a8686bf6fcb80ff86730d07afe1ef4b59b2e1/scripts/slave/recipes/v8.expected/full_tryserver_v8_v8_linux64_rel_ng.json
[modify] https://crrev.com/2a0a8686bf6fcb80ff86730d07afe1ef4b59b2e1/scripts/slave/recipes/v8.expected/full_tryserver_v8_v8_linux_arm64_rel_ng.json
[modify] https://crrev.com/2a0a8686bf6fcb80ff86730d07afe1ef4b59b2e1/scripts/slave/recipes/v8.expected/full_tryserver_v8_v8_foobar_rel_ng_with_cache.json
[modify] https://crrev.com/2a0a8686bf6fcb80ff86730d07afe1ef4b59b2e1/scripts/slave/recipes/v8.expected/full_tryserver_v8_v8_mac64_dbg_ng.json
[modify] https://crrev.com/2a0a8686bf6fcb80ff86730d07afe1ef4b59b2e1/scripts/slave/recipes/v8.expected/full_tryserver_v8_v8_win64_asan_rel_ng.json
[modify] https://crrev.com/2a0a8686bf6fcb80ff86730d07afe1ef4b59b2e1/scripts/slave/recipes/v8.expected/full_tryserver_v8_v8_foobar_rel_ng_with_build_id.json
[modify] https://crrev.com/2a0a8686bf6fcb80ff86730d07afe1ef4b59b2e1/scripts/slave/recipes/v8.expected/full_tryserver_v8_v8_win64_rel_ng_test_filter_builder.json
[modify] https://crrev.com/2a0a8686bf6fcb80ff86730d07afe1ef4b59b2e1/scripts/slave/recipes/v8.expected/full_tryserver_v8_v8_win_nosnap_shared_rel_ng.json
[modify] https://crrev.com/2a0a8686bf6fcb80ff86730d07afe1ef4b59b2e1/scripts/slave/recipes/v8.expected/full_tryserver_v8_v8_linux64_dbg_ng.json
[modify] https://crrev.com/2a0a8686bf6fcb80ff86730d07afe1ef4b59b2e1/scripts/slave/recipes/v8.expected/full_tryserver_v8_v8_mac64_rel_ng.json
[modify] https://crrev.com/2a0a8686bf6fcb80ff86730d07afe1ef4b59b2e1/scripts/slave/recipes/v8.expected/full_tryserver_v8_v8_linux64_ubsan_rel_ng.json
Project Member

Comment 22 by bugdroid1@chromium.org, Sep 7 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/tools/build/+/02601d4d66896af209eb7635e6aecf700eeb5e74

commit 02601d4d66896af209eb7635e6aecf700eeb5e74
Author: Nodir Turakulov <nodir@google.com>
Date: Fri Sep 07 22:04:08 2018

[chromium] Use buildbucket module in gen_tests_for_builders

Use buildbucket's try_build and ci_build in
chromium.test_api.gen_tests_for_builders

Bug: 694348
Change-Id: I1c83c5afd320c27b8b863590728337512569ca23
Reviewed-on: https://chromium-review.googlesource.com/1214289
Reviewed-by: Stephen Martinis <martiniss@chromium.org>
Commit-Queue: Nodir Turakulov <nodir@chromium.org>

[modify] https://crrev.com/02601d4d66896af209eb7635e6aecf700eeb5e74/scripts/slave/recipes/chromium_libfuzzer.expected/full_chromium_fyi_Libfuzzer_Upload_Linux_ASan_Debug.json
[modify] https://crrev.com/02601d4d66896af209eb7635e6aecf700eeb5e74/scripts/slave/recipes/chromium_libfuzzer.expected/full_chromium_fyi_Libfuzzer_Upload_Linux_MSan.json
[modify] https://crrev.com/02601d4d66896af209eb7635e6aecf700eeb5e74/scripts/slave/recipes/chromium_libfuzzer.expected/full_chromium_fyi_Libfuzzer_Upload_Mac_ASan.json
[modify] https://crrev.com/02601d4d66896af209eb7635e6aecf700eeb5e74/scripts/slave/recipes/chromium_libfuzzer.expected/full_chromium_fyi_Libfuzzer_Upload_Linux_UBSan.json
[modify] https://crrev.com/02601d4d66896af209eb7635e6aecf700eeb5e74/scripts/slave/recipes/chromium_clang_coverage_tot.expected/full_chromium_clang_ToTMacCoverage.json
[modify] https://crrev.com/02601d4d66896af209eb7635e6aecf700eeb5e74/scripts/slave/recipes/chromium_afl.expected/full_chromium_fyi_Afl_Upload_Linux_ASan.json
[modify] https://crrev.com/02601d4d66896af209eb7635e6aecf700eeb5e74/scripts/slave/recipe_modules/chromium/__init__.py
[modify] https://crrev.com/02601d4d66896af209eb7635e6aecf700eeb5e74/scripts/slave/recipes/chromium_libfuzzer.expected/full_chromium_fyi_Libfuzzer_Upload_Linux_ASan.json
[modify] https://crrev.com/02601d4d66896af209eb7635e6aecf700eeb5e74/scripts/slave/recipe_modules/chromium/test_api.py
[modify] https://crrev.com/02601d4d66896af209eb7635e6aecf700eeb5e74/scripts/slave/recipes/webrtc/more_configs.py
[modify] https://crrev.com/02601d4d66896af209eb7635e6aecf700eeb5e74/scripts/slave/recipes/win_analyze.expected/full_chromium_fyi_Chromium_Windows_Analyze.json
[modify] https://crrev.com/02601d4d66896af209eb7635e6aecf700eeb5e74/scripts/slave/recipes/webrtc/more_configs.expected/full_client_webrtc_Android32__more_configs_.json
[modify] https://crrev.com/02601d4d66896af209eb7635e6aecf700eeb5e74/scripts/slave/recipes/webrtc/more_configs.expected/full_tryserver_webrtc_android_more_configs.json
[modify] https://crrev.com/02601d4d66896af209eb7635e6aecf700eeb5e74/scripts/slave/recipes/webrtc/more_configs.expected/full_client_webrtc_Linux__more_configs_.json
[modify] https://crrev.com/02601d4d66896af209eb7635e6aecf700eeb5e74/scripts/slave/recipes/webrtc/more_configs.expected/full_tryserver_webrtc_win_more_configs.json
[modify] https://crrev.com/02601d4d66896af209eb7635e6aecf700eeb5e74/scripts/slave/recipes/chromium_libfuzzer_clang_tot.expected/full_chromium_fyi_ClangToTLinuxASanLibfuzzer.json
[modify] https://crrev.com/02601d4d66896af209eb7635e6aecf700eeb5e74/scripts/slave/README.recipes.md
[modify] https://crrev.com/02601d4d66896af209eb7635e6aecf700eeb5e74/scripts/slave/recipes/webrtc/libfuzzer.expected/full_tryserver_webrtc_linux_libfuzzer_rel.json
[modify] https://crrev.com/02601d4d66896af209eb7635e6aecf700eeb5e74/scripts/slave/recipes/webrtc/more_configs.expected/full_tryserver_webrtc_linux_more_configs.json
[modify] https://crrev.com/02601d4d66896af209eb7635e6aecf700eeb5e74/scripts/slave/recipes/webrtc/libfuzzer.expected/full_client_webrtc_Linux64_Release__Libfuzzer_.json
[modify] https://crrev.com/02601d4d66896af209eb7635e6aecf700eeb5e74/scripts/slave/recipes/chromium_clang_coverage_tot.expected/full_chromium_clang_ToTLinuxCoverage.json
[modify] https://crrev.com/02601d4d66896af209eb7635e6aecf700eeb5e74/scripts/slave/recipes/webrtc/more_configs.expected/full_client_webrtc_Win__more_configs_.json
[modify] https://crrev.com/02601d4d66896af209eb7635e6aecf700eeb5e74/scripts/slave/recipes/webrtc/libfuzzer.py
Project Member

Comment 23 by bugdroid1@chromium.org, Sep 7 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/tools/build/+/e4f2a2798582ed176b4c188a27823427d91f155b

commit e4f2a2798582ed176b4c188a27823427d91f155b
Author: Nodir Turakulov <nodir@google.com>
Date: Fri Sep 07 22:15:34 2018

[bisecion] use buildbucket.try_build in tests

Use buidbucket.try_build in bisection/desktop_bisect tests

Bug: 694348
Change-Id: If4a5462286818b7e51e10914e8668d1d4173c300
Reviewed-on: https://chromium-review.googlesource.com/1214288
Reviewed-by: Andrii Shyshkalov <tandrii@chromium.org>
Commit-Queue: Nodir Turakulov <nodir@chromium.org>

[modify] https://crrev.com/e4f2a2798582ed176b4c188a27823427d91f155b/scripts/slave/recipes/bisection/desktop_bisect.expected/basic_perf_tryjob_with_revisions.json
[modify] https://crrev.com/e4f2a2798582ed176b4c188a27823427d91f155b/scripts/slave/recipes/bisection/desktop_bisect.expected/basic_perf_tryjob_with_bucket.json
[modify] https://crrev.com/e4f2a2798582ed176b4c188a27823427d91f155b/scripts/slave/recipes/bisection/desktop_bisect.expected/basic_perf_tryjob.json
[modify] https://crrev.com/e4f2a2798582ed176b4c188a27823427d91f155b/scripts/slave/recipes/bisection/desktop_bisect.expected/basic_perf_tryjob_with_metric_valueset.json
[modify] https://crrev.com/e4f2a2798582ed176b4c188a27823427d91f155b/scripts/slave/recipes/bisection/desktop_bisect.expected/basic_perf_tryjob_with_metric.json
[modify] https://crrev.com/e4f2a2798582ed176b4c188a27823427d91f155b/scripts/slave/recipes/bisection/desktop_bisect.expected/perf_tryjob_failed_test.json
[modify] https://crrev.com/e4f2a2798582ed176b4c188a27823427d91f155b/scripts/slave/README.recipes.md
[modify] https://crrev.com/e4f2a2798582ed176b4c188a27823427d91f155b/scripts/slave/recipes/bisection/desktop_bisect.py
[modify] https://crrev.com/e4f2a2798582ed176b4c188a27823427d91f155b/scripts/slave/recipes/bisection/desktop_bisect.expected/deps_perf_tryjob.json
Project Member

Comment 24 by bugdroid1@chromium.org, Sep 8 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/04de15fdba0c23526103172a51e833b228f03e20

commit 04de15fdba0c23526103172a51e833b228f03e20
Author: depot-tools-chromium-autoroll <depot-tools-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Date: Sat Sep 08 00:04:02 2018

Roll src/third_party/depot_tools 1cefd62ebe68..aca984cbf105 (6 commits)

https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/1cefd62ebe68..aca984cbf105


git log 1cefd62ebe68..aca984cbf105 --date=short --no-merges --format='%ad %ae %s'
2018-09-07 cwallez@chromium.org Add test for a weirdness of gclient use_relative_paths and recurse_deps
2018-09-07 tandrii@chromium.org Make ehmaldonado top level OWNER.
2018-09-07 martiniss@google.com `git cl split`: Fix typos in cq_dry_run code
2018-09-07 cwallez@chromium.org gclient_test: use write() for hook tests
2018-09-07 nodir@google.com [bot_update] Pass git_repo param in test
2018-09-07 nodir@google.com Update tryserver to use buildbucket.build.input.gerrit_changes


Created with:
  gclient setdep -r src/third_party/depot_tools@aca984cbf105

The AutoRoll server is located here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.



BUG=chromium:878117,chromium:694348
TBR=agable@chromium.org

Change-Id: Id3ba13f175eb098bbabd21b9c762561ca134af23
Reviewed-on: https://chromium-review.googlesource.com/1213447
Reviewed-by: depot-tools-chromium-autoroll <depot-tools-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: depot-tools-chromium-autoroll <depot-tools-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#589724}
[modify] https://crrev.com/04de15fdba0c23526103172a51e833b228f03e20/DEPS
Project Member

Comment 26 by bugdroid1@chromium.org, Sep 8 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/tools/depot_tools/+/f022f91453f7c9caef7b7c7519d2e311dc0e72bd

commit f022f91453f7c9caef7b7c7519d2e311dc0e72bd
Author: Nodir Turakulov <nodir@chromium.org>
Date: Sat Sep 08 00:50:54 2018

Revert "[bot_update] Stop using repository properties"

This reverts commit 4d2b901804e0319d56594502f038d018b40afb97.

Reason for revert: https://chromium-review.googlesource.com/c/chromium/tools/build/+/1214622

Original change's description:
> [bot_update] Stop using repository properties
> 
> Stop using repository and patch_repository_url properties.
> Use self.m.buildbucket.build.input.gerrit_changes[0].{host, project}
> instead.
> 
> R=​ehmaldonado@chromium.org, tandrii@chromium.org
> 
> Recipe-Nontrivial-Roll: build
> Bug: 877161, 694348
> Change-Id: Ideb069c6c8f8b6e6cfb5217f8a04ea18f16d3056
> Reviewed-on: https://chromium-review.googlesource.com/1208368
> Commit-Queue: Nodir Turakulov <nodir@chromium.org>
> Reviewed-by: Andrii Shyshkalov <tandrii@chromium.org>

TBR=nodir@chromium.org,tandrii@chromium.org,ehmaldonado@chromium.org

Change-Id: I825242124382e9f1789d4a3da0a3bdd2a5fcab37
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 877161, 694348
Reviewed-on: https://chromium-review.googlesource.com/1214703
Reviewed-by: Nodir Turakulov <nodir@chromium.org>
Commit-Queue: Nodir Turakulov <nodir@chromium.org>

[modify] https://crrev.com/f022f91453f7c9caef7b7c7519d2e311dc0e72bd/recipes/recipe_modules/bot_update/examples/full.expected/tryjob_gerrit_webrtc.json
[modify] https://crrev.com/f022f91453f7c9caef7b7c7519d2e311dc0e72bd/recipes/recipe_modules/bot_update/examples/full.py
[modify] https://crrev.com/f022f91453f7c9caef7b7c7519d2e311dc0e72bd/recipes/README.recipes.md
[modify] https://crrev.com/f022f91453f7c9caef7b7c7519d2e311dc0e72bd/recipes/recipe_modules/bot_update/api.py
[modify] https://crrev.com/f022f91453f7c9caef7b7c7519d2e311dc0e72bd/recipes/recipe_modules/bot_update/__init__.py
Project Member

Comment 27 by bugdroid1@chromium.org, Sep 8 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/494afef8c699b826c2c42e2d5bc2256f64c62259

commit 494afef8c699b826c2c42e2d5bc2256f64c62259
Author: depot-tools-chromium-autoroll <depot-tools-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Date: Sat Sep 08 02:09:00 2018

Roll src/third_party/depot_tools aca984cbf105..4d2b901804e0 (1 commits)

https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/aca984cbf105..4d2b901804e0


git log aca984cbf105..4d2b901804e0 --date=short --no-merges --format='%ad %ae %s'
2018-09-08 nodir@google.com [bot_update] Stop using repository properties


Created with:
  gclient setdep -r src/third_party/depot_tools@4d2b901804e0

The AutoRoll server is located here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.



BUG=chromium:877161,chromium:694348
TBR=agable@chromium.org

Change-Id: Id654c6bb6ee3d471ebe214dd6762179069114c79
Reviewed-on: https://chromium-review.googlesource.com/1214582
Reviewed-by: depot-tools-chromium-autoroll <depot-tools-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: depot-tools-chromium-autoroll <depot-tools-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#589753}
[modify] https://crrev.com/494afef8c699b826c2c42e2d5bc2256f64c62259/DEPS
Project Member

Comment 28 by bugdroid1@chromium.org, Sep 8 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/1c2342acb567d0b1ce9bf54638261ede5638e395

commit 1c2342acb567d0b1ce9bf54638261ede5638e395
Author: depot-tools-chromium-autoroll <depot-tools-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Date: Sat Sep 08 04:37:24 2018

Roll src/third_party/depot_tools 4d2b901804e0..f022f91453f7 (1 commits)

https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/4d2b901804e0..f022f91453f7


git log 4d2b901804e0..f022f91453f7 --date=short --no-merges --format='%ad %ae %s'
2018-09-08 nodir@chromium.org Revert "[bot_update] Stop using repository properties"


Created with:
  gclient setdep -r src/third_party/depot_tools@f022f91453f7

The AutoRoll server is located here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.



BUG=chromium:877161,chromium:694348
TBR=agable@chromium.org

Change-Id: I26f83aba6c0a3e1adb3db8e4769af40c306023b5
Reviewed-on: https://chromium-review.googlesource.com/1214822
Reviewed-by: depot-tools-chromium-autoroll <depot-tools-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: depot-tools-chromium-autoroll <depot-tools-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#589770}
[modify] https://crrev.com/1c2342acb567d0b1ce9bf54638261ede5638e395/DEPS

Comment 29 by no...@chromium.org, Sep 8 

Issue 784021 has been merged into this issue.
Project Member

Comment 30 by bugdroid1@chromium.org, Sep 10 

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/luci/recipes-py/+/596d92ee90439a73ae92c66bd25d9ec27e43b1a7

commit 596d92ee90439a73ae92c66bd25d9ec27e43b1a7
Author: Nodir Turakulov <nodir@google.com>
Date: Mon Sep 10 17:54:10 2018

[buildbucket] Prefer patch_* properties

When parsing Gerrit CL from legacy sources, prefer patch_*
properties to buildbucket buildset because the latter
does not have Gerrit project information.

Bug: 694348
Change-Id: I0004115c7abd0b6b506bbddf5342f64b3a0845c4
Reviewed-on: https://chromium-review.googlesource.com/1215002
Reviewed-by: Andrii Shyshkalov <tandrii@chromium.org>
Commit-Queue: Nodir Turakulov <nodir@chromium.org>

[modify] https://crrev.com/596d92ee90439a73ae92c66bd25d9ec27e43b1a7/recipe_modules/buildbucket/api.py
[modify] https://crrev.com/596d92ee90439a73ae92c66bd25d9ec27e43b1a7/recipe_modules/buildbucket/tests/build.py
Project Member

Comment 31 by bugdroid1@chromium.org, Sep 10 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/tools/depot_tools/+/d91f0adca28010485feb68042594d59171867de3

commit d91f0adca28010485feb68042594d59171867de3
Author: Nodir Turakulov <nodir@google.com>
Date: Mon Sep 10 18:13:13 2018

Reland "[bot_update] Stop using repository properties"

This is a reland of 4d2b901804e0319d56594502f038d018b40afb97
verbatim. The problem was in the buildbucket recipe module, see
https://chromium-review.googlesource.com/c/infra/luci/recipes-py/+/1215002#message-2351f1089af71655dbaff576aa4d11f1dedc800b

Original change's description:
> [bot_update] Stop using repository properties
>
> Stop using repository and patch_repository_url properties.
> Use self.m.buildbucket.build.input.gerrit_changes[0].{host, project}
> instead.
>
> R=ehmaldonado@chromium.org, tandrii@chromium.org
>
> Recipe-Nontrivial-Roll: build
> Bug: 877161, 694348
> Change-Id: Ideb069c6c8f8b6e6cfb5217f8a04ea18f16d3056
> Reviewed-on: https://chromium-review.googlesource.com/1208368
> Commit-Queue: Nodir Turakulov <nodir@chromium.org>
> Reviewed-by: Andrii Shyshkalov <tandrii@chromium.org>

Recipe-Nontrivial-Roll: build
Recipe-Nontrivial-Roll: skia
Bug: 877161, 694348
Change-Id: I0a10ca7814a8f5bdfd30a491e36fb7261cdaf225
Reviewed-on: https://chromium-review.googlesource.com/1214705
Reviewed-by: Andrii Shyshkalov <tandrii@chromium.org>
Commit-Queue: Nodir Turakulov <nodir@chromium.org>

[modify] https://crrev.com/d91f0adca28010485feb68042594d59171867de3/recipes/recipe_modules/bot_update/examples/full.expected/tryjob_gerrit_webrtc.json
[modify] https://crrev.com/d91f0adca28010485feb68042594d59171867de3/recipes/recipe_modules/bot_update/examples/full.py
[modify] https://crrev.com/d91f0adca28010485feb68042594d59171867de3/recipes/README.recipes.md
[modify] https://crrev.com/d91f0adca28010485feb68042594d59171867de3/recipes/recipe_modules/bot_update/api.py
[modify] https://crrev.com/d91f0adca28010485feb68042594d59171867de3/recipes/recipe_modules/bot_update/__init__.py
Project Member

Comment 32 by bugdroid1@chromium.org, Sep 10 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e775edd2af6cadc46e26dc632e9b1d0c20c40558

commit e775edd2af6cadc46e26dc632e9b1d0c20c40558
Author: depot-tools-chromium-autoroll <depot-tools-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Date: Mon Sep 10 19:32:59 2018

Roll src/third_party/depot_tools a68660d0bb5d..d91f0adca280 (2 commits)

https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/a68660d0bb5d..d91f0adca280


git log a68660d0bb5d..d91f0adca280 --date=short --no-merges --format='%ad %ae %s'
2018-09-10 nodir@google.com Reland "[bot_update] Stop using repository properties"
2018-09-10 recipe-roller@chromium.org Roll recipe dependencies (trivial).


Created with:
  gclient setdep -r src/third_party/depot_tools@d91f0adca280

The AutoRoll server is located here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.



BUG=chromium:877161,chromium:694348
TBR=agable@chromium.org

Change-Id: I06098b00b5b0e4dfa95e238d33730d8926ea4de7
Reviewed-on: https://chromium-review.googlesource.com/1216888
Reviewed-by: depot-tools-chromium-autoroll <depot-tools-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: depot-tools-chromium-autoroll <depot-tools-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#590025}
[modify] https://crrev.com/e775edd2af6cadc46e26dc632e9b1d0c20c40558/DEPS
Project Member

Comment 33 by bugdroid1@chromium.org, Sep 10 

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/luci/recipes-py/+/35df4133e3d4282971f11b531c2e247c8644be81

commit 35df4133e3d4282971f11b531c2e247c8644be81
Author: Nodir Turakulov <nodir@google.com>
Date: Mon Sep 10 23:32:34 2018

[buildbucket] Remove gerrit_host param

Remove gerrit_host parameter from buildbucket.test_api.try_build in favor of
git_repo.

R=tandrii@chromium.org

Bug: 694348
Change-Id: Ibaf999786551d9606174a32fcdb6db5f0605f9ab
Reviewed-on: https://chromium-review.googlesource.com/1213403
Commit-Queue: Nodir Turakulov <nodir@chromium.org>
Reviewed-by: Ryan Tseng <hinoka@chromium.org>
Reviewed-by: Andrii Shyshkalov <tandrii@chromium.org>

[modify] https://crrev.com/35df4133e3d4282971f11b531c2e247c8644be81/recipe_modules/buildbucket/test_api.py
Project Member

Comment 34 by bugdroid1@chromium.org, Sep 11 

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/luci/recipes-py/+/fc3791701f0801ab86e840225a7a566fee806ba0

commit fc3791701f0801ab86e840225a7a566fee806ba0
Author: Nodir Turakulov <nodir@google.com>
Date: Tue Sep 11 02:37:12 2018

[buildbucket] add revision param to try_build

Some recipes need to test try builds with revision property set.
Add revision property to try_build.

Bug: 694348
Change-Id: I73611b051336c0ba47773a5de48e667d93d8bb2b
Reviewed-on: https://chromium-review.googlesource.com/1217725
Auto-Submit: Nodir Turakulov <nodir@chromium.org>
Commit-Queue: Andrii Shyshkalov <tandrii@chromium.org>
Reviewed-by: Andrii Shyshkalov <tandrii@chromium.org>

[modify] https://crrev.com/fc3791701f0801ab86e840225a7a566fee806ba0/recipe_modules/buildbucket/test_api.py
[modify] https://crrev.com/fc3791701f0801ab86e840225a7a566fee806ba0/recipe_modules/buildbucket/examples/full.py
Project Member

Comment 35 by bugdroid1@chromium.org, Sep 11 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/tools/depot_tools/+/ddda0b5b8a961e4abb2a1699ffdfe07920046c44

commit ddda0b5b8a961e4abb2a1699ffdfe07920046c44
Author: Nodir Turakulov <nodir@google.com>
Date: Tue Sep 11 19:38:59 2018

Fetch current Gerrit CL info in tryserver

Add tryserver.api.gerrit_change_info that returns detailed info about the
current Gerrit CL. It makes a Gerrit RPC in the background on the first read.
This step will be present in all tryjobs.

This mechanism can be used for extra details about the current CL.
This CL starts to use this in bot_update for gerrit_ref, and stops using
patch_ref property, and also update bot_update to use when the destination
branch is needed.

Also this CL removes no longer used properties in bot_update,
namely most of patch_* properties.

build.git manual roll: https://chromium-review.googlesource.com/c/chromium/tools/build/+/1217626

Recipe-Manual-Change: build
Recipe-Nontrivial-Roll: infra
Recipe-Nontrivial-Roll: skia
Recipe-Nontrivial-Roll: skiabuildbot
Recipe-Nontrivial-Roll: build_limited_scripts_slave
Recipe-Nontrivial-Roll: release_scripts
R=tandrii@chromium.org
Bug: 694348
Change-Id: I945d061b74278c3d1d227578abe16a64cdaca647
Reviewed-on: https://chromium-review.googlesource.com/1213557
Commit-Queue: Nodir Turakulov <nodir@chromium.org>
Reviewed-by: Andrii Shyshkalov <tandrii@chromium.org>
Reviewed-by: Edward Lesmes <ehmaldonado@chromium.org>

[modify] https://crrev.com/ddda0b5b8a961e4abb2a1699ffdfe07920046c44/recipes/recipe_modules/bot_update/examples/full.expected/tryjob_v8_head_by_default.json
[modify] https://crrev.com/ddda0b5b8a961e4abb2a1699ffdfe07920046c44/recipes/recipe_modules/bot_update/examples/full.expected/tryjob_gerrit_branch_heads.json
[modify] https://crrev.com/ddda0b5b8a961e4abb2a1699ffdfe07920046c44/recipes/recipe_modules/gerrit/api.py
[modify] https://crrev.com/ddda0b5b8a961e4abb2a1699ffdfe07920046c44/recipes/recipe_modules/bot_update/examples/full.expected/tryjob_gerrit_v8.json
[add] https://crrev.com/ddda0b5b8a961e4abb2a1699ffdfe07920046c44/recipes/recipe_modules/tryserver/test_api.py
[add] https://crrev.com/ddda0b5b8a961e4abb2a1699ffdfe07920046c44/recipes/recipe_modules/tryserver/examples/full.expected/with_gerrit_patch_and_target_ref.json
[modify] https://crrev.com/ddda0b5b8a961e4abb2a1699ffdfe07920046c44/recipes/recipe_modules/tryserver/examples/full.py
[modify] https://crrev.com/ddda0b5b8a961e4abb2a1699ffdfe07920046c44/recipes/recipe_modules/bot_update/examples/buildbucket.expected/try.json
[modify] https://crrev.com/ddda0b5b8a961e4abb2a1699ffdfe07920046c44/recipes/recipe_modules/bot_update/examples/full.expected/no_apply_patch_on_gclient.json
[modify] https://crrev.com/ddda0b5b8a961e4abb2a1699ffdfe07920046c44/recipes/recipe_modules/bot_update/examples/full.py
[modify] https://crrev.com/ddda0b5b8a961e4abb2a1699ffdfe07920046c44/recipes/README.recipes.md
[modify] https://crrev.com/ddda0b5b8a961e4abb2a1699ffdfe07920046c44/recipes/recipe_modules/bot_update/api.py
[modify] https://crrev.com/ddda0b5b8a961e4abb2a1699ffdfe07920046c44/recipes/recipe_modules/bot_update/examples/full.expected/tryjob_gerrit_webrtc.json
[modify] https://crrev.com/ddda0b5b8a961e4abb2a1699ffdfe07920046c44/recipes/recipe_modules/tryserver/examples/full.expected/with_gerrit_patch.json
[modify] https://crrev.com/ddda0b5b8a961e4abb2a1699ffdfe07920046c44/recipes/recipe_modules/bot_update/examples/full.expected/tryjob_gerrit_feature_branch.json
[modify] https://crrev.com/ddda0b5b8a961e4abb2a1699ffdfe07920046c44/recipes/recipe_modules/bot_update/examples/full.expected/tryjob_gerrit_angle.json
[modify] https://crrev.com/ddda0b5b8a961e4abb2a1699ffdfe07920046c44/recipes/recipe_modules/tryserver/api.py
[modify] https://crrev.com/ddda0b5b8a961e4abb2a1699ffdfe07920046c44/recipes/recipe_modules/bot_update/examples/full.expected/tryjob_gerrit_v8_feature_branch.json
[modify] https://crrev.com/ddda0b5b8a961e4abb2a1699ffdfe07920046c44/recipes/recipe_modules/bot_update/__init__.py
Project Member

Comment 36 by bugdroid1@chromium.org, Sep 11 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d1ade8c44315ccb153c290847f89b815d31e71db

commit d1ade8c44315ccb153c290847f89b815d31e71db
Author: depot-tools-chromium-autoroll <depot-tools-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Date: Tue Sep 11 20:50:42 2018

Roll src/third_party/depot_tools 56e273293a3c..ddda0b5b8a96 (1 commits)

https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/56e273293a3c..ddda0b5b8a96


git log 56e273293a3c..ddda0b5b8a96 --date=short --no-merges --format='%ad %ae %s'
2018-09-11 nodir@google.com Fetch current Gerrit CL info in tryserver


Created with:
  gclient setdep -r src/third_party/depot_tools@ddda0b5b8a96

The AutoRoll server is located here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.



BUG=chromium:694348
TBR=agable@chromium.org

Change-Id: Ib6ddaf771ff7ed802afe88d5f67b875ed4698ca2
Reviewed-on: https://chromium-review.googlesource.com/1220427
Reviewed-by: depot-tools-chromium-autoroll <depot-tools-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: depot-tools-chromium-autoroll <depot-tools-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#590462}
[modify] https://crrev.com/d1ade8c44315ccb153c290847f89b815d31e71db/DEPS
Project Member

Comment 37 by bugdroid1@chromium.org, Sep 11 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/tools/build/+/b532be92745a702eba01232a8e45c12375fdd6f9

commit b532be92745a702eba01232a8e45c12375fdd6f9
Author: Nodir Turakulov <nodir@google.com>
Date: Tue Sep 11 23:17:21 2018

Roll depot_tools recipe package

Manually roll
https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1213557

The only manual change is in chromium_trybot.py

Recipe-Nontrivial-Roll: build_limited_scripts_slave
Recipe-Nontrivial-Roll: infra
Recipe-Nontrivial-Roll: release_scripts
Bug: 694348
Change-Id: I5a256f0fd260d6797a91ef7a65e788ed6e23bc5b
Reviewed-on: https://chromium-review.googlesource.com/1217626
Reviewed-by: John Budorick <jbudorick@chromium.org>
Reviewed-by: Edward Lesmes <ehmaldonado@chromium.org>
Reviewed-by: Andrii Shyshkalov <tandrii@chromium.org>
Commit-Queue: Nodir Turakulov <nodir@chromium.org>

[modify] https://crrev.com/b532be92745a702eba01232a8e45c12375fdd6f9/scripts/slave/recipes/bisection/android_bisect_staging.expected/perf_tryjob_failed_test_android_nexus6_perf_bisect.json
[modify] https://crrev.com/b532be92745a702eba01232a8e45c12375fdd6f9/scripts/slave/recipes/v8.expected/full_tryserver_v8_v8_linux64_fyi_rel_ng.json
[modify] https://crrev.com/b532be92745a702eba01232a8e45c12375fdd6f9/scripts/slave/recipes/webrtc/standalone.expected/tryserver_webrtc_win_x64_win10.json
[modify] https://crrev.com/b532be92745a702eba01232a8e45c12375fdd6f9/scripts/slave/recipes/run_presubmit.expected/gyp.json
[modify] https://crrev.com/b532be92745a702eba01232a8e45c12375fdd6f9/scripts/slave/recipes/bisection/android_bisect_staging.expected/perf_tryjob_failed_test_android_nexus7_perf_bisect.json
[modify] https://crrev.com/b532be92745a702eba01232a8e45c12375fdd6f9/scripts/slave/recipes/bisection/android_bisect.expected/basic_perf_tryjob_with_metric_android_nexus5_perf_bisect.json
[modify] https://crrev.com/b532be92745a702eba01232a8e45c12375fdd6f9/scripts/slave/recipes/findit/chromium/update_components.expected/removal.json
[modify] https://crrev.com/b532be92745a702eba01232a8e45c12375fdd6f9/scripts/slave/recipes/bisection/android_bisect_staging.expected/basic_recipe_android_one_perf_bisect.json
[modify] https://crrev.com/b532be92745a702eba01232a8e45c12375fdd6f9/scripts/slave/recipes/webrtc/standalone.expected/tryserver_webrtc_win_compile_x64_dbg.json
[modify] https://crrev.com/b532be92745a702eba01232a8e45c12375fdd6f9/scripts/slave/recipes/bisection/android_bisect_staging.expected/basic_perf_tryjob_with_metric_android_one_perf_bisect.json
[modify] https://crrev.com/b532be92745a702eba01232a8e45c12375fdd6f9/scripts/slave/recipes/bisection/android_bisect_staging.expected/basic_recipe_staging_android_nexus5X_perf_bisect.json
[modify] https://crrev.com/b532be92745a702eba01232a8e45c12375fdd6f9/scripts/slave/recipes/libyuv/libyuv.expected/tryserver_libyuv_linux_tsan2.json
[modify] https://crrev.com/b532be92745a702eba01232a8e45c12375fdd6f9/scripts/slave/recipes/chromium_trybot.expected/swarming_trigger_failure.json
[modify] https://crrev.com/b532be92745a702eba01232a8e45c12375fdd6f9/scripts/slave/recipes/bisection/android_bisect.expected/basic_perf_tryjob_with_revisions_android_one_perf_bisect.json
[modify] https://crrev.com/b532be92745a702eba01232a8e45c12375fdd6f9/scripts/slave/recipes/bisection/android_bisect.expected/local_basic_recipe_disconnected_device.json
[modify] https://crrev.com/b532be92745a702eba01232a8e45c12375fdd6f9/scripts/slave/recipes/chromium_libfuzzer_trybot.expected/basic_linux_tryjob.json
[modify] https://crrev.com/b532be92745a702eba01232a8e45c12375fdd6f9/scripts/slave/recipes/bisection/android_bisect.expected/perf_tryjob_failed_test_android_one_perf_bisect.json
[modify] https://crrev.com/b532be92745a702eba01232a8e45c12375fdd6f9/scripts/slave/recipes/run_presubmit.expected/recipes-py.json
[modify] https://crrev.com/b532be92745a702eba01232a8e45c12375fdd6f9/scripts/slave/recipe_modules/chromium_tests/tests/api/deapply_patch.expected/basic.json
[modify] https://crrev.com/b532be92745a702eba01232a8e45c12375fdd6f9/scripts/slave/recipes/bisection/desktop_bisect.expected/basic_perf_tryjob.json
[modify] https://crrev.com/b532be92745a702eba01232a8e45c12375fdd6f9/scripts/slave/recipes/v8.expected/full_tryserver_v8_v8_foobar_rel_ng_with_build_id.json
[modify] https://crrev.com/b532be92745a702eba01232a8e45c12375fdd6f9/scripts/slave/recipes/v8.expected/full_tryserver_v8_v8_win_rel_ng.json
[modify] https://crrev.com/b532be92745a702eba01232a8e45c12375fdd6f9/scripts/slave/recipes/v8.expected/full_tryserver_v8_v8_linux64_tsan_rel.json
[modify] https://crrev.com/b532be92745a702eba01232a8e45c12375fdd6f9/scripts/slave/recipes/v8.expected/full_tryserver_v8_v8_win_nosnap_shared_rel_ng.json
[modify] https://crrev.com/b532be92745a702eba01232a8e45c12375fdd6f9/scripts/slave/recipes/bisection/android_bisect.expected/basic_perf_tryjob_with_revisions_android_webview_arm64_aosp_perf_bisect.json
[modify] https://crrev.com/b532be92745a702eba01232a8e45c12375fdd6f9/scripts/slave/recipes/bisection/android_bisect_staging.expected/local_basic_recipe_no_device.json
[modify] https://crrev.com/b532be92745a702eba01232a8e45c12375fdd6f9/scripts/slave/recipes/v8.expected/full_tryserver_v8_v8_linux64_jumbo_limited_compile_rel.json
[modify] https://crrev.com/b532be92745a702eba01232a8e45c12375fdd6f9/scripts/slave/recipes/run_presubmit.expected/chrome_golo.json
[modify] https://crrev.com/b532be92745a702eba01232a8e45c12375fdd6f9/scripts/slave/recipe_modules/chromium_tests/tests/api/compile_specific_targets.expected/failure_tryserver.json
[modify] https://crrev.com/b532be92745a702eba01232a8e45c12375fdd6f9/scripts/slave/recipes/bisection/desktop_bisect_staging.expected/basic_perf_tryjob_with_bucket.json
[modify] https://crrev.com/b532be92745a702eba01232a8e45c12375fdd6f9/scripts/slave/recipes/findit/chromium/update_components.expected/addition_into_subdirs.json
[modify] https://crrev.com/b532be92745a702eba01232a8e45c12375fdd6f9/scripts/slave/recipes/bisection/android_bisect.expected/perf_tryjob_config_error_android_nexus6_perf_bisect.json
[modify] https://crrev.com/b532be92745a702eba01232a8e45c12375fdd6f9/scripts/slave/recipes/bisection/android_bisect_staging.expected/basic_recipe_android_webview_nexus6_aosp_perf_bisect.json
[modify] https://crrev.com/b532be92745a702eba01232a8e45c12375fdd6f9/scripts/slave/recipes/webrtc/standalone.expected/tryserver_webrtc_android_compile_rel.json
[modify] https://crrev.com/b532be92745a702eba01232a8e45c12375fdd6f9/scripts/slave/recipes/chromium_trybot.expected/use_skia_patch_on_blink_trybot.json
[modify] https://crrev.com/b532be92745a702eba01232a8e45c12375fdd6f9/scripts/slave/recipes/bisection/android_bisect.expected/basic_perf_tryjob_with_metric_android_nexus5X_perf_bisect.json
[modify] https://crrev.com/b532be92745a702eba01232a8e45c12375fdd6f9/scripts/slave/recipes/v8.expected/full_tryserver_v8_v8_linux_gc_stress_dbg.json
[modify] https://crrev.com/b532be92745a702eba01232a8e45c12375fdd6f9/scripts/slave/recipes/cronet.expected/cronet_try.json
[modify] https://crrev.com/b532be92745a702eba01232a8e45c12375fdd6f9/scripts/slave/recipes/webrtc/standalone.expected/tryserver_webrtc_linux_compile_rel_chromium_failing_patch.json
[modify] https://crrev.com/b532be92745a702eba01232a8e45c12375fdd6f9/scripts/slave/recipes/findit/chromium/update_components.expected/failed_upload.json
[modify] https://crrev.com/b532be92745a702eba01232a8e45c12375fdd6f9/scripts/slave/recipes/libyuv/libyuv.expected/tryserver_libyuv_linux_ubsan.json
[modify] https://crrev.com/b532be92745a702eba01232a8e45c12375fdd6f9/scripts/slave/recipes/v8.expected/full_tryserver_v8_v8_linux64_rel_ng.json
[modify] https://crrev.com/b532be92745a702eba01232a8e45c12375fdd6f9/scripts/slave/recipes/bisection/android_bisect.expected/perf_tryjob_failed_test_android_nexus7_perf_bisect.json
[modify] https://crrev.com/b532be92745a702eba01232a8e45c12375fdd6f9/scripts/slave/recipes/bisection/android_bisect.expected/basic_recipe_android_one_perf_bisect.json
[modify] https://crrev.com/b532be92745a702eba01232a8e45c12375fdd6f9/scripts/slave/recipes/bisection/android_bisect.expected/basic_recipe_android_nexus7_perf_bisect.json
[modify] https://crrev.com/b532be92745a702eba01232a8e45c12375fdd6f9/scripts/slave/recipes/chromium_trybot.expected/dynamic_isolated_script_test_with_args_on_trybot.json
[modify] https://crrev.com/b532be92745a702eba01232a8e45c12375fdd6f9/scripts/slave/recipes/bisection/desktop_bisect.expected/basic_perf_tryjob_with_metric_valueset.json
[modify] https://crrev.com/b532be92745a702eba01232a8e45c12375fdd6f9/scripts/slave/recipes/bisection/android_bisect_staging.expected/perf_tryjob_failed_test_android_fyi_perf_bisect.json
[modify] https://crrev.com/b532be92745a702eba01232a8e45c12375fdd6f9/scripts/slave/recipes/findit/chromium/update_components.expected/conflict.json
[modify] https://crrev.com/b532be92745a702eba01232a8e45c12375fdd6f9/scripts/slave/recipes/webrtc/more_configs.expected/full_tryserver_webrtc_linux_more_configs.json
[modify] https://crrev.com/b532be92745a702eba01232a8e45c12375fdd6f9/scripts/slave/recipes/libyuv/libyuv.expected/tryserver_libyuv_android_x64.json
[modify] https://crrev.com/b532be92745a702eba01232a8e45c12375fdd6f9/scripts/slave/recipes/run_presubmit.expected/presubmit-infra-failure.json
[modify] https://crrev.com/b532be92745a702eba01232a8e45c12375fdd6f9/scripts/slave/recipes/run_presubmit.expected/v8_with_cache.json
[modify] https://crrev.com/b532be92745a702eba01232a8e45c12375fdd6f9/scripts/slave/recipes/bisection/android_bisect.expected/basic_perf_tryjob_android_nexus6_perf_bisect.json
[modify] https://crrev.com/b532be92745a702eba01232a8e45c12375fdd6f9/scripts/slave/recipes/bisection/android_bisect_staging.expected/basic_perf_tryjob_with_revisions_android_fyi_perf_bisect.json
[modify] https://crrev.com/b532be92745a702eba01232a8e45c12375fdd6f9/scripts/slave/recipes/run_presubmit.expected/catapult.json
[modify] https://crrev.com/b532be92745a702eba01232a8e45c12375fdd6f9/scripts/slave/recipes/libyuv/libyuv.expected/tryserver_libyuv_win_clang.json
[modify] https://crrev.com/b532be92745a702eba01232a8e45c12375fdd6f9/scripts/slave/recipes/webrtc/standalone.expected/tryserver_webrtc_linux32_arm_dbg.json
[modify] https://crrev.com/b532be92745a702eba01232a8e45c12375fdd6f9/scripts/slave/recipes/bisection/android_bisect_staging.expected/basic_perf_tryjob_with_revisions_android_one_perf_bisect.json
[modify] https://crrev.com/b532be92745a702eba01232a8e45c12375fdd6f9/scripts/slave/recipes/webrtc/standalone.expected/tryserver_webrtc_mac_asan.json
[modify] https://crrev.com/b532be92745a702eba01232a8e45c12375fdd6f9/scripts/slave/recipes/chromium_trybot.expected/dont_deapply_patch.json
[modify] https://crrev.com/b532be92745a702eba01232a8e45c12375fdd6f9/scripts/slave/recipes/webrtc/standalone.expected/tryserver_webrtc_linux_experimental.json
[modify] https://crrev.com/b532be92745a702eba01232a8e45c12375fdd6f9/scripts/slave/recipes/webrtc/standalone.expected/tryserver_webrtc_linux_msan.json
[modify] https://crrev.com/b532be92745a702eba01232a8e45c12375fdd6f9/scripts/slave/recipes/libyuv/libyuv.expected/tryserver_libyuv_win_x64_clang_rel.json
[modify] https://crrev.com/b532be92745a702eba01232a8e45c12375fdd6f9/scripts/slave/recipes/led_recipes_tester.expected/custom_builder.json
[modify] https://crrev.com/b532be92745a702eba01232a8e45c12375fdd6f9/scripts/slave/recipes/v8.expected/full_tryserver_v8_v8_linux_gcc_compile_rel.json
[modify] https://crrev.com/b532be92745a702eba01232a8e45c12375fdd6f9/scripts/slave/recipes/bisection/android_bisect_staging.expected/basic_recipe_android_fyi_perf_bisect.json
[modify] https://crrev.com/b532be92745a702eba01232a8e45c12375fdd6f9/scripts/slave/recipes/bisection/android_bisect_staging.expected/perf_tryjob_failed_test_android_one_perf_bisect.json
[modify] https://crrev.com/b532be92745a702eba01232a8e45c12375fdd6f9/scripts/slave/recipes/v8.expected/full_tryserver_v8_v8_linux_gcc_rel.json
[modify] https://crrev.com/b532be92745a702eba01232a8e45c12375fdd6f9/scripts/slave/recipes/webrtc/standalone.expected/tryserver_webrtc_android_compile_x64_dbg.json
[modify] https://crrev.com/b532be92745a702eba01232a8e45c12375fdd6f9/scripts/slave/recipes/findit/chromium/update_components.expected/addition.json
[modify] https://crrev.com/b532be92745a702eba01232a8e45c12375fdd6f9/scripts/slave/recipes/bisection/android_bisect.expected/basic_perf_tryjob_with_revisions_staging_android_nexus5X_perf_bisect.json
[modify] https://crrev.com/b532be92745a702eba01232a8e45c12375fdd6f9/scripts/slave/recipes/libyuv/libyuv.expected/tryserver_libyuv_win_rel.json
[modify] https://crrev.com/b532be92745a702eba01232a8e45c12375fdd6f9/scripts/slave/recipes/bisection/android_bisect.expected/basic_perf_tryjob_with_metric_android_nexus7_perf_bisect.json
[modify] https://crrev.com/b532be92745a702eba01232a8e45c12375fdd6f9/scripts/slave/recipes/bisection/android_bisect_staging.expected/basic_perf_tryjob_with_metric_android_nexus5_perf_bisect.json
[modify] https://crrev.com/b532be92745a702eba01232a8e45c12375fdd6f9/scripts/slave/recipes/bisection/android_bisect_staging.expected/basic_perf_tryjob_with_metric_android_fyi_perf_bisect.json
[modify] https://crrev.com/b532be92745a702eba01232a8e45c12375fdd6f9/scripts/slave/recipes/bisection/android_bisect_staging.expected/basic_perf_tryjob_staging_android_nexus5X_perf_bisect.json
[modify] https://crrev.com/b532be92745a702eba01232a8e45c12375fdd6f9/scripts/slave/recipes/webrtc/ios_api_framework.expected/trybot_build.json
[modify] https://crrev.com/b532be92745a702eba01232a8e45c12375fdd6f9/scripts/slave/recipes/chromium_trybot.expected/compile_because_of_analyze_with_filtered_compile_targets.json
[modify] https://crrev.com/b532be92745a702eba01232a8e45c12375fdd6f9/scripts/slave/recipes/bisection/android_bisect_staging.expected/basic_perf_tryjob_with_revisions_android_nexus7_perf_bisect.json
[modify] https://crrev.com/b532be92745a702eba01232a8e45c12375fdd6f9/scripts/slave/recipes/bisection/android_bisect_staging.expected/basic_perf_tryjob_with_metric_android_webview_nexus6_aosp_perf_bisect.json
[modify] https://crrev.com/b532be92745a702eba01232a8e45c12375fdd6f9/scripts/slave/recipes/bisection/android_bisect_staging.expected/perf_tryjob_failed_test_staging_android_nexus5X_perf_bisect.json
[modify] https://crrev.com/b532be92745a702eba01232a8e45c12375fdd6f9/scripts/slave/recipes/webrtc/standalone.expected/tryserver_webrtc_win_x64_clang_dbg.json
[modify] https://crrev.com/b532be92745a702eba01232a8e45c12375fdd6f9/scripts/slave/recipes/run_presubmit.expected/infra_with_runhooks.json
[modify] https://crrev.com/b532be92745a702eba01232a8e45c12375fdd6f9/scripts/slave/recipes/chromium_trybot.expected/check_swarming_version_failure.json
[modify] https://crrev.com/b532be92745a702eba01232a8e45c12375fdd6f9/scripts/slave/recipes/webrtc/standalone.expected/tryserver_webrtc_win_x64_win8.json
[modify] https://crrev.com/b532be92745a702eba01232a8e45c12375fdd6f9/scripts/slave/recipes/chromium_trybot.expected/no_compile_because_of_analyze.json
[modify] https://crrev.com/b532be92745a702eba01232a8e45c12375fdd6f9/scripts/slave/recipes/v8.expected/full_tryserver_v8_v8_mac64_asan_rel.json
[modify] https://crrev.com/b532be92745a702eba01232a8e45c12375fdd6f9/scripts/slave/recipes/chromium_trybot.expected/chromium_trybot_gerrit_feature_branch.json
[modify] https://crrev.com/b532be92745a702eba01232a8e45c12375fdd6f9/scripts/slave/recipes/webrtc/standalone.expected/tryserver_webrtc_linux_arm64_rel.json
[modify] https://crrev.com/b532be92745a702eba01232a8e45c12375fdd6f9/scripts/slave/recipes/bisection/android_bisect_staging.expected/basic_perf_tryjob_with_revisions_android_webview_nexus6_aosp_perf_bisect.json
[modify] https://crrev.com/b532be92745a702eba01232a8e45c12375fdd6f9/scripts/slave/recipes/chromium_upload_clang.expected/full_tryserver_chromium_mac_mac_upload_clang.json
[modify] https://crrev.com/b532be92745a702eba01232a8e45c12375fdd6f9/scripts/slave/recipes/v8.expected/full_tryserver_v8_v8_linux_arm64_rel_ng.json
[modify] https://crrev.com/b532be92745a702eba01232a8e45c12375fdd6f9/scripts/slave/recipes/webrtc/standalone.expected/tryserver_webrtc_android_experimental.json
[modify] https://crrev.com/b532be92745a702eba01232a8e45c12375fdd6f9/scripts/slave/recipes/chromium_trybot.expected/compile_failure_infra.json
[modify] https://crrev.com/b532be92745a702eba01232a8e45c12375fdd6f9/scripts/slave/recipes/webrtc/standalone.expected/tryserver_webrtc_win_compile_rel.json
[modify] https://crrev.com/b532be92745a702eba01232a8e45c12375fdd6f9/scripts/slave/recipes/bisection/desktop_bisect.expected/perf_tryjob_no_config.json
[modify] https://crrev.com/b532be92745a702eba01232a8e45c12375fdd6f9/scripts/slave/recipes/bisection/desktop_bisect_staging.expected/basic_perf_tryjob_with_metric.json
[modify] https://crrev.com/b532be92745a702eba01232a8e45c12375fdd6f9/scripts/slave/recipes/v8.expected/full_tryserver_v8_v8_linux_noi18n_rel_ng.json
[modify] https://crrev.com/b532be92745a702eba01232a8e45c12375fdd6f9/scripts/slave/recipes/libyuv/libyuv.expected/tryserver_libyuv_ios.json
[modify] https://crrev.com/b532be92745a702eba01232a8e45c12375fdd6f9/scripts/slave/recipes/v8.expected/full_tryserver_v8_v8_win64_dbg.json
[modify] https://crrev.com/b532be92745a702eba01232a8e45c12375fdd6f9/scripts/slave/recipes/bisection/android_bisect_staging.expected/basic_perf_tryjob_with_revisions_android_nexus5X_perf_bisect.json
[modify] https://crrev.com/b532be92745a702eba01232a8e45c12375fdd6f9/scripts/slave/recipes/webrtc/standalone.expected/tryserver_webrtc_android_compile_arm64_dbg.json
[modify] https://crrev.com/b532be92745a702eba01232a8e45c12375fdd6f9/infra/config/recipes.cfg
[modify] https://crrev.com/b532be92745a702eba01232a8e45c12375fdd6f9/scripts/slave/recipes/bisection/android_bisect.expected/basic_perf_tryjob_with_metric_android_fyi_perf_bisect.json
[modify] https://crrev.com/b532be92745a702eba01232a8e45c12375fdd6f9/scripts/slave/recipes/chromium_trybot.expected/swarming_basic_try_job.json
[modify] https://crrev.com/b532be92745a702eba01232a8e45c12375fdd6f9/scripts/slave/recipes/chromium_trybot.expected/swarmed_webkit_tests_interrupted.json
[modify] https://crrev.com/b532be92745a702eba01232a8e45c12375fdd6f9/scripts/slave/recipes/chromium_trybot.expected/swarming_basic_cq.json
[modify] https://crrev.com/b532be92745a702eba01232a8e45c12375fdd6f9/scripts/slave/recipes/bisection/desktop_bisect_staging.expected/perf_tryjob_config_error.json
[modify] https://crrev.com/b532be92745a702eba01232a8e45c12375fdd6f9/scripts/slave/recipes/chromium_trybot.expected/compile_failure_without_patch_ng.json
[modify] https://crrev.com/b532be92745a702eba01232a8e45c12375fdd6f9/scripts/slave/recipes/v8.expected/full_tryserver_v8_v8_linux64_asan_rel_ng.json
[modify] https://crrev.com/b532be92745a702eba01232a8e45c12375fdd6f9/scripts/slave/recipes/bisection/android_bisect_staging.expected/basic_perf_tryjob_with_revisions_android_nexus6_perf_bisect.json
[modify] https://crrev.com/b532be92745a702eba01232a8e45c12375fdd6f9/scripts/slave/recipes/v8/node_integration.expected/full_tryserver_v8_v8_node_linux64_rel.json
[modify] https://crrev.com/b532be92745a702eba01232a8e45c12375fdd6f9/scripts/slave/recipes/bisection/desktop_bisect_staging.expected/basic_perf_tryjob_with_metric_valueset.json
[modify] https://crrev.com/b532be92745a702eba01232a8e45c12375fdd6f9/scripts/slave/recipes/bisection/android_bisect_staging.expected/basic_perf_tryjob_with_metric_android_nexus5X_perf_bisect.json
[modify] https://crrev.com/b532be92745a702eba01232a8e45c12375fdd6f9/scripts/slave/recipes/webrtc/standalone.expected/tryserver_webrtc_linux_asan.json
[modify] https://crrev.com/b532be92745a702eba01232a8e45c12375fdd6f9/scripts/slave/recipes/chromium_trybot.expected/dynamic_swarmed_isolated_script_test_failure_no_result_json.json
[modify] https://crrev.com/b532be92745a702eba01232a8e45c12375fdd6f9/scripts/slave/recipes/bisection/android_bisect.expected/perf_tryjob_config_error_android_nexus5X_perf_bisect.json
[modify] https://crrev.com/b532be92745a702eba01232a8e45c12375fdd6f9/scripts/slave/recipes/webrtc/more_configs.expected/full_tryserver_webrtc_android_more_configs.json
[modify] https://crrev.com/b532be92745a702eba01232a8e45c12375fdd6f9/scripts/slave/recipes/run_presubmit.expected/chromium_dry_run.json
[modify] https://crrev.com/b532be92745a702eba01232a8e45c12375fdd6f9/scripts/slave/recipes/chromium_trybot.expected/clobber_analyze.json
[modify] https://crrev.com/b532be92745a702eba01232a8e45c12375fdd6f9/scripts/slave/recipes/bisection/android_bisect.expected/basic_perf_tryjob_with_metric_android_webview_nexus6_aosp_perf_bisect.json
[modify] https://crrev.com/b532be92745a702eba01232a8e45c12375fdd6f9/scripts/slave/recipes/webrtc/standalone.expected/tryserver_webrtc_linux_ubsan_vptr.json
[modify] https://crrev.com/b532be92745a702eba01232a8e45c12375fdd6f9/scripts/slave/recipes/webrtc/standalone.expected/tryserver_webrtc_win_compile_dbg.json
[modify] https://crrev.com/b532be92745a702eba01232a8e45c12375fdd6f9/scripts/slave/recipes/chromium_trybot.expected/swarming_test_failure.json
[modify] https://crrev.com/b532be92745a702eba01232a8e45c12375fdd6f9/scripts/slave/recipe_modules/chromium_tests/tests/api/run_tests_on_tryserver.expected/disable_deapply_patch_recipes.json
[modify] https://crrev.com/b532be92745a702eba01232a8e45c12375fdd6f9/scripts/slave/recipes/bisection/desktop_bisect.expected/deps_perf_tryjob.json
[modify] https://crrev.com/b532be92745a702eba01232a8e45c12375fdd6f9/scripts/slave/recipes/libyuv/libyuv.expected/tryserver_libyuv_ios_arm64.json
[modify] https://crrev.com/b532be92745a702eba01232a8e45c12375fdd6f9/scripts/slave/recipes/chromium_trybot.expected/use_webrtc_patch_on_chromium_trybot.json
[modify] https://crrev.com/b532be92745a702eba01232a8e45c12375fdd6f9/scripts/slave/recipes/bisection/android_bisect.expected/perf_tryjob_config_error_android_webview_arm64_aosp_perf_bisect.json
[modify] https://crrev.com/b532be92745a702eba01232a8e45c12375fdd6f9/scripts/slave/recipes/bisection/android_bisect_staging.expected/perf_tryjob_config_error_android_webview_arm64_aosp_perf_bisect.json
[modify] https://crrev.com/b532be92745a702eba01232a8e45c12375fdd6f9/scripts/slave/recipes/chromium_trybot.expected/bot_update_failure.json
[modify] https://crrev.com/b532be92745a702eba01232a8e45c12375fdd6f9/scripts/slave/recipes/libyuv/libyuv.expected/tryserver_libyuv_linux.json
[modify] https://crrev.com/b532be92745a702eba01232a8e45c12375fdd6f9/scripts/slave/recipes/bisection/android_bisect_staging.expected/basic_perf_tryjob_android_one_perf_bisect.json
[modify] https://crrev.com/b532be92745a702eba01232a8e45c12375fdd6f9/scripts/slave/recipes/bisection/android_bisect.expected/local_basic_recipe_failed_device.json
[modify] https://crrev.com/b532be92745a702eba01232a8e45c12375fdd6f9/scripts/slave/recipe_modules/chromium_tests/tests/api/trybot_steps.expected/basic.json
[modify] https://crrev.com/b532be92745a702eba01232a8e45c12375fdd6f9/scripts/slave/recipes/run_presubmit.expected/v8.json
[modify] https://crrev.com/b532be92745a702eba01232a8e45c12375fdd6f9/scripts/slave/recipes/v8.expected/full_tryserver_v8_v8_linux64_sanitizer_coverage_rel.json
[modify] https://crrev.com/b532be92745a702eba01232a8e45c12375fdd6f9/scripts/slave/recipes/webrtc/standalone.expected/tryserver_webrtc_android_arm64_rel.json
[modify] https://crrev.com/b532be92745a702eba01232a8e45c12375fdd6f9/scripts/slave/recipes/v8.expected/full_tryserver_v8_v8_linux_nosnap_dbg.json
[modify] https://crrev.com/b532be92745a702eba01232a8e45c12375fdd6f9/scripts/slave/recipes/run_presubmit.expected/depot_tools.json
[modify] https://crrev.com/b532be92745a702eba01232a8e45c12375fdd6f9/scripts/slave/recipes/bisection/android_bisect.expected/perf_tryjob_failed_test_staging_android_nexus5X_perf_bisect.json
[modify] https://crrev.com/b532be92745a702eba01232a8e45c12375fdd6f9/scripts/slave/recipes/chromium_trybot.expected/gclient_runhooks__with_patch__failure.json
[modify] https://crrev.com/b532be92745a702eba01232a8e45c12375fdd6f9/scripts/slave/recipes/bisection/android_bisect.expected/basic_perf_tryjob_android_nexus5X_perf_bisect.json
[modify] https://crrev.com/b532be92745a702eba01232a8e45c12375fdd6f9/scripts/slave/recipes/bisection/android_bisect_staging.expected/local_basic_recipe_failed_device.json
[modify] https://crrev.com/b532be92745a702eba01232a8e45c12375fdd6f9/scripts/slave/recipes/webrtc/standalone.expected/tryserver_webrtc_linux_dbg.json
[modify] https://crrev.com/b532be92745a702eba01232a8e45c12375fdd6f9/scripts/slave/recipes/run_presubmit.expected/chromium

Comment 38 by mknyszek@google.com, Sep 12 

Using buildbucket.build for this makes it harder to test recipe changes either via python recipes.py run --properties-file <file> <recipe> or via led, since both bypass buildbucket. We generally do specify a properties file manually.

Any suggestions on what we can do to make this better?

Comment 39 by no...@chromium.org, Sep 12 

i've sent https://chromium-review.googlesource.com/c/infra/luci/recipes-py/+/1222232 to make the buildbucket build property a JSON object, as opposed to base64 bytes of the message. I think this will significantly simplify this.

Now the difference is that revision/patchset is 3-4 levels deeper in the properties, by being more structured, as opposed to very flat. Note that the module at least currently does not require all the build fields to be specified. It will parse as much as you put there, so if your recipe works without build id, you have to specify it. 

Is this good enough? please elaborate your use cases. What else do you normally specify when running a recipe locally?

Comment 40 by no...@chromium.org, Sep 14 

(this rabbit hole is so deep!)
Project Member

Comment 41 by bugdroid1@chromium.org, Sep 14 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/tools/build/+/130ab6608e3c7152e21159032061c3ea471c2cce

commit 130ab6608e3c7152e21159032061c3ea471c2cce
Author: Nodir Turakulov <nodir@google.com>
Date: Fri Sep 14 19:30:53 2018

Fix get_files_affected_by_patch

get_files_affected_by_patch returns something even if there is no patch to
begin with. Return empty list in that case.

Also update tests that were inaccurate because of that.

Bug: 694348
Change-Id: I3614fad92d35eaab82c6cf6835e3d3ea7aea19e0
Reviewed-on: https://chromium-review.googlesource.com/1227055
Reviewed-by: Stephen Martinis <martiniss@chromium.org>
Commit-Queue: Nodir Turakulov <nodir@chromium.org>

[modify] https://crrev.com/130ab6608e3c7152e21159032061c3ea471c2cce/scripts/slave/recipe_modules/auto_bisect_staging/examples/full.expected/basic_bisect_other_direction.json
[modify] https://crrev.com/130ab6608e3c7152e21159032061c3ea471c2cce/scripts/slave/recipe_modules/auto_bisect_staging/examples/full.expected/failed_build_inconclusive_11.json
[modify] https://crrev.com/130ab6608e3c7152e21159032061c3ea471c2cce/scripts/slave/recipe_modules/auto_bisect/examples/full.expected/basic_bisect_other_direction.json
[modify] https://crrev.com/130ab6608e3c7152e21159032061c3ea471c2cce/scripts/slave/recipe_modules/auto_bisect_staging/examples/full.expected/no_repro.json
[modify] https://crrev.com/130ab6608e3c7152e21159032061c3ea471c2cce/scripts/slave/recipe_modules/auto_bisect/examples/full.expected/gathering_references_no_values.json
[modify] https://crrev.com/130ab6608e3c7152e21159032061c3ea471c2cce/scripts/slave/recipe_modules/auto_bisect/examples/full.expected/no_repro.json
[modify] https://crrev.com/130ab6608e3c7152e21159032061c3ea471c2cce/scripts/slave/recipe_modules/auto_bisect_staging/examples/full.expected/basic_linux_bisect.json
[modify] https://crrev.com/130ab6608e3c7152e21159032061c3ea471c2cce/scripts/slave/recipe_modules/auto_bisect/examples/full.expected/failed_build_inconclusive_11.json
[modify] https://crrev.com/130ab6608e3c7152e21159032061c3ea471c2cce/scripts/slave/recipes/ios/try.expected/icu_patch.json
[modify] https://crrev.com/130ab6608e3c7152e21159032061c3ea471c2cce/scripts/slave/recipe_modules/auto_bisect/examples/full.expected/basic_buildbot_bisect.json
[modify] https://crrev.com/130ab6608e3c7152e21159032061c3ea471c2cce/scripts/slave/recipes/ios/try.expected/patch_failure.json
[modify] https://crrev.com/130ab6608e3c7152e21159032061c3ea471c2cce/scripts/slave/recipe_modules/auto_bisect/examples/full.expected/failed_buildbucket_get.json
[modify] https://crrev.com/130ab6608e3c7152e21159032061c3ea471c2cce/scripts/slave/recipe_modules/auto_bisect/examples/full.expected/failed_build.json
[modify] https://crrev.com/130ab6608e3c7152e21159032061c3ea471c2cce/scripts/slave/recipe_modules/auto_bisect_staging/examples/full.expected/bad_config.json
[modify] https://crrev.com/130ab6608e3c7152e21159032061c3ea471c2cce/scripts/slave/recipe_modules/auto_bisect_staging/examples/full.expected/failed_build.json
[modify] https://crrev.com/130ab6608e3c7152e21159032061c3ea471c2cce/scripts/slave/recipe_modules/auto_bisect/examples/full.expected/return_code.json
[modify] https://crrev.com/130ab6608e3c7152e21159032061c3ea471c2cce/scripts/slave/recipe_modules/auto_bisect_staging/examples/full.expected/return_code_fail.json
[modify] https://crrev.com/130ab6608e3c7152e21159032061c3ea471c2cce/scripts/slave/recipe_modules/chromium_checkout/tests/full.py
[modify] https://crrev.com/130ab6608e3c7152e21159032061c3ea471c2cce/scripts/slave/recipe_modules/auto_bisect_staging/examples/full.expected/v8_roll_bisect.json
[modify] https://crrev.com/130ab6608e3c7152e21159032061c3ea471c2cce/scripts/slave/recipes/ios/try.expected/gn.json
[modify] https://crrev.com/130ab6608e3c7152e21159032061c3ea471c2cce/scripts/slave/recipes/ios/try.expected/basic.json
[modify] https://crrev.com/130ab6608e3c7152e21159032061c3ea471c2cce/scripts/slave/recipe_modules/auto_bisect/examples/full.expected/return_code_fail.json
[modify] https://crrev.com/130ab6608e3c7152e21159032061c3ea471c2cce/scripts/slave/recipe_modules/auto_bisect/examples/full.expected/multi_depot_recurse_with_uneven_deps_expansion.json
[modify] https://crrev.com/130ab6608e3c7152e21159032061c3ea471c2cce/scripts/slave/recipe_modules/chromium_checkout/api.py
[modify] https://crrev.com/130ab6608e3c7152e21159032061c3ea471c2cce/scripts/slave/recipe_modules/chromium_checkout/tests/full.expected/full.json
[modify] https://crrev.com/130ab6608e3c7152e21159032061c3ea471c2cce/scripts/slave/recipe_modules/auto_bisect_staging/examples/full.expected/v8_roll_bisect_bis.json
[modify] https://crrev.com/130ab6608e3c7152e21159032061c3ea471c2cce/scripts/slave/recipes/ios/try.expected/parent.json
[modify] https://crrev.com/130ab6608e3c7152e21159032061c3ea471c2cce/scripts/slave/recipe_modules/auto_bisect_staging/examples/full.expected/basic_buildbot_bisect.json
[modify] https://crrev.com/130ab6608e3c7152e21159032061c3ea471c2cce/scripts/slave/recipe_modules/auto_bisect_staging/examples/full.expected/no_values.json
[modify] https://crrev.com/130ab6608e3c7152e21159032061c3ea471c2cce/scripts/slave/recipe_modules/auto_bisect/examples/full.expected/v8_roll_bisect_bis.json
[modify] https://crrev.com/130ab6608e3c7152e21159032061c3ea471c2cce/scripts/slave/recipe_modules/auto_bisect/examples/full.expected/no_values.json
[modify] https://crrev.com/130ab6608e3c7152e21159032061c3ea471c2cce/scripts/slave/recipe_modules/auto_bisect/examples/full.expected/bad_config.json
[modify] https://crrev.com/130ab6608e3c7152e21159032061c3ea471c2cce/scripts/slave/recipe_modules/auto_bisect/examples/full.expected/retest_bisect.json
[modify] https://crrev.com/130ab6608e3c7152e21159032061c3ea471c2cce/scripts/slave/recipes/ios/try.expected/additional_compile_targets.json
[modify] https://crrev.com/130ab6608e3c7152e21159032061c3ea471c2cce/scripts/slave/recipe_modules/auto_bisect/examples/full.expected/failed_build_inconclusive_1.json
[modify] https://crrev.com/130ab6608e3c7152e21159032061c3ea471c2cce/scripts/slave/recipe_modules/auto_bisect/examples/full.expected/basic_resource_sizes_bisect.json
[modify] https://crrev.com/130ab6608e3c7152e21159032061c3ea471c2cce/scripts/slave/recipe_modules/auto_bisect_staging/examples/full.expected/return_code.json
[modify] https://crrev.com/130ab6608e3c7152e21159032061c3ea471c2cce/scripts/slave/recipes/ios/try.expected/goma_compilation_failure.json
[modify] https://crrev.com/130ab6608e3c7152e21159032061c3ea471c2cce/scripts/slave/recipe_modules/auto_bisect_staging/examples/full.expected/failed_build_inconclusive_1.json
[modify] https://crrev.com/130ab6608e3c7152e21159032061c3ea471c2cce/scripts/slave/recipe_modules/auto_bisect_staging/examples/full.expected/retest_bisect.json
[modify] https://crrev.com/130ab6608e3c7152e21159032061c3ea471c2cce/scripts/slave/recipe_modules/auto_bisect/examples/full.expected/basic_linux_bisect.json
[modify] https://crrev.com/130ab6608e3c7152e21159032061c3ea471c2cce/scripts/slave/recipes/ios/try.expected/no_tests.json
[modify] https://crrev.com/130ab6608e3c7152e21159032061c3ea471c2cce/scripts/slave/recipe_modules/auto_bisect_staging/examples/full.expected/gathering_references_no_values.json
[modify] https://crrev.com/130ab6608e3c7152e21159032061c3ea471c2cce/scripts/slave/recipe_modules/auto_bisect_staging/examples/full.expected/basic_resource_sizes_bisect.json
[modify] https://crrev.com/130ab6608e3c7152e21159032061c3ea471c2cce/scripts/slave/recipes/ios/try.expected/no_compilation.json
[modify] https://crrev.com/130ab6608e3c7152e21159032061c3ea471c2cce/scripts/slave/recipes/ios/try.py
[modify] https://crrev.com/130ab6608e3c7152e21159032061c3ea471c2cce/scripts/slave/recipe_modules/auto_bisect/examples/full.expected/v8_roll_bisect.json
[modify] https://crrev.com/130ab6608e3c7152e21159032061c3ea471c2cce/scripts/slave/recipe_modules/auto_bisect_staging/examples/full.expected/failed_buildbucket_get.json
Project Member

Comment 42 by bugdroid1@chromium.org, Sep 14 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/tools/build/+/1719aad292f58bbbc976d89242e4ca8e21bbd8ca

commit 1719aad292f58bbbc976d89242e4ca8e21bbd8ca
Author: Nodir Turakulov <nodir@google.com>
Date: Fri Sep 14 20:24:04 2018

Add src.git to the chromium's repo_path_map

All repos must be mapped, even the main repo.

TBR=martiniss@chromium.org
Bug: 694348
Change-Id: Ie4fa33809e9ce23fc18144202e33b6f96be3849d
Reviewed-on: https://chromium-review.googlesource.com/1226082
Reviewed-by: Nodir Turakulov <nodir@chromium.org>
Reviewed-by: Stephen Martinis <martiniss@chromium.org>
Commit-Queue: Nodir Turakulov <nodir@chromium.org>

[modify] https://crrev.com/1719aad292f58bbbc976d89242e4ca8e21bbd8ca/scripts/slave/recipe_modules/chromium/gclient_config.py
Project Member

Comment 43 by bugdroid1@chromium.org, Sep 14 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/tools/build/+/4724760a89d49bdf5315168ac221093ce36c2339

commit 4724760a89d49bdf5315168ac221093ce36c2339
Author: Nodir Turakulov <nodir@google.com>
Date: Fri Sep 14 20:48:07 2018

Fix Chromium URL

https://chromium-review.googlesource.com/c/chromium/tools/build/+/1226082
used an incorrect Chromium URL.

R=martiniss@chromium.org

Recipe-Nontrivial-Roll: build_limited_scripts_slave
Bug: 694348
Change-Id: Icd6cf8f160afbf6a505c6622e74cca90832115e7
Reviewed-on: https://chromium-review.googlesource.com/1226083
Commit-Queue: Nodir Turakulov <nodir@chromium.org>
Reviewed-by: Stephen Martinis <martiniss@chromium.org>

[modify] https://crrev.com/4724760a89d49bdf5315168ac221093ce36c2339/scripts/slave/recipe_modules/chromium/gclient_config.py
Project Member

Comment 44 by bugdroid1@chromium.org, Sep 14 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/tools/build/+/dff188d6b72aff6c4ac9a42b2c2e4c21dbacac1f

commit dff188d6b72aff6c4ac9a42b2c2e4c21dbacac1f
Author: Nodir Turakulov <nodir@google.com>
Date: Fri Sep 14 22:34:06 2018

[ios] Fix ios/try.py git repo URL

ios/try.py tests use icu git repo by default. Use it only in icu-specific test,
otherwise src.git

Bug: 694348
Change-Id: Ifef0080f30c2e37413f0dc82d20d31af1e421959
Reviewed-on: https://chromium-review.googlesource.com/1226088
Auto-Submit: Nodir Turakulov <nodir@chromium.org>
Commit-Queue: smut <smut@google.com>
Reviewed-by: smut <smut@google.com>

[modify] https://crrev.com/dff188d6b72aff6c4ac9a42b2c2e4c21dbacac1f/scripts/slave/recipes/ios/try.expected/additional_compile_targets.json
[modify] https://crrev.com/dff188d6b72aff6c4ac9a42b2c2e4c21dbacac1f/scripts/slave/recipes/ios/try.py
[modify] https://crrev.com/dff188d6b72aff6c4ac9a42b2c2e4c21dbacac1f/scripts/slave/recipes/ios/try.expected/goma_compilation_failure.json
[modify] https://crrev.com/dff188d6b72aff6c4ac9a42b2c2e4c21dbacac1f/scripts/slave/recipes/ios/try.expected/no_tests.json
[modify] https://crrev.com/dff188d6b72aff6c4ac9a42b2c2e4c21dbacac1f/scripts/slave/recipes/ios/try.expected/icu_patch.json
[modify] https://crrev.com/dff188d6b72aff6c4ac9a42b2c2e4c21dbacac1f/scripts/slave/recipes/ios/try.expected/gn.json
[modify] https://crrev.com/dff188d6b72aff6c4ac9a42b2c2e4c21dbacac1f/scripts/slave/recipes/ios/try.expected/no_compilation.json
[modify] https://crrev.com/dff188d6b72aff6c4ac9a42b2c2e4c21dbacac1f/scripts/slave/recipes/ios/try.expected/patch_failure.json
[modify] https://crrev.com/dff188d6b72aff6c4ac9a42b2c2e4c21dbacac1f/scripts/slave/recipes/ios/try.expected/basic.json
[modify] https://crrev.com/dff188d6b72aff6c4ac9a42b2c2e4c21dbacac1f/scripts/slave/recipes/ios/try.expected/parent.json
Project Member

Comment 45 by bugdroid1@chromium.org, Sep 14 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/tools/build/+/dcd143389e2eb514d8f8d689f6994b76a98996f2

commit dcd143389e2eb514d8f8d689f6994b76a98996f2
Author: Nodir Turakulov <nodir@google.com>
Date: Fri Sep 14 22:49:18 2018

Use buildbucket test API in webrtc/standalone.py

In particular, stop using "gerrit_url" and "gerrit_project" properties.

Also update webrtc/api.py to use tryserver module instead of
patch_* properties directly.

Bug: 694348
Change-Id: I04a8dd6360601b2e64c1c5e8e13b36bc07efbae4
Reviewed-on: https://chromium-review.googlesource.com/1222946
Commit-Queue: Nodir Turakulov <nodir@chromium.org>
Auto-Submit: Nodir Turakulov <nodir@chromium.org>
Reviewed-by: Andrii Shyshkalov <tandrii@chromium.org>
Reviewed-by: Oleh Prypin <oprypin@chromium.org>

[modify] https://crrev.com/dcd143389e2eb514d8f8d689f6994b76a98996f2/scripts/slave/recipes/webrtc/standalone.expected/tryserver_webrtc_win_asan.json
[modify] https://crrev.com/dcd143389e2eb514d8f8d689f6994b76a98996f2/scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_win32_release.json
[modify] https://crrev.com/dcd143389e2eb514d8f8d689f6994b76a98996f2/scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_mac64_debug.json
[modify] https://crrev.com/dcd143389e2eb514d8f8d689f6994b76a98996f2/scripts/slave/recipes/webrtc/standalone.expected/tryserver_webrtc_android_compile_arm64_dbg.json
[modify] https://crrev.com/dcd143389e2eb514d8f8d689f6994b76a98996f2/scripts/slave/recipes/webrtc/standalone.expected/tryserver_webrtc_win_compile_x64_dbg.json
[modify] https://crrev.com/dcd143389e2eb514d8f8d689f6994b76a98996f2/scripts/slave/recipes/webrtc/standalone.expected/tryserver_webrtc_linux_tsan2.json
[modify] https://crrev.com/dcd143389e2eb514d8f8d689f6994b76a98996f2/scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_win32_debug.json
[modify] https://crrev.com/dcd143389e2eb514d8f8d689f6994b76a98996f2/scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_linux_ubsan_vptr.json
[modify] https://crrev.com/dcd143389e2eb514d8f8d689f6994b76a98996f2/scripts/slave/recipe_modules/webrtc/api.py
[modify] https://crrev.com/dcd143389e2eb514d8f8d689f6994b76a98996f2/scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_perf_win7.json
[modify] https://crrev.com/dcd143389e2eb514d8f8d689f6994b76a98996f2/scripts/slave/recipes/webrtc/standalone.expected/tryserver_webrtc_win_compile_x64_rel.json
[modify] https://crrev.com/dcd143389e2eb514d8f8d689f6994b76a98996f2/scripts/slave/recipes/webrtc/standalone.expected/tryserver_webrtc_linux32_rel.json
[modify] https://crrev.com/dcd143389e2eb514d8f8d689f6994b76a98996f2/scripts/slave/recipes/webrtc/standalone.expected/tryserver_webrtc_android_experimental.json
[modify] https://crrev.com/dcd143389e2eb514d8f8d689f6994b76a98996f2/scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_android64_builder_arm64.json
[modify] https://crrev.com/dcd143389e2eb514d8f8d689f6994b76a98996f2/scripts/slave/recipes/webrtc/standalone.expected/tryserver_webrtc_linux_asan.json
[modify] https://crrev.com/dcd143389e2eb514d8f8d689f6994b76a98996f2/scripts/slave/recipes/webrtc/standalone.expected/tryserver_webrtc_linux_arm64_dbg.json
[modify] https://crrev.com/dcd143389e2eb514d8f8d689f6994b76a98996f2/scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_branches_mac__beta_.json
[modify] https://crrev.com/dcd143389e2eb514d8f8d689f6994b76a98996f2/scripts/slave/recipes/webrtc/standalone.expected/tryserver_webrtc_android_compile_arm64_rel.json
[modify] https://crrev.com/dcd143389e2eb514d8f8d689f6994b76a98996f2/scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_win64_debug.json
[modify] https://crrev.com/dcd143389e2eb514d8f8d689f6994b76a98996f2/scripts/slave/recipes/webrtc/standalone.expected/tryserver_webrtc_linux_ubsan_vptr.json
[modify] https://crrev.com/dcd143389e2eb514d8f8d689f6994b76a98996f2/scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_win64_debug__clang_.json
[modify] https://crrev.com/dcd143389e2eb514d8f8d689f6994b76a98996f2/scripts/slave/recipes/webrtc/standalone.expected/tryserver_webrtc_win_clang_rel.json
[modify] https://crrev.com/dcd143389e2eb514d8f8d689f6994b76a98996f2/scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_branches_win__beta_.json
[modify] https://crrev.com/dcd143389e2eb514d8f8d689f6994b76a98996f2/scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_fyi_android_asan__swarming_.json
[modify] https://crrev.com/dcd143389e2eb514d8f8d689f6994b76a98996f2/scripts/slave/recipes/webrtc/standalone.expected/tryserver_webrtc_win_experimental.json
[modify] https://crrev.com/dcd143389e2eb514d8f8d689f6994b76a98996f2/scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_android64__m_nexus5x_.json
[modify] https://crrev.com/dcd143389e2eb514d8f8d689f6994b76a98996f2/scripts/slave/recipes/webrtc/standalone.expected/tryserver_webrtc_linux_compile_rel.json
[modify] https://crrev.com/dcd143389e2eb514d8f8d689f6994b76a98996f2/scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_android32_builder_x86.json
[modify] https://crrev.com/dcd143389e2eb514d8f8d689f6994b76a98996f2/scripts/slave/recipes/webrtc/standalone.expected/tryserver_webrtc_mac_dbg.json
[modify] https://crrev.com/dcd143389e2eb514d8f8d689f6994b76a98996f2/scripts/slave/recipes/webrtc/standalone.expected/tryserver_webrtc_mac_rel.json
[modify] https://crrev.com/dcd143389e2eb514d8f8d689f6994b76a98996f2/scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_android64_builder_x64__dbg_.json
[modify] https://crrev.com/dcd143389e2eb514d8f8d689f6994b76a98996f2/scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_win32_release__clang_.json
[modify] https://crrev.com/dcd143389e2eb514d8f8d689f6994b76a98996f2/scripts/slave/recipes/webrtc/standalone.expected/tryserver_webrtc_android_compile_rel.json
[modify] https://crrev.com/dcd143389e2eb514d8f8d689f6994b76a98996f2/scripts/slave/recipes/webrtc/standalone.expected/tryserver_webrtc_win_compile_dbg.json
[modify] https://crrev.com/dcd143389e2eb514d8f8d689f6994b76a98996f2/scripts/slave/recipes/webrtc/standalone.expected/tryserver_webrtc_win_x64_dbg.json
[modify] https://crrev.com/dcd143389e2eb514d8f8d689f6994b76a98996f2/scripts/slave/recipes/webrtc/standalone.py
[modify] https://crrev.com/dcd143389e2eb514d8f8d689f6994b76a98996f2/scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_android32__m_nexus5x_.json
[modify] https://crrev.com/dcd143389e2eb514d8f8d689f6994b76a98996f2/scripts/slave/recipes/webrtc/standalone.expected/tryserver_webrtc_android_compile_dbg.json
[modify] https://crrev.com/dcd143389e2eb514d8f8d689f6994b76a98996f2/scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_fyi_win64_debug__win10_.json
[modify] https://crrev.com/dcd143389e2eb514d8f8d689f6994b76a98996f2/scripts/slave/recipes/webrtc/standalone.expected/tryserver_webrtc_android_arm64_rel.json
[modify] https://crrev.com/dcd143389e2eb514d8f8d689f6994b76a98996f2/scripts/slave/recipes/webrtc/standalone.expected/tryserver_webrtc_linux32_arm_rel.json
[modify] https://crrev.com/dcd143389e2eb514d8f8d689f6994b76a98996f2/scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_win32_asan.json
[delete] https://crrev.com/dff188d6b72aff6c4ac9a42b2c2e4c21dbacac1f/scripts/slave/recipes/webrtc/standalone.expected/tryserver_webrtc_linux_compile_rel_chromium_failing_patch.json
[modify] https://crrev.com/dcd143389e2eb514d8f8d689f6994b76a98996f2/scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_linux64_debug__arm_.json
[modify] https://crrev.com/dcd143389e2eb514d8f8d689f6994b76a98996f2/scripts/slave/recipes/webrtc/standalone.expected/tryserver_webrtc_linux_ubsan.json
[modify] https://crrev.com/dcd143389e2eb514d8f8d689f6994b76a98996f2/scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_android64__m_nexus5x__dbg_.json
[modify] https://crrev.com/dcd143389e2eb514d8f8d689f6994b76a98996f2/scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_win32_debug__clang_.json
[modify] https://crrev.com/dcd143389e2eb514d8f8d689f6994b76a98996f2/scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_linux_tsan_v2.json
[modify] https://crrev.com/dcd143389e2eb514d8f8d689f6994b76a98996f2/scripts/slave/recipes/webrtc/standalone.expected/tryserver_webrtc_linux_compile_dbg.json
[modify] https://crrev.com/dcd143389e2eb514d8f8d689f6994b76a98996f2/scripts/slave/recipes/webrtc/standalone.expected/tryserver_webrtc_linux_dbg.json
[modify] https://crrev.com/dcd143389e2eb514d8f8d689f6994b76a98996f2/scripts/slave/recipes/webrtc/standalone.expected/tryserver_webrtc_win_x64_rel.json
[modify] https://crrev.com/dcd143389e2eb514d8f8d689f6994b76a98996f2/scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_linux64_debug_forced.json
[modify] https://crrev.com/dcd143389e2eb514d8f8d689f6994b76a98996f2/scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_perf_linux_trusty.json
[modify] https://crrev.com/dcd143389e2eb514d8f8d689f6994b76a98996f2/scripts/slave/README.recipes.md
[modify] https://crrev.com/dcd143389e2eb514d8f8d689f6994b76a98996f2/scripts/slave/recipes/webrtc/standalone.expected/tryserver_webrtc_linux32_arm_dbg.json
[modify] https://crrev.com/dcd143389e2eb514d8f8d689f6994b76a98996f2/scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_branches_mac__stable_.json
[modify] https://crrev.com/dcd143389e2eb514d8f8d689f6994b76a98996f2/scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_linux_msan.json
[modify] https://crrev.com/dcd143389e2eb514d8f8d689f6994b76a98996f2/scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_win64_release.json
[modify] https://crrev.com/dcd143389e2eb514d8f8d689f6994b76a98996f2/scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_branches_linux__beta_.json
[modify] https://crrev.com/dcd143389e2eb514d8f8d689f6994b76a98996f2/scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_linux64_release__gcc_.json
[modify] https://crrev.com/dcd143389e2eb514d8f8d689f6994b76a98996f2/scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_linux32_debug__arm_.json
[modify] https://crrev.com/dcd143389e2eb514d8f8d689f6994b76a98996f2/scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_android32__m_nexus5x__failing_archive.json
[modify] https://crrev.com/dcd143389e2eb514d8f8d689f6994b76a98996f2/scripts/slave/recipes/webrtc/standalone.expected/tryserver_webrtc_win_x64_win10.json
[modify] https://crrev.com/dcd143389e2eb514d8f8d689f6994b76a98996f2/scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_perf_android32_tests__l_nexus5__forced_invalid.json
[modify] https://crrev.com/dcd143389e2eb514d8f8d689f6994b76a98996f2/scripts/slave/recipes/webrtc/standalone.expected/tryserver_webrtc_android_compile_x86_rel.json
[modify] https://crrev.com/dcd143389e2eb514d8f8d689f6994b76a98996f2/scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_android32_builder_x86__dbg_.json
[modify] https://crrev.com/dcd143389e2eb514d8f8d689f6994b76a98996f2/scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_linux32_debug.json
[modify] https://crrev.com/dcd143389e2eb514d8f8d689f6994b76a98996f2/scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_linux_ubsan.json
[modify] https://crrev.com/dcd143389e2eb514d8f8d689f6994b76a98996f2/scripts/slave/recipes/webrtc/standalone.expected/tryserver_webrtc_mac_asan.json
[modify] https://crrev.com/dcd143389e2eb514d8f8d689f6994b76a98996f2/scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_perf_mac_10_11.json
[modify] https://crrev.com/dcd143389e2eb514d8f8d689f6994b76a98996f2/scripts/slave/recipes/webrtc/standalone.expected/tryserver_webrtc_android_rel.json
[modify] https://crrev.com/dcd143389e2eb514d8f8d689f6994b76a98996f2/scripts/slave/recipes/webrtc/standalone.expected/tryserver_webrtc_linux_experimental.json
[modify] https://crrev.com/dcd143389e2eb514d8f8d689f6994b76a98996f2/scripts/slave/recipes/webrtc/standalone.expected/tryserver_webrtc_linux_gcc_rel.json
[modify] https://crrev.com/dcd143389e2eb514d8f8d689f6994b76a98996f2/scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_linux64_release__arm_.json
[modify] https://crrev.com/dcd143389e2eb514d8f8d689f6994b76a98996f2/scripts/slave/recipes/webrtc/standalone.expected/tryserver_webrtc_linux_msan.json
[modify] https://crrev.com/dcd143389e2eb514d8f8d689f6994b76a98996f2/scripts/slave/recipes/webrtc/standalone.expected/tryserver_webrtc_win_dbg.json
[modify] https://crrev.com/dcd143389e2eb514d8f8d689f6994b76a98996f2/scripts/slave/recipes/webrtc/standalone.expected/tryserver_webrtc_android_dbg.json
[modify] https://crrev.com/dcd143389e2eb514d8f8d689f6994b76a98996f2/scripts/slave/recipes/webrtc/standalone.expected/tryserver_webrtc_mac_compile_dbg.json
[modify] https://crrev.com/dcd143389e2eb514d8f8d689f6994b76a98996f2/scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_linux64_builder.json
[modify] https://crrev.com/dcd143389e2eb514d8f8d689f6994b76a98996f2/scripts/slave/recipes/webrtc/standalone.expected/tryserver_webrtc_mac_compile_rel.json
[modify] https://crrev.com/dcd143389e2eb514d8f8d689f6994b76a98996f2/scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_mac_asan.json
[modify] https://crrev.com/dcd143389e2eb514d8f8d689f6994b76a98996f2/scripts/slave/recipes/webrtc/standalone.expected/tryserver_webrtc_linux_rel.json
[modify] https://crrev.com/dcd143389e2eb514d8f8d689f6994b76a98996f2/scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_linux64_release.json
[modify] https://crrev.com/dcd143389e2eb514d8f8d689f6994b76a98996f2/scripts/slave/recipes/webrtc/standalone.expected/tryserver_webrtc_linux32_dbg.json
[modify] https://crrev.com/dcd143389e2eb514d8f8d689f6994b76a98996f2/scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_linux32_release__arm_.json
[modify] https://crrev.com/dcd143389e2eb514d8f8d689f6994b76a98996f2/scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_perf_android32_builder_forced.json
[modify] https://crrev.com/dcd143389e2eb514d8f8d689f6994b76a98996f2/scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_linux64_debug_failing_test.json
[modify] https://crrev.com/dcd143389e2eb514d8f8d689f6994b76a98996f2/scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_branches_linux__stable_.json
[modify] https://crrev.com/dcd143389e2eb514d8f8d689f6994b76a98996f2/scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_branches_win__stable_.json
[modify] https://crrev.com/dcd143389e2eb514d8f8d689f6994b76a98996f2/scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_perf_android64_builder.json
[modify] https://crrev.com/dcd143389e2eb514d8f8d689f6994b76a98996f2/scripts/slave/recipes/webrtc/standalone.expected/tryserver_webrtc_linux_compile_rel_chromium.json
[modify] https://crrev.com/dcd143389e2eb514d8f8d689f6994b76a98996f2/scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_android32__m_nexus5x__dbg_.json
[modify] https://crrev.com/dcd143389e2eb514d8f8d689f6994b76a98996f2/scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_mac64_release.json
[modify] https://crrev.com/dcd143389e2eb514d8f8d689f6994b76a98996f2/scripts/slave/recipes/webrtc/standalone.expected/tryserver_webrtc_android_compile_x64_dbg.json
[modify] https://crrev.com/dcd143389e2eb514d8f8d689f6994b76a98996f2/scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_perf_android32_builder.json
[modify] https://crrev.com/dcd143389e2eb514d8f8d689f6994b76a98996f2/scripts/slave/recipes/webrtc/standalone.expected/tryserver_webrtc_win_x64_clang_dbg.json
[modify] https://crrev.com/dcd143389e2eb514d8f8d689f6994b76a98996f2/scripts/slave/recipes/webrtc/standalone.expected/tryserver_webrtc_android_compile_x86_dbg.json
[modify] https://crrev.com/dcd143389e2eb514d8f8d689f6994b76a98996f2/scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_linux_asan.json
[modify] https://crrev.com/dcd143389e2eb514d8f8d689f6994b76a98996f2/scripts/slave/recipes/webrtc/standalone.expected/tryserver_webrtc_win_rel.json
[modify] https://crrev.com/dcd143389e2eb514d8f8d689f6994b76a98996f2/scripts/slave/recipes/webrtc/standalone.expected/tryserver_webrtc_win_x64_win8.json
[modify] https://crrev.com/dcd143389e2eb514d8f8d689f6994b76a98996f2/scripts/slave/recipes/webrtc/standalone.expected/tryserver_webrtc_linux_memcheck.json
[modify] https://crrev.com/dcd143389e2eb514d8f8d689f6994b76a98996f2/scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_win64_release__clang_.json
[modify] https://crrev.com/dcd143389e2eb514d8f8d689f6994b76a98996f2/scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_fyi_android_perf__swarming_.json
[modify] https://crrev.com/dcd143389e2eb514d8f8d689f6994b76a98996f2/scripts/slave/recipes/webrtc/standalone.expected/tryserver_webrtc_linux_arm64_rel.json
[modify] https://crrev.com/dcd143389e2eb514d8f8d689f6994b76a98996f2/scripts/slave/recipes/webrtc/standalone.expected/tryserver_webrtc_win_compile_rel.json
[modify] https://crrev.com/dcd143389e2eb514d8f8d689f6994b76a98996f2/scripts/slave/recipes/webrtc/standalone.expected/tryserver_webrtc_win_clang_dbg.json
[modify] https://crrev.com/dcd143389e2eb514d8f8d689f6994b76a98996f2/scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_linux64_debug.json
[modify] https://crrev.com/dcd143389e2eb514d8f8d689f6994b76a98996f2/scripts/slave/recipes/webrtc/standalone.expected/tryserver_webrtc_win_x64_clang_rel.json
[modify] https://crrev.com/dcd143389e2eb514d8f8d689f6994b76a98996f2/scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_android32_builder_arm.json
[modify] https://crrev.com/dcd143389e2eb514d8f8d689f6994b76a98996f2/scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_fyi_win64_debug__win8_.json
[modify] https://crrev.com/dcd143389e2eb514d8f8d689f6994b76a98996f2/scripts/slave/recipes/webrtc/standalone.expected/tryserver_webrtc_mac_experimental.json
Project Member

Comment 46 by bugdroid1@chromium.org, Sep 18 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/tools/depot_tools/+/0f322bfcf5098d175ac2649b506f297838d3ac54

commit 0f322bfcf5098d175ac2649b506f297838d3ac54
Author: Nodir Turakulov <nodir@google.com>
Date: Tue Sep 18 17:01:49 2018

[bot_update] Add gclient.get_gerrit_patch_root

Add a shortcut for getting local path to the patch repo.

In bot_update.api._destination_branch, start using it instead of reading
gclient config directly. This removes one more patch_project usage.

Recipe-Nontrivial-Roll: build
Recipe-Nontrivial-Roll: infra
Bug: 694348
Change-Id: If05371d0f6d11be6803ffa8392e029f5860dda25
Reviewed-on: https://chromium-review.googlesource.com/1217670
Commit-Queue: Nodir Turakulov <nodir@chromium.org>
Reviewed-by: Edward Lesmes <ehmaldonado@chromium.org>
Reviewed-by: Andrii Shyshkalov <tandrii@chromium.org>

[modify] https://crrev.com/0f322bfcf5098d175ac2649b506f297838d3ac54/recipes/README.recipes.md
[modify] https://crrev.com/0f322bfcf5098d175ac2649b506f297838d3ac54/recipes/recipe_modules/gclient/api.py
[modify] https://crrev.com/0f322bfcf5098d175ac2649b506f297838d3ac54/recipes/recipe_modules/bot_update/examples/buildbucket.expected/ci with invalid repo.json
[modify] https://crrev.com/0f322bfcf5098d175ac2649b506f297838d3ac54/recipes/recipe_modules/bot_update/api.py
[modify] https://crrev.com/0f322bfcf5098d175ac2649b506f297838d3ac54/recipes/recipe_modules/gclient/tests/patch_project.py
Project Member

Comment 47 by bugdroid1@chromium.org, Sep 18 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/tools/depot_tools/+/7b54572eb0c18346d82a76e85b854c3ec316a3bd

commit 7b54572eb0c18346d82a76e85b854c3ec316a3bd
Author: Nodir Turakulov <nodir@google.com>
Date: Tue Sep 18 17:28:47 2018

[gclient] Fix typo in get_gerrit_patch_root

https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1217670/17
used solution instead of solution name.

TBR=tandrii@chromium.org

Recipe-Nontrivial-Roll: build
Recipe-Nontrivial-Roll: infra
Bug: 694348
Change-Id: I829cba9223d73383791b018f9a23598443e8fa2c
Reviewed-on: https://chromium-review.googlesource.com/1231278
Reviewed-by: Nodir Turakulov <nodir@chromium.org>
Reviewed-by: Andrii Shyshkalov <tandrii@chromium.org>
Commit-Queue: Nodir Turakulov <nodir@chromium.org>

[modify] https://crrev.com/7b54572eb0c18346d82a76e85b854c3ec316a3bd/recipes/README.recipes.md
[modify] https://crrev.com/7b54572eb0c18346d82a76e85b854c3ec316a3bd/recipes/recipe_modules/gclient/api.py
Project Member

Comment 48 by bugdroid1@chromium.org, Sep 18 

The following revision refers to this bug:
  https://chrome-internal.googlesource.com/chrome/tools/release/scripts/+/94e3cd276cd6a0be671eb06649b657ee2c0a7afe

commit 94e3cd276cd6a0be671eb06649b657ee2c0a7afe
Author: Nodir Turakulov <nodir@google.com>
Date: Tue Sep 18 18:11:37 2018
Project Member

Comment 49 by bugdroid1@chromium.org, Sep 18 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/tools/depot_tools/+/33f71ae4d045483e4bd63315a18fe9fad36ad3e5

commit 33f71ae4d045483e4bd63315a18fe9fad36ad3e5
Author: Nodir Turakulov <nodir@google.com>
Date: Tue Sep 18 18:12:39 2018

[bot_update] Update examples to use buildbucket module

Update bot_update full.py example to use buildbucket module.
Also remove buidlbucket example.

Bug: 694348
Change-Id: Ib784583e0ded5ac95fabe99bc39a53f4646e80fc
Reviewed-on: https://chromium-review.googlesource.com/1231281
Reviewed-by: Andrii Shyshkalov <tandrii@chromium.org>
Commit-Queue: Nodir Turakulov <nodir@chromium.org>

[delete] https://crrev.com/1aa405fd859a3bd625b0d61184d6e4a3cf95c0b4/recipes/recipe_modules/bot_update/examples/full.expected/tryjob_empty_revision.json
[delete] https://crrev.com/1aa405fd859a3bd625b0d61184d6e4a3cf95c0b4/recipes/recipe_modules/bot_update/examples/buildbucket.expected/ci.json
[rename] https://crrev.com/33f71ae4d045483e4bd63315a18fe9fad36ad3e5/recipes/recipe_modules/bot_update/examples/full.expected/refs.json
[modify] https://crrev.com/33f71ae4d045483e4bd63315a18fe9fad36ad3e5/recipes/recipe_modules/bot_update/examples/full.expected/with_manifest_name.json
[modify] https://crrev.com/33f71ae4d045483e4bd63315a18fe9fad36ad3e5/recipes/recipe_modules/bot_update/examples/full.expected/tryjob_gerrit_branch_heads.json
[modify] https://crrev.com/33f71ae4d045483e4bd63315a18fe9fad36ad3e5/recipes/recipe_modules/bot_update/examples/full.expected/tryjob_fail_patch_download.json
[modify] https://crrev.com/33f71ae4d045483e4bd63315a18fe9fad36ad3e5/recipes/recipe_modules/bot_update/examples/full.expected/tryjob_gerrit_angle.json
[modify] https://crrev.com/33f71ae4d045483e4bd63315a18fe9fad36ad3e5/recipes/recipe_modules/bot_update/examples/full.expected/tryjob_v8_head_by_default.json
[delete] https://crrev.com/1aa405fd859a3bd625b0d61184d6e4a3cf95c0b4/recipes/recipe_modules/bot_update/examples/buildbucket.py
[delete] https://crrev.com/1aa405fd859a3bd625b0d61184d6e4a3cf95c0b4/recipes/recipe_modules/bot_update/examples/full.expected/with_manifest_name_no_patch.json
[delete] https://crrev.com/1aa405fd859a3bd625b0d61184d6e4a3cf95c0b4/recipes/recipe_modules/bot_update/examples/buildbucket.expected/ci without repo.json
[modify] https://crrev.com/33f71ae4d045483e4bd63315a18fe9fad36ad3e5/recipes/recipe_modules/bot_update/examples/full.expected/no_apply_patch_on_gclient.json
[modify] https://crrev.com/33f71ae4d045483e4bd63315a18fe9fad36ad3e5/recipes/recipe_modules/bot_update/examples/full.expected/basic_with_branch_heads.json
[modify] https://crrev.com/33f71ae4d045483e4bd63315a18fe9fad36ad3e5/recipes/recipe_modules/bot_update/examples/full.expected/tryjob_fail.json
[delete] https://crrev.com/1aa405fd859a3bd625b0d61184d6e4a3cf95c0b4/recipes/recipe_modules/bot_update/examples/full.expected/buildbot.json
[add] https://crrev.com/33f71ae4d045483e4bd63315a18fe9fad36ad3e5/recipes/recipe_modules/bot_update/examples/full.expected/unrecognized_commit_repo.json
[delete] https://crrev.com/1aa405fd859a3bd625b0d61184d6e4a3cf95c0b4/recipes/recipe_modules/bot_update/examples/full.expected/tryjob_gerrit_v8.json
[modify] https://crrev.com/33f71ae4d045483e4bd63315a18fe9fad36ad3e5/recipes/recipe_modules/bot_update/examples/full.expected/tryjob_v8.json
[delete] https://crrev.com/1aa405fd859a3bd625b0d61184d6e4a3cf95c0b4/recipes/recipe_modules/bot_update/examples/buildbucket.expected/try.json
[modify] https://crrev.com/33f71ae4d045483e4bd63315a18fe9fad36ad3e5/recipes/recipe_modules/bot_update/examples/full.py
[modify] https://crrev.com/33f71ae4d045483e4bd63315a18fe9fad36ad3e5/recipes/recipe_modules/bot_update/examples/full.expected/tryjob_gerrit_v8_feature_branch.json
[rename] https://crrev.com/33f71ae4d045483e4bd63315a18fe9fad36ad3e5/recipes/recipe_modules/bot_update/examples/full.expected/input_commit_with_id_without_repo.json
[modify] https://crrev.com/33f71ae4d045483e4bd63315a18fe9fad36ad3e5/recipes/recipe_modules/bot_update/examples/full.expected/basic_luci.json
[modify] https://crrev.com/33f71ae4d045483e4bd63315a18fe9fad36ad3e5/recipes/recipe_modules/bot_update/examples/full.expected/tryjob_gerrit_feature_branch.json
[modify] https://crrev.com/33f71ae4d045483e4bd63315a18fe9fad36ad3e5/recipes/recipe_modules/bot_update/examples/full.expected/basic.json
[modify] https://crrev.com/33f71ae4d045483e4bd63315a18fe9fad36ad3e5/recipes/recipe_modules/bot_update/examples/full.expected/deprecated_got_revision_mapping.json
[modify] https://crrev.com/33f71ae4d045483e4bd63315a18fe9fad36ad3e5/recipes/README.recipes.md
[delete] https://crrev.com/1aa405fd859a3bd625b0d61184d6e4a3cf95c0b4/recipes/recipe_modules/bot_update/examples/buildbucket.expected/ci with invalid repo.json
[modify] https://crrev.com/33f71ae4d045483e4bd63315a18fe9fad36ad3e5/recipes/recipe_modules/bot_update/examples/full.expected/tryjob_gerrit_webrtc.json
[modify] https://crrev.com/33f71ae4d045483e4bd63315a18fe9fad36ad3e5/recipes/recipe_modules/bot_update/examples/full.expected/tryjob_fail_patch.json
Project Member

Comment 50 by bugdroid1@chromium.org, Sep 18 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/tools/depot_tools/+/dd2ce986ce25528f89d36a61eae82b2213292df9

commit dd2ce986ce25528f89d36a61eae82b2213292df9
Author: Nodir Turakulov <nodir@google.com>
Date: Tue Sep 18 18:41:16 2018

[gclient] Update set_patch_project_revision

Update set_patch_project_revision to use repo_path_map instead of
patch_projects.
Also rename to set_patch_repo_revision.

Bug: 694348
Change-Id: Iba31f4910f8282160000b8fcef197052597530a4
Reviewed-on: https://chromium-review.googlesource.com/1226107
Commit-Queue: Nodir Turakulov <nodir@chromium.org>
Reviewed-by: Edward Lesmes <ehmaldonado@chromium.org>

[modify] https://crrev.com/dd2ce986ce25528f89d36a61eae82b2213292df9/recipes/recipe_modules/bot_update/examples/full.expected/tryjob_v8_head_by_default.json
[modify] https://crrev.com/dd2ce986ce25528f89d36a61eae82b2213292df9/recipes/recipe_modules/gclient/api.py
[modify] https://crrev.com/dd2ce986ce25528f89d36a61eae82b2213292df9/recipes/recipe_modules/gclient/tests/patch_project.py
[modify] https://crrev.com/dd2ce986ce25528f89d36a61eae82b2213292df9/recipes/recipe_modules/bot_update/examples/full.expected/no_apply_patch_on_gclient.json
[modify] https://crrev.com/dd2ce986ce25528f89d36a61eae82b2213292df9/recipes/README.recipes.md
[modify] https://crrev.com/dd2ce986ce25528f89d36a61eae82b2213292df9/recipes/recipe_modules/bot_update/api.py
[modify] https://crrev.com/dd2ce986ce25528f89d36a61eae82b2213292df9/recipes/recipe_modules/bot_update/examples/full.expected/tryjob_gerrit_webrtc.json
[modify] https://crrev.com/dd2ce986ce25528f89d36a61eae82b2213292df9/recipes/recipe_modules/bot_update/examples/full.expected/tryjob_gerrit_angle.json
[modify] https://crrev.com/dd2ce986ce25528f89d36a61eae82b2213292df9/recipes/recipe_modules/bot_update/examples/full.expected/tryjob_gerrit_v8_feature_branch.json
Project Member

Comment 51 by bugdroid1@chromium.org, Sep 18 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/37812790f2c5b3025e3cffc92c880ff3bb9a7f66

commit 37812790f2c5b3025e3cffc92c880ff3bb9a7f66
Author: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Date: Tue Sep 18 19:32:01 2018

Roll src/third_party/depot_tools 804797362e1d..1aa405fd859a (5 commits)

https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/804797362e1d..1aa405fd859a


git log 804797362e1d..1aa405fd859a --date=short --no-merges --format='%ad %ae %s'
2018-09-18 sergiyb@chromium.org Add an option to disable adding CC emails automatically
2018-09-18 nodir@google.com [gclient] Fix typo in get_gerrit_patch_root
2018-09-18 nodir@google.com [bot_update] Add gclient.get_gerrit_patch_root
2018-09-18 vadimsh@chromium.org [cipd] Pin hashes of CIPD packages.
2018-09-18 borenet@chromium.org Revert "gerrit_util: Support OAuth2 bearer tokens in CookieAuthenticator"


Created with:
  gclient setdep -r src/third_party/depot_tools@1aa405fd859a

The AutoRoll server is located here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.



BUG=chromium:878303,chromium:694348,chromium:694348,chromium:870166
TBR=agable@chromium.org

Change-Id: I439b74e4283ec9962446dd2b14a101175f7fbb4d
Reviewed-on: https://chromium-review.googlesource.com/1231496
Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#592145}
[modify] https://crrev.com/37812790f2c5b3025e3cffc92c880ff3bb9a7f66/DEPS
Project Member

Comment 52 by bugdroid1@chromium.org, Sep 18 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/tools/depot_tools/+/78eed01c0bbd387c0b6a0851918fb65f9e40bea2

commit 78eed01c0bbd387c0b6a0851918fb65f9e40bea2
Author: Nodir Turakulov <nodir@google.com>
Date: Tue Sep 18 19:51:53 2018

[bot_update] Use get_gerrit_patch_root

Use get_gerrit_patch_root in bot_update.ensure_checkout.

This fixes some tests expectations that expected CI builds to pass --patch_root
flag.

Also unify "root" and "patch_root" variables in ensure_checkout. Simpler.

This CL requires nontrivial rolls in all downstream packages because all
packages have incorrect expectations and/or tests.
In particular, this removes --patch_root flag from non-tryjob test
cases. Some tests are supposed to test tryjob scenario, but they use
properties.generic instead of properties.tryserver (or buildbucket.try_build)

Recipe-Nontrivial-Roll: build
Recipe-Nontrivial-Roll: build_limited_scripts_slave
Recipe-Nontrivial-Roll: infra
Recipe-Nontrivial-Roll: release_scripts
Recipe-Nontrivial-Roll: skiabuildbot
Bug: 694348
Change-Id: Ibc594fa42e3b4d2823672b41dda2d97154b10d38
Reviewed-on: https://chromium-review.googlesource.com/1231280
Commit-Queue: Nodir Turakulov <nodir@chromium.org>
Reviewed-by: Andrii Shyshkalov <tandrii@chromium.org>

[modify] https://crrev.com/78eed01c0bbd387c0b6a0851918fb65f9e40bea2/recipes/recipe_modules/bot_update/examples/full.expected/basic.json
[modify] https://crrev.com/78eed01c0bbd387c0b6a0851918fb65f9e40bea2/recipes/recipe_modules/bot_update/examples/full.expected/multiple_patch_refs.json
[modify] https://crrev.com/78eed01c0bbd387c0b6a0851918fb65f9e40bea2/recipes/recipe_modules/bot_update/examples/full.expected/refs.json
[modify] https://crrev.com/78eed01c0bbd387c0b6a0851918fb65f9e40bea2/recipes/recipes/fetch_end_to_end_test.expected/basic.json
[modify] https://crrev.com/78eed01c0bbd387c0b6a0851918fb65f9e40bea2/recipes/recipe_modules/bot_update/examples/full.expected/clobber.json
[modify] https://crrev.com/78eed01c0bbd387c0b6a0851918fb65f9e40bea2/recipes/recipe_modules/bot_update/examples/full.expected/gerrit_no_reset.json
[modify] https://crrev.com/78eed01c0bbd387c0b6a0851918fb65f9e40bea2/recipes/recipe_modules/bot_update/examples/full.expected/basic_luci.json
[modify] https://crrev.com/78eed01c0bbd387c0b6a0851918fb65f9e40bea2/recipes/recipe_modules/bot_update/examples/full.expected/gerrit_no_rebase_patch_ref.json
[modify] https://crrev.com/78eed01c0bbd387c0b6a0851918fb65f9e40bea2/recipes/README.recipes.md
[modify] https://crrev.com/78eed01c0bbd387c0b6a0851918fb65f9e40bea2/recipes/recipe_modules/bot_update/examples/full.expected/basic_with_branch_heads.json
[modify] https://crrev.com/78eed01c0bbd387c0b6a0851918fb65f9e40bea2/recipes/recipe_modules/bot_update/examples/full.expected/with_manifest_name.json
[modify] https://crrev.com/78eed01c0bbd387c0b6a0851918fb65f9e40bea2/recipes/recipe_modules/bot_update/api.py
[modify] https://crrev.com/78eed01c0bbd387c0b6a0851918fb65f9e40bea2/recipes/recipe_modules/bot_update/examples/full.expected/input_commit_with_id_without_repo.json
[modify] https://crrev.com/78eed01c0bbd387c0b6a0851918fb65f9e40bea2/recipes/recipe_modules/bot_update/examples/full.expected/reset_root_solution_revision.json
[modify] https://crrev.com/78eed01c0bbd387c0b6a0851918fb65f9e40bea2/recipes/recipe_modules/bot_update/examples/full.expected/with_tags.json
Project Member

Comment 53 by bugdroid1@chromium.org, Sep 18 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/981db1af9fc0c64ce363fe90e0be13a0bcd9d0a6

commit 981db1af9fc0c64ce363fe90e0be13a0bcd9d0a6
Author: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Date: Tue Sep 18 21:31:12 2018

Roll src/third_party/depot_tools 1aa405fd859a..dd2ce986ce25 (3 commits)

https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/1aa405fd859a..dd2ce986ce25


git log 1aa405fd859a..dd2ce986ce25 --date=short --no-merges --format='%ad %ae %s'
2018-09-18 nodir@google.com [gclient] Update set_patch_project_revision
2018-09-18 ehmaldonado@chromium.org gclient: delete unversioned directory before adding cipd dep for the same path
2018-09-18 nodir@google.com [bot_update] Update examples to use buildbucket module


Created with:
  gclient setdep -r src/third_party/depot_tools@dd2ce986ce25

The AutoRoll server is located here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.



BUG=chromium:694348,chromium:882611,chromium:694348
TBR=agable@chromium.org

Change-Id: I51d6fc4125e76f9f2435e9650e7434fe61ced729
Reviewed-on: https://chromium-review.googlesource.com/1232057
Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#592203}
[modify] https://crrev.com/981db1af9fc0c64ce363fe90e0be13a0bcd9d0a6/DEPS
Project Member

Comment 54 by bugdroid1@chromium.org, Sep 18 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/tools/build/+/69c813a6dd84a40e74bc0239d334cb3d154a6a55

commit 69c813a6dd84a40e74bc0239d334cb3d154a6a55
Author: Nodir Turakulov <nodir@google.com>
Date: Tue Sep 18 21:34:21 2018

[bisection] use buildbucket.try_build in tests

Like https://chromium-review.googlesource.com/c/chromium/tools/build/+/1214288
but for desktop_bisect_staging.

R=tandrii@chromium.org

Bug: 694348
Change-Id: I1f7dda69f7d42ae745dc9c128ed096e85d9ef539
Reviewed-on: https://chromium-review.googlesource.com/1232139
Reviewed-by: Dave Tu <dtu@chromium.org>
Commit-Queue: Nodir Turakulov <nodir@chromium.org>

[modify] https://crrev.com/69c813a6dd84a40e74bc0239d334cb3d154a6a55/scripts/slave/recipes/bisection/desktop_bisect_staging.expected/basic_perf_tryjob_with_metric_valueset.json
[modify] https://crrev.com/69c813a6dd84a40e74bc0239d334cb3d154a6a55/scripts/slave/recipes/bisection/desktop_bisect_staging.expected/basic_perf_tryjob_with_revisions.json
[modify] https://crrev.com/69c813a6dd84a40e74bc0239d334cb3d154a6a55/scripts/slave/recipes/bisection/desktop_bisect_staging.expected/basic_perf_tryjob.json
[modify] https://crrev.com/69c813a6dd84a40e74bc0239d334cb3d154a6a55/scripts/slave/README.recipes.md
[modify] https://crrev.com/69c813a6dd84a40e74bc0239d334cb3d154a6a55/scripts/slave/recipes/bisection/desktop_bisect_staging.expected/basic_perf_tryjob_with_bucket.json
[modify] https://crrev.com/69c813a6dd84a40e74bc0239d334cb3d154a6a55/scripts/slave/recipes/bisection/desktop_bisect_staging.py
[modify] https://crrev.com/69c813a6dd84a40e74bc0239d334cb3d154a6a55/scripts/slave/recipes/bisection/desktop_bisect_staging.expected/perf_tryjob_no_config.json
[modify] https://crrev.com/69c813a6dd84a40e74bc0239d334cb3d154a6a55/scripts/slave/recipes/bisection/desktop_bisect_staging.expected/deps_perf_tryjob.json
[modify] https://crrev.com/69c813a6dd84a40e74bc0239d334cb3d154a6a55/scripts/slave/recipes/bisection/desktop_bisect_staging.expected/basic_perf_tryjob_with_metric.json
[modify] https://crrev.com/69c813a6dd84a40e74bc0239d334cb3d154a6a55/scripts/slave/recipes/bisection/desktop_bisect_staging.expected/perf_tryjob_config_error.json
[modify] https://crrev.com/69c813a6dd84a40e74bc0239d334cb3d154a6a55/scripts/slave/recipes/bisection/desktop_bisect_staging.expected/basic.json
[modify] https://crrev.com/69c813a6dd84a40e74bc0239d334cb3d154a6a55/scripts/slave/recipes/bisection/desktop_bisect_staging.expected/perf_tryjob_failed_test.json
Project Member

Comment 55 by bugdroid1@chromium.org, Sep 18 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/tools/build/+/de4d9edc222a2830f1a25808d68d9cda511bd081

commit de4d9edc222a2830f1a25808d68d9cda511bd081
Author: Nodir Turakulov <nodir@google.com>
Date: Tue Sep 18 21:43:51 2018

Use gclient.get_gerrit_patch_root

Switch chromium_checkout/api.py and run_presubmit.py from
gclient.calcualate_patch_root to new and simpler gclient.get_gerrit_patch_root.

Also fix a typo in a repo URL.

Bug: 694348
Change-Id: Ie8ef8c2f7d888eeb066a38e3d6a366e3dccee4b7
Reviewed-on: https://chromium-review.googlesource.com/1226087
Reviewed-by: Stephen Martinis <martiniss@chromium.org>
Commit-Queue: Nodir Turakulov <nodir@chromium.org>

[modify] https://crrev.com/de4d9edc222a2830f1a25808d68d9cda511bd081/scripts/slave/README.recipes.md
[modify] https://crrev.com/de4d9edc222a2830f1a25808d68d9cda511bd081/scripts/slave/recipe_modules/chromium_checkout/tests/full.py
[modify] https://crrev.com/de4d9edc222a2830f1a25808d68d9cda511bd081/scripts/slave/recipes/run_presubmit.py
[modify] https://crrev.com/de4d9edc222a2830f1a25808d68d9cda511bd081/scripts/slave/recipe_modules/chromium_checkout/api.py
Project Member

Comment 57 by bugdroid1@chromium.org, Sep 18 

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/infra/+/d979a085aa309637b7a057a8493f293442f4309e

commit d979a085aa309637b7a057a8493f293442f4309e
Author: Nodir Turakulov <nodir@google.com>
Date: Tue Sep 18 23:18:33 2018

Stop using patch_project in infra_repo_trybot

Use buildbucket.build.input.gerrit_changes[0] instead.

R=tandrii@chromium.org

Bug: 694348
Change-Id: Idc76e0da5ec8a2d4ce25c55b4e1390344fc3a963
Reviewed-on: https://chromium-review.googlesource.com/1232496
Commit-Queue: Nodir Turakulov <nodir@chromium.org>
Commit-Queue: Andrii Shyshkalov <tandrii@chromium.org>
Auto-Submit: Nodir Turakulov <nodir@chromium.org>
Reviewed-by: Andrii Shyshkalov <tandrii@chromium.org>
Cr-Commit-Position: refs/heads/master@{#17684}
[modify] https://crrev.com/d979a085aa309637b7a057a8493f293442f4309e/recipes/README.recipes.md
[modify] https://crrev.com/d979a085aa309637b7a057a8493f293442f4309e/recipes/recipes/infra_repo_trybot.py
Project Member

Comment 58 by bugdroid1@chromium.org, Sep 18 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/tools/depot_tools/+/15b586a4932a5760cbff9478739d19d660e69b19

commit 15b586a4932a5760cbff9478739d19d660e69b19
Author: Nodir Turakulov <nodir@google.com>
Date: Tue Sep 18 23:33:19 2018

Remove PATCH_PROJECT

Remove PATCH_PROJECT from gclient config. It is not used.

R=tandrii@chromium.org

Bug: 694348
Change-Id: I56e4aefbe5e9b23296553bb61f878d6426197fa7
Reviewed-on: https://chromium-review.googlesource.com/1232873
Commit-Queue: Nodir Turakulov <nodir@chromium.org>
Commit-Queue: Robbie Iannucci <iannucci@chromium.org>
Auto-Submit: Nodir Turakulov <nodir@chromium.org>
Reviewed-by: Robbie Iannucci <iannucci@chromium.org>

[modify] https://crrev.com/15b586a4932a5760cbff9478739d19d660e69b19/recipes/recipe_modules/gclient/config.py
Project Member

Comment 59 by bugdroid1@chromium.org, Sep 18 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c341db6c8ccdd6c77c0d61f6379272bb6046ebe5

commit c341db6c8ccdd6c77c0d61f6379272bb6046ebe5
Author: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Date: Tue Sep 18 23:40:21 2018

Roll src/third_party/depot_tools dd2ce986ce25..07b5283a4ea1 (3 commits)

https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/dd2ce986ce25..07b5283a4ea1


git log dd2ce986ce25..07b5283a4ea1 --date=short --no-merges --format='%ad %ae %s'
2018-09-18 tandrii@chromium.org Revert "gclient: delete unversioned directory before adding cipd dep for the same path"
2018-09-18 nodir@google.com [bot_update] Use get_gerrit_patch_root
2018-09-18 tandrii@chromium.org gerrit_util: document hack.


Created with:
  gclient setdep -r src/third_party/depot_tools@07b5283a4ea1

The AutoRoll server is located here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.



BUG=chromium:882611,chromium:694348,chromium:881860
TBR=agable@chromium.org

Change-Id: I761e53cff80b5562c3e581360f0f3180b5e8350d
Reviewed-on: https://chromium-review.googlesource.com/1232024
Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#592260}
[modify] https://crrev.com/c341db6c8ccdd6c77c0d61f6379272bb6046ebe5/DEPS
Project Member

Comment 60 by bugdroid1@chromium.org, Sep 18 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/tools/depot_tools/+/79c651330b9414a1e97450c3d22f414f9bb58a92

commit 79c651330b9414a1e97450c3d22f414f9bb58a92
Author: Nodir Turakulov <nodir@google.com>
Date: Tue Sep 18 23:51:29 2018

[gclient] Remove is_blink_mode

Not used

R=tandrii@chromium.org

Bug: 694348
Change-Id: I3188881b1f92df1cbfdbf3aafe309abb9488d9b2
Reviewed-on: https://chromium-review.googlesource.com/1232874
Auto-Submit: Nodir Turakulov <nodir@chromium.org>
Commit-Queue: Robbie Iannucci <iannucci@chromium.org>
Reviewed-by: Robbie Iannucci <iannucci@chromium.org>

[modify] https://crrev.com/79c651330b9414a1e97450c3d22f414f9bb58a92/recipes/recipe_modules/gclient/api.py
[modify] https://crrev.com/79c651330b9414a1e97450c3d22f414f9bb58a92/recipes/recipe_modules/gclient/examples/full.py
Project Member

Comment 61 by bugdroid1@chromium.org, Sep 19 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/tools/build/+/bd4750e49513bf030f59c1d26c333c242602a9fc

commit bd4750e49513bf030f59c1d26c333c242602a9fc
Author: Nodir Turakulov <nodir@google.com>
Date: Wed Sep 19 00:23:24 2018

Stop using gclient_conifg.patch_projects

It has no effect.

R=martiniss@chromium.org, tandrii@chromium.org

Bug: 694348
Change-Id: I9fb9dc68f78dbdd58e27774c224ca0965d043abb
Reviewed-on: https://chromium-review.googlesource.com/1232717
Commit-Queue: Nodir Turakulov <nodir@chromium.org>
Commit-Queue: Andrii Shyshkalov <tandrii@chromium.org>
Auto-Submit: Nodir Turakulov <nodir@chromium.org>
Reviewed-by: Andrii Shyshkalov <tandrii@chromium.org>

[modify] https://crrev.com/bd4750e49513bf030f59c1d26c333c242602a9fc/scripts/slave/recipe_modules/v8/gclient_config.py
[modify] https://crrev.com/bd4750e49513bf030f59c1d26c333c242602a9fc/scripts/slave/recipe_modules/chromium/gclient_config.py
Project Member

Comment 62 by bugdroid1@chromium.org, Sep 19 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c15acfc2ac1c7cf58546ce888606929bfc0a1a8c

commit c15acfc2ac1c7cf58546ce888606929bfc0a1a8c
Author: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Date: Wed Sep 19 00:56:42 2018

Roll src/third_party/depot_tools 07b5283a4ea1..15b586a4932a (2 commits)

https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/07b5283a4ea1..15b586a4932a


git log 07b5283a4ea1..15b586a4932a --date=short --no-merges --format='%ad %ae %s'
2018-09-18 nodir@google.com Remove PATCH_PROJECT
2018-09-18 nodir@google.com [gclient] Remove calculate_patch_root


Created with:
  gclient setdep -r src/third_party/depot_tools@15b586a4932a

The AutoRoll server is located here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.



BUG=chromium:694348,chromium:694348
TBR=agable@chromium.org

Change-Id: I731dbabefa43fbb0c6c9665a06f9ff532730f2f2
Reviewed-on: https://chromium-review.googlesource.com/1232618
Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#592289}
[modify] https://crrev.com/c15acfc2ac1c7cf58546ce888606929bfc0a1a8c/DEPS
Project Member

Comment 63 by bugdroid1@chromium.org, Sep 19 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e6a5845e33a476d2f693ebcb8138f87b53016e06

commit e6a5845e33a476d2f693ebcb8138f87b53016e06
Author: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Date: Wed Sep 19 02:25:29 2018

Roll src/third_party/depot_tools 15b586a4932a..79c651330b94 (1 commits)

https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/15b586a4932a..79c651330b94


git log 15b586a4932a..79c651330b94 --date=short --no-merges --format='%ad %ae %s'
2018-09-18 nodir@google.com [gclient] Remove is_blink_mode


Created with:
  gclient setdep -r src/third_party/depot_tools@79c651330b94

The AutoRoll server is located here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.



BUG=chromium:694348
TBR=agable@chromium.org

Change-Id: If83b476bde46ba443ae6ee96de16064226875c06
Reviewed-on: https://chromium-review.googlesource.com/1232620
Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#592305}
[modify] https://crrev.com/e6a5845e33a476d2f693ebcb8138f87b53016e06/DEPS
Project Member

Comment 64 by bugdroid1@chromium.org, Sep 19 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/tools/build/+/a1207f542143f8efd6867af4db8f9e8628cdc3bb

commit a1207f542143f8efd6867af4db8f9e8628cdc3bb
Author: Nodir Turakulov <nodir@google.com>
Date: Wed Sep 19 04:31:25 2018

Stop passing PATCH_PROJECT

Passing PATCH_PROJECT has no effect. It is deprecated too. Remove it.

R=martiniss@chromium.org, tandrii@chromium.org

Bug: 694348
Change-Id: Ia80458766cf22c516b5aeda700261193f25855cb
Reviewed-on: https://chromium-review.googlesource.com/1232714
Auto-Submit: Nodir Turakulov <nodir@chromium.org>
Reviewed-by: Andrii Shyshkalov <tandrii@chromium.org>
Reviewed-by: John Budorick <jbudorick@chromium.org>
Commit-Queue: John Budorick <jbudorick@chromium.org>

[modify] https://crrev.com/a1207f542143f8efd6867af4db8f9e8628cdc3bb/scripts/slave/README.recipes.md
[modify] https://crrev.com/a1207f542143f8efd6867af4db8f9e8628cdc3bb/scripts/slave/recipe_modules/chromium_tests/api.py
[modify] https://crrev.com/a1207f542143f8efd6867af4db8f9e8628cdc3bb/scripts/slave/recipe_modules/chromium/api.py
Project Member

Comment 65 by bugdroid1@chromium.org, Sep 19 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/tools/build/+/030189ec4805ffa736c6e1c496af7277ab8ad98c

commit 030189ec4805ffa736c6e1c496af7277ab8ad98c
Author: Nodir Turakulov <nodir@google.com>
Date: Wed Sep 19 11:12:57 2018

Stop using patch_project in v8/api.py

R=machenbach@chromium.org, sergiyb@chromium.org

Bug: 694348
Change-Id: I8b7e623278f87ab995975730f19e6b03139c980f
Reviewed-on: https://chromium-review.googlesource.com/1232716
Commit-Queue: Michael Achenbach <machenbach@chromium.org>
Reviewed-by: Michael Achenbach <machenbach@chromium.org>
Auto-Submit: Nodir Turakulov <nodir@chromium.org>

[modify] https://crrev.com/030189ec4805ffa736c6e1c496af7277ab8ad98c/scripts/slave/recipe_modules/v8/api.py
[modify] https://crrev.com/030189ec4805ffa736c6e1c496af7277ab8ad98c/scripts/slave/recipes/v8.expected/full_tryserver_v8_v8_foobar_rel_ng_triggered_flakes.json
[modify] https://crrev.com/030189ec4805ffa736c6e1c496af7277ab8ad98c/scripts/slave/recipes/v8.expected/full_tryserver_v8_v8_foobar_rel_ng_triggered_failures.json
[modify] https://crrev.com/030189ec4805ffa736c6e1c496af7277ab8ad98c/scripts/slave/recipes/v8.expected/full_tryserver_v8_v8_foobar_rel_ng_triggered_slow_tests.json
[modify] https://crrev.com/030189ec4805ffa736c6e1c496af7277ab8ad98c/scripts/slave/recipes/v8.expected/full_tryserver_v8_v8_foobar_rel_ng_triggered_test_filter.json
[modify] https://crrev.com/030189ec4805ffa736c6e1c496af7277ab8ad98c/scripts/slave/recipes/v8.expected/full_tryserver_v8_v8_foobar_rel_ng_triggered_triggered_by_cq.json
[modify] https://crrev.com/030189ec4805ffa736c6e1c496af7277ab8ad98c/scripts/slave/recipes/v8.expected/full_tryserver_v8_v8_linux64_sanitizer_coverage_rel.json
[modify] https://crrev.com/030189ec4805ffa736c6e1c496af7277ab8ad98c/scripts/slave/recipes/v8.expected/full_tryserver_v8_v8_foobar_rel_ng_triggered_positional_extra_flags.json
Project Member

Comment 66 by bugdroid1@chromium.org, Sep 19 

The following revision refers to this bug:
  https://skia.googlesource.com/skia/+/473b40b7ca2574855afea20859cbb9841c54369f

commit 473b40b7ca2574855afea20859cbb9841c54369f
Author: Nodir Turakulov <nodir@google.com>
Date: Wed Sep 19 19:59:21 2018

Populate repo_path_map

checkout/api.py populates patch_projects mapping which has no effect.
All of its usages were migrated to repo_path_map mapping.
Populate repo_path_map instead.

R=rmistry@chromium.org

Bug: 694348
Change-Id: I4fc6fe86565f75f4b4b5b5ca041f584d30fcd8a5
Reviewed-on: https://skia-review.googlesource.com/155632
Auto-Submit: Nodir Turakulov <nodir@google.com>
Reviewed-by: Eric Boren <borenet@google.com>
Commit-Queue: Eric Boren <borenet@google.com>

[modify] https://crrev.com/473b40b7ca2574855afea20859cbb9841c54369f/infra/bots/recipe_modules/checkout/api.py
Project Member

Comment 67 by bugdroid1@chromium.org, Sep 19 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/tools/depot_tools/+/f837545214f5a8666c49f02c3b717bdc04604f7a

commit f837545214f5a8666c49f02c3b717bdc04604f7a
Author: Nodir Turakulov <nodir@google.com>
Date: Wed Sep 19 20:03:57 2018

[gclient] Remove patch_projects

It was superseded by repo_path_map.

Bug: 694348
Change-Id: If6b4790290bf2573f2a9367334decf064d382f52
Reviewed-on: https://chromium-review.googlesource.com/1232875
Commit-Queue: Nodir Turakulov <nodir@chromium.org>
Auto-Submit: Nodir Turakulov <nodir@chromium.org>
Reviewed-by: Andrii Shyshkalov <tandrii@chromium.org>

[modify] https://crrev.com/f837545214f5a8666c49f02c3b717bdc04604f7a/recipes/recipe_modules/bot_update/examples/full.py
[modify] https://crrev.com/f837545214f5a8666c49f02c3b717bdc04604f7a/recipes/recipe_modules/gclient/config.py
[modify] https://crrev.com/f837545214f5a8666c49f02c3b717bdc04604f7a/recipes/recipe_modules/gclient/tests/patch_project.py
Project Member

Comment 68 by bugdroid1@chromium.org, Sep 19 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/tools/build/+/7085ff77521149bce54e3a2ad1c65ac6578d2dca

commit 7085ff77521149bce54e3a2ad1c65ac6578d2dca
Author: Nodir Turakulov <nodir@google.com>
Date: Wed Sep 19 21:28:41 2018

Use buildbucket module in swarming module

Stop using deprecated patch_* properties in swarming/api.py
Also drop support for rietveld and make unit tests more unity.

Bug: 694348
Change-Id: I81524ea0c387acccead1624d6d21363fecedc604
Reviewed-on: https://chromium-review.googlesource.com/1234583
Auto-Submit: Nodir Turakulov <nodir@chromium.org>
Commit-Queue: Stephen Martinis <martiniss@chromium.org>
Reviewed-by: Stephen Martinis <martiniss@chromium.org>

[modify] https://crrev.com/7085ff77521149bce54e3a2ad1c65ac6578d2dca/scripts/slave/recipes/webrtc/standalone.expected/tryserver_webrtc_win_asan.json
[modify] https://crrev.com/7085ff77521149bce54e3a2ad1c65ac6578d2dca/scripts/slave/recipe_modules/swarming/examples/full.expected/show_shards_in_collect_step.json
[modify] https://crrev.com/7085ff77521149bce54e3a2ad1c65ac6578d2dca/scripts/slave/recipes/webrtc/standalone.expected/tryserver_webrtc_win_x64_win10.json
[modify] https://crrev.com/7085ff77521149bce54e3a2ad1c65ac6578d2dca/scripts/slave/recipes/webrtc/standalone.expected/tryserver_webrtc_mac_asan.json
[modify] https://crrev.com/7085ff77521149bce54e3a2ad1c65ac6578d2dca/scripts/slave/recipe_modules/swarming/api.py
[modify] https://crrev.com/7085ff77521149bce54e3a2ad1c65ac6578d2dca/scripts/slave/recipes/webrtc/standalone.expected/tryserver_webrtc_win_experimental.json
[modify] https://crrev.com/7085ff77521149bce54e3a2ad1c65ac6578d2dca/scripts/slave/recipes/webrtc/standalone.expected/tryserver_webrtc_mac_dbg.json
[modify] https://crrev.com/7085ff77521149bce54e3a2ad1c65ac6578d2dca/scripts/slave/recipes/webrtc/standalone.expected/tryserver_webrtc_linux32_dbg.json
[modify] https://crrev.com/7085ff77521149bce54e3a2ad1c65ac6578d2dca/scripts/slave/recipes/webrtc/standalone.expected/tryserver_webrtc_linux_tsan2.json
[delete] https://crrev.com/2cb3699e2517ee6387d915130dee4a5d4c68ac47/scripts/slave/recipe_modules/swarming/examples/full.expected/rietveld_trybot.json
[modify] https://crrev.com/7085ff77521149bce54e3a2ad1c65ac6578d2dca/scripts/slave/recipes/webrtc/standalone.expected/tryserver_webrtc_win_x64_dbg.json
[modify] https://crrev.com/7085ff77521149bce54e3a2ad1c65ac6578d2dca/scripts/slave/recipes/webrtc/standalone.expected/tryserver_webrtc_win_x64_win8.json
[modify] https://crrev.com/7085ff77521149bce54e3a2ad1c65ac6578d2dca/scripts/slave/recipes/webrtc/standalone.expected/tryserver_webrtc_android_rel.json
[modify] https://crrev.com/7085ff77521149bce54e3a2ad1c65ac6578d2dca/scripts/slave/recipes/webrtc/standalone.expected/tryserver_webrtc_linux_experimental.json
[modify] https://crrev.com/7085ff77521149bce54e3a2ad1c65ac6578d2dca/scripts/slave/recipe_modules/swarming/examples/full.py
[modify] https://crrev.com/7085ff77521149bce54e3a2ad1c65ac6578d2dca/scripts/slave/recipes/webrtc/standalone.expected/tryserver_webrtc_mac_rel.json
[modify] https://crrev.com/7085ff77521149bce54e3a2ad1c65ac6578d2dca/scripts/slave/recipes/ios/try.expected/basic.json
[modify] https://crrev.com/7085ff77521149bce54e3a2ad1c65ac6578d2dca/scripts/slave/recipes/webrtc/standalone.expected/tryserver_webrtc_win_rel.json
[modify] https://crrev.com/7085ff77521149bce54e3a2ad1c65ac6578d2dca/scripts/slave/recipes/webrtc/standalone.expected/tryserver_webrtc_win_clang_rel.json
[modify] https://crrev.com/7085ff77521149bce54e3a2ad1c65ac6578d2dca/scripts/slave/recipes/webrtc/standalone.expected/tryserver_webrtc_android_arm64_rel.json
[modify] https://crrev.com/7085ff77521149bce54e3a2ad1c65ac6578d2dca/scripts/slave/recipes/webrtc/standalone.expected/tryserver_webrtc_linux_memcheck.json
[modify] https://crrev.com/7085ff77521149bce54e3a2ad1c65ac6578d2dca/scripts/slave/recipes/webrtc/standalone.expected/tryserver_webrtc_linux_msan.json
[modify] https://crrev.com/7085ff77521149bce54e3a2ad1c65ac6578d2dca/scripts/slave/recipes/webrtc/standalone.expected/tryserver_webrtc_linux32_rel.json
[modify] https://crrev.com/7085ff77521149bce54e3a2ad1c65ac6578d2dca/scripts/slave/recipe_modules/swarming/examples/full.expected/show_isolated_out_in_collect_step.json
[modify] https://crrev.com/7085ff77521149bce54e3a2ad1c65ac6578d2dca/scripts/slave/recipes/webrtc/standalone.expected/tryserver_webrtc_android_experimental.json
[modify] https://crrev.com/7085ff77521149bce54e3a2ad1c65ac6578d2dca/scripts/slave/recipes/webrtc/standalone.expected/tryserver_webrtc_linux_ubsan.json
[modify] https://crrev.com/7085ff77521149bce54e3a2ad1c65ac6578d2dca/scripts/slave/recipes/webrtc/standalone.expected/tryserver_webrtc_linux_asan.json
[modify] https://crrev.com/7085ff77521149bce54e3a2ad1c65ac6578d2dca/scripts/slave/recipes/webrtc/standalone.expected/tryserver_webrtc_win_dbg.json
[modify] https://crrev.com/7085ff77521149bce54e3a2ad1c65ac6578d2dca/scripts/slave/recipes/webrtc/standalone.expected/tryserver_webrtc_android_dbg.json
[modify] https://crrev.com/7085ff77521149bce54e3a2ad1c65ac6578d2dca/scripts/slave/recipe_modules/swarming/examples/full.expected/gerrit_trybot.json
[modify] https://crrev.com/7085ff77521149bce54e3a2ad1c65ac6578d2dca/scripts/slave/recipes/ios/try.expected/gn.json
[modify] https://crrev.com/7085ff77521149bce54e3a2ad1c65ac6578d2dca/scripts/slave/recipes/webrtc/standalone.expected/tryserver_webrtc_linux_dbg.json
[modify] https://crrev.com/7085ff77521149bce54e3a2ad1c65ac6578d2dca/scripts/slave/recipes/webrtc/standalone.expected/tryserver_webrtc_linux_ubsan_vptr.json
[modify] https://crrev.com/7085ff77521149bce54e3a2ad1c65ac6578d2dca/scripts/slave/recipes/webrtc/standalone.expected/tryserver_webrtc_win_x64_rel.json
[modify] https://crrev.com/7085ff77521149bce54e3a2ad1c65ac6578d2dca/scripts/slave/recipes/webrtc/more_configs.expected/full_tryserver_webrtc_win_more_configs.json
[modify] https://crrev.com/7085ff77521149bce54e3a2ad1c65ac6578d2dca/scripts/slave/README.recipes.md
[modify] https://crrev.com/7085ff77521149bce54e3a2ad1c65ac6578d2dca/scripts/slave/recipes/webrtc/more_configs.expected/full_tryserver_webrtc_linux_more_configs.json
[modify] https://crrev.com/7085ff77521149bce54e3a2ad1c65ac6578d2dca/scripts/slave/recipes/webrtc/standalone.expected/tryserver_webrtc_mac_experimental.json
[modify] https://crrev.com/7085ff77521149bce54e3a2ad1c65ac6578d2dca/scripts/slave/recipes/webrtc/standalone.expected/tryserver_webrtc_linux_rel.json
[modify] https://crrev.com/7085ff77521149bce54e3a2ad1c65ac6578d2dca/scripts/slave/recipes/ios/try.expected/parent.json
Project Member

Comment 69 by bugdroid1@chromium.org, Sep 19 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/72aa1d1634061e0de286f2dc3291d7791d7f1b40

commit 72aa1d1634061e0de286f2dc3291d7791d7f1b40
Author: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Date: Wed Sep 19 22:56:36 2018

Roll src/third_party/depot_tools 21a51b392104..f837545214f5 (1 commits)

https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/21a51b392104..f837545214f5


git log 21a51b392104..f837545214f5 --date=short --no-merges --format='%ad %ae %s'
2018-09-19 nodir@google.com [gclient] Remove patch_projects


Created with:
  gclient setdep -r src/third_party/depot_tools@f837545214f5

The AutoRoll server is located here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.



BUG=chromium:694348
TBR=agable@chromium.org

Change-Id: I29b8d88fac7314f39da767295c48a1feaceb04da
Reviewed-on: https://chromium-review.googlesource.com/1234824
Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#592589}
[modify] https://crrev.com/72aa1d1634061e0de286f2dc3291d7791d7f1b40/DEPS
Project Member

Comment 70 by bugdroid1@chromium.org, Sep 19 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/6bda60680b9b6f36d9bacfd5e0d620dced107bb3

commit 6bda60680b9b6f36d9bacfd5e0d620dced107bb3
Author: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Date: Wed Sep 19 23:19:37 2018

Roll src/third_party/skia a5c578ff3d46..d89e81168423 (8 commits)

https://skia.googlesource.com/skia.git/+log/a5c578ff3d46..d89e81168423


git log a5c578ff3d46..d89e81168423 --date=short --no-merges --format='%ad %ae %s'
2018-09-19 bungeman@google.com SkImageGeneratorCG.h to only expose factory method.
2018-09-19 michaelludwig@google.com Increase precision for two point gradient coordinates.
2018-09-19 halcanary@google.com SkPDF: draw persepctive text
2018-09-19 halcanary@google.com SkImageGeneratorWIC: make the header compile without src/.
2018-09-19 brianosman@google.com GrColor -> SkColor in one GM
2018-09-19 herb@google.com Clean up GPU strike sk_sp
2018-09-19 nodir@google.com Populate repo_path_map
2018-09-19 reed@google.com Revert "always optimize third_party code"


Created with:
  gclient setdep -r src/third_party/skia@d89e81168423

The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel

BUG=chromium:884150,chromium:694348
TBR=reed@chromium.org

Change-Id: I008043cc934cb833a7a9934714c6e9d17a99139f
Reviewed-on: https://chromium-review.googlesource.com/1234823
Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#592597}
[modify] https://crrev.com/6bda60680b9b6f36d9bacfd5e0d620dced107bb3/DEPS
Project Member

Comment 71 by bugdroid1@chromium.org, Sep 21 

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/infra/+/4dd58cdd8c544dc46167ff768d3f62d3533ec7dc

commit 4dd58cdd8c544dc46167ff768d3f62d3533ec7dc
Author: Nodir Turakulov <nodir@google.com>
Date: Fri Sep 21 16:58:13 2018

Use new recipe API

Update infra.git recipes to use new APIs.
This CL finishes the migration for infra.git

Bug: 694348, 877161
Change-Id: I35083402166c912d46796824592df64791ad7e2f
Reviewed-on: https://chromium-review.googlesource.com/1237329
Commit-Queue: Nodir Turakulov <nodir@chromium.org>
Reviewed-by: Andrii Shyshkalov <tandrii@chromium.org>
Cr-Commit-Position: refs/heads/master@{#17792}
[modify] https://crrev.com/4dd58cdd8c544dc46167ff768d3f62d3533ec7dc/recipes/recipes/luci_py.expected/ci.json
[modify] https://crrev.com/4dd58cdd8c544dc46167ff768d3f62d3533ec7dc/recipes/recipes/luci_py.py
[modify] https://crrev.com/4dd58cdd8c544dc46167ff768d3f62d3533ec7dc/recipes/recipes/master_manager_config.py
[modify] https://crrev.com/4dd58cdd8c544dc46167ff768d3f62d3533ec7dc/recipes/recipes/recipe_simulation.py
[modify] https://crrev.com/4dd58cdd8c544dc46167ff768d3f62d3533ec7dc/recipes/recipes/master_manager_config.expected/master_manager_config.json
[modify] https://crrev.com/4dd58cdd8c544dc46167ff768d3f62d3533ec7dc/recipes/README.recipes.md
[modify] https://crrev.com/4dd58cdd8c544dc46167ff768d3f62d3533ec7dc/recipes/recipes/master_manager_config.expected/master_manager_config_patch.json
[modify] https://crrev.com/4dd58cdd8c544dc46167ff768d3f62d3533ec7dc/recipes/recipes/infra_continuous.py

Comment 72 by no...@chromium.org, Sep 24

Status: Fixed (was: Started)
tryserver, gclient and bot_update recipe modules were updated to read patchset from buildbucket module. This is the new way to denote a patchset in recipes. There is "recipe_engine/buildbucket" property that, among other things, specifies the patchset. This concludes this particular bug.

Remaining work is
- to update existing recipes to use the buildbucket module instead of the deprecated properties: bug 877161
- on buildbucket server side, start passing the new property, with the patchset: bug 875056
►

Sign in to add a comment