New issue
Advanced search Search tips

Issue 694338 link

Starred by 0 users

Issue metadata

Status: Fixed
Owner: ----
Closed: Apr 2018
Components:
EstimatedDays: ----
NextAction: ----
OS: Mac
Pri: 2
Type: Bug



Sign in to add a comment

Layout test fast/forms/calendar-picker/calendar-picker-appearance-zoom200.html is failing on WebKit Mac10.9

Project Member Reported by tdander...@chromium.org, Feb 20 2017

Issue description

The layout test fast/forms/calendar-picker/calendar-picker-appearance-zoom200.html is failing on WebKit Mac10.9 builder.

Suspecting CL https://chromium.googlesource.com/chromium/src/+/1b6330fb76698a0866f0232fdb3cac7b426f5df1 . This includes a change to third_party/WebKit/LayoutTests/platform/mac-mac10.9/fast/forms/calendar-picker/calendar-picker-appearance-zoom125-expected.png which may have been unintentional since it is different from all of the other tests changed by this CL.
 
Yep, that CL is the cause, and changing that baseline was unintended.

Will follow up by reverting that change to that baseline.
Project Member

Comment 2 by bugdroid1@chromium.org, Feb 21 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ffd1654da7e07244dab34c86cceafc8a2e6e18ec

commit ffd1654da7e07244dab34c86cceafc8a2e6e18ec
Author: qyearsley <qyearsley@chromium.org>
Date: Tue Feb 21 00:52:36 2017

Revert change to ".../calendar-picker-appearance-zoom12..." mac 10.9 baseline.

TBR=tdanderson
TBR_REASON=Making the waterfall green again, undoing minor accidental change
BUG= 694338 

Review-Url: https://codereview.chromium.org/2707993002
Cr-Commit-Position: refs/heads/master@{#451678}

[modify] https://crrev.com/ffd1654da7e07244dab34c86cceafc8a2e6e18ec/third_party/WebKit/LayoutTests/platform/mac-mac10.9/fast/forms/calendar-picker/calendar-picker-appearance-zoom125-expected.png

Status: Fixed (was: Assigned)
Status: Available (was: Fixed)
The tests still failures: https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Mac10.9/builds/43063
Components: UI>Browser>Zoom
Labels: OS-Mac
Mark those tests as failures https://codereview.chromium.org/2723443002
Project Member

Comment 6 by bugdroid1@chromium.org, Feb 27 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/642a66998d9cc9c4151a9c3284e43f805de7b590

commit 642a66998d9cc9c4151a9c3284e43f805de7b590
Author: hajimehoshi <hajimehoshi@chromium.org>
Date: Mon Feb 27 08:37:49 2017

Mark calendar-picker-appearance-zoom125/200.html as failures

BUG= 694338 
TBR=hajimehoshi@chromium.org
NOTRY=true

Review-Url: https://codereview.chromium.org/2723443002
Cr-Commit-Position: refs/heads/master@{#453172}

[modify] https://crrev.com/642a66998d9cc9c4151a9c3284e43f805de7b590/third_party/WebKit/LayoutTests/TestExpectations

Labels: -Sheriff-Chromium
This seems to be fixed, so I'm removing sheriff label.
Status: Assigned (was: Available)
Summary of this bug:

 1. This test started failing when baselines were accidentally changed in a wpt import CL, because the test failed on try bots
 2. Then previous baselines were added again, but the test was still failing -- maybe the failures on try bots before werne't one-off flaky failures?
 3. Now trying to rebaseline again: https://codereview.chromium.org/2722593002
Labels: -Hotlist-Sheriff-Chromium
Project Member

Comment 11 by bugdroid1@chromium.org, Mar 1 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/80455f9645fbb7d576e4ab83c1d78acf51cd4792

commit 80455f9645fbb7d576e4ab83c1d78acf51cd4792
Author: sergeyu <sergeyu@chromium.org>
Date: Wed Mar 01 00:48:40 2017

Revert of Rebaseline calendar-picker-appearance-zoom125/200.html. (patchset #2 id:20001 of https://codereview.chromium.org/2722593002/ )

Reason for revert:
The test still fails: https://uberchromegw.corp.google.com/i/chromium.webkit/builders/WebKit%20Mac10.9/builds/43188 . Reverting this CL.

Original issue's description:
> Rebaseline calendar-picker-appearance-zoom125/200.html.
>
> This CL would download the latest actual results for Mac10.9 from the
> continuous builder for calendar-picker-appearance-zoom125/200.html.
>
> BUG= 694338 
>
> Review-Url: https://codereview.chromium.org/2722593002
> Cr-Commit-Position: refs/heads/master@{#453631}
> Committed: https://chromium.googlesource.com/chromium/src/+/38c8282555876f13213276ff077bf449a1c70a4d

TBR=hajimehoshi@chromium.org,qyearsley@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG= 694338 

Review-Url: https://codereview.chromium.org/2722963002
Cr-Commit-Position: refs/heads/master@{#453779}

[modify] https://crrev.com/80455f9645fbb7d576e4ab83c1d78acf51cd4792/third_party/WebKit/LayoutTests/TestExpectations
[modify] https://crrev.com/80455f9645fbb7d576e4ab83c1d78acf51cd4792/third_party/WebKit/LayoutTests/platform/mac-mac10.9/fast/forms/calendar-picker/calendar-picker-appearance-zoom125-expected.png
[modify] https://crrev.com/80455f9645fbb7d576e4ab83c1d78acf51cd4792/third_party/WebKit/LayoutTests/platform/mac-mac10.9/fast/forms/calendar-picker/calendar-picker-appearance-zoom200-expected.png

It's possible that these tests are actually flaky, but it's probably worth trying once more to rebaseline (and check whether the new baselines are OK) for these two tests:

fast/forms/calendar-picker/calendar-picker-appearance-zoom125.html
fast/forms/calendar-picker/calendar-picker-appearance-zoom200.html
Labels: -Pri-1 Test-Layout Pri-2
Owner: ----
Status: Available (was: Assigned)
Project Member

Comment 14 by sheriffbot@chromium.org, Apr 23 2018

Labels: Hotlist-Recharge-Cold
Status: Untriaged (was: Available)
This issue has been Available for over a year. If it's no longer important or seems unlikely to be fixed, please consider closing it out. If it is important, please re-triage the issue.

Sorry for the inconvenience if the bug really should have been left as Available.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Status: Fixed (was: Untriaged)
This only seems to be an issue with slimming paint v2. Reopen if this is not the case.

Sign in to add a comment