New issue
Advanced search Search tips

Issue 694333 link

Starred by 2 users
Status: Fixed
Owner: ----
Closed: Apr 2017
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 2
Type: Feature

Blocking:
issue 488194



Sign in to add a comment

(Android) Using depracated org.apache.http.* classes

Project Member Reported by mar...@mwiacek.com, Feb 20 2017 
Steps to reproduce the problem:
Compiling different targets gives:

../../net/test/android/javatests/src/org/chromium/net/test/util/TestWebServer.java:12: warning: [deprecation] Header in org.apache.http has been deprecated
import org.apache.http.Header;
                      ^
../../net/test/android/javatests/src/org/chromium/net/test/util/TestWebServer.java:13: warning: [deprecation] HttpException in org.apache.http has been deprecated
import org.apache.http.HttpException;
                      ^
../../net/test/android/javatests/src/org/chromium/net/test/util/TestWebServer.java:14: warning: [deprecation] HttpRequest in org.apache.http has been deprecated
import org.apache.http.HttpRequest;
                      ^
../../net/test/android/javatests/src/org/chromium/net/test/util/TestWebServer.java:15: warning: [deprecation] HttpResponse in org.apache.http has been deprecated
import org.apache.http.HttpResponse;
                      ^
../../net/test/android/javatests/src/org/chromium/net/test/util/TestWebServer.java:16: warning: [deprecation] HttpStatus in org.apache.http has been deprecated
import org.apache.http.HttpStatus;
                      ^
../../net/test/android/javatests/src/org/chromium/net/test/util/TestWebServer.java:17: warning: [deprecation] HttpVersion in org.apache.http has been deprecated
import org.apache.http.HttpVersion;
                      ^
../../net/test/android/javatests/src/org/chromium/net/test/util/TestWebServer.java:18: warning: [deprecation] RequestLine in org.apache.http has been deprecated
import org.apache.http.RequestLine;
                      ^
../../net/test/android/javatests/src/org/chromium/net/test/util/TestWebServer.java:19: warning: [deprecation] StatusLine in org.apache.http has been deprecated
import org.apache.http.StatusLine;
                      ^
../../net/test/android/javatests/src/org/chromium/net/test/util/TestWebServer.java:20: warning: [deprecation] ByteArrayEntity in org.apache.http.entity has been deprecated
import org.apache.http.entity.ByteArrayEntity;
                             ^
../../net/test/android/javatests/src/org/chromium/net/test/util/TestWebServer.java:21: warning: [deprecation] DefaultHttpServerConnection in org.apache.http.impl has been deprecated
import org.apache.http.impl.DefaultHttpServerConnection;
                           ^
../../net/test/android/javatests/src/org/chromium/net/test/util/TestWebServer.java:22: warning: [deprecation] DateUtils in org.apache.http.impl.cookie has been deprecated
import org.apache.http.impl.cookie.DateUtils;
                                  ^
../../net/test/android/javatests/src/org/chromium/net/test/util/TestWebServer.java:23: warning: [deprecation] BasicHttpResponse in org.apache.http.message has been deprecated
import org.apache.http.message.BasicHttpResponse;
                              ^
../../net/test/android/javatests/src/org/chromium/net/test/util/TestWebServer.java:24: warning: [deprecation] BasicHttpParams in org.apache.http.params has been deprecated
import org.apache.http.params.BasicHttpParams;
                             ^
../../net/test/android/javatests/src/org/chromium/net/test/util/TestWebServer.java:25: warning: [deprecation] CoreProtocolPNames in org.apache.http.params has been deprecated
import org.apache.http.params.CoreProtocolPNames;
                             ^
../../net/test/android/javatests/src/org/chromium/net/test/util/TestWebServer.java:26: warning: [deprecation] HttpParams in org.apache.http.params has been deprecated
import org.apache.http.params.HttpParams;
                             ^
../../net/test/android/javatests/src/org/chromium/net/test/util/TestWebServer.java:109: warning: [deprecation] HttpRequest in org.apache.http has been deprecated
    private final Map<String, HttpRequest> mLastRequestMap = new HashMap<String, HttpRequest>();
                              ^
../../net/test/android/javatests/src/org/chromium/net/test/util/TestWebServer.java:109: warning: [deprecation] HttpRequest in org.apache.http has been deprecated
    private final Map<String, HttpRequest> mLastRequestMap = new HashMap<String, HttpRequest>();
                                                                                 ^
../../net/test/android/javatests/src/org/chromium/net/test/util/TestWebServer.java:406: warning: [deprecation] HttpRequest in org.apache.http has been deprecated
    public HttpRequest getLastRequest(String requestPath) {
           ^
../../net/test/android/javatests/src/org/chromium/net/test/util/TestWebServer.java:478: warning: [deprecation] HttpRequest in org.apache.http has been deprecated
    private void servedResponseFor(String path, HttpRequest request) {
                                                ^
../../net/test/android/javatests/src/org/chromium/net/test/util/TestWebServer.java:496: warning: [deprecation] HttpResponse in org.apache.http has been deprecated
    private HttpResponse getResponse(HttpRequest request) throws InterruptedException {
            ^
../../net/test/android/javatests/src/org/chromium/net/test/util/TestWebServer.java:496: warning: [deprecation] HttpRequest in org.apache.http has been deprecated
    private HttpResponse getResponse(HttpRequest request) throws InterruptedException {
                                     ^
../../net/test/android/javatests/src/org/chromium/net/test/util/TestWebServer.java:500: warning: [deprecation] RequestLine in org.apache.http has been deprecated
        RequestLine requestLine = request.getRequestLine();
        ^
../../net/test/android/javatests/src/org/chromium/net/test/util/TestWebServer.java:501: warning: [deprecation] HttpResponse in org.apache.http has been deprecated
        HttpResponse httpResponse = null;
        ^
../../net/test/android/javatests/src/org/chromium/net/test/util/TestWebServer.java:512: warning: [deprecation] HttpStatus in org.apache.http has been deprecated
            httpResponse = createResponse(HttpStatus.SC_NOT_FOUND);
                                          ^
../../net/test/android/javatests/src/org/chromium/net/test/util/TestWebServer.java:514: warning: [deprecation] HttpStatus in org.apache.http has been deprecated
            httpResponse = createResponse(HttpStatus.SC_NOT_FOUND);
                                          ^
../../net/test/android/javatests/src/org/chromium/net/test/util/TestWebServer.java:520: warning: [deprecation] HttpStatus in org.apache.http has been deprecated
            httpResponse = createResponse(HttpStatus.SC_NO_CONTENT);
                                          ^
../../net/test/android/javatests/src/org/chromium/net/test/util/TestWebServer.java:524: warning: [deprecation] HttpStatus in org.apache.http has been deprecated
            httpResponse = createResponse(HttpStatus.SC_FORBIDDEN); // arbitrary failure status
                                          ^
../../net/test/android/javatests/src/org/chromium/net/test/util/TestWebServer.java:528: warning: [deprecation] HttpStatus in org.apache.http has been deprecated
            httpResponse = createResponse(HttpStatus.SC_MOVED_TEMPORARILY);
                                          ^
../../net/test/android/javatests/src/org/chromium/net/test/util/TestWebServer.java:534: warning: [deprecation] Header in org.apache.http has been deprecated
            Header[] keys = request.getHeaders("Sec-WebSocket-Key");
            ^
../../net/test/android/javatests/src/org/chromium/net/test/util/TestWebServer.java:538: warning: [deprecation] HttpStatus in org.apache.http has been deprecated
                    httpResponse = createResponse(HttpStatus.SC_SWITCHING_PROTOCOLS);
                                                  ^
../../net/test/android/javatests/src/org/chromium/net/test/util/TestWebServer.java:544: warning: [deprecation] HttpStatus in org.apache.http has been deprecated
                    httpResponse = createResponse(HttpStatus.SC_NOT_FOUND);
                                                  ^
../../net/test/android/javatests/src/org/chromium/net/test/util/TestWebServer.java:547: warning: [deprecation] HttpStatus in org.apache.http has been deprecated
                httpResponse = createResponse(HttpStatus.SC_NOT_FOUND);
                                              ^
../../net/test/android/javatests/src/org/chromium/net/test/util/TestWebServer.java:553: warning: [deprecation] HttpStatus in org.apache.http has been deprecated
            httpResponse = createResponse(HttpStatus.SC_OK);
                                          ^
../../net/test/android/javatests/src/org/chromium/net/test/util/TestWebServer.java:554: warning: [deprecation] ByteArrayEntity in org.apache.http.entity has been deprecated
            ByteArrayEntity entity = createEntity(response.mResponseData);
            ^
../../net/test/android/javatests/src/org/chromium/net/test/util/TestWebServer.java:562: warning: [deprecation] StatusLine in org.apache.http has been deprecated
        StatusLine sl = httpResponse.getStatusLine();
        ^
../../net/test/android/javatests/src/org/chromium/net/test/util/TestWebServer.java:573: warning: [deprecation] HttpResponse in org.apache.http has been deprecated
    private void setDateHeaders(HttpResponse response) {
                                ^
../../net/test/android/javatests/src/org/chromium/net/test/util/TestWebServer.java:574: warning: [deprecation] DateUtils in org.apache.http.impl.cookie has been deprecated
        response.addHeader("Date", DateUtils.formatDate(new Date(), DateUtils.PATTERN_RFC1123));
                                                                    ^
../../net/test/android/javatests/src/org/chromium/net/test/util/TestWebServer.java:574: warning: [deprecation] DateUtils in org.apache.http.impl.cookie has been deprecated
        response.addHeader("Date", DateUtils.formatDate(new Date(), DateUtils.PATTERN_RFC1123));
                                   ^
../../net/test/android/javatests/src/org/chromium/net/test/util/TestWebServer.java:580: warning: [deprecation] HttpResponse in org.apache.http has been deprecated
    private HttpResponse createResponse(int status) {
            ^
../../net/test/android/javatests/src/org/chromium/net/test/util/TestWebServer.java:581: warning: [deprecation] HttpResponse in org.apache.http has been deprecated
        HttpResponse response = new BasicHttpResponse(HttpVersion.HTTP_1_0, status, null);
        ^
../../net/test/android/javatests/src/org/chromium/net/test/util/TestWebServer.java:581: warning: [deprecation] BasicHttpResponse in org.apache.http.message has been deprecated
        HttpResponse response = new BasicHttpResponse(HttpVersion.HTTP_1_0, status, null);
                                    ^
../../net/test/android/javatests/src/org/chromium/net/test/util/TestWebServer.java:581: warning: [deprecation] HttpVersion in org.apache.http has been deprecated
        HttpResponse response = new BasicHttpResponse(HttpVersion.HTTP_1_0, status, null);
                                                      ^
../../net/test/android/javatests/src/org/chromium/net/test/util/TestWebServer.java:588: warning: [deprecation] HttpStatus in org.apache.http has been deprecated
                sReasons.put(HttpStatus.SC_UNAUTHORIZED, "Unauthorized");
                             ^
../../net/test/android/javatests/src/org/chromium/net/test/util/TestWebServer.java:589: warning: [deprecation] HttpStatus in org.apache.http has been deprecated
                sReasons.put(HttpStatus.SC_NOT_FOUND, "Not Found");
                             ^
../../net/test/android/javatests/src/org/chromium/net/test/util/TestWebServer.java:590: warning: [deprecation] HttpStatus in org.apache.http has been deprecated
                sReasons.put(HttpStatus.SC_FORBIDDEN, "Forbidden");
                             ^
../../net/test/android/javatests/src/org/chromium/net/test/util/TestWebServer.java:591: warning: [deprecation] HttpStatus in org.apache.http has been deprecated
                sReasons.put(HttpStatus.SC_MOVED_TEMPORARILY, "Moved Temporarily");
                             ^
../../net/test/android/javatests/src/org/chromium/net/test/util/TestWebServer.java:604: warning: [deprecation] ByteArrayEntity in org.apache.http.entity has been deprecated
            ByteArrayEntity entity = createEntity(buf.toString().getBytes());
            ^
../../net/test/android/javatests/src/org/chromium/net/test/util/TestWebServer.java:615: warning: [deprecation] ByteArrayEntity in org.apache.http.entity has been deprecated
    private ByteArrayEntity createEntity(byte[] data) {
            ^
../../net/test/android/javatests/src/org/chromium/net/test/util/TestWebServer.java:616: warning: [deprecation] ByteArrayEntity in org.apache.http.entity has been deprecated
        ByteArrayEntity entity = new ByteArrayEntity(data);
        ^
../../net/test/android/javatests/src/org/chromium/net/test/util/TestWebServer.java:616: warning: [deprecation] ByteArrayEntity in org.apache.http.entity has been deprecated
        ByteArrayEntity entity = new ByteArrayEntity(data);
                                     ^
../../net/test/android/javatests/src/org/chromium/net/test/util/TestWebServer.java:752: warning: [deprecation] HttpParams in org.apache.http.params has been deprecated
            HttpParams params = new BasicHttpParams();
            ^
../../net/test/android/javatests/src/org/chromium/net/test/util/TestWebServer.java:752: warning: [deprecation] BasicHttpParams in org.apache.http.params has been deprecated
            HttpParams params = new BasicHttpParams();
                                    ^
../../net/test/android/javatests/src/org/chromium/net/test/util/TestWebServer.java:753: warning: [deprecation] CoreProtocolPNames in org.apache.http.params has been deprecated
            params.setParameter(CoreProtocolPNames.PROTOCOL_VERSION, HttpVersion.HTTP_1_0);
                                ^
../../net/test/android/javatests/src/org/chromium/net/test/util/TestWebServer.java:753: warning: [deprecation] HttpVersion in org.apache.http has been deprecated
            params.setParameter(CoreProtocolPNames.PROTOCOL_VERSION, HttpVersion.HTTP_1_0);
                                                                     ^
../../net/test/android/javatests/src/org/chromium/net/test/util/TestWebServer.java:760: warning: [deprecation] DefaultHttpServerConnection in org.apache.http.impl has been deprecated
                    DefaultHttpServerConnection conn = new DefaultHttpServerConnection();
                    ^
../../net/test/android/javatests/src/org/chromium/net/test/util/TestWebServer.java:760: warning: [deprecation] DefaultHttpServerConnection in org.apache.http.impl has been deprecated
                    DefaultHttpServerConnection conn = new DefaultHttpServerConnection();
                                                           ^
../../net/test/android/javatests/src/org/chromium/net/test/util/TestWebServer.java:764: warning: [deprecation] HttpRequest in org.apache.http has been deprecated
                    HttpRequest request = conn.receiveRequestHeader();
                    ^
../../net/test/android/javatests/src/org/chromium/net/test/util/TestWebServer.java:765: warning: [deprecation] HttpResponse in org.apache.http has been deprecated
                    HttpResponse response = mServer.getResponse(request);
                    ^
../../net/test/android/javatests/src/org/chromium/net/test/util/TestWebServer.java:774: warning: [deprecation] HttpException in org.apache.http has been deprecated
                } catch (HttpException e) {
                         ^
../../android_webview/javatests/src/org/chromium/android_webview/test/LoadUrlTest.java:10: warning: [deprecation] Header in org.apache.http has been deprecated
import org.apache.http.Header;
                      ^
../../android_webview/javatests/src/org/chromium/android_webview/test/LoadUrlTest.java:11: warning: [deprecation] HttpRequest in org.apache.http has been deprecated
import org.apache.http.HttpRequest;

What is the expected behavior?

What went wrong?
Classes are deprecated now

Did this work before? N/A 

Chrome version: 58  Channel: canary
OS Version: 6
Flash Version: 

https://codereview.chromium.org/2705963002/ - patch

Comment 1 by mar...@mwiacek.com, Feb 20 2017 

../../android_webview/javatests/src/org/chromium/android_webview/test/LoadUrlTest.java:118: warning: [deprecation] HttpRequest in org.apache.http has been deprecated
    private void validateRequestHeaders(String[] refNamesAndValues, HttpRequest request) {
                                                                    ^
../../android_webview/javatests/src/org/chromium/android_webview/test/LoadUrlTest.java:120: warning: [deprecation] Header in org.apache.http has been deprecated
            Header[] matchingHeaders = request.getHeaders(refNamesAndValues[i]);
            ^
../../android_webview/javatests/src/org/chromium/android_webview/test/LoadUrlTest.java:123: warning: [deprecation] Header in org.apache.http has been deprecated
            Header header = matchingHeaders[0];
            ^
../../android_webview/javatests/src/org/chromium/android_webview/test/LoadUrlTest.java:129: warning: [deprecation] HttpRequest in org.apache.http has been deprecated
    private void validateNoRequestHeaders(String[] refNamesAndValues, HttpRequest request) {
                                                                      ^
../../android_webview/javatests/src/org/chromium/android_webview/test/LoadUrlTest.java:131: warning: [deprecation] Header in org.apache.http has been deprecated
            Header[] matchingHeaders = request.getHeaders(refNamesAndValues[i]);
            ^
../../android_webview/javatests/src/org/chromium/android_webview/test/LoadUrlTest.java:194: warning: [deprecation] Header in org.apache.http has been deprecated
            Header[] matchingHeaders = webServer.getLastRequest(path).getHeaders(extraHeaders[0]);
            ^
../../android_webview/javatests/src/org/chromium/android_webview/test/LoadUrlTest.java:196: warning: [deprecation] Header in org.apache.http has been deprecated
            Header header = matchingHeaders[0];
            ^

                                                                         ^

Comment 2 by mar...@mwiacek.com, Feb 20 2017 

../../android_webview/javatests/src/org/chromium/android_webview/test/AwContentsClientOnFormResubmissionTest.java:104: warning: [deprecation] EncodingUtils in org.apache.http.util has been deprecated
        byte[] data = EncodingUtils.getBytes(postData, "BASE64");
                      ^

Comment 4 by jbudorick@chromium.org, Apr 3 2017

Blocking: 488194
Status: Fixed (was: Unconfirmed)
Thanks for the work here!
►

Sign in to add a comment