New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 694332 link

Starred by 2 users
Status: Fixed
Owner:
█ ortuno@chromium.org
Last visit > 30 days ago
Closed: May 2017
Cc:
jyasskin@chromium.org
█ scheib@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 2
Type: Feature

Blocking:
issue 490399



Sign in to add a comment

bluetooth: Increase target API to 23 (Marshmallow)

Project Member Reported by ortuno@chromium.org, Feb 20 2017 
When we first introduced the Web Bluetooth API, Marshmallow was very new so we decided to set the min to 21. This way developers that really wanted to use the API could use a chromium build.

Now that Marshmallow has 30% market share I think we should revisit that decision. 

There are two features that we could benefit from if we changed to 23:

 - Ability to set callback type[1] This is a small optimization that allows underlying hardware to just notify of the first sighting of the device.
 - Ability to set preferred transport[2]. We've had reports of users unable to use their devices when we connecting with classic[3].


Regarding testing: The test suite will still run on bots: http://crrev.com/2706763002

[1] https://developer.android.com/reference/android/bluetooth/le/ScanSettings.html#CALLBACK_TYPE_FIRST_MATCH
[2] https://developer.android.com/reference/android/bluetooth/BluetoothDevice.html#connectGatt(android.content.Context, boolean, android.bluetooth.BluetoothGattCallback, int)
[3]  Issue 693937
Project Member

Comment 1 by bugdroid1@chromium.org, Apr 17 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/049e6ec2d2ce7baf077601acf2755eb0cb0eafe3

commit 049e6ec2d2ce7baf077601acf2755eb0cb0eafe3
Author: ortuno <ortuno@chromium.org>
Date: Mon Apr 17 23:08:18 2017

bluetooth: Increase min api for Android

In order to be able to use new features of the BLE API this patch increases the min required version.

Users on Android L would have had to find an install chromium in order to use this API so chances are the usage was very low.

BUG= 694332 

Review-Url: https://codereview.chromium.org/2706763002
Cr-Commit-Position: refs/heads/master@{#465052}

[modify] https://crrev.com/049e6ec2d2ce7baf077601acf2755eb0cb0eafe3/device/bluetooth/android/java/src/org/chromium/device/bluetooth/ChromeBluetoothAdapter.java
[modify] https://crrev.com/049e6ec2d2ce7baf077601acf2755eb0cb0eafe3/device/bluetooth/android/java/src/org/chromium/device/bluetooth/ChromeBluetoothDevice.java
[modify] https://crrev.com/049e6ec2d2ce7baf077601acf2755eb0cb0eafe3/device/bluetooth/android/java/src/org/chromium/device/bluetooth/ChromeBluetoothRemoteGattCharacteristic.java
[modify] https://crrev.com/049e6ec2d2ce7baf077601acf2755eb0cb0eafe3/device/bluetooth/android/java/src/org/chromium/device/bluetooth/Wrappers.java
[modify] https://crrev.com/049e6ec2d2ce7baf077601acf2755eb0cb0eafe3/device/bluetooth/test/android/java/src/org/chromium/device/bluetooth/Fakes.java
Project Member

Comment 2 by bugdroid1@chromium.org, Apr 18 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/4f7b9875dd8c2d015a581bbbfb0f7967924d3779

commit 4f7b9875dd8c2d015a581bbbfb0f7967924d3779
Author: ortuno <ortuno@chromium.org>
Date: Tue Apr 18 02:42:50 2017

bluetooth: Stop requesting Bluetooth permission in <M devices

The underlying code that uses Bluetooth increased the min API in order
to support new features. Because of this it no longer makes sense
to request the permission in pre-M devices.

BUG= 694332 

Review-Url: https://codereview.chromium.org/2815633004
Cr-Commit-Position: refs/heads/master@{#465114}

[modify] https://crrev.com/4f7b9875dd8c2d015a581bbbfb0f7967924d3779/chrome/android/java/AndroidManifest.xml

Comment 4 by scheib@chromium.org, May 10 2017 

Done here? Any remaining work?

Comment 5 by ortuno@chromium.org, May 10 2017

Owner: ortuno@chromium.org
Status: Fixed (was: Available)
►

Sign in to add a comment