Inconsistent behaviors of BrowserCommandController in forced incognito mode |
|||
Issue descriptionChrome Version: (copy from chrome://version) Up to https://chromium.googlesource.com/chromium/src/+/d0286404a0fdb943d9e69ea7af0ffc85e0435f87 OS: Independent A code defect has been found in BrowserCommandController, which results inconsistent behaviors of enabling of IDC_OPTIONS when entering or exiting full-screen mode in forced incognito mode. This does not really impact end users, AFAICT, forced incognito mode is not actively used in Chrome.
,
Feb 20 2017
,
Feb 24 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/db473d55d6bc0c1caca424616a788ca0c19a4d69 commit db473d55d6bc0c1caca424616a788ca0c19a4d69 Author: zijiehe <zijiehe@chromium.org> Date: Fri Feb 24 01:13:41 2017 Fix an inconsistent behavior in BrowserCommandController An inconsistent behavior has been detected in BrowserCommandController, which disables IDC_OPTIONS when entering and exiting fullscreen mode unexpectedly. This change fixes the issue, and adds a test case to indicate this inconsistent behavior, and make it more "visible". R=msw BUG= 694331 Review-Url: https://codereview.chromium.org/2701973002 Cr-Commit-Position: refs/heads/master@{#452703} [modify] https://crrev.com/db473d55d6bc0c1caca424616a788ca0c19a4d69/chrome/browser/ui/browser_command_controller.cc [modify] https://crrev.com/db473d55d6bc0c1caca424616a788ca0c19a4d69/chrome/browser/ui/browser_command_controller_unittest.cc
,
Feb 24 2017
Since this change does not have an end-user impact. I will fix this issue as-is.
,
Mar 15 2017
> forced incognito mode is not actively used in Chrome. Isn't that used when a user does a "View Source" when not logged in to a Chromebook (e.g. user right-clicks on a captive portal auth page on the logins screen) |
|||
►
Sign in to add a comment |
|||
Comment 1 by zijiehe@chromium.org
, Feb 20 2017