New issue
Advanced search Search tips

Issue 694320 link

Starred by 1 user

Issue metadata

Status: Duplicate
Merged: issue 694307
Owner:
Closed: Feb 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux
Pri: 3
Type: Bug



Sign in to add a comment

fast/css/first-letter-rtc-crash.html fails because of error change (needs rebaseline?)

Project Member Reported by tansell@chromium.org, Feb 20 2017

Issue description

Logging bug so I can disable via TestExpectations

 * https://luci-milo.appspot.com/buildbot/chromium.fyi/WebKit%20Linux%20-%20RandomOrder/3098

 * https://build.chromium.org/p/chromium.fyi/builders/WebKit%20Linux%20-%20RandomOrder/builds/3098/steps/webkit_tests/logs/stdio

------------------------
Regressions: Unexpected text-only failures (1)
  fast/css/first-letter-rtc-crash.html [ Failure ]
------------------------

 * https://storage.googleapis.com/chromium-layout-test-archives/WebKit_Linux_-_RandomOrder/3098/layout-test-results/results.html

--- /b/rr/tmphu1tVR/w/layout-test-results/fast/css/first-letter-rtc-crash-expected.txt
+++ /b/rr/tmphu1tVR/w/layout-test-results/fast/css/first-letter-rtc-crash-actual.txt
@@ -1,5 +1,4 @@
 CONSOLE WARNING: line 21: The behavior that Selection.addRange() merges existing Range and the specified Range was removed. See https://www.chromestatus.com/features/6680566019653632 for more details.
-CONSOLE ERROR: line 56: Uncaught HierarchyRequestError: Failed to execute 'insertNode' on 'Range': The node to be inserted contains the insertion point; it may not be inserted into itself.
-text
+CONSOLE ERROR: line 38: Uncaught HierarchyRequestError: Failed to execute 'insertNode' on 'Range': The node to be inserted contains the insertion point; it may not be inserted into itself.
 a
 Test passes if it does not CRASH.

 
Components: -Blink>CSS -Blink>LayoutTests Blink>Editing>Selection
Labels: Test-Layout
Owner: tkent@chromium.org
Status: Assigned (was: Unconfirmed)
Suspecting: https://codereview.chromium.org/2709443002

Comment 2 by tkent@chromium.org, Feb 21 2017

Mergedinto: 694307
Status: Duplicate (was: Assigned)
Project Member

Comment 3 by bugdroid1@chromium.org, Feb 21 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/1efb7901eafb3fa00849b5f380ef8409c663b1d2

commit 1efb7901eafb3fa00849b5f380ef8409c663b1d2
Author: yosin <yosin@chromium.org>
Date: Tue Feb 21 02:27:25 2017

Get rid of redundant test layout test first-letter-rtc-crash.html

This patch gets or redundant layout test "first-letter-rtc-crash.html" for
improving code health and reduce maintenance cost.

The test verifies the specific edge case of |TextIterator| class. However, the
patch [1] changed first-letter handling in |TextIterator| and there are no
path verified by path.

The test is little minimized ClusterFuzz generated test script, it is hard to
read and change. Since the crash is caused by "FindString" command, the
expectation is not useful other than having it to indicate not crash.

BUG= 694307 ,  694320 
TEST=n/a; no behavior changes

Review-Url: https://codereview.chromium.org/2704273002
Cr-Commit-Position: refs/heads/master@{#451688}

[modify] https://crrev.com/1efb7901eafb3fa00849b5f380ef8409c663b1d2/third_party/WebKit/LayoutTests/TestExpectations
[delete] https://crrev.com/61f7ad29a14fe66a5cf77001359da80662b6ceb3/third_party/WebKit/LayoutTests/fast/css/first-letter-rtc-crash-expected.txt
[delete] https://crrev.com/61f7ad29a14fe66a5cf77001359da80662b6ceb3/third_party/WebKit/LayoutTests/fast/css/first-letter-rtc-crash.html

Sign in to add a comment