New issue
Advanced search Search tips

Issue 694285 link

Starred by 0 users
Status: Fixed
Owner:
jlebel@chromium.org
Closed: Mar 2017
Cc:
ew...@chromium.org
jlebel@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Mac
Pri: 3
Type: Task



Sign in to add a comment

Remove dead code related to Fast User Switcher

Project Member Reported by jlebel@chromium.org, Feb 20 2017 
Need to remove the function void ShowFastUserSwitcher(Browser* browser), in browser_commands.cc, and IDC_SHOW_FAST_USER_SWITCHER.

As mentioned in https://codereview.chromium.org/2687693002/diff/20001/chrome/browser/ui/browser_commands.cc#newcode1131
This method is not used anymore.

Comment 1 by jlebel@chromium.org, Mar 22 2017 

Need also to remove code related to kProfileAvatarRightClickTutorialDismissed and TUTORIAL_MODE_RIGHT_CLICK_SWITCHING
Project Member

Comment 2 by bugdroid1@chromium.org, Mar 22 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/39480fd2b6d3b9a01026520f6bc50c42f23850b0

commit 39480fd2b6d3b9a01026520f6bc50c42f23850b0
Author: jlebel <jlebel@chromium.org>
Date: Wed Mar 22 19:13:08 2017

Removing Fast User Switcher feature.

Fast User Switcher is not supported anymore.

BUG= 694285 

Review-Url: https://codereview.chromium.org/2709763002
Cr-Commit-Position: refs/heads/master@{#458828}

[modify] https://crrev.com/39480fd2b6d3b9a01026520f6bc50c42f23850b0/chrome/app/chrome_command_ids.h
[modify] https://crrev.com/39480fd2b6d3b9a01026520f6bc50c42f23850b0/chrome/browser/profiles/profile_window.cc
[modify] https://crrev.com/39480fd2b6d3b9a01026520f6bc50c42f23850b0/chrome/browser/ui/browser_command_controller.cc
[modify] https://crrev.com/39480fd2b6d3b9a01026520f6bc50c42f23850b0/chrome/browser/ui/browser_commands.cc
[modify] https://crrev.com/39480fd2b6d3b9a01026520f6bc50c42f23850b0/chrome/browser/ui/browser_commands.h
[modify] https://crrev.com/39480fd2b6d3b9a01026520f6bc50c42f23850b0/chrome/browser/ui/browser_window.h
[modify] https://crrev.com/39480fd2b6d3b9a01026520f6bc50c42f23850b0/chrome/browser/ui/cocoa/profiles/profile_chooser_controller.mm
[modify] https://crrev.com/39480fd2b6d3b9a01026520f6bc50c42f23850b0/chrome/browser/ui/cocoa/profiles/profile_chooser_controller_unittest.mm
[modify] https://crrev.com/39480fd2b6d3b9a01026520f6bc50c42f23850b0/chrome/browser/ui/profile_chooser_constants.h
[modify] https://crrev.com/39480fd2b6d3b9a01026520f6bc50c42f23850b0/chrome/browser/ui/views/frame/avatar_button_manager.cc
[modify] https://crrev.com/39480fd2b6d3b9a01026520f6bc50c42f23850b0/chrome/browser/ui/views/profiles/profile_chooser_view.cc
[modify] https://crrev.com/39480fd2b6d3b9a01026520f6bc50c42f23850b0/chrome/browser/ui/views/profiles/profile_chooser_view.h
Project Member

Comment 3 by bugdroid1@chromium.org, Mar 28 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/010bed54423a428a1812dfe7eab7ed95c5bf9982

commit 010bed54423a428a1812dfe7eab7ed95c5bf9982
Author: jlebel <jlebel@chromium.org>
Date: Tue Mar 28 17:32:20 2017

Removing fast user switcher tutorial

Second part for crrev.com/2709763002

BUG= 694285 

Review-Url: https://codereview.chromium.org/2765413002
Cr-Commit-Position: refs/heads/master@{#460157}

[modify] https://crrev.com/010bed54423a428a1812dfe7eab7ed95c5bf9982/chrome/app/generated_resources.grd
[modify] https://crrev.com/010bed54423a428a1812dfe7eab7ed95c5bf9982/chrome/browser/profiles/profile_window.cc
[modify] https://crrev.com/010bed54423a428a1812dfe7eab7ed95c5bf9982/chrome/browser/profiles/profile_window.h
[modify] https://crrev.com/010bed54423a428a1812dfe7eab7ed95c5bf9982/chrome/browser/profiles/profiles_state.cc
[modify] https://crrev.com/010bed54423a428a1812dfe7eab7ed95c5bf9982/chrome/browser/ui/cocoa/profiles/profile_chooser_controller.mm
[modify] https://crrev.com/010bed54423a428a1812dfe7eab7ed95c5bf9982/chrome/browser/ui/cocoa/profiles/profile_chooser_controller_unittest.mm
[modify] https://crrev.com/010bed54423a428a1812dfe7eab7ed95c5bf9982/chrome/browser/ui/profile_chooser_constants.h
[modify] https://crrev.com/010bed54423a428a1812dfe7eab7ed95c5bf9982/chrome/browser/ui/views/profiles/profile_chooser_view.cc
[modify] https://crrev.com/010bed54423a428a1812dfe7eab7ed95c5bf9982/chrome/browser/ui/views/profiles/profile_chooser_view.h
[modify] https://crrev.com/010bed54423a428a1812dfe7eab7ed95c5bf9982/chrome/common/pref_names.cc
[modify] https://crrev.com/010bed54423a428a1812dfe7eab7ed95c5bf9982/chrome/common/pref_names.h

Comment 4 by jlebel@chromium.org, Mar 29 2017

Status: Fixed (was: Available)

Comment 5 by jlebel@chromium.org, Dec 12 2017

Cc: ew...@chromium.org jlebel@chromium.org
 Issue 704934  has been merged into this issue.
►

Sign in to add a comment