New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 694284 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Feb 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Windows
Pri: 2
Type: Bug



Sign in to add a comment

audio_unittests failing on Windows Debug GPU FYI bots (WinAudioInputTest.WASAPIAudioInputStreamTestPacketSizes)

Project Member Reported by jmad...@chromium.org, Feb 20 2017

Issue description

Comment 1 by tommi@chromium.org, Feb 20 2017

Cc: -tommi@chromium.org kainino@chromium.org
Owner: tommi@chromium.org
I'll take a look.

Comment 2 by tommi@chromium.org, Feb 20 2017

CL out for review: https://codereview.chromium.org/2703253003/#
Project Member

Comment 3 by bugdroid1@chromium.org, Feb 20 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c6e9b13174cd446b65b679bdfca1c8a8dc25ac1c

commit c6e9b13174cd446b65b679bdfca1c8a8dc25ac1c
Author: tommi <tommi@chromium.org>
Date: Mon Feb 20 22:35:11 2017

WASAPIAudioInputStream: Revert to the previous buffer size calculation.

This reverts part of a change landed last week for the case when
no audio conversion is needed in WASAPIAudioInputStream.
The reason for reverting is that a part of the WASAPIAudioInputStreamTestPacketSizes
test started failing, the part that uses 5ms buffer sizes.

For the case when conversion is needed and we have an imperfect
buffer size ratio, we add one more buffer as before.

BUG= 694284 
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2703253003
Cr-Commit-Position: refs/heads/master@{#451665}

[modify] https://crrev.com/c6e9b13174cd446b65b679bdfca1c8a8dc25ac1c/media/audio/win/audio_low_latency_input_win.cc

Comment 4 by tommi@chromium.org, Feb 20 2017

Labels: OS-Linux
Status: Fixed (was: Assigned)

Comment 5 by tommi@chromium.org, Feb 20 2017

Labels: -OS-Linux

Sign in to add a comment