New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 694278 link

Starred by 1 user
Status: Fixed
Owner:
grunell@chromium.org
Closed: Mar 2017
Cc:
dalecur...@chromium.org
solenberg@chromium.org
█ olka@chromium.org
maxmorin@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 2
Type: Bug

Blocking:
issue 531883



Sign in to add a comment

Move AudioDebugFileWriter from content/ to media/

Project Member Reported by grunell@chromium.org, Feb 20 2017 
The only reason for having it in content/ is to access the FILE thread and the BrowserThread::DeleteOnFileThread deleter.

The FILE task runner can be passed, and a deleter can be added that uses it.
Project Member

Comment 1 by bugdroid1@chromium.org, Feb 23 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/3d7b06a12ea2897550ef82afef840a06501ab544

commit 3d7b06a12ea2897550ef82afef840a06501ab544
Author: grunell <grunell@chromium.org>
Date: Thu Feb 23 20:15:19 2017

Move AudioDebugFileWriter from content/ to media/.

* Move audio_debug_file_writer* to media/audio/.
* Remove media::AudioFileWriter interface.
* Pass FILE task runner from content to media to be able to perform operations on that thread.
* This is done in AudioInputController, thus its Create() functions and constructor are updated.
* AudioDebugFileWriter is now created in AudioInputController constructor.

BUG= 694278 

CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2702323002
Cr-Commit-Position: refs/heads/master@{#452602}

[modify] https://crrev.com/3d7b06a12ea2897550ef82afef840a06501ab544/content/browser/BUILD.gn
[delete] https://crrev.com/f3f17d64c61c095f5d7542bb74e2e7137f339b14/content/browser/renderer_host/media/audio_debug_file_writer.h
[modify] https://crrev.com/3d7b06a12ea2897550ef82afef840a06501ab544/content/browser/renderer_host/media/audio_input_renderer_host.cc
[modify] https://crrev.com/3d7b06a12ea2897550ef82afef840a06501ab544/content/browser/renderer_host/media/audio_input_renderer_host_unittest.cc
[modify] https://crrev.com/3d7b06a12ea2897550ef82afef840a06501ab544/content/browser/speech/speech_recognizer_impl.cc
[modify] https://crrev.com/3d7b06a12ea2897550ef82afef840a06501ab544/content/test/BUILD.gn
[modify] https://crrev.com/3d7b06a12ea2897550ef82afef840a06501ab544/media/audio/BUILD.gn
[rename] https://crrev.com/3d7b06a12ea2897550ef82afef840a06501ab544/media/audio/audio_debug_file_writer.cc
[add] https://crrev.com/3d7b06a12ea2897550ef82afef840a06501ab544/media/audio/audio_debug_file_writer.h
[rename] https://crrev.com/3d7b06a12ea2897550ef82afef840a06501ab544/media/audio/audio_debug_file_writer_unittest.cc
[delete] https://crrev.com/f3f17d64c61c095f5d7542bb74e2e7137f339b14/media/audio/audio_file_writer.h
[modify] https://crrev.com/3d7b06a12ea2897550ef82afef840a06501ab544/media/audio/audio_input_controller.cc
[modify] https://crrev.com/3d7b06a12ea2897550ef82afef840a06501ab544/media/audio/audio_input_controller.h
[modify] https://crrev.com/3d7b06a12ea2897550ef82afef840a06501ab544/media/audio/audio_input_controller_unittest.cc
[modify] https://crrev.com/3d7b06a12ea2897550ef82afef840a06501ab544/media/audio/test_audio_input_controller_factory.cc

Comment 2 by grunell@chromium.org, Mar 2 2017

Status: Fixed (was: Assigned)
►

Sign in to add a comment