{Single,Two}ClientArcPackageSyncTest are failing. |
||||
Issue descriptionChrome Version: ToT OS: ChromeOS What steps will reproduce the problem? (1) Run sync_integration_test --gtest_filter=*Arc* What is the expected result? - Successfully passed. What happens instead? - Failed. The tests are failing at: [119266:119266:0220/232631.536339:FATAL:instance_holder.h(102)] Check failed: in stance == nullptr || instance_ == nullptr. #0 0x7f3222f4656b base::debug::StackTrace::StackTrace() #1 0x7f3222f44bec base::debug::StackTrace::StackTrace() #2 0x7f3222fab1dc logging::LogMessage::~LogMessage() #3 0x00000265e2fb arc::InstanceHolder<>::SetInstance() #4 0x00000265c5fa arc::SyncArcPackageHelper::SetupArcService() #5 0x00000265c129 arc::SyncArcPackageHelper::SetupTest() #6 0x00000265bf10 arc::SyncArcPackageHelper::GetInstance() #7 0x0000006d6745 arc::SingleClientArcPackageSyncTest::SetupClients() #8 0x00000267179b SyncTest::SetupSync() SetUpArcService() https://cs.chromium.org/chromium/src/chrome/browser/sync/test/integration/sync_arc_package_helper.cc?type=cs&q=sync_arc+package:%5Echromium$&l=144 is called from the iteration https://cs.chromium.org/chromium/src/chrome/browser/sync/test/integration/sync_arc_package_helper.cc?type=cs&q=sync_arc+package:%5Echromium$&l=74 According to the code, it seems ARC is being set up for multiple Profile instances. However, ARC is singleton by design so it won't work. Note that sync_integration_tests looks not continuously running on ChromeOS bots, now.
,
Feb 21 2017
,
Feb 21 2017
Yes, I am actively fixing sync_integration_tests. Since I don't have any knowledge about arc, I hope if you can fix the arc tests will be great helpful!
,
Feb 23 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/653559e3d446669fe50661afb09ffdc464a37c5c commit 653559e3d446669fe50661afb09ffdc464a37c5c Author: hidehiko <hidehiko@chromium.org> Date: Thu Feb 23 03:06:10 2017 Add DCHECK to make sure Profile instance is same. The Profile instance owned by ArcAppListPrefs and ArcSessionManager::profile() must be same. This CL adds the DCHECK. During the test, it turned out that ARC is enabled for unexpected tests. As a result, ArcAppListPrefs is expected to be alive at most one instance (for Primary user Profile), but many instances are created. Such tests are not designed to use ARC, so disable ARC for them to pass them. The command_line flag is moved from sync_arc_package_helper.cc. However, tests using sync_arc_package_helper are currently failing ( crbug.com/694261 ), and redesign looks needed. Thus, this CL leaves those tests as is. In future, probably with fixing the bug, the flag needs to be added there. BUG= 694261 BUG=657687 BUG=b/31079732 TEST=Ran trybots. Review-Url: https://codereview.chromium.org/2708693002 Cr-Commit-Position: refs/heads/master@{#452366} [modify] https://crrev.com/653559e3d446669fe50661afb09ffdc464a37c5c/chrome/browser/sync/test/integration/sync_test.cc [modify] https://crrev.com/653559e3d446669fe50661afb09ffdc464a37c5c/chrome/browser/ui/app_list/arc/arc_app_list_prefs.cc
,
Mar 7 2017
It seems auto update is broken. Manual update. https://codereview.chromium.org/2711033002/ Fix Arc integration test. After all the refactor/clean up of ArcSessionManager, clean up Arc sync integration test setup/shut down logic and stop confusing ArcSessionManager state machine with sync test profile. Minor cleanup for ArcPackageSyncDataTypeController. BUG= 694261 TEST=Run sync_integration_test --gtest_filter=*Arc*. All Arc related tests passed. Review-Url: https://codereview.chromium.org/2711033002 Cr-Commit-Position: refs/heads/master@{#454692} Committed: https://chromium.googlesource.com/chromium/src/+/853b5ae0c2f47d981dd8b390d321a886e465c005
,
May 9 2017
|
||||
►
Sign in to add a comment |
||||
Comment 1 by s...@chromium.org
, Feb 21 2017