New issue
Advanced search Search tips

Issue 694222 link

Starred by 1 user
Status: Fixed
Owner:
jochen@chromium.org
Closed: Apr 2017
Cc:
dpranke@chromium.org
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

add support for global "comments" on OWNERS

Project Member Reported by jochen@chromium.org, Feb 20 2017 
git cl owners currently shows comments it finds in OWNERS files. If you want to annotate yourself with e.g., your timezone, you'll have to add that comment into every OWNERS files you're in.

Instead, we should have a central file where you can add a generic comment for yourself.
Project Member

Comment 1 by bugdroid1@chromium.org, Apr 4 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/tools/depot_tools/+/72606f8c2402da51a92c91e324125e2026fcf457

commit 72606f8c2402da51a92c91e324125e2026fcf457
Author: Jochen Eisinger <jochen@chromium.org>
Date: Tue Apr 04 08:53:32 2017

Add support for a global status files for OWNERS

This allows for having some global comments such as timezones or
long-term unavailability.

The comments go into build/OWNERS.status (that way, they should be
available in all repos that map in build/ for the gn config files).
The local can be overwritten in codereview.settings.

The format is

email: status

Comments (starting with #) are allowed in that file, but they're ignored.

BUG= 694222 
R=dpranke@chromium.org

Change-Id: I49f58be87497d1ccaaa74f0a2f3d373403be44e7
Reviewed-on: https://chromium-review.googlesource.com/459542
Commit-Queue: Jochen Eisinger <jochen@chromium.org>
Reviewed-by: Dirk Pranke <dpranke@chromium.org>

[modify] https://crrev.com/72606f8c2402da51a92c91e324125e2026fcf457/tests/git_cl_test.py
[modify] https://crrev.com/72606f8c2402da51a92c91e324125e2026fcf457/git_cl.py
[modify] https://crrev.com/72606f8c2402da51a92c91e324125e2026fcf457/presubmit_support.py
[modify] https://crrev.com/72606f8c2402da51a92c91e324125e2026fcf457/owners.py
[modify] https://crrev.com/72606f8c2402da51a92c91e324125e2026fcf457/tests/owners_unittest.py
[modify] https://crrev.com/72606f8c2402da51a92c91e324125e2026fcf457/tests/owners_finder_test.py
[modify] https://crrev.com/72606f8c2402da51a92c91e324125e2026fcf457/tests/presubmit_unittest.py
[modify] https://crrev.com/72606f8c2402da51a92c91e324125e2026fcf457/owners_finder.py

Comment 4 by jochen@chromium.org, Apr 7 2017

Status: Fixed (was: Assigned)
Project Member

Comment 5 by bugdroid1@chromium.org, Apr 10 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/tools/depot_tools/+/76f5fc6cd95efaca49b8f0459f1bf8468a97bc8c

commit 76f5fc6cd95efaca49b8f0459f1bf8468a97bc8c
Author: Jochen Eisinger <jochen@chromium.org>
Date: Mon Apr 10 12:33:41 2017

Also print comments found in files during presubmit owners suggestion

R=dpranke@chromium.org
BUG= 694222 

Change-Id: I5676db2283dd43378293bc9bb32f71e0a1225806
Reviewed-on: https://chromium-review.googlesource.com/471609
Reviewed-by: Dirk Pranke <dpranke@chromium.org>
Commit-Queue: Jochen Eisinger <jochen@chromium.org>

[modify] https://crrev.com/76f5fc6cd95efaca49b8f0459f1bf8468a97bc8c/presubmit_canned_checks.py
[modify] https://crrev.com/76f5fc6cd95efaca49b8f0459f1bf8468a97bc8c/presubmit_support.py
[modify] https://crrev.com/76f5fc6cd95efaca49b8f0459f1bf8468a97bc8c/tests/presubmit_unittest.py
►

Sign in to add a comment