New issue
Advanced search Search tips

Issue 694220 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Mar 2017
Cc:
EstimatedDays: ----
NextAction: ----
OS: iOS
Pri: 3
Type: Bug



Sign in to add a comment

Create design for ContentSuggestionsArticle

Project Member Reported by gambard@chromium.org, Feb 20 2017

Issue description

Content Suggestion should present some article with the same layout as Android.
 
Summary: Create design for ContentSuggestionsArticle (was: Create ContentSuggestionsArticle)
Project Member

Comment 3 by bugdroid1@chromium.org, Feb 21 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/9bd3a256d47b5d8f8418bdd89eb4a9f72686ceeb

commit 9bd3a256d47b5d8f8418bdd89eb4a9f72686ceeb
Author: gambard <gambard@chromium.org>
Date: Tue Feb 21 20:15:30 2017

Fetch images for ContentSuggestions

BUG= 694220 

Review-Url: https://codereview.chromium.org/2701833003
Cr-Commit-Position: refs/heads/master@{#451829}

[modify] https://crrev.com/9bd3a256d47b5d8f8418bdd89eb4a9f72686ceeb/ios/chrome/browser/content_suggestions/content_suggestions_mediator.mm
[modify] https://crrev.com/9bd3a256d47b5d8f8418bdd89eb4a9f72686ceeb/ios/chrome/browser/ui/content_suggestions/BUILD.gn
[modify] https://crrev.com/9bd3a256d47b5d8f8418bdd89eb4a9f72686ceeb/ios/chrome/browser/ui/content_suggestions/content_suggestions_article_item.h
[modify] https://crrev.com/9bd3a256d47b5d8f8418bdd89eb4a9f72686ceeb/ios/chrome/browser/ui/content_suggestions/content_suggestions_article_item.mm
[modify] https://crrev.com/9bd3a256d47b5d8f8418bdd89eb4a9f72686ceeb/ios/chrome/browser/ui/content_suggestions/content_suggestions_article_item_unittest.mm
[modify] https://crrev.com/9bd3a256d47b5d8f8418bdd89eb4a9f72686ceeb/ios/chrome/browser/ui/content_suggestions/content_suggestions_collection_updater.mm
[modify] https://crrev.com/9bd3a256d47b5d8f8418bdd89eb4a9f72686ceeb/ios/chrome/browser/ui/content_suggestions/content_suggestions_data_source.h
[add] https://crrev.com/9bd3a256d47b5d8f8418bdd89eb4a9f72686ceeb/ios/chrome/browser/ui/content_suggestions/content_suggestions_image_fetcher.h

Project Member

Comment 4 by bugdroid1@chromium.org, Mar 1 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/25eac092d62daca30149285866c0b70dfad089b4

commit 25eac092d62daca30149285866c0b70dfad089b4
Author: gambard <gambard@chromium.org>
Date: Wed Mar 01 15:02:10 2017

Add first layout for the suggested articles

This CL adds a layout to make the articles look better.

BUG= 694220 

Review-Url: https://codereview.chromium.org/2727603002
Cr-Commit-Position: refs/heads/master@{#453934}

[modify] https://crrev.com/25eac092d62daca30149285866c0b70dfad089b4/ios/chrome/browser/ui/content_suggestions/BUILD.gn
[modify] https://crrev.com/25eac092d62daca30149285866c0b70dfad089b4/ios/chrome/browser/ui/content_suggestions/content_suggestions_article_item.mm

Status: Fixed (was: Assigned)
Project Member

Comment 6 by bugdroid1@chromium.org, Mar 21 2017

Sign in to add a comment