New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 694186 link

Starred by 1 user
Status: Fixed
Owner:
hcarmona@chromium.org
Closed: Feb 2017
Cc:
nyerramilli@chromium.org
kkaluri@chromium.org
█ msrchandra@chromium.org
█ ranjitkan@chromium.org
dpa...@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Mac
Pri: 2
Type: Bug-Regression



Sign in to add a comment

Regression : [md-settings] Side bar menu option does not change after navigating to previous sub-page.

Reported by yfulgaon...@etouch.net, Feb 20 2017 
Chrome Version : 58.0.3018.0 (Official Build) 5e7216844858ad1d08a70ac7aeef88547db2be7f-refs/heads/master@{#451537} 32/64 bit
OS : Windows (7,8,10), Mac (10.11.6, 10.12.1, 10.12), Linux (14.04 LTS)

What steps will reproduce the problem?
1. Launch chrome, navigate to chrome://md-settings, open "Main menu" side bar and click on "On startup".
2. Again click open "Main menu" side bar and click on "People".
3. Click on browser's back navigation button (page navigates to "On startup" section) and open "Main menu" side bar.
4. Observe the blue highlight.

Actual : Side bar menu option does not change after navigating to previous sub-page.
Expected : Side bar menu option should change according to the navigated sub-page.

This is a regression issue broken in ‘M-58’, below is the Manual Regression range and will soon update other info.
Good build : 58.0.3014.0
Bad build : 58.0.3015.0
Actual_Result.mp4
1.2 MB View Download
Expected_Result.mp4
1.1 MB View Download

Comment 1 by kkaluri@chromium.org, Feb 20 2017

Cc: kkaluri@chromium.org
Labels: hasbisect-per-revision
Owner: hcarmona@chromium.org
Status: Assigned (was: Unconfirmed)
Bisect Info:
===========
Good build : 58.0.3014.0,   Revision Range - 450840
Bad build  : 58.0.3015.0,   Revision Range - 451180

After executing the per-revision bisect script , i got the following CL's between good and bad build versions
===========================================
https://chromium.googlesource.com/chromium/src/+log/953322582e01e05f831456fecea0d48af331f16f..f26ccb9043c276fb76b875f90361ef5b58acc510

The suspecting Change Log is :
-----------
https://chromium.googlesource.com/chromium/src/+/f26ccb9043c276fb76b875f90361ef5b58acc510

Review URL:  https://codereview.chromium.org/2651293003

hcarmona@- Could you please look into this issue, if it's related to your change?  if not could you please help us to reassign this issue to the right owner.

Comment 2 by hcarmona@chromium.org, Feb 21 2017

Status: Started (was: Assigned)
Yes, this was me: fixing
Project Member

Comment 3 by bugdroid1@chromium.org, Feb 22 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/eddd7d9f355c397453f99e1ea1978568f7e103c4

commit eddd7d9f355c397453f99e1ea1978568f7e103c4
Author: hcarmona <hcarmona@chromium.org>
Date: Wed Feb 22 21:28:06 2017

Fix issue where side nav wasn't updated every time the route changed.

BUG= 694186 
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2708993003
Cr-Commit-Position: refs/heads/master@{#452209}

[modify] https://crrev.com/eddd7d9f355c397453f99e1ea1978568f7e103c4/chrome/browser/resources/settings/settings_menu/settings_menu.js
[modify] https://crrev.com/eddd7d9f355c397453f99e1ea1978568f7e103c4/chrome/test/data/webui/settings/settings_menu_test.js

Comment 4 by hcarmona@chromium.org, Feb 22 2017

Status: Fixed (was: Started)

Comment 5 by sureshkumari@chromium.org, Feb 28 2017

Labels: TE-Verified-M58 TE-Verified-58.0.3025.5
Tested the issue on Windows-7, Mac 10.12.2 and Linux Ubuntu-14.04 using Chrome version 58.0.3025.5 as per the comment #0.

Observed that the fix is working as expected.

Attaching the screen cast for reference.

Hence, adding the verified labels.

Thanks.
694186.mp4
897 KB View Download
►

Sign in to add a comment