New issue
Advanced search Search tips

Issue 694166 link

Starred by 1 user

Issue metadata

Status: Archived
Owner: ----
Closed: Sep 13
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug



Sign in to add a comment

ResourceBundle::GetImageNamed returns yellow squares instead of resource PNG

Project Member Reported by fhorschig@chromium.org, Feb 20 2017

Issue description

Is there an intentional difference between |ResourceBundle::GetNativeImageNamed| and |ResourceBundle::GetImageNamed|? 
If so, can we document this somewhere (preferably in the code)?

When working on CLs [1] loading PNGs into the FaviconService,
we used |ResourceBundle::GetImageNamed| to load the added resources.
Instead of the images, we received a small yellow image as response.

We used |ResourceBundle::GetNativeImageNamed| to have it working as intended.

There is no clue that those function might work differently and the expected behavior would be that both behave in a similar way.


[1] Patchset with unexpected behavior:
https://codereview.chromium.org/2695713004/#ps120001
Change icon_cacher_impl.cc to use GetNativeImageNamed and all icons will appear.
In order to see the effect, be offline when starting Chrome for the first time. If it works, you see images. If it doesn't there will be yellow tiles (background inferred from unsuitable image).
 
Project Member

Comment 1 by sheriffbot@chromium.org, Feb 21 2018

Labels: Hotlist-Recharge-Cold
Status: Untriaged (was: Available)
This issue has been Available for over a year. If it's no longer important or seems unlikely to be fixed, please consider closing it out. If it is important, please re-triage the issue.

Sorry for the inconvenience if the bug really should have been left as Available. If you change it back, also remove the "Hotlist-Recharge-Cold" label.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

Comment 2 by sczs@chromium.org, Feb 21 2018

Cc: -ios-bugs@chromium.org
Owner: sdefresne@chromium.org
Status: Assigned (was: Untriaged)
sdefresne@ since you worked with Assets not long ago, do you think this is still an issue?
Labels: -OS-iOS
Owner: ----
Status: Untriaged (was: Assigned)
This has nothing to do with Assets catalog. This is about loading images from .pak (i.e. Chromium's datapack). Not sure whether this is iOS specific or not. Back to triage queue for UI component.
Status: Archived (was: Untriaged)
Archiving old bugs that haven't been actively assigned in over 180 days.

If you feel this issue should still be addressed, feel free to reopen it or to file a new issue. Thanks!

Sign in to add a comment