Project: chromium Issues People Development process History Sign in
New issue
Advanced search Search tips
Issue 694159 Cleanup ContentSuggestions
Starred by 1 user Project Member Reported by gambard@chromium.org, Feb 20 Back to list
Status: Assigned
Owner:
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: iOS
Pri: 3
Type: Bug



Sign in to add a comment
Lot of classes have been created, make sure to remove the unused one.
 
Project Member Comment 1 by bugdroid1@chromium.org, Feb 21
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/75308d89e602764154da191eb0cb065c352cdd93

commit 75308d89e602764154da191eb0cb065c352cdd93
Author: gambard <gambard@chromium.org>
Date: Tue Feb 21 11:58:33 2017

Cleanup ContentSuggestions, removing unused functions

Rename ContentSuggestionsItem to ContentSuggestionsTextItem and remove the
addEmptyItem method as it is unused.

BUG=694159

Review-Url: https://codereview.chromium.org/2699393003
Cr-Commit-Position: refs/heads/master@{#451736}

[modify] https://crrev.com/75308d89e602764154da191eb0cb065c352cdd93/ios/chrome/browser/content_suggestions/content_suggestions_coordinator.mm
[modify] https://crrev.com/75308d89e602764154da191eb0cb065c352cdd93/ios/chrome/browser/content_suggestions/content_suggestions_mediator.mm
[modify] https://crrev.com/75308d89e602764154da191eb0cb065c352cdd93/ios/chrome/browser/ui/content_suggestions/BUILD.gn
[modify] https://crrev.com/75308d89e602764154da191eb0cb065c352cdd93/ios/chrome/browser/ui/content_suggestions/content_suggestions_collection_updater.h
[modify] https://crrev.com/75308d89e602764154da191eb0cb065c352cdd93/ios/chrome/browser/ui/content_suggestions/content_suggestions_collection_updater.mm
[modify] https://crrev.com/75308d89e602764154da191eb0cb065c352cdd93/ios/chrome/browser/ui/content_suggestions/content_suggestions_commands.h
[rename] https://crrev.com/75308d89e602764154da191eb0cb065c352cdd93/ios/chrome/browser/ui/content_suggestions/content_suggestions_text_item.h
[rename] https://crrev.com/75308d89e602764154da191eb0cb065c352cdd93/ios/chrome/browser/ui/content_suggestions/content_suggestions_text_item.mm
[rename] https://crrev.com/75308d89e602764154da191eb0cb065c352cdd93/ios/chrome/browser/ui/content_suggestions/content_suggestions_text_item_actions.h
[rename] https://crrev.com/75308d89e602764154da191eb0cb065c352cdd93/ios/chrome/browser/ui/content_suggestions/content_suggestions_text_item_unittest.mm
[modify] https://crrev.com/75308d89e602764154da191eb0cb065c352cdd93/ios/chrome/browser/ui/content_suggestions/content_suggestions_view_controller.h
[modify] https://crrev.com/75308d89e602764154da191eb0cb065c352cdd93/ios/chrome/browser/ui/content_suggestions/content_suggestions_view_controller.mm

Components: UI>Browser>Omnibox
Components: -UI>Browser>Omnibox UI>Browser>NewTabPage
Project Member Comment 4 by bugdroid1@chromium.org, Mar 20
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/be5b17ba520de8c5ebf31d4c4dfac8be44a50366

commit be5b17ba520de8c5ebf31d4c4dfac8be44a50366
Author: gambard <gambard@chromium.org>
Date: Mon Mar 20 17:14:48 2017

Move ContentSuggestions identifiers to custom target

This CL moves the identifier used in ContentSuggestions to a custom target,
allowing an easier include in future refactoring.

BUG=694159

Review-Url: https://codereview.chromium.org/2762643003
Cr-Commit-Position: refs/heads/master@{#458105}

[modify] https://crrev.com/be5b17ba520de8c5ebf31d4c4dfac8be44a50366/ios/chrome/browser/content_suggestions/BUILD.gn
[modify] https://crrev.com/be5b17ba520de8c5ebf31d4c4dfac8be44a50366/ios/chrome/browser/content_suggestions/content_suggestions_coordinator.mm
[modify] https://crrev.com/be5b17ba520de8c5ebf31d4c4dfac8be44a50366/ios/chrome/browser/content_suggestions/content_suggestions_mediator.mm
[modify] https://crrev.com/be5b17ba520de8c5ebf31d4c4dfac8be44a50366/ios/chrome/browser/ui/content_suggestions/BUILD.gn
[modify] https://crrev.com/be5b17ba520de8c5ebf31d4c4dfac8be44a50366/ios/chrome/browser/ui/content_suggestions/content_suggestion.h
[modify] https://crrev.com/be5b17ba520de8c5ebf31d4c4dfac8be44a50366/ios/chrome/browser/ui/content_suggestions/content_suggestion.mm
[modify] https://crrev.com/be5b17ba520de8c5ebf31d4c4dfac8be44a50366/ios/chrome/browser/ui/content_suggestions/content_suggestions_article_item.h
[modify] https://crrev.com/be5b17ba520de8c5ebf31d4c4dfac8be44a50366/ios/chrome/browser/ui/content_suggestions/content_suggestions_article_item.mm
[modify] https://crrev.com/be5b17ba520de8c5ebf31d4c4dfac8be44a50366/ios/chrome/browser/ui/content_suggestions/content_suggestions_collection_updater.mm
[modify] https://crrev.com/be5b17ba520de8c5ebf31d4c4dfac8be44a50366/ios/chrome/browser/ui/content_suggestions/content_suggestions_view_controller.mm
[add] https://crrev.com/be5b17ba520de8c5ebf31d4c4dfac8be44a50366/ios/chrome/browser/ui/content_suggestions/identifier/BUILD.gn
[rename] https://crrev.com/be5b17ba520de8c5ebf31d4c4dfac8be44a50366/ios/chrome/browser/ui/content_suggestions/identifier/content_suggestion_identifier.h
[rename] https://crrev.com/be5b17ba520de8c5ebf31d4c4dfac8be44a50366/ios/chrome/browser/ui/content_suggestions/identifier/content_suggestion_identifier.mm
[rename] https://crrev.com/be5b17ba520de8c5ebf31d4c4dfac8be44a50366/ios/chrome/browser/ui/content_suggestions/identifier/content_suggestion_identifier_unittest.mm
[rename] https://crrev.com/be5b17ba520de8c5ebf31d4c4dfac8be44a50366/ios/chrome/browser/ui/content_suggestions/identifier/content_suggestions_section_information.h
[rename] https://crrev.com/be5b17ba520de8c5ebf31d4c4dfac8be44a50366/ios/chrome/browser/ui/content_suggestions/identifier/content_suggestions_section_information.mm

Project Member Comment 5 by bugdroid1@chromium.org, Mar 21
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ce6b6a0d684b1ba63accead22156e32d53d169cc

commit ce6b6a0d684b1ba63accead22156e32d53d169cc
Author: gambard <gambard@chromium.org>
Date: Tue Mar 21 09:53:34 2017

Cleanup ContentSuggestions cells

This CL moves the ContentSuggestions cells and items to a separate forlder.
It also renames the ContentSuggestionsTextItem to ContentSuggestionsButtonItem.

BUG=694159

Review-Url: https://codereview.chromium.org/2761753002
Cr-Commit-Position: refs/heads/master@{#458363}

[modify] https://crrev.com/ce6b6a0d684b1ba63accead22156e32d53d169cc/ios/chrome/browser/content_suggestions/BUILD.gn
[modify] https://crrev.com/ce6b6a0d684b1ba63accead22156e32d53d169cc/ios/chrome/browser/content_suggestions/content_suggestions_coordinator.mm
[modify] https://crrev.com/ce6b6a0d684b1ba63accead22156e32d53d169cc/ios/chrome/browser/ui/content_suggestions/BUILD.gn
[add] https://crrev.com/ce6b6a0d684b1ba63accead22156e32d53d169cc/ios/chrome/browser/ui/content_suggestions/cells/BUILD.gn
[rename] https://crrev.com/ce6b6a0d684b1ba63accead22156e32d53d169cc/ios/chrome/browser/ui/content_suggestions/cells/content_suggestions_article_item.h
[rename] https://crrev.com/ce6b6a0d684b1ba63accead22156e32d53d169cc/ios/chrome/browser/ui/content_suggestions/cells/content_suggestions_article_item.mm
[rename] https://crrev.com/ce6b6a0d684b1ba63accead22156e32d53d169cc/ios/chrome/browser/ui/content_suggestions/cells/content_suggestions_article_item_unittest.mm
[rename] https://crrev.com/ce6b6a0d684b1ba63accead22156e32d53d169cc/ios/chrome/browser/ui/content_suggestions/cells/content_suggestions_button_item.h
[rename] https://crrev.com/ce6b6a0d684b1ba63accead22156e32d53d169cc/ios/chrome/browser/ui/content_suggestions/cells/content_suggestions_button_item.mm
[add] https://crrev.com/ce6b6a0d684b1ba63accead22156e32d53d169cc/ios/chrome/browser/ui/content_suggestions/cells/content_suggestions_button_item_actions.h
[add] https://crrev.com/ce6b6a0d684b1ba63accead22156e32d53d169cc/ios/chrome/browser/ui/content_suggestions/cells/content_suggestions_button_item_unittest.mm
[rename] https://crrev.com/ce6b6a0d684b1ba63accead22156e32d53d169cc/ios/chrome/browser/ui/content_suggestions/cells/content_suggestions_expandable_item.h
[rename] https://crrev.com/ce6b6a0d684b1ba63accead22156e32d53d169cc/ios/chrome/browser/ui/content_suggestions/cells/content_suggestions_expandable_item.mm
[rename] https://crrev.com/ce6b6a0d684b1ba63accead22156e32d53d169cc/ios/chrome/browser/ui/content_suggestions/cells/content_suggestions_expandable_item_unittest.mm
[rename] https://crrev.com/ce6b6a0d684b1ba63accead22156e32d53d169cc/ios/chrome/browser/ui/content_suggestions/cells/content_suggestions_favicon_internal_cell.h
[rename] https://crrev.com/ce6b6a0d684b1ba63accead22156e32d53d169cc/ios/chrome/browser/ui/content_suggestions/cells/content_suggestions_favicon_internal_cell.mm
[rename] https://crrev.com/ce6b6a0d684b1ba63accead22156e32d53d169cc/ios/chrome/browser/ui/content_suggestions/cells/content_suggestions_favicon_item.h
[rename] https://crrev.com/ce6b6a0d684b1ba63accead22156e32d53d169cc/ios/chrome/browser/ui/content_suggestions/cells/content_suggestions_favicon_item.mm
[rename] https://crrev.com/ce6b6a0d684b1ba63accead22156e32d53d169cc/ios/chrome/browser/ui/content_suggestions/cells/content_suggestions_favicon_item_unittest.mm
[rename] https://crrev.com/ce6b6a0d684b1ba63accead22156e32d53d169cc/ios/chrome/browser/ui/content_suggestions/cells/content_suggestions_footer_item.h
[rename] https://crrev.com/ce6b6a0d684b1ba63accead22156e32d53d169cc/ios/chrome/browser/ui/content_suggestions/cells/content_suggestions_footer_item.mm
[rename] https://crrev.com/ce6b6a0d684b1ba63accead22156e32d53d169cc/ios/chrome/browser/ui/content_suggestions/cells/content_suggestions_footer_item_unittest.mm
[rename] https://crrev.com/ce6b6a0d684b1ba63accead22156e32d53d169cc/ios/chrome/browser/ui/content_suggestions/cells/content_suggestions_stack_item.h
[rename] https://crrev.com/ce6b6a0d684b1ba63accead22156e32d53d169cc/ios/chrome/browser/ui/content_suggestions/cells/content_suggestions_stack_item.mm
[add] https://crrev.com/ce6b6a0d684b1ba63accead22156e32d53d169cc/ios/chrome/browser/ui/content_suggestions/cells/content_suggestions_stack_item_actions.h
[rename] https://crrev.com/ce6b6a0d684b1ba63accead22156e32d53d169cc/ios/chrome/browser/ui/content_suggestions/cells/content_suggestions_stack_item_unittest.mm
[rename] https://crrev.com/ce6b6a0d684b1ba63accead22156e32d53d169cc/ios/chrome/browser/ui/content_suggestions/cells/expandable_item.h
[modify] https://crrev.com/ce6b6a0d684b1ba63accead22156e32d53d169cc/ios/chrome/browser/ui/content_suggestions/content_suggestions_collection_updater.mm
[delete] https://crrev.com/9a4c7a14b2cbe13930f50c07f84a1d3b00f1567b/ios/chrome/browser/ui/content_suggestions/content_suggestions_stack_item_actions.h
[delete] https://crrev.com/9a4c7a14b2cbe13930f50c07f84a1d3b00f1567b/ios/chrome/browser/ui/content_suggestions/content_suggestions_text_item_actions.h
[delete] https://crrev.com/9a4c7a14b2cbe13930f50c07f84a1d3b00f1567b/ios/chrome/browser/ui/content_suggestions/content_suggestions_text_item_unittest.mm
[modify] https://crrev.com/ce6b6a0d684b1ba63accead22156e32d53d169cc/ios/chrome/browser/ui/content_suggestions/content_suggestions_view_controller.h
[modify] https://crrev.com/ce6b6a0d684b1ba63accead22156e32d53d169cc/ios/chrome/browser/ui/content_suggestions/content_suggestions_view_controller.mm
[modify] https://crrev.com/ce6b6a0d684b1ba63accead22156e32d53d169cc/ios/chrome/browser/ui/content_suggestions/identifier/BUILD.gn
[modify] https://crrev.com/ce6b6a0d684b1ba63accead22156e32d53d169cc/ios/chrome/browser/ui/settings/BUILD.gn
[modify] https://crrev.com/ce6b6a0d684b1ba63accead22156e32d53d169cc/ios/chrome/browser/ui/settings/material_cell_catalog_view_controller.mm
[modify] https://crrev.com/ce6b6a0d684b1ba63accead22156e32d53d169cc/ios/chrome/test/BUILD.gn

Project Member Comment 6 by bugdroid1@chromium.org, Mar 24
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/77379e3d2fb537896faa10d251518a5c4da2269e

commit 77379e3d2fb537896faa10d251518a5c4da2269e
Author: gambard <gambard@chromium.org>
Date: Fri Mar 24 13:26:02 2017

Remove image property from ContentSuggestion

The images are fetched using a ContentSuggestionsImageFetcher. This property
is not used.

BUG=694159

Review-Url: https://codereview.chromium.org/2774873002
Cr-Commit-Position: refs/heads/master@{#459403}

[modify] https://crrev.com/77379e3d2fb537896faa10d251518a5c4da2269e/ios/chrome/browser/ui/content_suggestions/content_suggestion.h
[modify] https://crrev.com/77379e3d2fb537896faa10d251518a5c4da2269e/ios/chrome/browser/ui/content_suggestions/content_suggestion.mm

Project Member Comment 9 by bugdroid1@chromium.org, Apr 5
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e7cde9afc4a89a78efb266e835c06b6d637ee75c

commit e7cde9afc4a89a78efb266e835c06b6d637ee75c
Author: gambard <gambard@chromium.org>
Date: Wed Apr 05 16:39:16 2017

Remove unused code

Remove some unused code in ContentSuggestions.
This code was added when more type of suggestions were planned.

BUG=694159

Review-Url: https://codereview.chromium.org/2798963002
Cr-Commit-Position: refs/heads/master@{#462110}

[modify] https://crrev.com/e7cde9afc4a89a78efb266e835c06b6d637ee75c/ios/chrome/browser/content_suggestions/content_suggestions_coordinator.mm
[modify] https://crrev.com/e7cde9afc4a89a78efb266e835c06b6d637ee75c/ios/chrome/browser/content_suggestions/mediator_util.mm
[modify] https://crrev.com/e7cde9afc4a89a78efb266e835c06b6d637ee75c/ios/chrome/browser/ui/content_suggestions/cells/BUILD.gn
[delete] https://crrev.com/dae287d8e707b2b9774b6d26bfd6240aa366c12c/ios/chrome/browser/ui/content_suggestions/cells/content_suggestions_button_item.h
[delete] https://crrev.com/dae287d8e707b2b9774b6d26bfd6240aa366c12c/ios/chrome/browser/ui/content_suggestions/cells/content_suggestions_button_item.mm
[delete] https://crrev.com/dae287d8e707b2b9774b6d26bfd6240aa366c12c/ios/chrome/browser/ui/content_suggestions/cells/content_suggestions_button_item_actions.h
[delete] https://crrev.com/dae287d8e707b2b9774b6d26bfd6240aa366c12c/ios/chrome/browser/ui/content_suggestions/cells/content_suggestions_button_item_unittest.mm
[delete] https://crrev.com/dae287d8e707b2b9774b6d26bfd6240aa366c12c/ios/chrome/browser/ui/content_suggestions/cells/content_suggestions_expandable_item.h
[delete] https://crrev.com/dae287d8e707b2b9774b6d26bfd6240aa366c12c/ios/chrome/browser/ui/content_suggestions/cells/content_suggestions_expandable_item.mm
[delete] https://crrev.com/dae287d8e707b2b9774b6d26bfd6240aa366c12c/ios/chrome/browser/ui/content_suggestions/cells/content_suggestions_expandable_item_unittest.mm
[delete] https://crrev.com/dae287d8e707b2b9774b6d26bfd6240aa366c12c/ios/chrome/browser/ui/content_suggestions/cells/content_suggestions_favicon_internal_cell.h
[delete] https://crrev.com/dae287d8e707b2b9774b6d26bfd6240aa366c12c/ios/chrome/browser/ui/content_suggestions/cells/content_suggestions_favicon_internal_cell.mm
[delete] https://crrev.com/dae287d8e707b2b9774b6d26bfd6240aa366c12c/ios/chrome/browser/ui/content_suggestions/cells/content_suggestions_favicon_item.h
[delete] https://crrev.com/dae287d8e707b2b9774b6d26bfd6240aa366c12c/ios/chrome/browser/ui/content_suggestions/cells/content_suggestions_favicon_item.mm
[delete] https://crrev.com/dae287d8e707b2b9774b6d26bfd6240aa366c12c/ios/chrome/browser/ui/content_suggestions/cells/content_suggestions_favicon_item_unittest.mm
[delete] https://crrev.com/dae287d8e707b2b9774b6d26bfd6240aa366c12c/ios/chrome/browser/ui/content_suggestions/cells/content_suggestions_stack_item.h
[delete] https://crrev.com/dae287d8e707b2b9774b6d26bfd6240aa366c12c/ios/chrome/browser/ui/content_suggestions/cells/content_suggestions_stack_item.mm
[delete] https://crrev.com/dae287d8e707b2b9774b6d26bfd6240aa366c12c/ios/chrome/browser/ui/content_suggestions/cells/content_suggestions_stack_item_actions.h
[delete] https://crrev.com/dae287d8e707b2b9774b6d26bfd6240aa366c12c/ios/chrome/browser/ui/content_suggestions/cells/content_suggestions_stack_item_unittest.mm
[delete] https://crrev.com/dae287d8e707b2b9774b6d26bfd6240aa366c12c/ios/chrome/browser/ui/content_suggestions/cells/expandable_item.h
[modify] https://crrev.com/e7cde9afc4a89a78efb266e835c06b6d637ee75c/ios/chrome/browser/ui/content_suggestions/content_suggestions_collection_updater.mm
[modify] https://crrev.com/e7cde9afc4a89a78efb266e835c06b6d637ee75c/ios/chrome/browser/ui/content_suggestions/content_suggestions_commands.h
[modify] https://crrev.com/e7cde9afc4a89a78efb266e835c06b6d637ee75c/ios/chrome/browser/ui/content_suggestions/content_suggestions_view_controller.h
[modify] https://crrev.com/e7cde9afc4a89a78efb266e835c06b6d637ee75c/ios/chrome/browser/ui/content_suggestions/content_suggestions_view_controller.mm
[modify] https://crrev.com/e7cde9afc4a89a78efb266e835c06b6d637ee75c/ios/chrome/browser/ui/content_suggestions/identifier/content_suggestion_identifier_unittest.mm
[modify] https://crrev.com/e7cde9afc4a89a78efb266e835c06b6d637ee75c/ios/chrome/browser/ui/content_suggestions/identifier/content_suggestions_section_information.h

Project Member Comment 10 by bugdroid1@chromium.org, Apr 6
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/4f6e28eee5894edfb1a5daf79812dafcacb9d93b

commit 4f6e28eee5894edfb1a5daf79812dafcacb9d93b
Author: gambard <gambard@chromium.org>
Date: Thu Apr 06 14:51:33 2017

Remove the bookmark provider from ContentSuggestions

The bookmarks are not currently part of ContentSuggestions on iOS.
This CL removes the provider from the ContentSuggestionsService used on iOS.

BUG=694159

Review-Url: https://codereview.chromium.org/2805703002
Cr-Commit-Position: refs/heads/master@{#462470}

[modify] https://crrev.com/4f6e28eee5894edfb1a5daf79812dafcacb9d93b/ios/chrome/browser/ntp_snippets/ios_chrome_content_suggestions_service_factory.cc

Sign in to add a comment