New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 694158 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Apr 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Mac
Pri: 1
Type: Bug-Regression



Sign in to add a comment

Regression: Misalignment between sliderbar and its text is seen on chrome://md-settings/fonts.

Reported by dmascare...@etouch.net, Feb 20 2017

Issue description

Chrome Version:58.0.3018.0 (Official Build) Revision 5e7216844858ad1d08a70ac7aeef88547db2be7f-refs/heads/master@{#451537}
OS:Windows (7,8,10), Mac OS X(10.10.5, 10.11.4)

What steps will reproduce the problem?
1. Launch chrome and navigate to chrome://md-settings/fonts
2. Drag the ‘Minimum font size’ slider to the maximum(Tiny to Huge) and observe.

Actual: Misalignment between sliderbar and text is seen i.e. Space between sliderbar and text increases 
Expected: Sliderbar and its text should be proper aligned.

This is regression issue, broken in ‘M 58’ and below is manual bisect:
Good build:58.0.2990.0
Bad build:58.0.2991.0

 
Slider.png
57.5 KB View Download
Labels: Needs-Bisect
Status: Untriaged (was: Unconfirmed)
Labels: -Needs-Bisect hasbisect-per-revision
Owner: scottchen@chromium.org
Status: Assigned (was: Untriaged)
Using the per-revision bisect providing the bisect results,
Good build : 58.0.2998.0 (Revision: 447146) - ignore the regression in bug report..
Bad build : 58.0.2999.4 (Revision: 447413)

You are probably looking for a change made after 447309 (known good), but no later than 447310 (first known bad).
CHANGELOG URL:
The script might not always return single CL as suspectas some perf builds might get missing due to failure.
  https://chromium.googlesource.com/chromium/src/+log/b6f1374b024b68b909ffb632b5a8c184391476bf..a2176d0c08e0a2367c91c2edb8ae255f185130ae

scottchen@, could you please check the issue and help..
Owner: bettes@chromium.org
This appears to only happening when you increase the text size with that toggle.

This is happening now because we added a default line-height to all text, which makes the "tiny" and "huge" text have a 90px line-height, which seems to be the correct behavior to me. 

The real bug here seems to be that the "tiny" and "huge" text stayed 12px, when really, it should increase/decrease in size like all the other texts on the settings page. 

+bettes@ could you please confirm whether or not we want "tiny" and "huge" to change in size? if so, I'll change it to use relative font-size as opposed to the 12px hard-coded size we have now.
Friendly ping to get an update on this.

Thanks.

Comment 5 by hdodda@chromium.org, Mar 21 2017

Able to reproduce the issue in mac os 10.12.3 using chrome M59 #59.0.3047 .

@Could someone please provide us an update on this issue. 

Thanks!
Status: Fixed (was: Assigned)

Sign in to add a comment