Issue metadata
Sign in to add a comment
|
GTK+ theme should never be enabled for supervised users |
||||||||||||||||||||||
Issue descriptionChrome Version: 58.0.3018.0 dev OS: Ubuntu 14.04 What steps will reproduce the problem? (1)Launch chrome,Sign in and be in GTK+ theme >> Add/Create Supervised user and be in GTK+ theme (2)Now in main user click on profile icon on top and hover on profile names and observe orange highlight (3)Now switch to supervised user and observe same. Expected: Default orange highlight should be seen in supervised user when in GTK+ theme Actual: Instead Grey focus is only seen even when in GTK+ theme. Manual Bisect Info: ==================== Good Build: 58.0.3005.2 dev Bad Build: 58.0.3006.0 dev NOTE: This issue is not applicable to Windows.
,
Feb 21 2017
,
Feb 21 2017
The theme highlight shown in the video is correct behavior. The supervised user is not using the GTK+ theme, while the normal user is. However, it appears the option to use the GTK+ theme has been disabled for supervised users. I don't know why this is the case since you can install extension themes. FYI I authored the CL that added the orange highlight: https://codereview.chromium.org/2624683002/ And the one that respects theme settings for the profile chooser window (previously, it would fallback on the GTK+ theme, which is incorrect for classic theme users): https://codereview.chromium.org/2697513008/
,
Feb 21 2017
Manual Bisect: Good Build—-58.0.3005.2 Revision (448507) Bad Build—--58.0.3006.0 Revision (448862) Hasbisect-per revision-bisect info: ChangeLog: https://chromium.googlesource.com/chromium/src/+log/ecd303a7ad5531522b00dcb6268b769717c14952..f0de79a0e44c878b66df8012e77ff38896fe8faf Review-Url: https://codereview.chromium.org/2624683002 thomasanderson@ Kindly take a look and please help us to reassign this issue to a right owner if not with respect to this change. Thanks.
,
Feb 22 2017
https://cs.chromium.org/chromium/src/chrome/test/data/webui/settings/appearance_page_test.js?rcl=6a23306766d02a480c7992f91b51e9691d6511b8&l=163 According to that test, the GTK theme should never be available to supervised users, so the bug is that the orange highlights showed up in the first place. working on a fix now
,
Feb 22 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/a7b1d4e984b58061e973c31de0c7b403ec14f42c commit a7b1d4e984b58061e973c31de0c7b403ec14f42c Author: thomasanderson <thomasanderson@google.com> Date: Wed Feb 22 08:15:19 2017 Linux UI: Never use GTK theme for supervised profiles The GTK+ theme should not be available to supervised users. See https://cs.chromium.org/chromium/src/chrome/test/data/webui/settings/appearance_page_test.js?rcl=6a23306766d02a480c7992f91b51e9691d6511b8&l=163 BUG= 694154 R=sky@chromium.org Review-Url: https://codereview.chromium.org/2706243004 Cr-Commit-Position: refs/heads/master@{#451924} [modify] https://crrev.com/a7b1d4e984b58061e973c31de0c7b403ec14f42c/chrome/browser/ui/views/chrome_browser_main_extra_parts_views_linux.cc
,
Feb 22 2017
,
Feb 28 2017
Tested this issue on Linux Ubuntu-14.04 using chrome version-58.0.3025.5 as per comment#6 & observed below: 1.Orange highlight is seen when user hover on profile names for the main user with GTK mode in settings 2.switch to supervised user 3.observed GTK+ theme by default (User unable to change to classic theme) & gray focus is seen when user hover on profile names thomasanderson@, Could you please confirm, is this the expected behaviour for the same. Please find the attached screencast for the same. Thanks in advance.
,
Feb 28 2017
#8 That is correct behavior, but you've pointed out another bug in md-settings :) See the attached screenshots, and notice the difference between the old settings and material design settings. I've opened bug 697134 for this
,
Mar 1 2017
jmukthavaram@, thank you for thorough testing and spotting a new bug. Thank you! |
|||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||
Comment 1 by kavvaru@chromium.org
, Feb 20 2017Status: Untriaged (was: Unconfirmed)