New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 694130 link

Starred by 3 users
Status: Fixed
Owner:
dgozman@chromium.org
Closed: Feb 2017
Cc:
gov...@chromium.org
█ manoranj...@chromium.org
nyerramilli@chromium.org
█ msrchandra@chromium.org
█ ranjitkan@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Mac
Pri: 1
Type: Bug-Regression



Sign in to add a comment

Regression: Unable to perform any action on Devtools after reloading its Settings page

Reported by jshan...@etouch.net, Feb 20 2017 
Chrome Version : 58.0.3018.0 (Official Build) 5e7216844858ad1d08a70ac7aeef88547db2be7f-refs/heads/master@{#451537} 32/64 bit
OS : Windows (7,8,10), Mac OS X(10.10.5, 10.11.4)

Steps:
1. Launch Chrome and open devtools, press F1 key to open the devtools 'Settings'
2. Click on Workshop, reload the page and close 'Settings' overlay
3. Click on '>>' icon or any section like 'Performance' and observe

Actual: Unable to perform any action on Devtools after reloading its Settings page

Expected: Should be able to perform action on Devtools after reloading its Settings page

This is a regression issue broken in ‘M-58’, below is the Manual Regression range and will soon update other info.

Good build : 58.0.3017.0
Bad build : 58.0.3018.0

Note: Will soon update Linux info
Actual_video.mp4
1.2 MB View Download
Expected_video.mp4
702 KB View Download

Comment 1 by nyerramilli@chromium.org, Feb 20 2017

Cc: gov...@chromium.org manoranj...@chromium.org
Labels: hasbisect-per-revision ReleaseBlock-Beta OS-Linux
Owner: dgozman@chromium.org
Status: Assigned (was: Unconfirmed)
adding blocker label as this is recent regression, please change if required..

Using the per-revision bisect providing the bisect results,
Good build : 58.0.3017.0 (Revision: 451476)
Bad build : 58.0.3018.0 (Revision: 451537)

You are probably looking for a change made after 451522 (known good), but no later than 451523 (first known bad).
CHANGELOG URL:
The script might not always return single CL as suspectas some perf builds might get missing due to failure.
  https://chromium.googlesource.com/chromium/src/+log/0fea64cb0a598ecd2051bb7c58e6fbf9422b1aef..3e3774f369e1e642d06e895276b08814b279c20c

dgozman@,could you please check the issue and help.

Note: Able to reproduce the issue on Ubuntu 14.04 using Chrome Dev#58.0.3018.0

Comment 2 by manoranj...@chromium.org, Feb 23 2017 

dgozman@, As we are close to M58 branching (preferably next week), can you please prepare a fix ASAP?

Thank you!
Project Member

Comment 3 by bugdroid1@chromium.org, Feb 23 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/169beb0367bc0ca03c4cb0baa18d183740f157d0

commit 169beb0367bc0ca03c4cb0baa18d183740f157d0
Author: dgozman <dgozman@chromium.org>
Date: Thu Feb 23 00:56:26 2017

[DevTools] Fix Dialog's close button to properly close dialog.

Recently regressed in crrev.com/3e3774f369e1e642d06e895276b08814b279c20c.

BUG= 694130 

Review-Url: https://codereview.chromium.org/2706293007
Cr-Commit-Position: refs/heads/master@{#452319}

[modify] https://crrev.com/169beb0367bc0ca03c4cb0baa18d183740f157d0/third_party/WebKit/LayoutTests/http/tests/inspector/persistence/persistence-go-to-file-dialog.html
[modify] https://crrev.com/169beb0367bc0ca03c4cb0baa18d183740f157d0/third_party/WebKit/Source/devtools/front_end/main/Main.js
[modify] https://crrev.com/169beb0367bc0ca03c4cb0baa18d183740f157d0/third_party/WebKit/Source/devtools/front_end/network/NetworkLogViewColumns.js
[modify] https://crrev.com/169beb0367bc0ca03c4cb0baa18d183740f157d0/third_party/WebKit/Source/devtools/front_end/perf_ui/FilmStripView.js
[modify] https://crrev.com/169beb0367bc0ca03c4cb0baa18d183740f157d0/third_party/WebKit/Source/devtools/front_end/quick_open/FilteredListWidget.js
[modify] https://crrev.com/169beb0367bc0ca03c4cb0baa18d183740f157d0/third_party/WebKit/Source/devtools/front_end/settings/SettingsScreen.js
[modify] https://crrev.com/169beb0367bc0ca03c4cb0baa18d183740f157d0/third_party/WebKit/Source/devtools/front_end/sources/AddSourceMapURLDialog.js
[modify] https://crrev.com/169beb0367bc0ca03c4cb0baa18d183740f157d0/third_party/WebKit/Source/devtools/front_end/ui/Dialog.js
[modify] https://crrev.com/169beb0367bc0ca03c4cb0baa18d183740f157d0/third_party/WebKit/Source/devtools/front_end/ui/GlassPane.js
[modify] https://crrev.com/169beb0367bc0ca03c4cb0baa18d183740f157d0/third_party/WebKit/Source/devtools/front_end/ui/SuggestBox.js
[modify] https://crrev.com/169beb0367bc0ca03c4cb0baa18d183740f157d0/third_party/WebKit/Source/devtools/front_end/ui/Toolbar.js
[modify] https://crrev.com/169beb0367bc0ca03c4cb0baa18d183740f157d0/third_party/WebKit/Source/devtools/front_end/ui/UIUtils.js

Comment 4 by dgozman@chromium.org, Feb 23 2017

Status: Fixed (was: Assigned)

Comment 5 by manoranj...@chromium.org, Feb 23 2017 

Thank you so much for the quick update.

Comment 6 by kkaluri@chromium.org, Feb 28 2017

Labels: TE-Verified-M58 TE-Verified-58.0.3025.5
Verified this issue on Windows-10, Mac 10.12.3 and Ubuntu-14.04 using Chrome version 58.0.3025.5 as per the comment #0.

Observed that the fix is working as expected.

Attaching the screen cast for reference.

Hence, adding the verified labels.

Thanks.
Issue 694130.mp4
2.0 MB View Download
►

Sign in to add a comment