Issue metadata
Sign in to add a comment
|
Regresion : "Set as default" button is seen chopped from both the (left & right) sides.
Reported by
yfulgaon...@etouch.net,
Feb 20 2017
|
||||||||||||||||||||||
Issue descriptionChrome Version : 58.0.3018.0 (Official Build) 5e7216844858ad1d08a70ac7aeef88547db2be7f-refs/heads/master@{#451537} 32/64 bit OS : Windows (7,8,10) Precondition : Please set "Firefox" as your default browser. What steps will reproduce the problem? 1. Freshly install chrome and launch it. 2. Type chrome://restart in omnibox and hit 'Enter' key (chrome restarts). 3. Observe the "Set as default" button in a dialog. Actual : "Set as default" button is seen chopped from both the sides. Expected : "Set as default" button should be seen properly. This is a regression issue broken in ‘M-58’, below is the Manual Regression range and will soon update other info. Good build : 58.0.3017.0 Bad build : 58.0.3018.0 Note : Above issue is not seen on Mac(10.11.6, 10.12.1, 10.12) OS and will soon update Linux info once the Linux build #58.0.3018.0 is available.
,
Feb 20 2017
Using the per-revision bisect providing the bisect results, Good build: 58.0.3017.0 (Revision: 451476). Bad build: 58.0.3018.0 (Revision: 451537). You are probably looking for a change made after 451496 (known good), but no later than 451497 (first known bad). CHANGE-LOG URL: --------------- https://chromium.googlesource.com/chromium/src/+log/4ce7ff3ecc5d5b638cfdd38b956e80671426742a..b621d8cec36bec73ef3eacddbcd7c998aee80cae From the CL above, assigning the issue to the concern owner @bsep: Could you please look into the issue, pardon me if it has nothing to do with your changes and if possible please assign it to concern owner. Review-Url: https://codereview.chromium.org/2660553005 Note : Able to reproduce the issue in Ubuntu 14.04 & Win 10.0 Not in Mac 10.12.3.and able to reproduce in latest Canary #58.0.3018.0
,
Feb 20 2017
,
Feb 21 2017
,
Feb 22 2017
I'm not seeing this reproduce on 58.0.3020.0 (see attached screenshots for this and duplicate issue 694412 ). Not sure why, it doesn't seem like the relevant code has been updated since my change. Feel free to reopen if this comes up again.
,
Feb 22 2017
,
Feb 23 2017
With response to comment #5, Rechecked the issue on latest canary #58.0.3021.0 in Win 10 machine and issue is still reproducible. Please follow the below steps to reproduce the original issue consistently. Precondition : Set "Firefox" as your default browser. 1. Freshly install chrome and launch it. 2. Open NTP, type chrome://restart in omnibox and hit 'Enter'. 3. Repeat step 2 again and observe. (Kindly refer an attached screencast)
,
Feb 23 2017
Okay I see it. It only reproduces at 1x dsf, and not with the force-device-scale-factor flag, annoyingly.
,
Feb 23 2017
,
Feb 24 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/2c407ccc88aae08641fcb667277df2b08a2f251a commit 2c407ccc88aae08641fcb667277df2b08a2f251a Author: bsep <bsep@chromium.org> Date: Fri Feb 24 21:48:55 2017 Fix the absence of padding on some UI buttons. It turns out that despite what I thought some buttons are being created as MdTextButtons even when harmony is off, for example in the infobar. So this patch reverts some changes from crrev.com/2660553005 to ensure behavior pre-harmony remains unchanged. BUG= 694129 Review-Url: https://codereview.chromium.org/2702403010 Cr-Commit-Position: refs/heads/master@{#452937} [modify] https://crrev.com/2c407ccc88aae08641fcb667277df2b08a2f251a/chrome/browser/ui/views/chrome_views_delegate.cc [modify] https://crrev.com/2c407ccc88aae08641fcb667277df2b08a2f251a/chrome/browser/ui/views/chrome_views_delegate.h [modify] https://crrev.com/2c407ccc88aae08641fcb667277df2b08a2f251a/chrome/browser/ui/views/harmony/harmony_layout_delegate.cc [modify] https://crrev.com/2c407ccc88aae08641fcb667277df2b08a2f251a/chrome/browser/ui/views/harmony/layout_delegate.cc [modify] https://crrev.com/2c407ccc88aae08641fcb667277df2b08a2f251a/chrome/browser/ui/views/harmony/layout_delegate.h [modify] https://crrev.com/2c407ccc88aae08641fcb667277df2b08a2f251a/ui/views/controls/button/md_text_button.cc [modify] https://crrev.com/2c407ccc88aae08641fcb667277df2b08a2f251a/ui/views/layout/layout_constants.h [modify] https://crrev.com/2c407ccc88aae08641fcb667277df2b08a2f251a/ui/views/views_delegate.cc [modify] https://crrev.com/2c407ccc88aae08641fcb667277df2b08a2f251a/ui/views/views_delegate.h [modify] https://crrev.com/2c407ccc88aae08641fcb667277df2b08a2f251a/ui/views/window/dialog_client_view.cc
,
Feb 24 2017
,
Feb 28 2017
Tested the issue on Windows-7 and Linux Ubuntu-14.04 using Chrome version 58.0.3025.5 as per the comment #0. Observed that the fix is working as expected. Please find the attached the screenshot for reference. Hence, adding the verified labels. Thanks. |
|||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||
Comment 1 by yfulgaon...@etouch.net
, Feb 20 2017