Issue metadata
Sign in to add a comment
|
11.4%-30.4% regression in service_worker.service_worker_micro_benchmark at 450910:451096 |
||||||||||||||||||||||
Issue descriptionSee the link to graphs below.
,
Feb 19 2017
Started bisect job https://chromeperf.appspot.com/buildbucket_job_status/8987214341606053120
,
Feb 19 2017
likely the same as Issue 694043
,
Feb 19 2017
=== Auto-CCing suspected CL author darin@chromium.org === Hi darin@chromium.org, the bisect results pointed to your CL, please take a look at the results. === BISECT JOB RESULTS === Perf regression found with culprit Suspected Commit Author : darin Commit : 2d145fe56a1d995fc1a016da03c1f91f217612e0 Date : Thu Feb 16 15:22:35 2017 Subject: HTML MessagePort as mojo::MessagePipeHandle Bisect Details Configuration: winx64_high_dpi_perf_bisect Benchmark : service_worker.service_worker_micro_benchmark Metric : concurrent_100_response_50_percentile/concurrent_100_response_50_percentile Change : 45.41% | 74.8125 -> 108.788333333 Revision Result N chromium@450964 74.8125 +- 12.2505 6 good chromium@450969 75.6533 +- 5.03963 6 good chromium@450970 98.0133 +- 1.45808 6 bad <-- chromium@450971 109.49 +- 3.89224 6 bad chromium@450973 104.871 +- 4.77063 6 bad chromium@450981 105.11 +- 3.72099 6 bad chromium@450997 116.801 +- 9.78116 6 bad chromium@451030 104.152 +- 10.0869 6 bad chromium@451096 108.788 +- 6.03256 6 bad To Run This Test src/tools/perf/run_benchmark -v --browser=release_x64 --output-format=chartjson --upload-results --pageset-repeat=1 --also-run-disabled-tests service_worker.service_worker_micro_benchmark Debug Info https://chromeperf.appspot.com/buildbucket_job_status/8987214341606053120 Is this bisect wrong? https://chromeperf.appspot.com/bad_bisect?try_job_id=5782048729464832 | O O | Visit http://www.chromium.org/developers/speed-infra/perf-bug-faq | X | for more information addressing perf regression bugs. For feedback, | / \ | file a bug with component Speed>Bisection. Thank you!
,
Feb 19 2017
I wonder if this could be due to making Blob registration IPCs synchronous.
,
Feb 20 2017
Yes, this benchmark is very sensitive to changes in Blob code. It measures a SW responding to many (up to 100) concurrent XHR requests using something like respondWith(new Response(‘hello’)), which ends up creating a Blob. Is the MessagePort commit expected to slow down blob creation? Since this microbenchmark isn't super representative of real world usage, we might just accept this regression.
,
Feb 20 2017
Yes, the MessagePort includes the change that turns Blob registration IPC into Synchronous, therefore it is pretty much expected that it slows down Blob creation. The benchmark isn't really representative as you say so I suppose we can probably just accept (or update the benchmark code), but let's also check if we don't have any important real-world usage this change might badly affect. (I can't think of for now)
,
Feb 21 2017
Yeah, I don't know of one and a cursory investigation of top SW sites didn't show usage. I think we can just accept this. If it turns out to matter we could also consider transferring string-constructed responses as streams rather than blobs. |
|||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||
Comment 1 by falken@chromium.org
, Feb 19 2017