New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 694033 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: Feb 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux
Pri: 1
Type: Bug

Blocked on:
issue 662541
issue 805169
issue 805764
issue 805771

Blocking:
issue 770853



Sign in to add a comment

Move "Ozone Linux" bot from chromium.fyi to chromium.linux

Project Member Reported by toniki...@chromium.org, Feb 19 2017

Issue description

The linux_chromium_ozone_compile_only_ng bot is alive since later 2016 (thanks to Thomas Anderson), and both Frederic Wang and I guard it, keeping it green with miscellaneous build fixes:

https://codereview.chromium.org/2500863002/
https://codereview.chromium.org/2620503002/
https://codereview.chromium.org/2646983002/
https://codereview.chromium.org/2678283003/
https://codereview.chromium.org/2687293002/
https://codereview.chromium.org/2694683002/

On offline conversations with Dirk Pranke, he believe it is too early to add linux_chromium_ozone_compile_only_ng bot to the CQ, but, as an intermediate step, we could move the builder onto the main waterfall.
This way sheriffs will start watching the builders and can revert changes or notify developers accordingly.

I am assigning it to Dirk so that he can triage.

 

Comment 1 by s...@google.com, Feb 21 2017

Components: -Infra Infra>Client>Chrome
Labels: OS-Linux
Labels: -Pri-3 Pri-1
Labels: -Pri-1 Pri-2
Owner: jbudorick@chromium.org
@jbudorick - I'm punting this to your team now. I'm not sure how urgent this is; maybe one of the cc'ed people that have been watching the FYI bot can comment on how often this is breaking?

Comment 5 by kbr@chromium.org, Aug 10 2017

Cc: kbr@chromium.org
Cc: jamescook@chromium.org
Owner: dpranke@chromium.org
Status: Started (was: Assigned)
I think we can add this now ... https://chromium-review.googlesource.com/647690 for a start.
Project Member

Comment 8 by bugdroid1@chromium.org, Sep 5 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/bb279d2a599faa8f28ece17b398cfdbb9f7db098

commit bb279d2a599faa8f28ece17b398cfdbb9f7db098
Author: Dirk Pranke <dpranke@chromium.org>
Date: Tue Sep 05 17:38:32 2017

Add linux_chromium_ozone_compile_ng as a 10% cq experiment.

R=jbudorick@chromium.org
BUG= 694033 

Change-Id: I42f7c410daee41e6202d871746dc9ac56361c444
Reviewed-on: https://chromium-review.googlesource.com/647690
Reviewed-by: John Budorick <jbudorick@chromium.org>
Commit-Queue: Dirk Pranke <dpranke@chromium.org>
Cr-Commit-Position: refs/heads/master@{#499666}
[modify] https://crrev.com/bb279d2a599faa8f28ece17b398cfdbb9f7db098/infra/config/cq.cfg

Labels: -Pri-2 Pri-1
Cc: timbrown@chromium.org
+timbrown could you take this one?

This involves moving the ozone linux bot from chromium.fyi to chromium.linux.  All of the files in this CS need changes:
https://cs.chromium.org/search/?q=%22ozone+linux%22&sq=package:chromium
eg. code in build/masters/master.chromium.fyi/master.cfg would need to move to build/masters/master.chromium.linux/master.cfg.

Comment 11 by kbr@chromium.org, Dec 8 2017

Blockedon: 662541
We're in the middle of autogenerating all of the various waterfalls' JSON files in src/testing/buildbot and it would be inconvenient if this bot moved waterfalls at this precise moment. Please wait for us to finish  Issue 662541 . It will then be trivial to move this bot between waterfalls src-side.

got it, we'll wait until  bug 662541  is fixed.  Also, thanks Ken for making this type of task easier for devs in the future!
Blocking: 770853
Adding this as a blocker for 770853 since it was decided in discussions with dpranke that we could combine the VR and Ozone CQ bots.
Summary: Move "Ozone Linux" bot from chromium.fyi to chromium.linux (was: Add linux_chromium_ozone_compile_only_ng buildbot to main waterfall)
Owner: timbrown@chromium.org
I'll have a go at this.
Project Member

Comment 16 by bugdroid1@chromium.org, Jan 23 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f850cad0279bb7e92589e086bf8b40d4c3018b8b

commit f850cad0279bb7e92589e086bf8b40d4c3018b8b
Author: Tim Brown <timbrown@chromium.org>
Date: Tue Jan 23 00:24:51 2018

Move "Ozone Linux" builder onto main waterfall

Specifically, move it from chromium.fyi to chromium.linux. This way
sheriffs will start watching the builders and can revert changes or
notify developers accordingly.

Bug:  694033 
Change-Id: I11aa400b63697a7e131c374fe926b69759f151fc
Reviewed-on: https://chromium-review.googlesource.com/875200
Reviewed-by: Dirk Pranke <dpranke@chromium.org>
Commit-Queue: Tim Brown <timbrown@chromium.org>
Cr-Commit-Position: refs/heads/master@{#531080}
[modify] https://crrev.com/f850cad0279bb7e92589e086bf8b40d4c3018b8b/testing/buildbot/chromium.fyi.json
[modify] https://crrev.com/f850cad0279bb7e92589e086bf8b40d4c3018b8b/testing/buildbot/chromium.linux.json
[modify] https://crrev.com/f850cad0279bb7e92589e086bf8b40d4c3018b8b/testing/buildbot/waterfalls.pyl

Status: Fixed (was: Started)
Status: Assigned (was: Fixed)
This is not fixed yet.  There are still several files that need to change:
https://cs.chromium.org/search/?q=%22Ozone+Linux%22&sq=package:chromium&type=cs
Project Member

Comment 19 by bugdroid1@chromium.org, Jan 23 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/tools/build/+/c02609da9da8cb2a602e330913cfb563cd7bf03e

commit c02609da9da8cb2a602e330913cfb563cd7bf03e
Author: Tim Brown <timbrown@chromium.org>
Date: Tue Jan 23 23:47:24 2018

Move "Ozone Linux" builder onto main waterfall

Specifically move it from chromium.fyi to chromium.linux.

Bug:  694033 
Change-Id: Ie3d1ad13e9a5879e436a08685d5b8e3863c82aa2
Reviewed-on: https://chromium-review.googlesource.com/881944
Commit-Queue: Tim Brown <timbrown@chromium.org>
Reviewed-by: Dirk Pranke <dpranke@chromium.org>

[modify] https://crrev.com/c02609da9da8cb2a602e330913cfb563cd7bf03e/masters/master.chromium.linux/master_linux_cfg.py
[modify] https://crrev.com/c02609da9da8cb2a602e330913cfb563cd7bf03e/masters/master.chromium.fyi/master.cfg
[modify] https://crrev.com/c02609da9da8cb2a602e330913cfb563cd7bf03e/masters/master.chromium.linux/slaves.cfg
[modify] https://crrev.com/c02609da9da8cb2a602e330913cfb563cd7bf03e/masters/master.chromium.fyi/slaves.cfg
[modify] https://crrev.com/c02609da9da8cb2a602e330913cfb563cd7bf03e/scripts/slave/gatekeeper.json
[modify] https://crrev.com/c02609da9da8cb2a602e330913cfb563cd7bf03e/scripts/slave/recipe_modules/chromium_tests/chromium_fyi.py
[modify] https://crrev.com/c02609da9da8cb2a602e330913cfb563cd7bf03e/scripts/slave/recipe_modules/chromium_tests/chromium_linux.py
[modify] https://crrev.com/c02609da9da8cb2a602e330913cfb563cd7bf03e/scripts/slave/recipe_modules/chromium_tests/trybots.py

Blockedon: 805169

Comment 21 by kbr@chromium.org, Jan 24 2018

This bot's caused the Chromium tree to close:
https://ci.chromium.org/buildbot/chromium.linux/Ozone%20Linux/

Comment 22 by kbr@chromium.org, Jan 24 2018

Cc: hinoka@chromium.org efoo@chromium.org
Fixing mb_config.pyl in https://chromium-review.googlesource.com/882392 . Also, the bot needs to be added to the LUCI config files per instructions in https://chromium.googlesource.com/chromium/src/+/infra/config . I'll do that too.

Project Member

Comment 23 by bugdroid1@chromium.org, Jan 24 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d0421b0f77aad37c5bace0cf3081f64cf496e457

commit d0421b0f77aad37c5bace0cf3081f64cf496e457
Author: Kenneth Russell <kbr@chromium.org>
Date: Wed Jan 24 02:35:10 2018

Move "Ozone Linux" to chromium.linux in mb_config.pyl.

TBR=dpranke@chromium.org, jbudorick@chromium.org, timbrown@chromium.org
NOTRY=true
NOTREECHECKS=true

Bug:  694033 
Change-Id: I309538992960913a39ad827c96c043120d6915ee
Reviewed-on: https://chromium-review.googlesource.com/882392
Reviewed-by: Kenneth Russell <kbr@chromium.org>
Reviewed-by: Dirk Pranke <dpranke@chromium.org>
Commit-Queue: Kenneth Russell <kbr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#531405}
[modify] https://crrev.com/d0421b0f77aad37c5bace0cf3081f64cf496e457/tools/mb/mb_config.pyl

Comment 24 by kbr@chromium.org, Jan 24 2018

Adjusted the LUCI console in https://chromium-review.googlesource.com/882497 . Not sure whether bugdroid will link to that bug here.

Project Member

Comment 25 by bugdroid1@chromium.org, Jan 24 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/9dcd8a50be9b54ed785a24db76b3908da8be300f

commit 9dcd8a50be9b54ed785a24db76b3908da8be300f
Author: Antonio Gomes <tonikitoo@igalia.com>
Date: Wed Jan 24 11:51:53 2018

Raise linux_chromium_ozone_compile_ng cq experiment from 10% to 50%

Bot is stable over the past months.
BUG= 694033 

Change-Id: I2f383da545eb39c4745a7cb18e35473f7aa62300
Reviewed-on: https://chromium-review.googlesource.com/793472
Reviewed-by: Dirk Pranke <dpranke@chromium.org>
Commit-Queue: Antonio Gomes <tonikitoo@igalia.com>
Cr-Commit-Position: refs/heads/master@{#531503}
[modify] https://crrev.com/9dcd8a50be9b54ed785a24db76b3908da8be300f/infra/config/cq.cfg

Comment 26 by kbr@chromium.org, Jan 25 2018

Blockedon: 805764
Project Member

Comment 27 by bugdroid1@chromium.org, Jan 25 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/9544bf3c7cb0639977b7c56b6f9db1b272cef60b

commit 9544bf3c7cb0639977b7c56b6f9db1b272cef60b
Author: Xianzhu Wang <wangxianzhu@chromium.org>
Date: Thu Jan 25 02:06:15 2018

Revert "Raise linux_chromium_ozone_compile_ng cq experiment from 10% to 50%"

This reverts commit 9dcd8a50be9b54ed785a24db76b3908da8be300f.

Reason for revert: This overloads the slaves in the group.

Bug:  805771 

Original change's description:
> Raise linux_chromium_ozone_compile_ng cq experiment from 10% to 50%
>
> Bot is stable over the past months.
> BUG= 694033 
>
> Change-Id: I2f383da545eb39c4745a7cb18e35473f7aa62300
> Reviewed-on: https://chromium-review.googlesource.com/793472
> Reviewed-by: Dirk Pranke <dpranke@chromium.org>
> Commit-Queue: Antonio Gomes <tonikitoo@igalia.com>
> Cr-Commit-Position: refs/heads/master@{#531503}

TBR=dpranke@chromium.org,tonikitoo@igalia.com

Change-Id: Ifdca60a3a76c71c1433dca88a5bb278b9165c85a
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug:  694033 
Reviewed-on: https://chromium-review.googlesource.com/884556
Reviewed-by: Dirk Pranke <dpranke@chromium.org>
Reviewed-by: Xianzhu Wang <wangxianzhu@chromium.org>
Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#531783}
[modify] https://crrev.com/9544bf3c7cb0639977b7c56b6f9db1b272cef60b/infra/config/cq.cfg

Blockedon: 805771
Project Member

Comment 29 by bugdroid1@chromium.org, Feb 6 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/63ac398a34ea3ca78afb88367c07184bc1006e95

commit 63ac398a34ea3ca78afb88367c07184bc1006e95
Author: Dirk Pranke <dpranke@chromium.org>
Date: Tue Feb 06 23:30:40 2018

Bump linux_chromium_ozone_compile_only_ng to 50%.

This bumps the experimental builder to 50% and also
marks it as "compile_only", which means that we don't
include any debug symbols (this speeds up the build).

R=jbudorick@chromium.org
BUG= 694033 

Change-Id: I73713462395bcc360172883aa898af72c8a8ecd7
Reviewed-on: https://chromium-review.googlesource.com/898366
Reviewed-by: John Budorick <jbudorick@google.com>
Reviewed-by: John Budorick <jbudorick@chromium.org>
Commit-Queue: Dirk Pranke <dpranke@chromium.org>
Cr-Commit-Position: refs/heads/master@{#534832}
[modify] https://crrev.com/63ac398a34ea3ca78afb88367c07184bc1006e95/infra/config/cq.cfg
[modify] https://crrev.com/63ac398a34ea3ca78afb88367c07184bc1006e95/tools/mb/mb_config.pyl

Project Member

Comment 30 by bugdroid1@chromium.org, Feb 16 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b996d8755bfc31e41634de537cd9badf39f22da9

commit b996d8755bfc31e41634de537cd9badf39f22da9
Author: Dirk Pranke <dpranke@chromium.org>
Date: Fri Feb 16 23:16:57 2018

Bump linux_chromium_ozone_compile_only_ng to a 100% experiment.

It looks like we have plenty of capacity.

R=jbudorick@chromium.org
BUG= 694033 

Change-Id: I36c232b1a3fd3a91a501144630bf6ff7ec73a9dc
Reviewed-on: https://chromium-review.googlesource.com/920657
Reviewed-by: John Budorick <jbudorick@chromium.org>
Commit-Queue: Dirk Pranke <dpranke@chromium.org>
Cr-Commit-Position: refs/heads/master@{#537451}
[modify] https://crrev.com/b996d8755bfc31e41634de537cd9badf39f22da9/infra/config/cq.cfg

Status: Fixed (was: Assigned)
I think this is done now.
Project Member

Comment 32 by bugdroid1@chromium.org, Feb 21 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/4d0e622872afa498d355d9fd1b0060bd89b2b8a0

commit 4d0e622872afa498d355d9fd1b0060bd89b2b8a0
Author: Dirk Pranke <dpranke@chromium.org>
Date: Wed Feb 21 02:01:45 2018

Mark linux_chromium_ozone_compile_only_ng non-experimental in the CQ.

Promoting this from 100% experiment to full membership.

R=jbudorick@chromium.org
BUG= 694033 

Change-Id: I0b19fa84c8af049f415e2ebb2bc0c84595cca9fc
Reviewed-on: https://chromium-review.googlesource.com/927534
Reviewed-by: John Budorick <jbudorick@chromium.org>
Commit-Queue: Dirk Pranke <dpranke@chromium.org>
Cr-Commit-Position: refs/heads/master@{#537991}
[modify] https://crrev.com/4d0e622872afa498d355d9fd1b0060bd89b2b8a0/infra/config/cq.cfg

Sign in to add a comment