MPEG1 Audio: Incorrect condition for Level2 and valid combinations of bitrate and channels
Reported by
jirka.ra...@gmail.com,
Feb 19 2017
|
||||
Issue descriptionUserAgent: Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/56.0.2924.87 Safari/537.36 Example URL: https://cs.chromium.org/chromium/src/media/formats/mpeg/mpeg1_audio_stream_parser.cc?rcl=19142f86f469c28331a5a272595bbfb2392f0abd&l=141 Steps to reproduce the problem: 1. Look at Your source file mpeg1_audio_stream_parser.cc, line 141 2. Compare Your condition "if (layer == kLayer2 && kIsAllowed[bitrate_index][channel_mode])" to document http://mpgedit.org/mpgedit/mpeg_format/MP3Format.html, section "For Layer II there are some combinations of bitrate and mode which are not allowed. Here is a list of allowed combinations." 3. Based on this document is correct condition "if (layer == kLayer2 && !kIsAllowed[bitrate_index][channel_mode])" What is the expected behavior? Chrome can play MPEG audio Level without problem. What went wrong? Chrome can not play valid MPEG audio Level2. Did this work before? N/A Is it a problem with Flash or HTML5? HTML5 Does this work in other browsers? N/A Chrome version: 56.0.2924.87 Channel: stable OS Version: 10.0 Flash Version: Shockwave Flash 24.0 r0 Contents of chrome://gpu: Graphics Feature Status Canvas: Hardware accelerated Flash: Hardware accelerated Flash Stage3D: Hardware accelerated Flash Stage3D Baseline profile: Hardware accelerated Compositing: Hardware accelerated Multiple Raster Threads: Enabled Native GpuMemoryBuffers: Software only. Hardware acceleration disabled Rasterization: Software only. Hardware acceleration disabled Video Decode: Hardware accelerated Video Encode: Hardware accelerated VPx Video Decode: Software only, hardware acceleration unavailable WebGL: Hardware accelerated WebGL2: Hardware accelerated Driver Bug Workarounds clear_uniforms_before_first_program_use disable_discard_framebuffer disable_framebuffer_cmaa exit_on_context_lost force_cube_complete msaa_is_slow scalarize_vec_and_mat_constructor_args texsubimage_faster_than_teximage Problems Detected VPx decoding is too slow on Intel Broadwell, Skylake, and CherryView: 616318 Disabled Features: accelerated_vpx_decode Accelerated VPx decoding is hanging on some videos.: 654111 Disabled Features: accelerated_vpx_decode Some drivers are unable to reset the D3D device in the GPU process sandbox Applied Workarounds: exit_on_context_lost TexSubImage is faster for full uploads on ANGLE Applied Workarounds: texsubimage_faster_than_teximage Clear uniforms before first program use on all platforms: 124764, 349137 Applied Workarounds: clear_uniforms_before_first_program_use Always rewrite vec/mat constructors to be consistent: 398694 Applied Workarounds: scalarize_vec_and_mat_constructor_args ANGLE crash on glReadPixels from incomplete cube map texture: 518889 Applied Workarounds: force_cube_complete On Intel GPUs MSAA performance is not acceptable for GPU rasterization: 527565 Applied Workarounds: msaa_is_slow Framebuffer discarding can hurt performance on non-tilers: 570897 Applied Workarounds: disable_discard_framebuffer Limited enabling of Chromium GL_INTEL_framebuffer_CMAA: 535198 Applied Workarounds: disable_framebuffer_cmaa Accelerated rasterization has been disabled, either via blacklist, about:flags or the command line. Disabled Features: rasterization Native GpuMemoryBuffers have been disabled, either via about:flags or command line. Disabled Features: native_gpu_memory_buffers Version Information Data exported 19. 2. 2017 1:01:06 Chrome version Chrome/56.0.2924.87 Operating system Windows NT 10.0.14393 Software rendering list version 12.06 Driver bug list version 9.24 ANGLE commit id a4aaa2de57dc 2D graphics backend Skia/56 bf2d9e02d58ea01f1c239f7e2fc024cba140ccb1 Command Line Args --flag-switches-begin --flag-switches-end Driver Information Initialization time 106 In-process GPU false Sandboxed false GPU0 VENDOR = 0x8086, DEVICE= 0x191b *ACTIVE* GPU1 VENDOR = 0x10de, DEVICE= 0x139b Optimus false AMD switchable false Desktop compositing Aero Glass Diagonal Monitor Size of \\.\DISPLAY1 26.9" Driver vendor Intel Corporation Driver version 20.19.15.4331 Driver date 11-20-2015 Pixel shader version 5.0 Vertex shader version 5.0 Max. MSAA samples 16 Machine model name Machine model version GL_VENDOR Google Inc. GL_RENDERER ANGLE (Intel(R) HD Graphics 530 Direct3D11 vs_5_0 ps_5_0) GL_VERSION OpenGL ES 3.0 (ANGLE 2.1.0.a4aaa2de57dc) GL_EXTENSIONS GL_ANGLE_depth_texture GL_ANGLE_framebuffer_blit GL_ANGLE_framebuffer_multisample GL_ANGLE_instanced_arrays GL_ANGLE_lossy_etc_decode GL_ANGLE_pack_reverse_row_order GL_ANGLE_robust_client_memory GL_ANGLE_texture_compression_dxt3 GL_ANGLE_texture_compression_dxt5 GL_ANGLE_texture_usage GL_ANGLE_translated_shader_source GL_CHROMIUM_bind_generates_resource GL_CHROMIUM_bind_uniform_location GL_CHROMIUM_copy_compressed_texture GL_CHROMIUM_copy_texture GL_CHROMIUM_sync_query GL_EXT_blend_minmax GL_EXT_color_buffer_float GL_EXT_color_buffer_half_float GL_EXT_debug_marker GL_EXT_discard_framebuffer GL_EXT_disjoint_timer_query GL_EXT_draw_buffers GL_EXT_frag_depth GL_EXT_map_buffer_range GL_EXT_occlusion_query_boolean GL_EXT_read_format_bgra GL_EXT_robustness GL_EXT_sRGB GL_EXT_shader_texture_lod GL_EXT_texture_compression_dxt1 GL_EXT_texture_filter_anisotropic GL_EXT_texture_format_BGRA8888 GL_EXT_texture_norm16 GL_EXT_texture_rg GL_EXT_texture_storage GL_EXT_unpack_subimage GL_KHR_debug GL_NV_EGL_stream_consumer_external GL_NV_fence GL_NV_pack_subimage GL_NV_pixel_buffer_object GL_OES_EGL_image GL_OES_EGL_image_external GL_OES_EGL_image_external_essl3 GL_OES_compressed_ETC1_RGB8_texture GL_OES_depth32 GL_OES_element_index_uint GL_OES_get_program_binary GL_OES_mapbuffer GL_OES_packed_depth_stencil GL_OES_rgb8_rgba8 GL_OES_standard_derivatives GL_OES_texture_float GL_OES_texture_float_linear GL_OES_texture_half_float GL_OES_texture_half_float_linear GL_OES_texture_npot GL_OES_vertex_array_object Disabled Extensions Window system binding vendor Google Inc. (adapter LUID: 0000000000009a03) Window system binding version 1.4 (ANGLE 2.1.0.a4aaa2de57dc) Window system binding extensions EGL_EXT_create_context_robustness EGL_ANGLE_d3d_share_handle_client_buffer EGL_ANGLE_d3d_texture_client_buffer EGL_ANGLE_surface_d3d_texture_2d_share_handle EGL_ANGLE_query_surface_pointer EGL_ANGLE_window_fixed_size EGL_ANGLE_keyed_mutex EGL_ANGLE_surface_orientation EGL_ANGLE_direct_composition EGL_NV_post_sub_buffer EGL_KHR_create_context EGL_EXT_device_query EGL_KHR_image EGL_KHR_image_base EGL_KHR_gl_texture_2D_image EGL_KHR_gl_texture_cubemap_image EGL_KHR_gl_renderbuffer_image EGL_KHR_get_all_proc_addresses EGL_KHR_stream EGL_KHR_stream_consumer_gltexture EGL_NV_stream_consumer_gltexture_yuv EGL_ANGLE_flexible_surface_compatibility EGL_ANGLE_stream_producer_d3d_texture_nv12 EGL_ANGLE_create_context_webgl_compatibility EGL_CHROMIUM_create_context_bind_generates_resource Direct rendering Yes Reset notification strategy 0x8252 GPU process crash count 0 Compositor Information Tile Update Mode One-copy Partial Raster Enabled GpuMemoryBuffers Status ATC Software only ATCIA Software only DXT1 Software only DXT5 Software only ETC1 Software only R_8 Software only RG_88 Software only BGR_565 Software only RGBA_4444 Software only RGBX_8888 Software only RGBA_8888 Software only BGRX_8888 Software only BGRA_8888 Software only YVU_420 Software only YUV_420_BIPLANAR Software only UYVY_422 Software only Diagnostics 0 b3DAccelerationEnabled true b3DAccelerationExists true bAGPEnabled true bAGPExistenceValid true bAGPExists true bCanRenderWindow true bDDAccelerationEnabled true bDriverBeta false bDriverDebug false bDriverSigned false bDriverSignedValid false bNoHardware false dwBpp 32 dwDDIVersion 12 dwHeight 1440 dwRefreshRate 60 dwWHQLLevel 0 dwWidth 2560 iAdapter 0 lDriverSize 34397360 lMiniVddSize 0 szAGPStatusEnglish Enabled szAGPStatusLocalized Povoleno szChipType Intel(R) HD Graphics Family szD3DStatusEnglish Enabled szD3DStatusLocalized Povoleno szDACType Internal szDDIVersionEnglish 12 szDDIVersionLocalized 12 szDDStatusEnglish Enabled szDDStatusLocalized Povoleno szDXVAHDEnglish Supported szDXVAModes ModeMPEG2_A ModeMPEG2_C ModeWMV9_C ModeVC1_C szDescription Intel(R) HD Graphics 530 szDeviceId 0x191B szDeviceIdentifier {D7B78E66-5A5B-11CF-7363-EB26BAC2D935} szDeviceName \\.\DISPLAY1 szDisplayMemoryEnglish 4151 MB szDisplayMemoryLocalized 4151 MB szDisplayModeEnglish 2560 x 1440 (32 bit) (60Hz) szDisplayModeLocalized 2560 x 1440 (32 bit) (60Hz) szDriverAssemblyVersion 20.19.15.4331 szDriverAttributes Final Retail szDriverDateEnglish 20.11.2015 1:00:00 szDriverDateLocalized 11/20/2015 01:00:00 szDriverLanguageEnglish English szDriverLanguageLocalized Angličtina szDriverModelEnglish WDDM 2.0 szDriverModelLocalized WDDM 2.0 szDriverName igdumdim64.dll,igd10iumd64.dll,igd10iumd64.dll,igd12umd64.dll szDriverNodeStrongName oem11.inf:5f63e5340a14bf6c:iSKLD_w10:20.19.15.4331:pci\ven_8086&dev_191b&subsys_06e41028 szDriverSignDate Unknown szDriverVersion 20.19.0015.4331 szKeyDeviceID Enum\PCI\VEN_8086&DEV_191B&SUBSYS_06E41028&REV_06 szKeyDeviceKey \Registry\Machine\System\CurrentControlSet\Control\Video\{0A6316ED-7EDE-492D-AA76-F9334A900BEC}\0000 szManufacturer Intel Corporation szMiniVdd neznámý szMiniVddDateEnglish Unknown szMiniVddDateLocalized neznámý szMonitorMaxRes Unknown szMonitorName Generic PnP Monitor szNotesEnglish No problems found. szNotesLocalized Nebyly zjištěny žádné problémy. szOverlayEnglish Supported szRankOfInstalledDriver 00D10001 szRegHelpText Unknown szRevision Unknown szRevisionId 0x0006 szSubSysId 0x06E41028 szTestResultD3D7English Not run szTestResultD3D7Localized Není spuštěno szTestResultD3D8English Not run szTestResultD3D8Localized Není spuštěno szTestResultD3D9English Not run szTestResultD3D9Localized Není spuštěno szTestResultDDEnglish Not run szTestResultDDLocalized Není spuštěno szVdd neznámý szVendorId 0x8086 1 b3DAccelerationEnabled true b3DAccelerationExists true bAGPEnabled true bAGPExistenceValid false bAGPExists false bCanRenderWindow false bDDAccelerationEnabled true bDriverBeta false bDriverDebug false bDriverSigned false bDriverSignedValid false bNoHardware false dwBpp 0 dwDDIVersion 12 dwHeight 0 dwRefreshRate 0 dwWHQLLevel 0 dwWidth 0 iAdapter 0 lDriverSize 17463992 lMiniVddSize 0 szAGPStatusEnglish Enabled szAGPStatusLocalized Povoleno szChipType GeForce GTX 960M szD3DStatusEnglish Enabled szD3DStatusLocalized Povoleno szDACType Integrated RAMDAC szDDIVersionEnglish 12 szDDIVersionLocalized 12 szDDStatusEnglish Enabled szDDStatusLocalized Povoleno szDXVAHDEnglish Unknown szDXVAModes Unknown szDescription NVIDIA GeForce GTX 960M szDeviceId 0x139B szDeviceIdentifier Unknown szDeviceName Unknown szDisplayMemoryEnglish 6042 MB szDisplayMemoryLocalized 6042 MB szDisplayModeEnglish Unknown szDisplayModeLocalized neznámý szDriverAssemblyVersion 10.18.13.6881 szDriverAttributes Final Retail szDriverDateEnglish 10.07.2016 1:00:00 szDriverDateLocalized 7/10/2016 01:00:00 szDriverLanguageEnglish English szDriverLanguageLocalized Angličtina szDriverModelEnglish WDDM 2.0 szDriverModelLocalized WDDM 2.0 szDriverName nvd3dumx.dll,nvwgf2umx.dll,nvwgf2umx.dll,nvwgf2umx.dll szDriverNodeStrongName oem10.inf:0f066de379c1b3f2:Section094:10.18.13.6881:pci\ven_10de&dev_139b&subsys_06e41028 szDriverSignDate Unknown szDriverVersion 10.18.0013.6881 szKeyDeviceID Enum\PCI\VEN_10DE&DEV_139B&SUBSYS_06E41028&REV_A2 szKeyDeviceKey Unknown szManufacturer NVIDIA szMiniVdd neznámý szMiniVddDateEnglish Unknown szMiniVddDateLocalized neznámý szMonitorMaxRes Unknown szMonitorName Unknown szNotesEnglish No problems found. szNotesLocalized Nebyly zjištěny žádné problémy. szOverlayEnglish Unknown szRankOfInstalledDriver 00D10001 szRegHelpText Unknown szRevision Unknown szRevisionId 0x00A2 szSubSysId 0x06E41028 szTestResultD3D7English Not run szTestResultD3D7Localized Není spuštěno szTestResultD3D8English Not run szTestResultD3D8Localized Není spuštěno szTestResultD3D9English Not run szTestResultD3D9Localized Není spuštěno szTestResultDDEnglish Not run szTestResultDDLocalized Není spuštěno szVdd neznámý szVendorId 0x10DE Log Messages GpuProcessHostUIShim: The GPU process exited normally. Everything is okay.
,
Feb 20 2017
This looks like out of scope for TE, hence adding the respective label for it to triage further.
,
Feb 21 2017
Thanks for the detailed report, since I wrote that code I'll take a look :)
,
Feb 22 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/333c4148fe97a5a5e9964b0e390edf2a3fb36cf7 commit 333c4148fe97a5a5e9964b0e390edf2a3fb36cf7 Author: dalecurtis <dalecurtis@chromium.org> Date: Wed Feb 22 18:22:09 2017 Fix mpeg-1 layer2 parsing typo. Path was rejecting all valid files and passing on all invalid ones :/ BUG= 693962 TEST=new unittest Review-Url: https://codereview.chromium.org/2705353002 Cr-Commit-Position: refs/heads/master@{#452136} [modify] https://crrev.com/333c4148fe97a5a5e9964b0e390edf2a3fb36cf7/media/formats/mpeg/mpeg1_audio_stream_parser.cc [modify] https://crrev.com/333c4148fe97a5a5e9964b0e390edf2a3fb36cf7/media/formats/mpeg/mpeg1_audio_stream_parser_unittest.cc [add] https://crrev.com/333c4148fe97a5a5e9964b0e390edf2a3fb36cf7/media/test/data/sfx.mp2
,
Feb 22 2017
|
||||
►
Sign in to add a comment |
||||
Comment 1 by ranjitkan@chromium.org
, Feb 20 2017