New issue
Advanced search Search tips

Issue 693953 link

Starred by 1 user

Issue metadata

Status: WontFix
Owner:
Closed: Dec 18
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug

Blocking:
issue 73362



Sign in to add a comment

Remove web_contents_sizer, and provide a WebContents API for setting the size.

Project Member Reported by m...@chromium.org, Feb 18 2017

Issue description

There's a utility function in chrome/browser/ui/web_contents_sizer.* that directly manipulates the native views on Aura/Mac/Android. Instead, this should be encapsulated in the WebContents.

There was one prior attempt to do this (https://codereview.chromium.org/2695093005/). However, that attempt broke some tests. This revealed that some callers of ResizeWebContents() are doing so *before* the main frame's RenderWidgetHostView is created. It was also not possible to fix this by having them provide an initial size in WebContents::CreateParams::initial_size because all of the desktop platform impls ignore this field (!).

Therefore, we need a solution where the size of the WebContents can be set by the embedder, and possibly before the main frame's RWHV is even created; and it needs to guarantee the RWHV is set to that size either immediately or upon creation.
 
Project Member

Comment 1 by sheriffbot@chromium.org, Feb 21 2018

Labels: Hotlist-Recharge-Cold
Status: Untriaged (was: Available)
This issue has been Available for over a year. If it's no longer important or seems unlikely to be fixed, please consider closing it out. If it is important, please re-triage the issue.

Sorry for the inconvenience if the bug really should have been left as Available. If you change it back, also remove the "Hotlist-Recharge-Cold" label.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

Comment 2 by m...@chromium.org, Feb 22 2018

Status: Available (was: Untriaged)
Status: Assigned (was: Available)
Labels: Hotlist-DesktopUIToolingRequired Hotlist-DesktopUIChecked
*** UI Mass Triage***

Status: WontFix (was: Assigned)
Still an issue, but nothing currently driving the need to fix it. Closing out...

Sign in to add a comment