Reduce dependency from Editor class |
||||
Issue descriptionFor better encapsulation and faster compilation, we should expose Editor API via LocalFrame. We can get rid of include "Editor.h" now: - FocusController.cpp doesn't use Editor. - SpellCheckerClientImpl.cpp doesn't use Editor. FrameLoader uses: - clear() in FrameLoader::clear() which has number of m_frame member reference can move to Frame::clear() - clearLastEditCommand() in commitProvisionalLoad(); I think we can get rid of this method and make Editor::clear() to clear m_lastEditCommand.
,
Feb 18 2017
For testing of getting rid of clarEditCommand() from commitProvisionLoad(),
we could have following layout test:
<div conttenteditable id="editor"></div>
<script>
const editor = document.getElementById('editor');
editor.focus();
document.execCommand('insertText', false, 'abc');
window.onload = function() {
editor.innerText = internals.lastEditCommand === 'insertText' ? 'PASS' : 'FAIL';
};
</script>
,
Feb 20 2017
Since "users" looks our customer in this site, changed tile.
,
Mar 31 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/a88e0c666a6779d12c8af4a32f02f468bf6904b8 commit a88e0c666a6779d12c8af4a32f02f468bf6904b8 Author: bhagirathi.s <bhagirathi.s@samsung.com> Date: Fri Mar 31 06:52:11 2017 Remove unused header editor.h Editor.h is included in FocusController.cpp and SpellCheckerClientImpl.cpp but not used. Removed it to reduce unnecessary dependency from editor class. BUG=693887 Review-Url: https://codereview.chromium.org/2782553003 Cr-Commit-Position: refs/heads/master@{#461061} [modify] https://crrev.com/a88e0c666a6779d12c8af4a32f02f468bf6904b8/third_party/WebKit/Source/core/page/FocusController.cpp [modify] https://crrev.com/a88e0c666a6779d12c8af4a32f02f468bf6904b8/third_party/WebKit/Source/web/SpellCheckerClientImpl.cpp
,
Apr 6 2018
This issue has been Available for over a year. If it's no longer important or seems unlikely to be fixed, please consider closing it out. If it is important, please re-triage the issue. Sorry for the inconvenience if the bug really should have been left as Available. For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Apr 18 2018
|
||||
►
Sign in to add a comment |
||||
Comment 1 by yosin@chromium.org
, Feb 18 2017