The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/5509091b50695c6a3a9a1967d3e2bc8df615863e

commit 5509091b50695c6a3a9a1967d3e2bc8df615863e
Author: tansell <tansell@chromium.org>
Date: Mon Feb 20 12:54:31 2017

WebKit LayoutTests needs more resources.

The webaudio/Panner/hrtf-database.html needs these two audio files,
otherwise it just times out. Bug  https://crbug.com/693838  logged.

BUG= 52475 , 693838 

Review-Url: https://codereview.chromium.org/2704863002
Cr-Commit-Position: refs/heads/master@{#451608}

[modify] https://crrev.com/5509091b50695c6a3a9a1967d3e2bc8df615863e/BUILD.gn

Does this also fix  issue 694321 ?

Per c#1, closing as fixed.

Hi rtoy,

My CL in c#1 is a work around and not the correct solution. The top level build file shouldn't be referencing random files under //third_party/WebKit/Source/platform/audio/resources/

Please update the build rules in //third_party/WebKit/Source/platform/audio/ to correctly reference the resources it needs/uses.

Thanks!

(Or alternative if these files are only needed for LayoutTests, move them into the LayoutTest directory.)

Need some guidance here.  Composite.flac is required by the HRTF panner (internally).  Composite.wav was the original version that was used to create the flac file.  The test is to ensure that the flac file produces EXACTLY the same audio data as the wav file.

What should be done?

Does "required by the HRTF panner (internally)" mean that you're compiling it into the binary?

If so, and if we *also* need to be able to read it during the test, then the change that landed is arguably good enough.

Alternatively, we could copy the file into LayoutTests/webaudio/resources and have some sort of presubmit check to ensure they stay up to date; the latter would probably be less surprising.

Yes, Composite.flac is referenced in some grd file.  Composite.wav is no referenced anywhere anymore, but we left it around to make sure they're consistent in case ffmpeg should change change the output of the flac file.

Ideally, we'd be able to test using just the panner, but that is really hard because Composite.flac gets loaded and modified and applied to audio, so it's not easy to tell if something changed (other than the output is slightly different from what it used to be).  Thus, we load both files for the test.

Maybe the best way is just copy these two files to the layout directory and use that to verify that the flac and wav files are identical.  We lose the connection to the actual usage, but we will be notified right away if something should change in decoding these files.

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/45c331005b44ee0528b6aaaf8b0fbc8ab249b567

commit 45c331005b44ee0528b6aaaf8b0fbc8ab249b567
Author: rtoy <rtoy@chromium.org>
Date: Thu Mar 09 20:33:52 2017

Copy HRTF files to webaudio/resources/hrtf

Don't reference the files in Source/platform/audio/resources from the
tests.  Copy them to webaudio/resources/hrtf.  And add a README to
indicate where these files came from.  The README in
platform/audio/resources already references this directory, so we're
all set.

Also removed the files from BUILD.gn, reverting the previous
change.

BUG= 693838 ,
TEST=hrtf-database.html

Review-Url: https://codereview.chromium.org/2741543002
Cr-Commit-Position: refs/heads/master@{#455853}

[modify] https://crrev.com/45c331005b44ee0528b6aaaf8b0fbc8ab249b567/BUILD.gn
[modify] https://crrev.com/45c331005b44ee0528b6aaaf8b0fbc8ab249b567/third_party/WebKit/LayoutTests/webaudio/Panner/hrtf-database.html
[add] https://crrev.com/45c331005b44ee0528b6aaaf8b0fbc8ab249b567/third_party/WebKit/LayoutTests/webaudio/resources/hrtf/Composite.flac
[add] https://crrev.com/45c331005b44ee0528b6aaaf8b0fbc8ab249b567/third_party/WebKit/LayoutTests/webaudio/resources/hrtf/Composite.wav
[add] https://crrev.com/45c331005b44ee0528b6aaaf8b0fbc8ab249b567/third_party/WebKit/LayoutTests/webaudio/resources/hrtf/README

Thank you!