Code health.
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/8c4ba287b0e85a33c6ec3a7a3d9007896f703cdb commit 8c4ba287b0e85a33c6ec3a7a3d9007896f703cdb Author: pfeldman <pfeldman@chromium.org> Date: Wed Feb 22 17:43:36 2017 DevTools: normalize native breakpoint names. BUG= 693803 Review-Url: https://codereview.chromium.org/2700263003 Cr-Commit-Position: refs/heads/master@{#452114} [modify] https://crrev.com/8c4ba287b0e85a33c6ec3a7a3d9007896f703cdb/third_party/WebKit/LayoutTests/inspector-protocol/debugger/domdebugger-setInnerHTML.html [modify] https://crrev.com/8c4ba287b0e85a33c6ec3a7a3d9007896f703cdb/third_party/WebKit/Source/core/dom/Document.cpp [modify] https://crrev.com/8c4ba287b0e85a33c6ec3a7a3d9007896f703cdb/third_party/WebKit/Source/core/dom/Element.cpp [modify] https://crrev.com/8c4ba287b0e85a33c6ec3a7a3d9007896f703cdb/third_party/WebKit/Source/core/dom/FrameRequestCallbackCollection.cpp [modify] https://crrev.com/8c4ba287b0e85a33c6ec3a7a3d9007896f703cdb/third_party/WebKit/Source/core/frame/DOMWindow.cpp [modify] https://crrev.com/8c4ba287b0e85a33c6ec3a7a3d9007896f703cdb/third_party/WebKit/Source/devtools/front_end/sources/EventListenerBreakpointsSidebarPane.js [modify] https://crrev.com/8c4ba287b0e85a33c6ec3a7a3d9007896f703cdb/third_party/WebKit/Source/modules/geolocation/Geolocation.cpp
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/c0ff4c0d40a8b9ab8ed809a446aa298450c23462 commit c0ff4c0d40a8b9ab8ed809a446aa298450c23462 Author: pfeldman <pfeldman@chromium.org> Date: Thu Feb 23 02:40:26 2017 DevTools: do not use RAII for sync native breakpoints, reuse AsyncTask where possible. BUG= 693803 Review-Url: https://codereview.chromium.org/2700293002 Cr-Commit-Position: refs/heads/master@{#452355} [modify] https://crrev.com/c0ff4c0d40a8b9ab8ed809a446aa298450c23462/third_party/WebKit/LayoutTests/inspector/sources/debugger-frameworks/frameworks-skip-break-program.html [modify] https://crrev.com/c0ff4c0d40a8b9ab8ed809a446aa298450c23462/third_party/WebKit/Source/bindings/core/v8/ScriptController.cpp [modify] https://crrev.com/c0ff4c0d40a8b9ab8ed809a446aa298450c23462/third_party/WebKit/Source/core/dom/Document.cpp [modify] https://crrev.com/c0ff4c0d40a8b9ab8ed809a446aa298450c23462/third_party/WebKit/Source/core/dom/Element.cpp [modify] https://crrev.com/c0ff4c0d40a8b9ab8ed809a446aa298450c23462/third_party/WebKit/Source/core/dom/FrameRequestCallbackCollection.cpp [modify] https://crrev.com/c0ff4c0d40a8b9ab8ed809a446aa298450c23462/third_party/WebKit/Source/core/frame/DOMTimer.cpp [modify] https://crrev.com/c0ff4c0d40a8b9ab8ed809a446aa298450c23462/third_party/WebKit/Source/core/frame/DOMTimerCoordinator.cpp [modify] https://crrev.com/c0ff4c0d40a8b9ab8ed809a446aa298450c23462/third_party/WebKit/Source/core/frame/DOMWindow.cpp [modify] https://crrev.com/c0ff4c0d40a8b9ab8ed809a446aa298450c23462/third_party/WebKit/Source/core/inspector/BUILD.gn [modify] https://crrev.com/c0ff4c0d40a8b9ab8ed809a446aa298450c23462/third_party/WebKit/Source/core/inspector/InspectorInstrumentation.cpp [modify] https://crrev.com/c0ff4c0d40a8b9ab8ed809a446aa298450c23462/third_party/WebKit/Source/core/inspector/InspectorInstrumentation.h [modify] https://crrev.com/c0ff4c0d40a8b9ab8ed809a446aa298450c23462/third_party/WebKit/Source/core/inspector/InspectorInstrumentationCustomInl.h [modify] https://crrev.com/c0ff4c0d40a8b9ab8ed809a446aa298450c23462/third_party/WebKit/Source/core/loader/DocumentLoader.cpp [modify] https://crrev.com/c0ff4c0d40a8b9ab8ed809a446aa298450c23462/third_party/WebKit/Source/devtools/front_end/sources/EventListenerBreakpointsSidebarPane.js [modify] https://crrev.com/c0ff4c0d40a8b9ab8ed809a446aa298450c23462/third_party/WebKit/Source/modules/geolocation/Geolocation.cpp [modify] https://crrev.com/c0ff4c0d40a8b9ab8ed809a446aa298450c23462/third_party/WebKit/Source/modules/notifications/Notification.cpp
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/26664a7d9d2e37eeaaf5f565cb651a4f37c4e438 commit 26664a7d9d2e37eeaaf5f565cb651a4f37c4e438 Author: caseq <caseq@chromium.org> Date: Thu Feb 23 03:10:56 2017 Revert of DevTools: do not use RAII for sync native breakpoints, reuse AsyncTask where possible. (patchset #6 id:100001 of https://codereview.chromium.org/2700293002/ ) Reason for revert: This broke build according to #39 Original issue's description: > DevTools: do not use RAII for sync native breakpoints, reuse AsyncTask where possible. > > BUG= 693803 > > Review-Url: https://codereview.chromium.org/2700293002 > Cr-Commit-Position: refs/heads/master@{#452355} > Committed: https://chromium.googlesource.com/chromium/src/+/c0ff4c0d40a8b9ab8ed809a446aa298450c23462 TBR=kozyatinskiy@chromium.org,dgozman@chromium.org,alph@chromium.org,pfeldman@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG= 693803 Review-Url: https://codereview.chromium.org/2713613003 Cr-Commit-Position: refs/heads/master@{#452367} [modify] https://crrev.com/26664a7d9d2e37eeaaf5f565cb651a4f37c4e438/third_party/WebKit/LayoutTests/inspector/sources/debugger-frameworks/frameworks-skip-break-program.html [modify] https://crrev.com/26664a7d9d2e37eeaaf5f565cb651a4f37c4e438/third_party/WebKit/Source/bindings/core/v8/ScriptController.cpp [modify] https://crrev.com/26664a7d9d2e37eeaaf5f565cb651a4f37c4e438/third_party/WebKit/Source/core/dom/Document.cpp [modify] https://crrev.com/26664a7d9d2e37eeaaf5f565cb651a4f37c4e438/third_party/WebKit/Source/core/dom/Element.cpp [modify] https://crrev.com/26664a7d9d2e37eeaaf5f565cb651a4f37c4e438/third_party/WebKit/Source/core/dom/FrameRequestCallbackCollection.cpp [modify] https://crrev.com/26664a7d9d2e37eeaaf5f565cb651a4f37c4e438/third_party/WebKit/Source/core/frame/DOMTimer.cpp [modify] https://crrev.com/26664a7d9d2e37eeaaf5f565cb651a4f37c4e438/third_party/WebKit/Source/core/frame/DOMTimerCoordinator.cpp [modify] https://crrev.com/26664a7d9d2e37eeaaf5f565cb651a4f37c4e438/third_party/WebKit/Source/core/frame/DOMWindow.cpp [modify] https://crrev.com/26664a7d9d2e37eeaaf5f565cb651a4f37c4e438/third_party/WebKit/Source/core/inspector/BUILD.gn [modify] https://crrev.com/26664a7d9d2e37eeaaf5f565cb651a4f37c4e438/third_party/WebKit/Source/core/inspector/InspectorInstrumentation.cpp [modify] https://crrev.com/26664a7d9d2e37eeaaf5f565cb651a4f37c4e438/third_party/WebKit/Source/core/inspector/InspectorInstrumentation.h [modify] https://crrev.com/26664a7d9d2e37eeaaf5f565cb651a4f37c4e438/third_party/WebKit/Source/core/inspector/InspectorInstrumentationCustomInl.h [modify] https://crrev.com/26664a7d9d2e37eeaaf5f565cb651a4f37c4e438/third_party/WebKit/Source/core/loader/DocumentLoader.cpp [modify] https://crrev.com/26664a7d9d2e37eeaaf5f565cb651a4f37c4e438/third_party/WebKit/Source/devtools/front_end/sources/EventListenerBreakpointsSidebarPane.js [modify] https://crrev.com/26664a7d9d2e37eeaaf5f565cb651a4f37c4e438/third_party/WebKit/Source/modules/geolocation/Geolocation.cpp [modify] https://crrev.com/26664a7d9d2e37eeaaf5f565cb651a4f37c4e438/third_party/WebKit/Source/modules/notifications/Notification.cpp
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/fbd566a07bb73d4321780c44ac5ed0fb2ef342e0 commit fbd566a07bb73d4321780c44ac5ed0fb2ef342e0 Author: pfeldman <pfeldman@chromium.org> Date: Thu Feb 23 23:17:11 2017 DevTools: do not use RAII for sync native breakpoints, reuse AsyncTask where possible. BUG= 693803 Review-Url: https://codereview.chromium.org/2700293002 Cr-Original-Commit-Position: refs/heads/master@{#452355} Committed: https://chromium.googlesource.com/chromium/src/+/c0ff4c0d40a8b9ab8ed809a446aa298450c23462 Review-Url: https://codereview.chromium.org/2700293002 Cr-Commit-Position: refs/heads/master@{#452667} [modify] https://crrev.com/fbd566a07bb73d4321780c44ac5ed0fb2ef342e0/third_party/WebKit/LayoutTests/inspector/sources/debugger-frameworks/frameworks-skip-break-program.html [modify] https://crrev.com/fbd566a07bb73d4321780c44ac5ed0fb2ef342e0/third_party/WebKit/Source/bindings/core/v8/ScriptController.cpp [modify] https://crrev.com/fbd566a07bb73d4321780c44ac5ed0fb2ef342e0/third_party/WebKit/Source/core/dom/Document.cpp [modify] https://crrev.com/fbd566a07bb73d4321780c44ac5ed0fb2ef342e0/third_party/WebKit/Source/core/dom/Element.cpp [modify] https://crrev.com/fbd566a07bb73d4321780c44ac5ed0fb2ef342e0/third_party/WebKit/Source/core/dom/FrameRequestCallbackCollection.cpp [modify] https://crrev.com/fbd566a07bb73d4321780c44ac5ed0fb2ef342e0/third_party/WebKit/Source/core/frame/DOMTimer.cpp [modify] https://crrev.com/fbd566a07bb73d4321780c44ac5ed0fb2ef342e0/third_party/WebKit/Source/core/frame/DOMTimerCoordinator.cpp [modify] https://crrev.com/fbd566a07bb73d4321780c44ac5ed0fb2ef342e0/third_party/WebKit/Source/core/frame/DOMWindow.cpp [modify] https://crrev.com/fbd566a07bb73d4321780c44ac5ed0fb2ef342e0/third_party/WebKit/Source/core/inspector/BUILD.gn [modify] https://crrev.com/fbd566a07bb73d4321780c44ac5ed0fb2ef342e0/third_party/WebKit/Source/core/inspector/InspectorInstrumentation.cpp [modify] https://crrev.com/fbd566a07bb73d4321780c44ac5ed0fb2ef342e0/third_party/WebKit/Source/core/inspector/InspectorInstrumentation.h [modify] https://crrev.com/fbd566a07bb73d4321780c44ac5ed0fb2ef342e0/third_party/WebKit/Source/core/inspector/InspectorInstrumentationCustomInl.h [modify] https://crrev.com/fbd566a07bb73d4321780c44ac5ed0fb2ef342e0/third_party/WebKit/Source/core/loader/DocumentLoader.cpp [modify] https://crrev.com/fbd566a07bb73d4321780c44ac5ed0fb2ef342e0/third_party/WebKit/Source/devtools/front_end/sources/EventListenerBreakpointsSidebarPane.js [modify] https://crrev.com/fbd566a07bb73d4321780c44ac5ed0fb2ef342e0/third_party/WebKit/Source/modules/geolocation/Geolocation.cpp [modify] https://crrev.com/fbd566a07bb73d4321780c44ac5ed0fb2ef342e0/third_party/WebKit/Source/modules/notifications/Notification.cpp
Comment 1 by bugdroid1@chromium.org
, Feb 22 2017