New issue
Advanced search Search tips

Issue 693801 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Apr 2017
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: ----
Type: ----



Sign in to add a comment

[Component Request] UI>Browser>Previews

Project Member Reported by bengr@chromium.org, Feb 18 2017

Issue description

1] Component Name: UI>Browser>Previews

Guideline 1 (Clarity): Component name should be descriptive beyond the core
project team
(i.e. please avoid using non-industry standard abbreviations, code words,
project names, etc...)

Guideline 2 (Permanence): Component names should describe features/
functions and not team names, code locations, etc..., which are more
subject to change and make the hierarchy less predictable for people
triaging issues.

Guideline 3 (Specific): Components are meant to explicitly track functional
work areas.  If you are trying to track a Proj(ect) or an on-going effort
(e.g. Hotlist-Conops), please instead request a label for a (Proj- or
Hotlist-)

Guideline 4 (Discoverable/ Predictable): Components should be parented
where people would logically expect to find them (i.e. follow product
decomposition when naming versus team decomposition)

2] Parent Component (e.g. Blink, UI>Browser, etc...): UI>Browser

Note: We generally avoid creating new component namespaces, unless there is
a new hierarchy that needs to be expressed.  Please try and use existing
components as parents.

3] Description of Component: Work on the collection of page transformation techniques that signficantly improve load performance or data efficiency, at the possible cost of decreased fidelity.

4] Admin/ Owner: bengr@chromium.org

5] Please specify what triage practices will be followed for the component
(i.e. what team will do it and how frequently).

I will triage issues several times a week, with tbansal@, ryansturm@, megjablon@, and sclittle@ as backup.



 

Comment 1 by ojan@chromium.org, Feb 18 2017

We crossed streams a bit. Most of the code changes for this will be in Blink, so I'd have a preference for Blink>Previews. Ben, sounds like you're fine with either one?

Comment 2 by bengr@chromium.org, Feb 21 2017

Ojan and I chatted offline about this. Since a lot of the code will be outside of Blink, and because Previews is tightly coupled to a UI component, let's stay with UI>Browser>Previews. Issues that also involve Blink will have the relevant Blink component listed as well. 

Comment 3 by sshru...@google.com, Feb 25 2017

Owner: sshruthi@chromium.org
Status: Started (was: Untriaged)

Comment 4 by sshru...@google.com, Feb 25 2017

Done. Please verify and close.

Comment 5 by laforge@google.com, Feb 28 2017

@Shruthi - Thanks for adding.

To the requestor - Is Previews a user visible/ identifiable feature?  This seems like something that would more appropriate under Blink>Internals.
Owner: bengr@chromium.org
bengr@, thoughts on laforge's question in c#5?

Comment 7 by bengr@chromium.org, Mar 15 2017

Yes, Previews is user visible. Whenever we show a preview, we also show an Infobar that says we've made the page faster/leaner, along with a link to show the original version of the page. Also, only parts of our implementation are in Blink, so Blink> doesn't seem quite right.
Status: Fixed (was: Started)
Sounds good.

Sign in to add a comment