NavigationManager should encapsulate VisibleItem for accessing IsOverridingUserAgent() and SetIsOverridingUserAgent() |
||
Issue descriptionTo access IsOverridingUserAgent() and SetIsOverridingUserAgent() of visible item. Instead of doing: web::NavigationItemImpl* visible_item = navigation_manager->GetVisibleItem(); visible_item->SetIsOverridingUserAgent(true); We should do: navigation_manager->SetUseDesktopUserAgent(true); where we encapsulate visible item to provide one more layer of abstraction.
,
Mar 17 2017
It turns out this approach is error prone, so won't fix. |
||
►
Sign in to add a comment |
||
Comment 1 by liaoyuke@chromium.org
, Feb 18 2017