New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 693798 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: Feb 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 1
Type: Bug



Sign in to add a comment

"benchmarks.system_health_smoke_test.SystemHealthBenchmarkSmokeTest.system_health.memory_desktop.browse:news:reddit" is flaky

Project Member Reported by chromium...@appspot.gserviceaccount.com, Feb 18 2017

Issue description

"benchmarks.system_health_smoke_test.SystemHealthBenchmarkSmokeTest.system_health.memory_desktop.browse:news:reddit" is flaky.

This issue was created automatically by the chromium-try-flakes app. Please find the right owner to fix the respective test/step and assign this issue to them. If the step/test is infrastructure-related, please add Infra-Troopers label and change issue status to Untriaged. When done, please remove the issue from Sheriff Bug Queue by removing the Sheriff-Chromium label.

We have detected 6 recent flakes. List of all flakes can be found at https://chromium-try-flakes.appspot.com/all_flake_occurrences?key=ahVzfmNocm9taXVtLXRyeS1mbGFrZXNyfQsSBUZsYWtlInJiZW5jaG1hcmtzLnN5c3RlbV9oZWFsdGhfc21va2VfdGVzdC5TeXN0ZW1IZWFsdGhCZW5jaG1hcmtTbW9rZVRlc3Quc3lzdGVtX2hlYWx0aC5tZW1vcnlfZGVza3RvcC5icm93c2U6bmV3czpyZWRkaXQM.

Flaky tests should be disabled within 30 minutes unless culprit CL is found and reverted. Please see more details here: https://sites.google.com/a/chromium.org/dev/developers/tree-sheriffs/sheriffing-bug-queues#triaging-auto-filed-flakiness-bugs
 

Comment 1 by fdoray@chromium.org, Feb 21 2017

Owner: altimin@chromium.org
Status: Assigned (was: Untriaged)
First failure seen on Feb 16. Suspecting https://codereview.chromium.org/2696833002
Cc: altimin@chromium.org
Owner: alexclarke@chromium.org
I believe that it is again a side-effect of https://codereview.chromium.org/2572893002/. Alex, can you take a look?
This will get fixed by https://codereview.chromium.org/2708963002/
Project Member

Comment 4 by bugdroid1@chromium.org, Feb 22 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/85ed9bafd675dc129eebb238ac3c679d436e5d40

commit 85ed9bafd675dc129eebb238ac3c679d436e5d40
Author: alexclarke <alexclarke@chromium.org>
Date: Wed Feb 22 11:46:17 2017

Fix potential DCHECK in TaskQueueThrottler::IncreaseThrottleRefCount

If TaskQueueThrottler::IncreaseThrottleRefCount was called on a
disabled task queue whose next task was delayed, then a DCHECK in
OnTimeDomainHasDelayedWork could fire.  This patch prevents that from
happening.

This may fix the cluster fuzz warning too.

BUG= 693096 ,  693798 

Review-Url: https://codereview.chromium.org/2708963002
Cr-Commit-Position: refs/heads/master@{#451999}

[modify] https://crrev.com/85ed9bafd675dc129eebb238ac3c679d436e5d40/third_party/WebKit/Source/platform/scheduler/base/task_queue_impl.cc
[modify] https://crrev.com/85ed9bafd675dc129eebb238ac3c679d436e5d40/third_party/WebKit/Source/platform/scheduler/renderer/task_queue_throttler.cc
[modify] https://crrev.com/85ed9bafd675dc129eebb238ac3c679d436e5d40/third_party/WebKit/Source/platform/scheduler/renderer/task_queue_throttler_unittest.cc

Status: Fixed (was: Assigned)

Sign in to add a comment