New issue
Advanced search Search tips

Issue 693795 link

Starred by 1 user
Status: Fixed
Owner:
xiaoche...@chromium.org
Closed: Feb 2017
Cc:
editing-dev@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug

Blocking:
issue 517298



Sign in to add a comment

editing/spelling/spellcheck-async-mutation.html is not well designed

Project Member Reported by xiaoche...@chromium.org, Feb 18 2017 
The test case is supposed to modified DOM at the time when SpellCheckRequest has been sent out from Blink, but not yet resolved.

However, the current implementation of the test modifies DOM at an incorrect timing, when the request is already resolved.
Project Member

Comment 1 by bugdroid1@chromium.org, Feb 24 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e7f1cb881be7f52498d58b21ea855a5db487a515

commit e7f1cb881be7f52498d58b21ea855a5db487a515
Author: xiaochengh <xiaochengh@chromium.org>
Date: Fri Feb 24 02:23:48 2017

Stop SpellChecker from adding marker when checking range is modified

This patch makes SpellChecker not to add spelling markers if the
checking range has been modified. It also modifies layout test
editing/spelling/spellcheck-async-mutation.html, which is supposed
to test behavior in such case but was incorrectly designed.

BUG= 693795 
TEST=editing/spelling/spellcheck-async-mutation.html

Review-Url: https://codereview.chromium.org/2711113004
Cr-Commit-Position: refs/heads/master@{#452719}

[delete] https://crrev.com/b1424a997d92b500ccd797d4ee690246e40182b4/third_party/WebKit/LayoutTests/editing/spelling/spellcheck-async-mutation-expected.txt
[modify] https://crrev.com/e7f1cb881be7f52498d58b21ea855a5db487a515/third_party/WebKit/LayoutTests/editing/spelling/spellcheck-async-mutation.html
[modify] https://crrev.com/e7f1cb881be7f52498d58b21ea855a5db487a515/third_party/WebKit/Source/core/editing/spellcheck/SpellChecker.cpp

Comment 2 by xiaoche...@chromium.org, Feb 24 2017

Labels: M-58
Status: Fixed (was: Assigned)
►

Sign in to add a comment