Refactoring NavigationItemImpl navigation initiation code |
||
Issue description1. enum class NavigationInitiationType should be in navigation_item_impl.h instead of navigation_manager_impl.h. 2. The default NavigationInitiationType value of navigation item should be RENDERER_INITIATED instead of USER_INITIATED because USER_INITIATED has higher permissions than RENDERER_INITIATED.
,
Feb 22 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/01ce4225edd03c523175bb2c6b6cf0af8d5e9c86 commit 01ce4225edd03c523175bb2c6b6cf0af8d5e9c86 Author: liaoyuke <liaoyuke@chromium.org> Date: Wed Feb 22 18:27:16 2017 Change navigation initiation type default value to RENDERER_INITIATED This CL changes the default value of navigation initiation type to RENDERER_INITIATED because USER_INITIATED has higher permissions than RENDERER_INITIATED. BUG= 693789 Review-Url: https://codereview.chromium.org/2706173003 Cr-Commit-Position: refs/heads/master@{#452140} [modify] https://crrev.com/01ce4225edd03c523175bb2c6b6cf0af8d5e9c86/ios/web/navigation/navigation_item_impl.h [modify] https://crrev.com/01ce4225edd03c523175bb2c6b6cf0af8d5e9c86/ios/web/navigation/navigation_item_impl.mm [modify] https://crrev.com/01ce4225edd03c523175bb2c6b6cf0af8d5e9c86/ios/web/navigation/navigation_manager_impl.h
,
Feb 22 2017
|
||
►
Sign in to add a comment |
||
Comment 1 Deleted