New issue
Advanced search Search tips

Issue 693783 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Feb 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Mac
Pri: 3
Type: Bug



Sign in to add a comment

[Mac RTL] Reload button needs mirroring

Project Member Reported by avi@google.com, Feb 17 2017

Issue description

I haven't yet figured out why the arrows work, but the reload button needs to be mirrored too.
 

Comment 1 by shrike@chromium.org, Feb 18 2017

Status: Assigned (was: Untriaged)
Project Member

Comment 2 by bugdroid1@chromium.org, Feb 23 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/1f70ddc9356fa9b1e2ec5f64c92ee09ba740bc41

commit 1f70ddc9356fa9b1e2ec5f64c92ee09ba740bc41
Author: lgrey <lgrey@chromium.org>
Date: Thu Feb 23 00:10:10 2017

[Mac] Flip toolbar button images in RTL

Just wastefully flipping everything instead of trying to get clever here
(but n = 5, so...)

BUG= 693783 

Review-Url: https://codereview.chromium.org/2710123002
Cr-Commit-Position: refs/heads/master@{#452292}

[modify] https://crrev.com/1f70ddc9356fa9b1e2ec5f64c92ee09ba740bc41/chrome/browser/ui/cocoa/l10n_util.h
[modify] https://crrev.com/1f70ddc9356fa9b1e2ec5f64c92ee09ba740bc41/chrome/browser/ui/cocoa/l10n_util.mm
[modify] https://crrev.com/1f70ddc9356fa9b1e2ec5f64c92ee09ba740bc41/chrome/browser/ui/cocoa/toolbar/toolbar_button_cocoa.mm

Comment 3 by lgrey@chromium.org, Feb 23 2017

Status: Fixed (was: Assigned)
Confirmed in Canary

Sign in to add a comment