New issue
Advanced search Search tips

Issue 693735 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Feb 2017
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

Remove unneeded entries from WindowWebAudio.idl

Project Member Reported by rtoy@chromium.org, Feb 17 2017

Issue description

I don't think the attributes in WindowWebAudio.idl are needed anymore.  The use counters for the constructors were updated to use Measure.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Feb 27 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/9f058d69c1820c58ca8df07865b7021e5ba3030f

commit 9f058d69c1820c58ca8df07865b7021e5ba3030f
Author: rtoy <rtoy@chromium.org>
Date: Mon Feb 27 18:12:00 2017

Remove unnecessary window WebAudio attributes

These attributes were added to measure the usage of the new WebAudio constructors.  This has been replaced with a different scheme using the IDL files to specify measurement.

Thus, these are obsolete and should be removed.  The corresponding UseCounter entries are also removed.

BUG= 693735 
TEST=none

Review-Url: https://codereview.chromium.org/2700233003
Cr-Commit-Position: refs/heads/master@{#453259}

[modify] https://crrev.com/9f058d69c1820c58ca8df07865b7021e5ba3030f/third_party/WebKit/Source/core/frame/UseCounter.h
[modify] https://crrev.com/9f058d69c1820c58ca8df07865b7021e5ba3030f/third_party/WebKit/Source/modules/modules_idl_files.gni
[delete] https://crrev.com/2b7b343f00720cb53ac5b10918125037ee03deb0/third_party/WebKit/Source/modules/webaudio/DOMWindowWebAudio.h
[delete] https://crrev.com/2b7b343f00720cb53ac5b10918125037ee03deb0/third_party/WebKit/Source/modules/webaudio/WindowWebAudio.idl

Project Member

Comment 2 by bugdroid1@chromium.org, Feb 27 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/9f058d69c1820c58ca8df07865b7021e5ba3030f

commit 9f058d69c1820c58ca8df07865b7021e5ba3030f
Author: rtoy <rtoy@chromium.org>
Date: Mon Feb 27 18:12:00 2017

Remove unnecessary window WebAudio attributes

These attributes were added to measure the usage of the new WebAudio constructors.  This has been replaced with a different scheme using the IDL files to specify measurement.

Thus, these are obsolete and should be removed.  The corresponding UseCounter entries are also removed.

BUG= 693735 
TEST=none

Review-Url: https://codereview.chromium.org/2700233003
Cr-Commit-Position: refs/heads/master@{#453259}

[modify] https://crrev.com/9f058d69c1820c58ca8df07865b7021e5ba3030f/third_party/WebKit/Source/core/frame/UseCounter.h
[modify] https://crrev.com/9f058d69c1820c58ca8df07865b7021e5ba3030f/third_party/WebKit/Source/modules/modules_idl_files.gni
[delete] https://crrev.com/2b7b343f00720cb53ac5b10918125037ee03deb0/third_party/WebKit/Source/modules/webaudio/DOMWindowWebAudio.h
[delete] https://crrev.com/2b7b343f00720cb53ac5b10918125037ee03deb0/third_party/WebKit/Source/modules/webaudio/WindowWebAudio.idl

Project Member

Comment 3 by bugdroid1@chromium.org, Feb 27 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/9f058d69c1820c58ca8df07865b7021e5ba3030f

commit 9f058d69c1820c58ca8df07865b7021e5ba3030f
Author: rtoy <rtoy@chromium.org>
Date: Mon Feb 27 18:12:00 2017

Remove unnecessary window WebAudio attributes

These attributes were added to measure the usage of the new WebAudio constructors.  This has been replaced with a different scheme using the IDL files to specify measurement.

Thus, these are obsolete and should be removed.  The corresponding UseCounter entries are also removed.

BUG= 693735 
TEST=none

Review-Url: https://codereview.chromium.org/2700233003
Cr-Commit-Position: refs/heads/master@{#453259}

[modify] https://crrev.com/9f058d69c1820c58ca8df07865b7021e5ba3030f/third_party/WebKit/Source/core/frame/UseCounter.h
[modify] https://crrev.com/9f058d69c1820c58ca8df07865b7021e5ba3030f/third_party/WebKit/Source/modules/modules_idl_files.gni
[delete] https://crrev.com/2b7b343f00720cb53ac5b10918125037ee03deb0/third_party/WebKit/Source/modules/webaudio/DOMWindowWebAudio.h
[delete] https://crrev.com/2b7b343f00720cb53ac5b10918125037ee03deb0/third_party/WebKit/Source/modules/webaudio/WindowWebAudio.idl

Project Member

Comment 4 by bugdroid1@chromium.org, Feb 27 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/9f058d69c1820c58ca8df07865b7021e5ba3030f

commit 9f058d69c1820c58ca8df07865b7021e5ba3030f
Author: rtoy <rtoy@chromium.org>
Date: Mon Feb 27 18:12:00 2017

Remove unnecessary window WebAudio attributes

These attributes were added to measure the usage of the new WebAudio constructors.  This has been replaced with a different scheme using the IDL files to specify measurement.

Thus, these are obsolete and should be removed.  The corresponding UseCounter entries are also removed.

BUG= 693735 
TEST=none

Review-Url: https://codereview.chromium.org/2700233003
Cr-Commit-Position: refs/heads/master@{#453259}

[modify] https://crrev.com/9f058d69c1820c58ca8df07865b7021e5ba3030f/third_party/WebKit/Source/core/frame/UseCounter.h
[modify] https://crrev.com/9f058d69c1820c58ca8df07865b7021e5ba3030f/third_party/WebKit/Source/modules/modules_idl_files.gni
[delete] https://crrev.com/2b7b343f00720cb53ac5b10918125037ee03deb0/third_party/WebKit/Source/modules/webaudio/DOMWindowWebAudio.h
[delete] https://crrev.com/2b7b343f00720cb53ac5b10918125037ee03deb0/third_party/WebKit/Source/modules/webaudio/WindowWebAudio.idl

Project Member

Comment 5 by bugdroid1@chromium.org, Feb 27 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/9f058d69c1820c58ca8df07865b7021e5ba3030f

commit 9f058d69c1820c58ca8df07865b7021e5ba3030f
Author: rtoy <rtoy@chromium.org>
Date: Mon Feb 27 18:12:00 2017

Remove unnecessary window WebAudio attributes

These attributes were added to measure the usage of the new WebAudio constructors.  This has been replaced with a different scheme using the IDL files to specify measurement.

Thus, these are obsolete and should be removed.  The corresponding UseCounter entries are also removed.

BUG= 693735 
TEST=none

Review-Url: https://codereview.chromium.org/2700233003
Cr-Commit-Position: refs/heads/master@{#453259}

[modify] https://crrev.com/9f058d69c1820c58ca8df07865b7021e5ba3030f/third_party/WebKit/Source/core/frame/UseCounter.h
[modify] https://crrev.com/9f058d69c1820c58ca8df07865b7021e5ba3030f/third_party/WebKit/Source/modules/modules_idl_files.gni
[delete] https://crrev.com/2b7b343f00720cb53ac5b10918125037ee03deb0/third_party/WebKit/Source/modules/webaudio/DOMWindowWebAudio.h
[delete] https://crrev.com/2b7b343f00720cb53ac5b10918125037ee03deb0/third_party/WebKit/Source/modules/webaudio/WindowWebAudio.idl

Project Member

Comment 6 by bugdroid1@chromium.org, Feb 27 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/9f058d69c1820c58ca8df07865b7021e5ba3030f

commit 9f058d69c1820c58ca8df07865b7021e5ba3030f
Author: rtoy <rtoy@chromium.org>
Date: Mon Feb 27 18:12:00 2017

Remove unnecessary window WebAudio attributes

These attributes were added to measure the usage of the new WebAudio constructors.  This has been replaced with a different scheme using the IDL files to specify measurement.

Thus, these are obsolete and should be removed.  The corresponding UseCounter entries are also removed.

BUG= 693735 
TEST=none

Review-Url: https://codereview.chromium.org/2700233003
Cr-Commit-Position: refs/heads/master@{#453259}

[modify] https://crrev.com/9f058d69c1820c58ca8df07865b7021e5ba3030f/third_party/WebKit/Source/core/frame/UseCounter.h
[modify] https://crrev.com/9f058d69c1820c58ca8df07865b7021e5ba3030f/third_party/WebKit/Source/modules/modules_idl_files.gni
[delete] https://crrev.com/2b7b343f00720cb53ac5b10918125037ee03deb0/third_party/WebKit/Source/modules/webaudio/DOMWindowWebAudio.h
[delete] https://crrev.com/2b7b343f00720cb53ac5b10918125037ee03deb0/third_party/WebKit/Source/modules/webaudio/WindowWebAudio.idl

Project Member

Comment 7 by bugdroid1@chromium.org, Feb 27 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/9f058d69c1820c58ca8df07865b7021e5ba3030f

commit 9f058d69c1820c58ca8df07865b7021e5ba3030f
Author: rtoy <rtoy@chromium.org>
Date: Mon Feb 27 18:12:00 2017

Remove unnecessary window WebAudio attributes

These attributes were added to measure the usage of the new WebAudio constructors.  This has been replaced with a different scheme using the IDL files to specify measurement.

Thus, these are obsolete and should be removed.  The corresponding UseCounter entries are also removed.

BUG= 693735 
TEST=none

Review-Url: https://codereview.chromium.org/2700233003
Cr-Commit-Position: refs/heads/master@{#453259}

[modify] https://crrev.com/9f058d69c1820c58ca8df07865b7021e5ba3030f/third_party/WebKit/Source/core/frame/UseCounter.h
[modify] https://crrev.com/9f058d69c1820c58ca8df07865b7021e5ba3030f/third_party/WebKit/Source/modules/modules_idl_files.gni
[delete] https://crrev.com/2b7b343f00720cb53ac5b10918125037ee03deb0/third_party/WebKit/Source/modules/webaudio/DOMWindowWebAudio.h
[delete] https://crrev.com/2b7b343f00720cb53ac5b10918125037ee03deb0/third_party/WebKit/Source/modules/webaudio/WindowWebAudio.idl

Comment 8 by rtoy@chromium.org, Feb 28 2017

Owner: rtoy@chromium.org
Status: Fixed (was: Available)

Sign in to add a comment