inspector-protocol/heap-profiler/ should not depend on extracted front end resources |
||
Issue descriptionThe tests inside inspector-protocol/heap-profiler/ fail with the following error; ---------------------- TypeError: HeapSnapshotWorker.HeapSnapshotLoader is not a constructor ---------------------- If the contents of third_party/WebKit/Source/devtools/front_end/ is not available. I've worked around this problem in https://codereview.chromium.org/2705653002/ but it seems bad that these tests depend on the contents of that directory rather than the compiled / output files found in out/ The files it seems to need are; src/third_party/WebKit/Source/devtools/front_end/common/TextUtils.js src/third_party/WebKit/Source/devtools/front_end/common/UIString.js src/third_party/WebKit/Source/devtools/front_end/heap_snapshot_model/HeapSnapshotModel.js src/third_party/WebKit/Source/devtools/front_end/heap_snapshot_worker/HeapSnapshot.js src/third_party/WebKit/Source/devtools/front_end/heap_snapshot_worker/HeapSnapshotLoader.js src/third_party/WebKit/Source/devtools/front_end/platform/utilities.js
,
Feb 18 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/2bf83ac0e39afbe323a7afe1bd89386ebda50034 commit 2bf83ac0e39afbe323a7afe1bd89386ebda50034 Author: tansell <tansell@chromium.org> Date: Sat Feb 18 04:01:14 2017 WebKit LayoutTests needs more resources. It needs the PerformanceTests directory. This should fix the following failures; * fast/harness/perftests/perf-runner-compute-statistics.html * fast/harness/perftests/runs-per-second-iterations.html * fast/harness/perftests/runs-per-second-log.html * fast/harness/perftests/measure-frame-time.html * fast/harness/perftests/measure-time.html Which are failing with; CONSOLE ERROR: line 66: Uncaught ReferenceError: PerfTestRunner is not defined It needs the extracted devtools resources (bug https://crbug.com/693723 created for this). This should fix the following failures; * inspector-protocol/heap-profiler/heap-samples-in-snapshot.html * inspector-protocol/heap-profiler/heap-snapshot-with-active-dom-object.html * inspector-protocol/heap-profiler/heap-snapshot-with-detached-dom-tree.html * inspector-protocol/heap-profiler/heap-snapshot-with-event-listener.html Which are failing with; TypeError: HeapSnapshotWorker.HeapSnapshotLoader is not a constructor BUG= 52475 , 693723 NOTRY=true Review-Url: https://codereview.chromium.org/2705653002 Cr-Commit-Position: refs/heads/master@{#451412} [modify] https://crrev.com/2bf83ac0e39afbe323a7afe1bd89386ebda50034/BUILD.gn [modify] https://crrev.com/2bf83ac0e39afbe323a7afe1bd89386ebda50034/third_party/WebKit/Source/devtools/BUILD.gn [modify] https://crrev.com/2bf83ac0e39afbe323a7afe1bd89386ebda50034/third_party/WebKit/public/BUILD.gn
,
Dec 15 2017
|
||
►
Sign in to add a comment |
||
Comment 1 by l...@chromium.org
, Feb 17 2017Owner: chenwilliam@chromium.org
Status: Assigned (was: Untriaged)