New issue
Advanced search Search tips

Issue 693721 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Feb 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Mac
Pri: 2
Type: Bug



Sign in to add a comment

ClangToTMac tester fails to symbolize stacks after framework bundling change

Project Member Reported by thakis@chromium.org, Feb 17 2017

Issue description

started here:

https://build.chromium.org/p/chromium.fyi/builders/ClangToTMac%20tester/builds/6534

  No minidump found via crashpad_database_util
  *************** BROWSER STANDARD OUTPUT ***************
  dyld: Library not loaded: @rpath/libbase.dylib
    Referenced from: /b/swarm_slave/w/irPUn7GO/out/Release/Chromium.app/Contents/Versions/58.0.3015.0/Chromium Framework.framework/Helpers/crashpad_handler
    Reason: image not found
  [0216/220704.258464:ERROR:file_io.cc(30)] read: expected 8, observed 0
  [13307:771:0216/220704.992556:ERROR:render_frame_impl.cc(522)] Intentionally crashing (with null pointer dereference) because user navigated to chrome://crash/
  Received signal 11 SEGV_MAPERR 000000000000
   [0x0001116f862c]
   [0x0001116f84e1]
   [0x7fff97d385aa]
   [0x000000000000]
   [0x0001142c5961]
   [0x0001142b2b58]
   [0x0001142a840b]
   [0x0001142a8287]
   [0x0001142a5a6b]
   [0x000112b021fb]
   [0x0001116f8f80]
   [0x00011997637c]
   [0x000119974492]
   [0x0001116f8f80]
   [0x00011172917b]
   [0x0001117294cc]
   [0x000111729903]
   [0x00011172c59a]
   [0x00011171a5da]
   [0x00011172bfd4]
   [0x7fff9872e5b1]
   [0x7fff9871fc62]
   [0x7fff9871f3ef]
   [0x7fff9871ee75]
   [0x7fff982710fc]
   [0x00011172ce4e]
   [0x00011172c41c]
   [0x000111728e4e]
   [0x000111754743]
   [0x0001143074cc]
   [0x0001144388d0]
   [0x000114437b16]
   [0x00010a68277b]
   [0x00010a647daa]
   [0x7fff937a85fd]
  [end of stack trace]
  
  *********** END OF BROWSER STANDARD OUTPUT ************
  ********************* BROWSER LOG *********************
  No log file
  ***************** END OF BROWSER LOG ******************
  Traceback (most recent call last):
    File "/b/swarm_slave/w/irPUn7GO/third_party/catapult/telemetry/telemetry/testing/browser_test_case.py", line 41, in WrappedMethod
      method(self)
    File "/b/swarm_slave/w/irPUn7GO/tools/perf/core/stacktrace_unittest.py", line 40, in testCrashMinimalSymbols
      '\n'.join(c.exception.stack_trace))
  AssertionError: 'PrepareRenderViewForNavigation' not found in 'No crash dump found.'
[18/26] measurements.smoothness_unittest.CustomResultsWrapperUnitTest.testOnlyOneInteractionRecordPerPage queued



First error looks like rpaths are wrong in component builds; also looks like stacks aren't symbolized, which then leads to the assertion.
 

Comment 1 by thakis@chromium.org, Feb 17 2017

Oh and first bad build contains  https://codereview.chromium.org/2700013002 which looks like likely culprit.

Comment 2 by thakis@chromium.org, Feb 17 2017

Components: Tests>Telemetry

Comment 3 by rsesek@chromium.org, Feb 17 2017

Labels: Build
Owner: rsesek@chromium.org
Status: Started (was: Untriaged)
I think the issue is just that crashpad_handler fails to start, which means a minidump doesn't get generated so the test cannot pass. With https://codereview.chromium.org/2704763002/ the test passes for me locally.
Project Member

Comment 4 by bugdroid1@chromium.org, Feb 18 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/91bfdf3e5fd8b4403f1a346552c0ad991c52913d

commit 91bfdf3e5fd8b4403f1a346552c0ad991c52913d
Author: rsesek <rsesek@chromium.org>
Date: Sat Feb 18 07:37:12 2017

[Mac] Fix crashpad_handler @rpath in the component build.

After versioning the framework in 247dfa7270288b09ff4ff433e616408102b51755b,
crashpad_handler would fail to start in a component build with this error:

dyld: Library not loaded: @rpath/libbase.dylib
  Referenced from:
  /Volumes/Build/src/out/debug/Chromium.app/Contents/Versions/58.0.3016.0/Chromium
  Framework.framework/Helpers/crashpad_handler
    Reason: image not found

BUG= 693721 , 662466 
R=mark@chromium.org

Review-Url: https://codereview.chromium.org/2704763002
Cr-Commit-Position: refs/heads/master@{#451441}

[modify] https://crrev.com/91bfdf3e5fd8b4403f1a346552c0ad991c52913d/build/secondary/third_party/crashpad/crashpad/handler/BUILD.gn

Sign in to add a comment