New issue
Advanced search Search tips

Issue 693718 link

Starred by 1 user

Issue metadata

Status: Duplicate
Merged: issue 694402
Owner:
Closed: Feb 2017
Cc:
EstimatedDays: ----
NextAction: ----
OS: Windows
Pri: 1
Type: Bug

Blocking:
issue 82385
issue 685244



Sign in to add a comment

CrWinAsan failing compile

Project Member Reported by thakis@chromium.org, Feb 17 2017

Issue description

https://build.chromium.org/p/chromium.fyi/builders/CrWinAsan/builds/4548/steps/compile/logs/stdio

FAILED: gen/v8/bytecode-peephole-table.cc 
C:/b/depot_tools/python276_bin/python.exe ../../v8/tools/run.py ./mkpeephole gen/v8/bytecode-peephole-table.cc
=================================================================
==3864==ERROR: AddressSanitizer: attempting free on address which was not malloc()-ed: 0x00ad01a0 in thread T0
    #0 0x2e3bda in free c:\b\c\b\crwinasan\src\third_party\llvm\projects\compiler-rt\lib\asan\asan_malloc_win.cc:45
    #1 0x6b110ba1 in ltoa+0x1a1 (C:\b\c\b\CrWinAsan\src\out\Release\ucrtbase.DLL+0x10030ba1)
    #2 0x77ba8e64 in RtlIsCurrentThreadAttachExempt+0x5e (C:\Windows\SysWOW64\ntdll.dll+0x7dea8e64)
    #3 0x77bc9d23 in LdrShutdownProcess+0x96 (C:\Windows\SysWOW64\ntdll.dll+0x7dec9d23)
    #4 0x77bc9c6f in RtlExitUserProcess+0x73 (C:\Windows\SysWOW64\ntdll.dll+0x7dec9c6f)
    #5 0x75f279dc in ExitProcess+0x14 (C:\Windows\syswow64\kernel32.dll+0x7dd779dc)
    #6 0x30a35f in exit_or_terminate_process d:\rs1\minkernel\crts\ucrt\src\appcrt\startup\exit.cpp:129
    #7 0x30a31d in common_exit d:\rs1\minkernel\crts\ucrt\src\appcrt\startup\exit.cpp:265
    #8 0x30a456 in exit d:\rs1\minkernel\crts\ucrt\src\appcrt\startup\exit.cpp:278
    #9 0x2fdcfe in __scrt_common_main_seh f:\dd\vctools\crt\vcstartup\src\startup\exe_common.inl:260
    #10 0x75f23379 in BaseThreadInitThunk+0x11 (C:\Windows\syswow64\kernel32.dll+0x7dd73379)
    #11 0x77ba92b1 in RtlInitializeExceptionChain+0x62 (C:\Windows\SysWOW64\ntdll.dll+0x7dea92b1)
    #12 0x77ba9284 in RtlInitializeExceptionChain+0x35 (C:\Windows\SysWOW64\ntdll.dll+0x7dea9284)

Address 0x00ad01a0 is a wild pointer.
SUMMARY: AddressSanitizer: bad-free c:\b\c\b\crwinasan\src\third_party\llvm\projects\compiler-rt\lib\asan\asan_malloc_win.cc:45 in free


Not 100% sure if this is due to a v8 change or an asan change, but asan feels more likely.

Bot's been red for 4 days now :-/
 
Owner: etienneb@chromium.org
Status: Assigned (was: Unconfirmed)
This is a known issue.
The patch is not yet landed
  https://reviews.llvm.org/D25946

And other fix for a bug with prevent_icf is also on it's way.
FYI: There are strings allocated within the CRT that are allocated before allocation functions can be hooked. ASAN won't have full coverage on this rare cases.

Comment 3 by thakis@chromium.org, Feb 17 2017

The bot used to be green. Did someone land upstream that regressed this?

Please always keep upstream trunk green. If something lands upstream that you know broke something, please revert first and fix later.
This was only failing on 64-bit?
If it's failing on a 32-bits, than the fix may be wrong.

Comment 5 by thakis@chromium.org, Feb 17 2017

That's a 32-bit bot.
ok. I'm gonna take a look to it.
Thx to report it.

Comment 7 by thakis@chromium.org, Feb 17 2017

(But maybe mkpeephole is a 64-bit host binary? Not sure. In any case, that bot used to be happy until 4 days ago.)

Comment 8 by r...@chromium.org, Feb 21 2017

Mergedinto: 694402
Status: Duplicate (was: Assigned)

Sign in to add a comment