Issue metadata
Sign in to add a comment
|
PasswordManagerBrowserTestBase.ShowFormNotSecureOnUsernameField failing in official builds |
||||||||||||||||||
Issue descriptione.g. https://build.chromium.org/p/chromium.fyi/builders/CrWinClang%20tester/builds/12259/steps/browser_tests/logs/PasswordManagerBrowserTestBase.ShowFormNotSecureOnUsernameField Not much information: PasswordManagerBrowserTestBase.ShowFormNotSecureOnUsernameField (run #1): [ RUN ] PasswordManagerBrowserTestBase.ShowFormNotSecureOnUsernameField [4656:4268:0217/113408.557:INFO:CONSOLE(0)] "This page includes a password or credit card input in a non-secure context. A warning has been added to the URL bar. For more information, see https://goo.gl/zmWq3m.", source: http://example.com:54039/password/password_form.html (0) [4656:6132:0217/113408.562:WARNING:embedded_test_server.cc(219)] Request not handled. Returning 404: /favicon.ico This bot happens to use clang/win, but it also does official builds. I'm guessing the test is just broken in official builds. Recent CL that's likely cause: https://codereview.chromium.org/2682473002
,
Feb 17 2017
Not sure if your comment 1 means "oh yes, will fix" or not :-) The test runs and fails on official bots and that does need fixing.
,
Feb 17 2017
,
Feb 17 2017
Issue 693762 has been merged into this issue.
,
Feb 17 2017
,
Feb 17 2017
Emergency at home means I won't get to this in the next few hours. The test can be disabled if needed.
,
Feb 18 2017
Hmm, looks like a timeout? Weird. Disabling in https://codereview.chromium.org/2701813003/ until we have time to investigate.
,
Feb 18 2017
Timeout occurs because the warning doesn't show and the dialog detection works by blocking on the appearance of the dialog. My theory is that the HttpFormWarning experiment is on for the CQ bots but not the official queues.
,
Feb 18 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/318b5ba71be0ccbf2bbc2f79d55af1d2b2d24f93 commit 318b5ba71be0ccbf2bbc2f79d55af1d2b2d24f93 Author: estark <estark@chromium.org> Date: Sat Feb 18 06:17:19 2017 Disable PasswordManagerBrowserTestBase.ShowFormNotSecureOnUsernameField Test is failing on official builds and no time to investigate quite yet. BUG= 693717 TBR=elawrence@chromium.org,thakis@chromium.org Review-Url: https://codereview.chromium.org/2701813003 Cr-Commit-Position: refs/heads/master@{#451424} [modify] https://crrev.com/318b5ba71be0ccbf2bbc2f79d55af1d2b2d24f93/chrome/browser/password_manager/password_manager_browsertest.cc
,
Feb 22 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/d844eb57169233599e3908198e4784236d2bce03 commit d844eb57169233599e3908198e4784236d2bce03 Author: elawrence <elawrence@chromium.org> Date: Wed Feb 22 13:23:02 2017 Enable HttpFormWarning feature for browser tests The HttpFormWarning is enabled by fieldtrial_testing_config.json but that configuration is not used by the official builders, causing the ShowFormNotSecureOnUsernameField browser test to fail when run on the builders. Explicitly enable the feature for the affected browser tests. BUG= 693717 Review-Url: https://codereview.chromium.org/2709703003 Cr-Commit-Position: refs/heads/master@{#452026} [modify] https://crrev.com/d844eb57169233599e3908198e4784236d2bce03/chrome/browser/password_manager/password_manager_browsertest.cc
,
Feb 22 2017
|
|||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||
Comment 1 by elawrence@chromium.org
, Feb 17 2017