New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 693708 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
not on Chrome anymore
Closed: Feb 2017
Cc:
EstimatedDays: ----
NextAction: ----
OS: Windows
Pri: 1
Type: Bug



Sign in to add a comment

WebglConformance video test failures on gpu fyi Win10 Debug (Intel HD 530)

Project Member Reported by fjhenigman@chromium.org, Feb 17 2017

Issue description

since https://build.chromium.org/p/chromium.gpu.fyi/builders/Win10%20Debug%20%28Intel%20HD%20530%29/builds/246

webgl_conformance_tests webgl_conformance_tests

failures:
WebglConformance_conformance_extensions_oes_texture_float_with_video
WebglConformance_conformance_extensions_oes_texture_half_float_with_video
WebglConformance_conformance_textures_image_bitmap_from_video_tex_2d_rgb_rgb_unsigned_byte
WebglConformance_conformance_textures_image_bitmap_from_video_tex_2d_rgb_rgb_unsigned_short_5_6_5
WebglConformance_conformance_textures_image_bitmap_from_video_tex_2d_rgba_rgba_unsigned_byte
WebglConformance_conformance_textures_image_bitmap_from_video_tex_2d_rgba_rgba_unsigned_short_4_4_4_4
WebglConformance_conformance_textures_image_bitmap_from_video_tex_2d_rgba_rgba_unsigned_short_5_5_5_1
WebglConformance_conformance_textures_misc_texture_npot_video
WebglConformance_conformance_textures_misc_texture_upload_size
WebglConformance_conformance_textures_video_tex_2d_rgb_rgb_unsigned_byte
WebglConformance_conformance_textures_video_tex_2d_rgb_rgb_unsigned_short_5_6_5
WebglConformance_conformance_textures_video_tex_2d_rgba_rgba_unsigned_byte
WebglConformance_conformance_textures_video_tex_2d_rgba_rgba_unsigned_short_4_4_4_4
WebglConformance_conformance_textures_video_tex_2d_rgba_rgba_unsigned_short_5_5_5_1


jmadill@ suggests reverting https://codereview.chromium.org/2696963002


 
Cc: jbau...@chromium.org
Labels: -Pri-2 GPU-Intel Pri-1
Status: Assigned (was: Untriaged)
Chris can you revert https://codereview.chromium.org/2696963002? Seems suspicious for video failures:

Replace IMFTransform with ID3D11VideoProcessor

As far as I can tell, ID3D11VideoProcessor is the only one that understands
how to convert HDR10 content into scRGB textures. A future change will enable
use of this in order to properly decode HDR content.

Hubbe, this bot is not run on the CQ, but is an important test because it represents most of our Windows users.
Yeah, looks like d3d11_device_context_ isn't initialized if share_nv12_textures_ is true, so that code crashes.
Cc: ccameron@chromium.org
Owner: jbau...@chromium.org
John, Chris doesn't seem to be available, can you handle the revert?
Project Member

Comment 4 by bugdroid1@chromium.org, Feb 17 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/4a1e5ced806c4452252e6531e50b3549b31f5f96

commit 4a1e5ced806c4452252e6531e50b3549b31f5f96
Author: jbauman <jbauman@chromium.org>
Date: Fri Feb 17 22:08:08 2017

Revert of Replace IMFTransform with ID3D11VideoProcessor (patchset #5 id:80001 of https://codereview.chromium.org/2696963002/ )

Reason for revert:
Crashes on Intel GPU drivers. e.g. https://build.chromium.org/p/chromium.gpu.fyi/builders/Win10%20Debug%20%28Intel%20HD%20530%29/builds/246

BUG= 693708 
TBR=hubbe@chromium.org

Original issue's description:
> Replace IMFTransform with ID3D11VideoProcessor
>
> As far as I can tell, ID3D11VideoProcessor is the only one that understands
> how to convert HDR10 content into scRGB textures. A future change will enable
> use of this in order to properly decode HDR content.
>
> BUG= 682416 
> CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
>
> Review-Url: https://codereview.chromium.org/2696963002
> Cr-Commit-Position: refs/heads/master@{#451192}
> Committed: https://chromium.googlesource.com/chromium/src/+/e3b65029f700b1bf7b218aaf00e0d8bfbb4aab48

TBR=ccameron@chromium.org,hubbe@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG= 682416 

Review-Url: https://codereview.chromium.org/2701933002
Cr-Commit-Position: refs/heads/master@{#451385}

[modify] https://crrev.com/4a1e5ced806c4452252e6531e50b3549b31f5f96/media/gpu/dxva_video_decode_accelerator_win.cc
[modify] https://crrev.com/4a1e5ced806c4452252e6531e50b3549b31f5f96/media/gpu/dxva_video_decode_accelerator_win.h
[modify] https://crrev.com/4a1e5ced806c4452252e6531e50b3549b31f5f96/ui/gfx/color_space_win.cc
[modify] https://crrev.com/4a1e5ced806c4452252e6531e50b3549b31f5f96/ui/gfx/color_space_win.h

Status: Fixed (was: Assigned)

Sign in to add a comment