New issue
Advanced search Search tips

Issue 693701 link

Starred by 2 users

Issue metadata

Status: Duplicate
Merged: issue 664048
Owner:
Closed: Feb 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Chrome , Mac
Pri: 1
Type: Bug

Blocking:
issue 671375
issue 684849



Sign in to add a comment

MD Settings: Prediction service toggle button reflects & sets wrong values

Project Member Reported by nparker@chromium.org, Feb 17 2017

Issue description

OS: 56.0.2924.87 linux
I couldn't repro on ToT since I didn't know how to show old settings there.

Repro:
* Open chrome://md-settings and chrome://settings in two tabs.
* Toggle "Use a prediction service to load pages more quickly" on /md-settings.  It doesn't show toggled on /settings. 
 

Comment 1 by dbeam@chromium.org, Feb 17 2017

don't look anywhere other than canary, IMO
Blocking: 671375 684849
Labels: -Pri-3 Proj-MaterialDesign-WebUI OS-Chrome OS-Mac OS-Windows Pri-1
Summary: MD Settings: Prediction service toggle button reflects & sets wrong values (was: One setting on /md-settings doesn't mirror /settings)
great catch, thanks. Repros on ToT. Old settings aka Options is always available at chrome://settings-frame.

SettingsBooleanControlBehavior assumes that 0 = "off" for numeric prefs, but "net.network_prediction_options" doesn't work this way. (We should check for others too.)

https://cs.chromium.org/chromium/src/chrome/browser/resources/options/browser_options.js?type=cs&q=networkPredictionOptions&sq=package:chromium&l=547

Comment 3 by dbeam@chromium.org, Feb 18 2017

Mergedinto: 664048
Status: Duplicate (was: Untriaged)

Sign in to add a comment