settings-dropdown-menu width calculated incorrectly |
||||||||||
Issue descriptionThe settings-dropdown-menu expands horizontally based on the width of the largest available item. Currently however it does not correctly take into consideration the width of the arrow in the right. This can be seen in the fonts dropdown menu or the timezone menu. (Other menus fit within the minimum dropdown width). This may be a paper-dropdown issue, or an issue with the way we embed paper-dropdown.
,
Apr 19 2017
It looks like this can be addressed with some minor tweaks to md_selec_css.html.
,
Apr 19 2017
@stevenjb a screenshot would be helpful determine whether this is a dupe of issue 710802 .
,
Apr 19 2017
It looks like it may be a dupe. I'll check to see if my changes affect issue 710802 . Screenshot attached.
,
Apr 19 2017
So the difference between this and issue 710802 is that issue only occurs for very large fonts, I have a fix for this that doesn't seem to impact issue 710802 , but see comment there.
,
Apr 19 2017
-> dpapad@ since this is related to issue 710802 .
,
Apr 19 2017
,
Apr 19 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/25e4011a30bc7e0cbb2912ea1fe47defefa606f8 commit 25e4011a30bc7e0cbb2912ea1fe47defefa606f8 Author: dpapad <dpapad@chromium.org> Date: Wed Apr 19 23:04:02 2017 WebUI: Fix calculation of md-select text and arrow spacing. Previous calculation was not properly taking into account the position of the arrow. New calculation ensures that there is always some white space between the arrow and the text. BUG= 693698 , 710802 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2825403003 Cr-Commit-Position: refs/heads/master@{#465800} [modify] https://crrev.com/25e4011a30bc7e0cbb2912ea1fe47defefa606f8/ui/webui/resources/html/md_select_css.html
,
Apr 19 2017
,
Apr 20 2017
,
Apr 20 2017
Your change meets the bar and is auto-approved for M59. Please go ahead and merge the CL to branch 3071 manually. Please contact milestone owner if you have questions. Owners: amineer@(Android), cmasso@(iOS), gkihumba@(ChromeOS), Abdul Syed@(Desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Apr 21 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/6eb1222c5a221fc570b5a2cee9e418c496a3b55a commit 6eb1222c5a221fc570b5a2cee9e418c496a3b55a Author: Lei Zhang <thestig@chromium.org> Date: Fri Apr 21 23:57:08 2017 M59: WebUI: Fix calculation of md-select text and arrow spacing. Previous calculation was not properly taking into account the position of the arrow. New calculation ensures that there is always some white space between the arrow and the text. BUG= 693698 , 710802 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2825403003 Cr-Commit-Position: refs/heads/master@{#465800} (cherry picked from commit 25e4011a30bc7e0cbb2912ea1fe47defefa606f8) Review-Url: https://codereview.chromium.org/2836763002 . Cr-Commit-Position: refs/branch-heads/3071@{#138} Cr-Branched-From: a106f0abbf69dad349d4aaf4bcc4f5d376dd2377-refs/heads/master@{#464641} [modify] https://crrev.com/6eb1222c5a221fc570b5a2cee9e418c496a3b55a/ui/webui/resources/html/md_select_css.html
,
May 8 2017
Chrome OS 9532.0.0, 60.0.3092.0 |
||||||||||
►
Sign in to add a comment |
||||||||||
Comment 1 by steve...@chromium.org
, Mar 1 2017