New issue
Advanced search Search tips

Issue 693692 link

Starred by 1 user

Issue metadata

Status: Assigned
Owner:
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux
Pri: 2
Type: Bug



Sign in to add a comment

When switching the decode cache we should retain pending decode requests

Project Member Reported by vmp...@chromium.org, Feb 17 2017

Issue description

Right now when we switch the decode cache, we cancel all of the pending requests. I think we can do better if we're going to get a new cache and re-generate the tasks when we get a new cache.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Feb 28 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f5cbd80af75b987838cd8da22416edef4fc18355

commit f5cbd80af75b987838cd8da22416edef4fc18355
Author: vmpstr <vmpstr@chromium.org>
Date: Tue Feb 28 02:35:47 2017

cc: Regenerate image decode requests tasks when cache switches.

Right now, when we switch the cache, we fail any decode that was
enqueued but not yet processed or processed but the callback wasn't
issued yet. This patch makes these requests orphaned instead, and if
a new cache is set, then it regenerates the tasks from the new cache
and processes them. If, however, the dtor runs, then the callbacks are
issued with the failure code.

BUG=693692
R=khushalsagar@chromium.org, enne@chromium.org
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel

Review-Url: https://codereview.chromium.org/2718243002
Cr-Commit-Position: refs/heads/master@{#453471}

[modify] https://crrev.com/f5cbd80af75b987838cd8da22416edef4fc18355/cc/tiles/decoded_image_tracker_unittest.cc
[modify] https://crrev.com/f5cbd80af75b987838cd8da22416edef4fc18355/cc/tiles/image_controller.cc
[modify] https://crrev.com/f5cbd80af75b987838cd8da22416edef4fc18355/cc/tiles/image_controller.h
[modify] https://crrev.com/f5cbd80af75b987838cd8da22416edef4fc18355/cc/tiles/image_controller_unittest.cc

Sign in to add a comment