New issue
Advanced search Search tips

Issue 693682 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Feb 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug



Sign in to add a comment

ImageController shutdown can complete a task multiple times.

Project Member Reported by vmp...@chromium.org, Feb 17 2017

Issue description

We should only be completing each task once, but we don't right now.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Feb 22 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/fbe2b0877565ac300ce38da21e4bf0fb93e7de40

commit fbe2b0877565ac300ce38da21e4bf0fb93e7de40
Author: khushalsagar <khushalsagar@chromium.org>
Date: Wed Feb 22 22:29:38 2017

cc: Fix cleanup path for image decode requests in ImageController.

The change fixes a couple of things in the ImageController:

1) We try to mark each image decode task as completed when tearing down
the work queued for the image worker in StopWorkerTasks. Since multiple
requests for the same image will re-use the tasks, we try to complete
the same task again.

2) Make sure that we tear down the worker tasks when switching caches,
not just when the cache is reset.

BUG= 693682 
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel

Review-Url: https://codereview.chromium.org/2699533010
Cr-Commit-Position: refs/heads/master@{#452237}

[modify] https://crrev.com/fbe2b0877565ac300ce38da21e4bf0fb93e7de40/cc/tiles/image_controller.cc
[modify] https://crrev.com/fbe2b0877565ac300ce38da21e4bf0fb93e7de40/cc/tiles/image_controller_unittest.cc

Status: Fixed (was: Assigned)

Sign in to add a comment