New issue
Advanced search Search tips

Issue 693677 link

Starred by 1 user
Status: Fixed
Owner:
vmp...@chromium.org
Closed: Feb 2017
Cc:
enne@chromium.org
khushals...@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux
Pri: 2
Type: Bug



Sign in to add a comment

ImageController should inform the caller of the decode status

Project Member Reported by vmp...@chromium.org, Feb 17 2017 
The communication between ImageController and the caller when it comes to the image decodes is just a callback that is called whether the image is decoded or cancelled. We should probably provide more information to the caller.

In the current design, the callers are the trackers, which are still cc concepts, so we can be pretty verbose (like an enum with an explicit state). The trackers can then decide what to send up the chain.
Project Member

Comment 1 by bugdroid1@chromium.org, Feb 27 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/fa6e385073a6d05bdee9d60e3814e7a77a035be6

commit fa6e385073a6d05bdee9d60e3814e7a77a035be6
Author: vmpstr <vmpstr@chromium.org>
Date: Mon Feb 27 22:51:30 2017

cc: Make image controller return a status with the callback.

This patch adds a status to the callback when image decode requests
happen. This makes it possible for the caller to react appropriately
to failures.

R=khushalsagar@chromium.org, enne@chromium.org
BUG= 693677 
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel

Review-Url: https://codereview.chromium.org/2703633004
Cr-Commit-Position: refs/heads/master@{#453370}

[modify] https://crrev.com/fa6e385073a6d05bdee9d60e3814e7a77a035be6/cc/tiles/checker_image_tracker.cc
[modify] https://crrev.com/fa6e385073a6d05bdee9d60e3814e7a77a035be6/cc/tiles/checker_image_tracker.h
[modify] https://crrev.com/fa6e385073a6d05bdee9d60e3814e7a77a035be6/cc/tiles/checker_image_tracker_unittest.cc
[modify] https://crrev.com/fa6e385073a6d05bdee9d60e3814e7a77a035be6/cc/tiles/decoded_image_tracker.cc
[modify] https://crrev.com/fa6e385073a6d05bdee9d60e3814e7a77a035be6/cc/tiles/decoded_image_tracker.h
[modify] https://crrev.com/fa6e385073a6d05bdee9d60e3814e7a77a035be6/cc/tiles/decoded_image_tracker_unittest.cc
[modify] https://crrev.com/fa6e385073a6d05bdee9d60e3814e7a77a035be6/cc/tiles/image_controller.cc
[modify] https://crrev.com/fa6e385073a6d05bdee9d60e3814e7a77a035be6/cc/tiles/image_controller.h
[modify] https://crrev.com/fa6e385073a6d05bdee9d60e3814e7a77a035be6/cc/tiles/image_controller_unittest.cc

Comment 2 by vmp...@chromium.org, Feb 27 2017

Status: Fixed (was: Assigned)
►

Sign in to add a comment